From nobody Thu Apr 2 20:20:48 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010006.outbound.protection.outlook.com [52.101.193.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B143402425; Thu, 26 Mar 2026 15:22:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538546; cv=fail; b=ZmG8g3BZnyMyy0o+nxxpZEo3IITFB7smyG3WfHWUNdxMKKwV2QArpKevB1uqqgWLeFuOBgYxmRrJHejaJHYRSyA0fVyyYpLFOEhUZ9mcwO+AoXMzkw5mTIFDxvtcU5OHRmDvFpOYmTZNporrpjGWf4+z+iIhOAZ6wxyb9xwL3X4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538546; c=relaxed/simple; bh=oRvEojYWqiVmqA2SsbYvRsX2wSHF08/J0m73i2njv4s=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=DKYBy0kKuwJkWYb0BLd9BwJPJKboj00sOo6kwXR5zpN2KrkRTlHiXhGISsoZb77u62AzSqk5Z9Mus+3D4tfWwUtcSl26jGng/PYCpzCgQriKLXxKWm2kMyiryCv2iADUf3shj0y2qSHPBltJpYhB0bWgZzbf32JdDDHgvOMzt5U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ZvhTKHBI; arc=fail smtp.client-ip=52.101.193.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ZvhTKHBI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vXDndl7hojGhHQKFoEHTUhE10aBU1hgzqJtmKrAlm+bxYwlEC1R8P7yNRhl4Y2AsLKWpfqSaSijbg6svTav5WTePG0oY3FulltQBrDfntFwZ72Vf8oR1VZPa+WDBoMjZzkZdaqok2gu9J90UY+Nt9WjNx5krFedzy8sweuNrmLGPWlWy3i/A2Q9SIraM3D8JiTbAJ/9N3yAOY6HfiNUnojQq/EQDbQ73mfT52WMCIDxDT8kRWudQ2IOZeUyzZa77qXUvW6hQryHrmCu7VxEYsxn83epe5uvqwJXCZcwJSMWJDjMPEIoWz2FUAmQdUdzVpN6zQIvnjD3QOxQuGp7tRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T3I017rWFlcUiqECWKqv4C3wiCUF/u1SgALaw9fV9Qw=; b=N2fudP/ZVy8ofr0YiSMUpw0b2lKrNpxD+immFbXeVYQMq3azi5CjnuC3H628+14VKYp7NSWZmqRWq05sYjtkFnHDF8O/00/KV0ZqfhzMVgkGG67FkGsm9RMqDbR3C/bSEgRR4gUKRPZotsS46bLR8El0vi/y1xZg42mJkgy7BxFHkP9RJs0bPuYBWGB7nOeBm8DiUb3PYFrkovGgf3BX7Dmul9nF6/KeUymULGzZkXZPx+gAf6PHSbRNzuukoxLofiVB2EtSRd97NImfd1aR2TvUIWcZ4BGzKaHuNwMRvIVXtSHdm08QSOtnjER960+YQMXHzjwCfDTyZoc35Zw41g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T3I017rWFlcUiqECWKqv4C3wiCUF/u1SgALaw9fV9Qw=; b=ZvhTKHBIe2MZzhrzrcXaPow+CUaslX0KLNR99AmSSS5jAWJkwqHDZinv2P/P6p6PGAWqwA6jBy4nVRWTSEpZ4mUIlMLill2oXJ0icbzJ2U9fHFWCpwZzPRBDrGYZphye4Rwveiq1w2hk9otXGPG+zEtVC8fohR3QFb5hMveqF7sioCQezwsXEAhBSZpBPeciv4bWCPc7gFPcEQMLSiGfYJ7yXNfA+ebO0lxSRl2chFSzEbX5JonAKjBw83M1CGzLlblm56oQz09k+PjMTrsY8Z2kxgHj/oF5P/M4assk9xYtj3E0I66jyvNRt0Pq8GAqnoPzQXGJnGUTslYXtvn3Rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8219.namprd12.prod.outlook.com (2603:10b6:8:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Thu, 26 Mar 2026 15:22:19 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.004; Thu, 26 Mar 2026 15:22:19 +0000 From: Alexandre Courbot Date: Fri, 27 Mar 2026 00:22:07 +0900 Subject: [PATCH v2 1/7] rust: dma: add from-slice constructors for Coherent and CoherentBox Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-nova-dma-removal-v2-1-616e1d0b5cb3@nvidia.com> References: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> In-Reply-To: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> To: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TY4PR01CA0069.jpnprd01.prod.outlook.com (2603:1096:405:370::12) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a2796b0-e1c0-4697-ed84-08de8b4b7881 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|921020|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: TbHT8/mcBMQJcoO//wGf0cNw+AGx639jhkmXnyh4zu2MqTeDscWTt2ChuVJur/5Gt5BAb6Zga4agO9BwoE8fkWr40Qy1+pWZa7b2u/g7OSgywSAbk3GDGG8ea7Q3z3vxJLMa752vmYZ5oVvIkkDlKoD852XGEo55s48w7lkAILwz18+UE6bsYegmF1I8cJ3ZIpqeRmqqUxlcumr2BL7Qb4hK98YIiHynCjS5VXe3khje/yYgF/AaU1qnqcFTPXqcFX5WfL2QoPAnxiykSuR9Y/EnRsh0F+GdsW6S+T5JEARzv0JSngbOgBRdECUe0opVC2b2q2Hk8fx5BI+xamNcNrpZk7+1rdWbuXuHDR6IVud4lzXxia1leY/Eh9rLGJQCsEd53mVP+qpYF5g6Iiygz98/WJUOieq1oYOuWW4cET+OXUNtucNImX012VygWaZwxQSZc0cQXEAwlWfSS3SODk3/6SOuy905ReJSX3nWRpo0NhRWd1Z99SZPvPOetnwcvSsr6K9OrmSB3fopFCn9l0/b7V9SBVLpQ2MnNybGBcn9NzwTa1Gkv/r0c6jut2F3Qbssr2IBaKI18B2gQ8jLQjBH9aySzx9SAqpf1KQ8DESce2N6tj/XAGfYUSwflLWi3DOaKrADip1y7kSzDZkLgoH/SmXjuGVAwh44/HyyfTphGvA29KUt+NKnLFKi2f4XNd3SSi+DVzAj5JSyde966MErlDcEoTzqvVFWVdS7yEXDW4ZQ0WJlCLVGplyu9CPSHqi11XG9/GE/yW/+ukMNmQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXk4ZUhIU09oVm5iNlYvekRPc1dVdUwxUDJMa21JUmFEbVB4YTZMdWw0Rkhv?= =?utf-8?B?QkM1YXpYaVBzbTRMUHdnZDd6R1Y0VGZRSjBRK3ZQVURESVFXa0FPU2lFYjVD?= =?utf-8?B?UllTbGNzaThNeXppTEMvVWo3ZFlNUURhKzhETG1WMURqRzQrdnl0bnZaUW5P?= =?utf-8?B?aHlUSXNtdGVnaG9KeVhCa1NXWGVscytGZFFsdHBtbTR4aC9leVp2MHRKcTMw?= =?utf-8?B?UFhFQWltenFnamovYTJlNG5mZHJORDRzRDhmY2JjRWx3Q1EwRTJXVDBML1ds?= =?utf-8?B?dU1pMmM0NXY1bWtzOTFpWFNyOElYckNQUGdydlFaU1VxMFZXUEVUdFVrcEVo?= =?utf-8?B?ZUVDeEZQWnhKL2luNks2V1dSWXFQMnpSam1wdkNwVjNITGJzOFIzTzBjWHI4?= =?utf-8?B?ZlQrUjVtOVJiano4VFBxWDFDS3hicTlubnhVRmtKaFNHWGNTZVpIeGFMS0I5?= =?utf-8?B?emI3SUFybEdFV2dyaW9xMzdna2pMNExlWWlnQnVVVFJqVk13cWhKdmZXVVht?= =?utf-8?B?eUJEd3BRVHlpaWJpNks5ZUxmWHQ3VXR5Ti92QUNhN3BldmZDY0dKMXAyZk1G?= =?utf-8?B?RmI3VUh6Z0RVNUJYbmxEZzIvL3NZTkpNUmFkYVRMWlR0V2tBSGRneldNYytt?= =?utf-8?B?QUtWdmFva1NFaXNnMElyaU9TcEJqclY3NGo1TVhFU3ZJUW4yWmd3MFpodlhs?= =?utf-8?B?SjJCcnNIVTE2RVFXRHUwVEQxaHhYRW9CYXJEQk90RWJ6OElNSVp2WjU0YXVN?= =?utf-8?B?T3BNblN4WU52bWdBQ1R4SlRKbHdZTUlYVUYzNXBKVG13MUpyejgrQWNxbVJL?= =?utf-8?B?aTIvNFJzOTN3RUx1U1R3Mk5qZmwxUGsyZlpGZzFNTTFoSHEvQ0I2ZkZydlU5?= =?utf-8?B?Nlo2eHdBbUxFN1pGR095ZnBEd3V0aVB4OHFQOWtDUldaR3BRcWF6S01FK3kw?= =?utf-8?B?K3ZnSjMzUmZHcmdHUjRiZ2t0WlplOExpNjZ4MGhpaTdPQm8zU3hIYWJGM09y?= =?utf-8?B?cm1XVjJEV1NKYUlVNm9kemVMRlZtR1BjaWtVTU1xQVJ4b2hzOE16Z2ZVMys5?= =?utf-8?B?TlBxS2FxYUgveWVmQkNnSFgrS1I5aFJQWEF1Ui94cUxpYUVxSE5DcmROWnZs?= =?utf-8?B?S3FZTXhiNGdFQTJOd2dOUlFzYktaVjJzTVdHNlkwOHE5bGJXaVZiL2hac2Yv?= =?utf-8?B?K01LNHFRMXBKY2RYemV3d3I0N1N2Y2FIWDlaZGtkY3hiRDRBemwzNFYzNUkz?= =?utf-8?B?Z2JiTGF5ZlB3NCsrdThXdkxjQW9qTTBKVTZQQnZNbENiUGJ2L2RlVGN5ZExP?= =?utf-8?B?V0E3elNtUWpoRk9kY0FQd0NpWU51R1V4ZUlEUG5oY0xTQkFqYlZvbXIvU0Zk?= =?utf-8?B?TGM2U2ZRYU5SWEJSeFhhcnJMSGdnWUJTVUdHeTV6QnhlMDU4dVhnSS9OSTBy?= =?utf-8?B?enJ0eTZMSDg2S2VHT2Roc3JrajJmQmFoR2ltL29WbldXTXEwRjhML1F6eG1R?= =?utf-8?B?d2NnMUIvRkFiT3BtWFZRZkZHZ29TdWFEOUNRWEZ3ZFZWY3ZyOUwyQnMraUhz?= =?utf-8?B?L0k4NkNpbUMvbWQxZ0JTZ1g0U0tESlExVU9sK3FZaHVQVDNFTFNGZ3pveUpX?= =?utf-8?B?Zkw3K1ZFL1R0U0NOaUNBMHdWbWxxQmJRVGVQRFRNeUJ5VzdlSU5RZnpTUmRu?= =?utf-8?B?RE1QK081TEJUUzhKcm1DbkxHV3JINHV6Q2l6K2FVUDc0MWdPMXJCY05Ca0xh?= =?utf-8?B?cnZTM0FrL1EvWHdRUWJmTFJVVml1Sld0eWl5V2Y4a1BsVFlES05SY04zNjNx?= =?utf-8?B?dTVkdmVqT05HdG80cnpNQ0N2dWFEeUVkbVBJdUFWVHA2Wm1VK0Z3RXZQYmFE?= =?utf-8?B?V21rWDFDOWZldy9pY0xMVGdvbWxxSTJUNHAwTjRBRFlMdnBybFNpZXFvYm9m?= =?utf-8?B?blYzVzcwUlRGNHhEZ25JM3YrUFhYc0VINEwyL3pQYUlqZ2dLNWI4aEF2ZHUr?= =?utf-8?B?VXVLSGRMcitXVGRJM29xMzZCTmF1Y2pxdzZmSTA5Z24zaVlSS2I4R3RwYzFC?= =?utf-8?B?d0Z5enh0UFdIdG1HbzBZV3RhVDdFVE1jR2t0aElBa2tqS1BTaEc4TkduTkVh?= =?utf-8?B?b3dQM0FOdys2WXk3N0VTbmJ1OVdUZi9xZWFDOER6NVBLZnpKN2llSEVXYmNN?= =?utf-8?B?c3lQSkQyUWdja0pkek1IdFRZUjc1SXo2NnJFOHI0eUthVnpEamxUcUlUajMx?= =?utf-8?B?Q2pKSGJGSE1ONGJ1c1RjVDJNY1JTQlR0cGJxUjVZRzZLRnNNL0JZVmJOcDdD?= =?utf-8?B?dldFSVJ4UUduVkl6R3g0aExUbXp1bm02NDlpb2MxdmVWNkFORENqc2ZWQkVq?= =?utf-8?Q?8Y+0AE93FEDFIz6zDhz0AuCaSNw2d1KwD2fE46sSNI8Tu?= X-MS-Exchange-AntiSpam-MessageData-1: AgXrt+dEECtmaw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a2796b0-e1c0-4697-ed84-08de8b4b7881 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 15:22:19.6370 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64dHzJVatRy7UeB4ewWLG/4NUFpbngeZebiGShBMfwEkXFCz+bwYJS8b46JfRoU/nUXLEvoP3TpzQIdsav4I2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219 A very common pattern is to create a block of coherent memory with the content of an already-existing slice of bytes (e.g. a loaded firmware blob). `CoherentBox` makes this easier, but still implies a potentially panicking operation with `copy_from_slice` that requires a `PANIC` comment. Add `from_slice_with_attrs` and `from_slice` methods to both `Coherent` and `CoherentBox` to turn this into a trivial one-step operation. Reviewed-by: Andreas Hindborg Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- rust/kernel/dma.rs | 107 +++++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 107 insertions(+) diff --git a/rust/kernel/dma.rs b/rust/kernel/dma.rs index 8b7a9572ead2..40799fa418d6 100644 --- a/rust/kernel/dma.rs +++ b/rust/kernel/dma.rs @@ -453,6 +453,66 @@ pub fn init_at(&mut self, i: usize, init: impl Init= ) -> Result =20 Ok(()) } + + /// Allocates a region of coherent memory of the same size as `data` a= nd initializes it with a + /// copy of its contents. + /// + /// This is the [`CoherentBox`] variant of [`Coherent::from_slice_with= _attrs`]. + /// + /// # Examples + /// + /// ``` + /// use core::ops::Deref; + /// + /// # use kernel::device::{Bound, Device}; + /// use kernel::dma::{ + /// attrs::*, + /// CoherentBox + /// }; + /// + /// # fn test(dev: &Device) -> Result { + /// let data =3D [0u8, 1u8, 2u8, 3u8]; + /// let c: CoherentBox<[u8]> =3D + /// CoherentBox::from_slice_with_attrs(dev, &data, GFP_KERNEL, DMA= _ATTR_NO_WARN)?; + /// + /// assert_eq!(c.deref(), &data); + /// # Ok::<(), Error>(()) } + /// ``` + pub fn from_slice_with_attrs( + dev: &device::Device, + data: &[T], + gfp_flags: kernel::alloc::Flags, + dma_attrs: Attrs, + ) -> Result + where + T: Copy, + { + let mut slice =3D Self(Coherent::::alloc_slice_with_attrs( + dev, + data.len(), + gfp_flags, + dma_attrs, + )?); + + // PANIC: `slice` was created with length `data.len()`. + slice.copy_from_slice(data); + + Ok(slice) + } + + /// Performs the same functionality as [`CoherentBox::from_slice_with_= attrs`], except the + /// `dma_attrs` is 0 by default. + #[inline] + pub fn from_slice( + dev: &device::Device, + data: &[T], + gfp_flags: kernel::alloc::Flags, + ) -> Result + where + T: Copy, + { + Self::from_slice_with_attrs(dev, data, gfp_flags, Attrs(0)) + } } =20 impl CoherentBox { @@ -839,6 +899,53 @@ pub fn zeroed_slice( ) -> Result> { Self::zeroed_slice_with_attrs(dev, len, gfp_flags, Attrs(0)) } + + /// Allocates a region of coherent memory of the same size as `data` a= nd initializes it with a + /// copy of its contents. + /// + /// # Examples + /// + /// ``` + /// # use kernel::device::{Bound, Device}; + /// use kernel::dma::{ + /// attrs::*, + /// Coherent + /// }; + /// + /// # fn test(dev: &Device) -> Result { + /// let data =3D [0u8, 1u8, 2u8, 3u8]; + /// // `c` has the same content as `data`. + /// let c: Coherent<[u8]> =3D + /// Coherent::from_slice_with_attrs(dev, &data, GFP_KERNEL, DMA_AT= TR_NO_WARN)?; + /// + /// # Ok::<(), Error>(()) } + /// ``` + #[inline] + pub fn from_slice_with_attrs( + dev: &device::Device, + data: &[T], + gfp_flags: kernel::alloc::Flags, + dma_attrs: Attrs, + ) -> Result> + where + T: Copy, + { + CoherentBox::from_slice_with_attrs(dev, data, gfp_flags, dma_attrs= ).map(Into::into) + } + + /// Performs the same functionality as [`Coherent::from_slice_with_att= rs`], except the + /// `dma_attrs` is 0 by default. + #[inline] + pub fn from_slice( + dev: &device::Device, + data: &[T], + gfp_flags: kernel::alloc::Flags, + ) -> Result> + where + T: Copy, + { + Self::from_slice_with_attrs(dev, data, gfp_flags, Attrs(0)) + } } =20 impl Coherent<[T]> { --=20 2.53.0 From nobody Thu Apr 2 20:20:48 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010002.outbound.protection.outlook.com [52.101.61.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 981A1402B83; Thu, 26 Mar 2026 15:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.2 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538550; cv=fail; b=VDXHWV8CujlYiUycoPf3r/rIhkWt13M+g4qQyaR7KsFTCVVQvQV8SIew8a/r2PfiYEIj4s+H1EWhT6eKhQNpKHD6Fngf9aV4ULRei/YVoOskj38KVfbTAfTEIL/Hd2kVXh7Z6in3wv4vupRJY9AWyNWxKVdWGV9Un5c5DRvFHtY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538550; c=relaxed/simple; bh=UCqwgzGLsktbM1fNSW1Qvfj68yX8dBMNhJS0izODVS0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=RjWjylmMrtheUxfWmDhagx9GkHznuTyCjUckR0OGjCmtOAoPQdHU+7Ahimd/Jo3Mdg0txoNSK+ZtcHBBCETdaxT4g0wA7P4nZb9lq1ok3mbePYITeUuUiGjNXOtRWjsYWY1SRPT471JOhxtxMF1xlM1z/44j4cciq/4zYyMx5ow= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=BI1HKmoy; arc=fail smtp.client-ip=52.101.61.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="BI1HKmoy" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fxNKIAAN8eQ/nK+qrBeGGehpZBmceuL2R8dr02Y2WxEBq8whYEt0zl6xS7RuDPa0rer0n8qYuV2TPVdMPiW2zxGDf3gHeCptiL8r3YCZB37kdsGc+SOd/eUuec2HcvCar5SPPzGA+8TmXxOKjN5advyB5e1LqzopjxzT7xHdveotg+LlYw5CahRH5VA1bzNs0QWev7WqK2+S+mzWn5vk/EayeEsd61XIlz+eWHNoqUv2lN2GlESLT9VtL+fTOFCafibavwxRM9+yTkwG/ZTeaM7mxd1bnwo1KVPqR2paziPUZHpRe2WReO+PO8RRzy9lj/fFit83Yvdz/XT9EmGV/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OvqAAfSnkluAzxkdNzNjFzAZuyomYtNnybrGrjIAVUg=; b=yEpQF9oG5YTsG7aRvpoOeALAORRwVmvOqCZ3BLU2elXfNgGyby9tnCJQWXHixErPt1hzjp5zeZEC3K5jMezuOf9Ru/4r7tlkicN6132/FYR1x6ydEH0XrpykP1vyfyE7XoKTb3NQD/4B8eWJZ05aNWj/W43nVl0SQjE3mFE3zCDHX3+4wTutaFFuXurtQJ/SHz7HAtVNkgY0LIltG3zNNrNK51AbeKqtnpT/dPbSWd6spOXCLk2A8a3ssvu2BP0yiHRc+Z2a7Rsc5j0so01D6tM+M2DL1QWk0wpcZGpCxqssNYDqjSZD/cnDJIkViUvNmTN4CjA2D6ad8nQ2lU9HUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OvqAAfSnkluAzxkdNzNjFzAZuyomYtNnybrGrjIAVUg=; b=BI1HKmoyuJ1QsDWx/eUQFdmOA4nT8IGu5vznSb/jv/BSrSPcDJoOr4NZ9uLn6zkvSF1yF/p9NypF5MXpjfAnfMTd60BoRpFQh4xlIjK6yysbQ13IlVYyeNG4PpovV2pimNHdcXjM9aXzdSiSNCm15w/CAh/evq2UM/HWKyWxMCtYy1S7u59sBHIYV0CrqQoo5rFWjMM33DxLVS6ndwjiDhpNKoN9p/Fdw1uIYUwJ0K8If67eBUPgv0fqX1QEOBlV0FTyunlc4pwS2Vsk1Bn7UQb+SrVYJA7+JTcE9GTj9wfQ0GZXB293nA5o2GlcjpzS+tE015pUlFcO7faO604GPw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8219.namprd12.prod.outlook.com (2603:10b6:8:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Thu, 26 Mar 2026 15:22:23 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.004; Thu, 26 Mar 2026 15:22:23 +0000 From: Alexandre Courbot Date: Fri, 27 Mar 2026 00:22:08 +0900 Subject: [PATCH v2 2/7] gpu: nova-core: firmware: riscv: use dma::Coherent Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-nova-dma-removal-v2-2-616e1d0b5cb3@nvidia.com> References: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> In-Reply-To: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> To: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TY4P286CA0090.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:369::17) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 724ec2a7-56cc-44cf-c790-08de8b4b7ab7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|921020|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: sZE5a67huUtCkCAxAvGENE8au4tvIb41Ylaum30PEncy3cwb4FAInRt4woqbEkAsHogHk8jKpWxfyNpYSmcAg6X/QeH2dXxzUyIZdB6JLTQhp+rk/e2KlHd0eyxfEpwNlGtBgopBCcB2PdlkYldBVzESK0RLFJ/6ZM8/4cAqVH2nr1VjtDFTTNq9XqDh4goaROKCqjPbbxsY0Jb5hYYNBj2PAD3HkmIJ3HeiGgoSGJsYTfbnm4TlBYZNTeatRBeqIsAR9w+6UUvVT6rfLkw+I48xfnDBFVJH5rJcriE2jXtaBfJbfN7scuNmO5JF2+2E2utUGgddOviDXcCCuEo5ImVyuNRjOuc9UVJuLuAa7VNk8VQPFUzCh7oTzaJdT65tbnnCF4smgv2FPAf+/zx0jH6B6BuNfyvKNZnxJq9SbBfJqK3/mkqB7ewJ3MBujdjO3qWDVXCGfn3LFnW6epvyyJmWmEyccRRqcv4OFjw2NTyAPBxTCGD9rFYJIyZMQZpUxruA2PODLPsWfscNXlUCXwv2D20XtFnSS0BJAx+DUdDQntxPOmWJdxtk+Ipb4xkzaM5KwW9eh3Hy3c4L/qKr2sC/3y8Ho058rNyQIOGokEAYQVIrQeKR2jDmW/C3zLFGbOtRBpNOgUYsyDFXGN21qXF1u+IAP78fUZRrJuvVqWs9SdAVxFfEB+gf4HEE7kxQeVBOhQWHIlkb/EMhkGV7stuGiHpBEDMynTshnX9WUUXWsi3R2Mas/klsGU1CTqm4uuloEYJcO9zbzPxq/yO4BA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUUrR1lnSVlrcjdIK1MzNmVhYUkwT3oyL2o4NmFyUU5rY28rMlhNT0hhNXlx?= =?utf-8?B?NE1NcFNEQXh5TTI3U1cvdnBYYVJnYXk1M3JnQlNQQkFQZVhWVWVNNXV1YVBj?= =?utf-8?B?cTNPaXdtMjhMak9iQlJkSlZ5U0l6MGx3SXRRZEtpZE9ZcFNsZUFSZWUwb0xB?= =?utf-8?B?cU4yNjc5UmQ3ZlpBQVNHR1J6VnRGU1kwK20rcU8zSVhCR3RzWmpBWVVvR2xH?= =?utf-8?B?Uml0UHQvcVUzcGt2ZW8ySWRJa2ppWTE4aGk0RGV0N1haM004ZVZZeU1CVTZ5?= =?utf-8?B?M0VWWHV4a0xiS2hmTWZQekdSOXBSSUNJenhhSXBHSkQ5SFZrV2N3a1V6eFJC?= =?utf-8?B?WUJoTlVOTEFpejVRUlpBVzl0V1NmaUN0UWhEb29zYUVGZzl4THp4aURLeSs0?= =?utf-8?B?U0xJTHRrUkh5VVh1NlZEU3JkOGdHMFd5NW52VkVyM1FCbFFtbUU2VmcvaTlL?= =?utf-8?B?cThWYjQwNVk5cWFKTGZsWlc2OVltZ2dSamlERXl5UDJka2Rvb0xPY2hYNEhP?= =?utf-8?B?QkdnQkxEemtGbnNtd0syeWt6bi8vMzU4TFpOQ3NSSjBTbVJ1L0xGd2YxNm5O?= =?utf-8?B?RUlqZVhpWDZnZDNGR0dabFRIN0xIWkZNZSs1VExFYmxrLzNNaGViVEM1blZw?= =?utf-8?B?djFGcXFNYmFPSkQxd29aVGRlREkyb2tVVG5welNDMXZPSDJlYU9kaWEzNGpi?= =?utf-8?B?RmhocmdQdXVIZkV2MWZGaVhJd3k3T0RJd3pMeFNyM0gvUm93dzUyNnd0Q0F5?= =?utf-8?B?dGtXV2FiNmlmSHA5SzJ3QTFzR2w5K2hQeTluTFFvSGF5RU1oai9VbXpTTFBy?= =?utf-8?B?aUhtUU9pY2Y1RjEyb1hnaHA3cmpQNEd2YVRMTXJ4YitONllEdW8velducUJ4?= =?utf-8?B?ZWZUOTJKUjFKOWViR25kVFR2NGdKRS9nQ3h6Sm5ZME5XY25GTUluWnFIMkVB?= =?utf-8?B?MXdFQkxiV0gzanZsMmRXMVJnWHBKbWJDcVVuRHVUNUFzU0g1aUFzNGluSGg3?= =?utf-8?B?VGFkdjJYUDJxZmRkQWVRRkZlaGdBc3RUT1V2b2t1cldlUUJGMU91amhTTlFt?= =?utf-8?B?YWpLUHRsNDZsSWlWZXA5MXYwUUwyL2lZV1d5SUR5TGNTZ0dkei80UWM2NC9M?= =?utf-8?B?ZUVJTW13R0ttMmJZNEZ2bS94LzhKNDdSNHYvR3EyTkZhTldHK04yaHcwcENV?= =?utf-8?B?SW1IdUJaU1gxWUE1QUtQY1RKaUh1WFRHK0lnOXhkNHVUb2VzeVFJV1hCQ0tT?= =?utf-8?B?RER3Z3A3MU9PWHhtdXM4d2xHQjl2YWdtQTE3eS81bzJVQkRiTDVKOXRVd0t5?= =?utf-8?B?cXpsNTlmV3Z3UVphMUYyN2wzcjJIbWo3ckt6ZW14WFJDaFJNRGZ0TmpucVd0?= =?utf-8?B?eG9HdWNqVnpDeGVrZ3EzRWpvVTlCd3NhLzNTb2lhR1ZGRnRrdTFqQTFQUVRa?= =?utf-8?B?TVNrbFM2Q0NSOFYxeDZwc3FTcFdiN3VreHJhREo3OWFkc3k3ZEFFRWIvQVdG?= =?utf-8?B?VGliclhQY1ZTRXdLZEtHZnRTQTNRZUYyenBPZ1k1bWNxMkRnWmZnUEUrZ2xq?= =?utf-8?B?SXRDbTFaamJOZmlUeXMyaCttbWNxWUhCUmVIVzZJMThrNXYxZEFXQWJEemFq?= =?utf-8?B?YlFDZEpCaGFrcUxBTUszMWpnVzMxS04rWGkySEpYNVY3SXVCU0g1K3FiK2VW?= =?utf-8?B?RUIwM25lQmJTZkRrTEVmbVhoYWJUZnZhaDVEVjlrN2ptRnNCakc2eVdvQTh2?= =?utf-8?B?bmFNd1JGRVF0d29EMmlsa2dDNTIvZ0ZrZDl1VVBxVlMvUE1aYW9mTnFGQkd2?= =?utf-8?B?UGN6Nk41Vzd2UUJYaDM4TDFEbG8rUmtISW50RTZlQWRNd2t5UVAzcFdscTRP?= =?utf-8?B?cHNOb3Y1U0JWWUlqcmI4TmVyaW11NGYrL0Q3SjQvZHMwSzVUNzBxWWhlVURk?= =?utf-8?B?aUNlSm5IejV1TGpoYzlHcmk5NUxWODNVVVFPZmN1dVA4QmZVQ2tRTmtqUlhs?= =?utf-8?B?SklnNnovN05sOXY3b2FzbWlvT3NKYTJ4QkJwZnc2ZDJVSVltSDZOWVpmU1RH?= =?utf-8?B?Si9mVUpRbXdlaG9iSWplOUdMa0pYU0xKbWpFTmdpc0Rwc2FWSENrU2RzRkVS?= =?utf-8?B?LzVLTjBxaldnVUt6eGQzRWpCZkN3VzFVTVFhZHQ1QUhibHhoblN6MEk4N1hF?= =?utf-8?B?T0l2Zld6QWdEbkNQZ0I5WTgrVyt4akNsdDhnd1JUQ3RmMjM5RHI4Z3lwRmVV?= =?utf-8?B?aVB0MkhtSFZMSzY4Z21YN09SWVA5TE1VSjRWRS9VV1o2RW5KREMrZ1dtRTZr?= =?utf-8?B?TjUvbnFJTmhlSnduWUUyTFNUQURHL05HWFY1OUhNR28rNTByenB5WisvbVVO?= =?utf-8?Q?CI/x7cRHwYwn+mbORQMCbuv6txO3TuVdmoCL2VdY4gh32?= X-MS-Exchange-AntiSpam-MessageData-1: RwZsSoRklvWUSA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 724ec2a7-56cc-44cf-c790-08de8b4b7ab7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 15:22:23.4277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yiyow4bkaxd8So5C8AunteddYwhCagQ49tBLHE/tubUBmTZ9zkQh2xECAFlIFo8naTX0e0GGt1o1zvM4p6EE0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219 Replace the nova-core local `DmaObject` with a `Coherent` that can fulfill the same role. Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/firmware/riscv.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/firmware/riscv.rs b/drivers/gpu/nova-cor= e/firmware/riscv.rs index 14aad2f0ee8a..2afa7f36404e 100644 --- a/drivers/gpu/nova-core/firmware/riscv.rs +++ b/drivers/gpu/nova-core/firmware/riscv.rs @@ -5,13 +5,13 @@ =20 use kernel::{ device, + dma::Coherent, firmware::Firmware, prelude::*, transmute::FromBytes, // }; =20 use crate::{ - dma::DmaObject, firmware::BinFirmware, num::FromSafeCast, // }; @@ -66,7 +66,7 @@ pub(crate) struct RiscvFirmware { /// Application version. pub(crate) app_version: u32, /// Device-mapped firmware image. - pub(crate) ucode: DmaObject, + pub(crate) ucode: Coherent<[u8]>, } =20 impl RiscvFirmware { @@ -81,7 +81,7 @@ pub(crate) fn new(dev: &device::Device, fw= : &Firmware) -> Result< let len =3D usize::from_safe_cast(bin_fw.hdr.data_size); let end =3D start.checked_add(len).ok_or(EINVAL)?; =20 - DmaObject::from_data(dev, fw.data().get(start..end).ok_or(EINV= AL)?)? + Coherent::from_slice(dev, fw.data().get(start..end).ok_or(EINV= AL)?, GFP_KERNEL)? }; =20 Ok(Self { --=20 2.53.0 From nobody Thu Apr 2 20:20:48 2026 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010063.outbound.protection.outlook.com [52.101.61.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 598A24035DD; Thu, 26 Mar 2026 15:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.63 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538553; cv=fail; b=Lk8T7zKlNuPPBvQMqCH2/lqq8kXLLi7w8moa/PX//eoYK64KOY2uPFFvtQYbvEcBb4W0V6esD8MOq2crtbLptSvuX0OKFehInJFXYelMli49l3E2KXNg15wKLdw679UkM2yISDB/d+QOU1qHSN4EpdsH9Gl0IQ7mT3MsrFJLqm8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538553; c=relaxed/simple; bh=c+sR3IvEDTgVuRax8e+6uVDYm0yinMrGAysiLW6VVtg=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ZIpz2V+4NBVwMQfE9+eZ0dD91tIQTkAkpXZGBjSJn9vrd1nXbctQ9CV/Vh9i15kZgQcvxPqQoGTIYybUZxFNef6FhW7IUoz6cbvpoxK3ge2y6de+5RRuy2aGmcTtQ5J3ouMqQ7uj1albMopZ1UB/d1X1OACPqcI8hunXfBztfIQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Qk/6ixa/; arc=fail smtp.client-ip=52.101.61.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Qk/6ixa/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lAd2KBI/ftr0Bn3tjifykQcViHeSWS//Z8nZGBk49jPK589Lr0RDzRLd9rXJpuhJfKTCLro3p60kCohm/glivn27l2kIeo2B2ttvJfmBgMXlzGjWA/cUby5NjE4ESCs2BA4LgrfqVa34cKGkLqUNVJ1g8HnKmIlZJYDDJ3PE6XhdD08a05hWmBFbIumuH8cwfXbXxRG/jCLb7rk3S/nfw1yw25y1WQUYeXIVneTqKZFTiAkrseIejQ+OjjmDkfbFnc5GXakJXamZGqa9JOw4BTJjtts8sM2bTFURoHtfkWqiVCmVSylOX4NsoJuycIjhxpr5KJGhA9tHZZhx3il6hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=US/sMtO05Igki3c7zBGYTLNLE7x0WvBwb/Wr8HvZKvg=; b=qkv8JUPZKWaIMflm/kNyJ36pZPa/unxBvskFtc3xcAgN2XVS0EEGmsHKqo4ZVwmQlf2lPFdZsBIcOnWpAovcWpZMSb6Mt2dwAKbgba28/knMRZgpaWyOilG63VMTDGZ883DiKAxvPZyn/a0cO3dswFcNuff70cWSFVYjb79035q4IeHibQooridNzs+U0if+iVu3g92jrfLqWAs6tbNrwKP/3HEhVeksl0tIb2+K6EqKTQywhgTmXFuf2jIUWS30UuovyAhvXZsb31WrRvTOY9z1S8y/aMIeKg4wWHdlK+kqrM+lApQqiALMLz3GuqbKS7rpZJDaQgKXp3FinoU2fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=US/sMtO05Igki3c7zBGYTLNLE7x0WvBwb/Wr8HvZKvg=; b=Qk/6ixa/PG3RlR2exiYI24TF9pDU/QULrIfOJ9sNzipWVOYEqQ7XKB/ExsxgalejmmS3dwGI7w2XKTRPdQDvcAdh6R2MxSSSk5Ah1SesMVa1UjjFdn8vaHe8PkC+HJGSU8bDwtFO01ItnwedxH/ODJNyYY4SRgD+beg6jC9bmkGjPHttxpGw/4OCbmKHbFIIWsJK7JAOAbB1VGrq6NQkC7w7qNeVJwBec8ZNKJk0EQ+oDNkot2DQjtyrZ7DjolrDiiwTru96ZraNS0NqKdeKYKqGbl8FjAxEUBZ0F2uuJz2JksZAOlpzKQEH71bw1GmLtZFq8PlEtzDHhAyBC+HDpQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8219.namprd12.prod.outlook.com (2603:10b6:8:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Thu, 26 Mar 2026 15:22:27 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.004; Thu, 26 Mar 2026 15:22:27 +0000 From: Alexandre Courbot Date: Fri, 27 Mar 2026 00:22:09 +0900 Subject: [PATCH v2 3/7] gpu: nova-core: firmware: fwsec: use dma::Coherent Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-nova-dma-removal-v2-3-616e1d0b5cb3@nvidia.com> References: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> In-Reply-To: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> To: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TYWP286CA0014.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:178::20) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: d36adc34-8028-47ca-c032-08de8b4b7d31 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|921020|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: mzVPNQSjQeUwGWsTP+TQaU4MY0+PdeVoO8To0QdYAtPVsJQ0qJd+6L3OXY9GihjLwY5g3wGLSOLkoEFdwqa49UlrrHo2aekK4gVlYlnKGSnhociXEq1Y5svGN68Pe+HcZ2WG880h7yu5d5vGyXXmtUfL4GlnL1pBjiyuuh5dyRbsaajCN8gEPvHOkAW5yNpfVcy9eepoiv5J4xQDx+YA36QclqIx6h90uZJBJUKgD6ijKRxyiXFUtT/H2kkBnvYIeJqZHWbiOOcbwDnUbd4kXudEiR4mvexqEPqnhhzN+ivAv1iqVtyeK6dADpoDEenS6foq1bErGp7SnfObZvShuNeqRDw8b23gJzkHXsJuBTEo8umi9Vr+vyeJaIyt8TzTUFs1afzM8pPgf2HVGz3O9vd5HMPLPf3GhKu1ReuSOPBZbvnMXex6AjP0Lx+qDhfLESbteWRzhIcase/AF6uHTDQa3NGm9GFaFQqx9I7RUFTVtqYWa2MbDELYs8l2D2Mw0WICfTy/G2TbXgKVmSxZ8ETlmkbhC49Y2w8BPjz+HXWqiuOuoXBdEXUABtu7TtwTlVZgLHiaMpXofK2F1wFdOXgtnyfHsbO0eEtY9MIoDgSx9NMmN1zVvjlHZjYUs28S0H4o72n3jQqmSUMn71HmLpwdz/Za88lXIUEn6lCSgJG89gGeovhTP/TSA5divaM56e0EwfzbnBp1Ot+AQ0vt64rY813d4+vrfNppr1n7Dng+yuy8H422cxKoXinPXQj8vcsoTFgjwuEXu5m/ErH7Ow== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGUxUTAwSWtDdFgvRE00bnBkc2N0Ni9FQUdsaE9zazNjblZZU3V0YW15T1ZL?= =?utf-8?B?dnFVdWtqYU81VjI4aHh0OFZpK3U2c0s5a0NDQnN0Y21mdlV4Mm4xek1xOU9k?= =?utf-8?B?WGJVYXh2OHJIRGhWTmRjREY4SEhqRGhOTlJHb3haMTNNMjdjRVoxMkF4QjdK?= =?utf-8?B?ekpXZUlNNXJBUEMzb0U5eXczZXBhZXdSUEFyeTYreGx3dFhZVGZjUVJ6Rml1?= =?utf-8?B?OGN0aC8vUWs5UUpBT0wyQWtQR0MrNXNsVW43RE1UK3RLNkRzV2c2TXd3cnVt?= =?utf-8?B?bFc0UU9TRmczbWpzUys0K0VUUWpoWkcyODhBaFBJcXpvWFZSeWdrNm9PNCtG?= =?utf-8?B?cmpkK0JUVGRKZjNYQms4YmZON0RPMzVMSnRlcVRZUFY0UEVBSkh1TDlCQ1Qz?= =?utf-8?B?cnkzUHJsWi9yNGx6OXd4b0xGQXpSenVyVEdyVmU5U25GeUhlUkl0NlUxcVV0?= =?utf-8?B?QW9JZmFlTlFTL09IZXRCay9lVjhNKzJRNGFzM3ZJZ0ViZ1d3NzNBWDhPMDZI?= =?utf-8?B?U0NldnBJMkRnQ1JqVzZrREpzNEVDbEEzbVNvVTNkTW54TnYwVjhHUnZ1SjJM?= =?utf-8?B?TWpuR0FzQ0lGbVA5aHpBck5DYWhxcUxVTUJyZ3ppaGpJVVQzVHlyeXNjSjlt?= =?utf-8?B?Y2kvUjRDOWRYS1FtVnNHQUFVaHhiREJIeUE3a1diOTYzTi81ZmJCYTBsN1Zr?= =?utf-8?B?WS9MZkw5MVlhNWJRczNvMjVacWJMTG5Ga1FxY1BjSk4zSUVSOUg3ZGhkcTJO?= =?utf-8?B?N2ovUjBXcUZOdHBvbmJxSDRLekhTZVdzM1lPbGpjSUIrQTFoblZnRDlCaG5E?= =?utf-8?B?T3NKUS93dm5heXU5ZWoxRzEzd3I0emE1TmszQ1cwaGd0NlVxdFJ3TE1nMDdj?= =?utf-8?B?SVFRMEtjRDJ6RFUzQ3o4bjF1VzM4RmNWc3FoVVlEVVFJMXZsdnkzUjZwOWZt?= =?utf-8?B?QzFQeEhHYzR2Vmh3U0pLc0tWR2J0Q2NQNDMwUDdQWjVwOE5iTTAyNG5PMUdX?= =?utf-8?B?cGNSMzZIK0hrYjlJdHV4eTV3bjFSWVJId1plU0Z5c3ZINW9JNFMvMDMyTHNM?= =?utf-8?B?bjRpYkNZSUNYbGNGdWhNUlR6V0lNK0F6KzliOFNJR0xuQXo4cDhGMllndmRm?= =?utf-8?B?Kzl6eFFNRFpMYkxkOWIzNzZ6V1ZxUmN1bDk1aG5udDEyMU1tTk01OGhPY3ZC?= =?utf-8?B?c2wwSklHTm1Kb3lWa25EWHdXb1ZlYnh5REQ3dWV0dDUrRHVwekc1eGtsVW51?= =?utf-8?B?VGlZSE9MUU13d2EvMVBIbkgxN3VJNkVtOXdUWVR3SEg4YzJnY3ljZ0ZUbU1N?= =?utf-8?B?cnVxaExld1JTRldGOWFDTGNRcUQ0dW1mendId2p0OHNJRDN0T0Vod1Bud1lx?= =?utf-8?B?aHFqNGIwd0sva20zZDdic2huRTEwT2pyajNLRHYybTAxWWUyQzAveEJ0T0Y1?= =?utf-8?B?ZTAvd28zY3lBV2l0MU44QmJjWkZMS2FqaWVNMHRzY09zZjdxemdPRkJRMW1Z?= =?utf-8?B?QzVsYXRTb0ZEV2tTaUJYSkhDWGNLUHQ5ZGdxcVRpZmpiaHBkOVJaSWNMVFdG?= =?utf-8?B?V1dVa0UwNEZnaEliMllQVlNsZUMzL0RKaGpCTGkzYWFlMTIrUStvYmd6UzdV?= =?utf-8?B?bmgxc0NMT3lTdzF1ZmlXMWFydS9vblhlRzJ0allEcnFOOVp1OEY1UlRDam5T?= =?utf-8?B?N2NDUDJCOU1TUEo3TjZJOStDQStmci9CQ0pyQ1ZBZk42ekxlbTBqMm5WMDNL?= =?utf-8?B?MmRkdC9ZM1g0cXRnV3NpblRRZXoxZ0xkRmRJanZJRUZpQ1FTVjNIb1k1eFBw?= =?utf-8?B?VGVYUzkyYk9ZcDBOSzBNTy85bHFGcjBvRVBMdVBZcHFwZUVBL2VzS2NCRmVy?= =?utf-8?B?VVExRDI3cEV3MG5oQWJGZ3l2MitLMDArVXBlVW9DZkVleWRvVXBrbnc3NXFo?= =?utf-8?B?bkNna1RTeE5vTkhCNjBxSXRGUUpGTElyNkd0Zm85NkJYMUtTcGRzd2lrR1Z0?= =?utf-8?B?N2lrTkxIVThpVUg2V3ozMU5WaFIwY3crUEliZGE4ZmxmdUdVbkh0YS9Saytv?= =?utf-8?B?SzUxZm9Lak1BQW1LRVpRY0hxY01jK3FFdTZWSzZ6dEFmVVBoakNrWnVmd0N0?= =?utf-8?B?TjEzZG1tVEhnWHZNbGJNUkhyOHAwL3pPUWl2Zjg2WXN4bzBqd1oyc1ZXNnpM?= =?utf-8?B?MVhWYXVNWkM3WnloRmp2YU56cDN5ZzhycG81ejBFMHpGeW5LQTlNeVZvYWt4?= =?utf-8?B?dGVTUERCcDRwcUtYdERxT3RjbzgrWC9ZOE1USkRwZEQvcVBLT0V3LzZXVUxn?= =?utf-8?B?eVJLZmRhZWNUQU40RlNtbElrRVNrdjFmUWdpZ2s5d21qejNLYjlSUHNlL1JG?= =?utf-8?Q?E+ivOlbYGKFwouf6zLApBfCAqL0OEpvbzzHg8cnWEuutK?= X-MS-Exchange-AntiSpam-MessageData-1: HK9figwDMlANqg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d36adc34-8028-47ca-c032-08de8b4b7d31 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 15:22:27.3847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N0E/65VAumYPbjXFGwaXJURso16a6F1YGUr/EJJmPHx5pP+Y/1RX2eDGYnqxx8PUkQQx9Bo6ZX5qpolVDXYq7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219 Replace the nova-core local `DmaObject` with a `Coherent` that can fulfill the same role. Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/firmware/fwsec/bootloader.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs b/drivers/g= pu/nova-core/firmware/fwsec/bootloader.rs index 3b12d90d9412..bcb713a868e2 100644 --- a/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs +++ b/drivers/gpu/nova-core/firmware/fwsec/bootloader.rs @@ -12,6 +12,7 @@ self, Device, // }, + dma::Coherent, io::{ register::WithBase, // Io, @@ -29,7 +30,6 @@ }; =20 use crate::{ - dma::DmaObject, driver::Bar0, falcon::{ self, @@ -129,7 +129,7 @@ unsafe impl AsBytes for BootloaderDmemDescV2 {} /// operation. pub(crate) struct FwsecFirmwareWithBl { /// DMA object the bootloader will copy the firmware from. - _firmware_dma: DmaObject, + _firmware_dma: Coherent<[u8]>, /// Code of the bootloader to be loaded into non-secure IMEM. ucode: KVec, /// Descriptor to be loaded into DMEM for the bootloader to read. @@ -211,7 +211,7 @@ pub(crate) fn new( =20 ( align_padding, - DmaObject::from_data(dev, firmware_obj.as_slice())?, + Coherent::from_slice(dev, firmware_obj.as_slice(), GFP_KER= NEL)?, ) }; =20 --=20 2.53.0 From nobody Thu Apr 2 20:20:48 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010064.outbound.protection.outlook.com [52.101.201.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 783F9407119; Thu, 26 Mar 2026 15:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.64 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538559; cv=fail; b=Yk77UG/crEL+ZuOtvctO3tpc+97dA7dulLJSAKeg5jWPcnKvC3m4hgyjTJ3xD0y3NIzRIBn9g1PqxHyk17qTaP7sc+sQMtkJrOj2/tG7Z4L4LM56zYV/jvEOsJIUFx0QLEDZTnfYNnjLn3rhBEIxIwu1TRzheTtOFJDvcjVpxuU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538559; c=relaxed/simple; bh=3+EjKkR0UKIPp7be0JKoVgXwE0rvWt/yQiBojFtwsb8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=NHZ5MoxTdwBh4vQ+eTPSUDqGB6EAA0ramOAu1bI5nmCRwMhL+cMP5boclsUrBUOBZT0tX9ySJzdUWIdAqAUx+RSiHQ+YZnpLpsfPzw/VHG19o/tcmFPCD4zJ4GfEtrl7Qst+cFb4ZGOUplq5bRk4vj3ZVmYWC3dkMNOJrFQ0KbU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=dWuHSE4T; arc=fail smtp.client-ip=52.101.201.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dWuHSE4T" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DinJsCzISYpkenRRib2Jr2vIWSJPoUD1+3Zh1djpAH0O2uWnrVtEsylVd8dlIUN3GDmz62Xdd+dZATew3uZFTwzjmoKWeYgxEQSAdo+oWNiwrvaT6BWGUSEy+Yem7zgXiDZMsT46frKihwC6TU0oBHMxlSgtv2ByGCnGxdsuoLyvLDSXux0B/AepQgRQNzowJHihtCIDjKvmVYXra8ENOn+qf3txwk3G7dYqDWhk8YddRcnm8p9hvLF65KBT3Tuv966zm21xAIzoGdPOCHL3xsGRjcBIrMsobCp/s5xkGYQaN8mlRljmbHzQ1f9a09nkky2IecOUyi3It/xTgitSYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RcwpdnlxnKWrq8UQygURStPZS9WKawS90pO8lig9H9w=; b=TsWV1yaahOYOaE6Z9qqQm9EMUw0ighOyEqxAxjLaK45HlV5ou0HsobZytrxVr9D7DuwyI6TrB9ZZCFUdU+6oa8Hw2NlQb0JStgYn7tKeBWlzugfNw/fobjOhablydNIFCF4Cr2SNBxwgvgdZq9D3P5qFYinQdsvYzkj4nA6WuF6q/4L6aEwUeV//8nW9mrGlr/pkxs/0ygRGkIqQMt8jjxfZ4uDjGmcPgOGEEQZ1O4MgaPlnE0Rxl/fclKD950EhPA4g3EmgGBidrTR+2yFlMHyeKgN4cMNSfpo5De/lqCJx90mE1mg1WmZibdDjU3nBXq+WmZ+cyYF6CtzVjEjAUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RcwpdnlxnKWrq8UQygURStPZS9WKawS90pO8lig9H9w=; b=dWuHSE4TEYonekXRTkqlJ8KlR0QQ2X+k5jpqZteE/wBR+E3mHAbggU1eIecE413fHgmFpMiNioxNCki3vppZJ642uE9oRSxjBzSGuTXbd6sBFa76/M0gdzhgIVZzxW8SEp2xKjipY4okBAO/mQqO1sCj/Gg4kxv0hW2aEwAZQnY7YJe4U3JJm7MgbH1LRLeKdto9pjYV7+fFfNTfLBi/T9vgjvGjyEQX3Ubwno2aqsUC+hgfWMCBwXzBe7VQw8S9jihNhrHP3iX8Y8j9mPFM7gHtT/i8DJNaA1/gNSONORNiLWRwOkHwX2YnmPOhz1cH7GXtlIusIiWYkk/KB5HQUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8219.namprd12.prod.outlook.com (2603:10b6:8:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Thu, 26 Mar 2026 15:22:31 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.004; Thu, 26 Mar 2026 15:22:31 +0000 From: Alexandre Courbot Date: Fri, 27 Mar 2026 00:22:10 +0900 Subject: [PATCH v2 4/7] gpu: nova-core: falcon: use dma::Coherent Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-nova-dma-removal-v2-4-616e1d0b5cb3@nvidia.com> References: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> In-Reply-To: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> To: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TYCP286CA0094.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b4::8) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: b0bccabc-be9b-4b6f-91c5-08de8b4b7f6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|921020|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 0B10xCIlv+AdX5ZjUJIAmzruv9rPL3L+BBuyEJczTmZOz3Xp9qfF2L7QQa2un8c0uLqh79Wb+tJiqTDBntU45lso6eiTIUfk5uUg2a336O577eCn9LoFn6nAJu5UAVaLINPJlaC31Gdzkyi9A07HdflPS7ZIAnnQYk9s0o8SYNmc8bj3OsGzifONNzwfg55zbJnMPCG5DaaGysq4XEC4oMOMQ3K34RbxwbVXEOT/R7bI3HBNCj9YCmqz3ksR7s4o7I0V75nGlEDVbtND9wFi4+oGgmd0f39kald5H+atb3ToB6v2NAgveYppxI8opoDdEDDKHXZrcsm5nH7zB758uqKCad/tRLUeKhuj9gHpsS8wO9D9YGgqNjkxKMAQ83s5DOm/7JltlceJ0cs2nH9rnSQA0/V/T/dAGoc4JSSdVwV8oQRxZHC0H82wlEvHPtZPFVOCJMoW9iDHDEyUbNW8DRgRYC73hPg3IAzAIhmTdIgjg+XwjMoYeCMQqqMBK0xZiLkjvAgm2imnyY73LG3871lf6zmFRbk7w414MXe5trhJ5FPx/DLtgDbC4G8R0gPGmALdX/82llgew/l4v1rbSm0fVNHcWL0b4yVR4LYBk6B9yeV/RfSe+MS3DevLmHXzKWO4/1aQ06io2xRJ0y48rD4oEYja9Bf0bfjDBPqv8dKYn8px6BZIk/qNDyJkQZ19/T2IVvo5CJz+6OEYLMf8vokgBGBZidWMecI0+yUjs/Ntcyp0nLPn+3VHtNUelRejrbF2PGEvj4Vv6vR1HRCwIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck1tWTJOZ3lrdG1PK2NrdEh3bjFiRFpuM1AxOHN4L0p2YVArZ3FWbVpVcDVJ?= =?utf-8?B?SUtOWk45V0JyR2ZPd0ZOOHRLcjExTjArdVJIR2VMU2hqTVgzNmJuUG1hK2o2?= =?utf-8?B?TEtLTzFHYU1kdXJ4a0tlU3c0QWdZYVpEaHVGZTdMVSszQzYxUHhxczJ4a0FX?= =?utf-8?B?VjdCMWdmL3dQbHN4TGtSUFpmbitsZHVVc2Evb2dZYzVrZWltK2wyaytvbk9X?= =?utf-8?B?MTdmeW83OWNCUlk4cWwvdFJOWURGWnY0UTFSbFkvVGs1WTRPbzVYWG0vVGR0?= =?utf-8?B?Q1hvT1JzN3RlY2w1cUtTbTlXY1YwRGk3ZmFyeDNaMis5MFVQRmNxS1VWZUhy?= =?utf-8?B?K2NKRCs1VWFHVUNNSmNvV3lVWFBHQ2t4TUJUaTVuNlE1eXlCeFcyME9ZSXhT?= =?utf-8?B?aXcwL2JGcEtxMVJZVVVZbWNhWGJsc24zenpaWCtnckt0V281L1ZHQ1Fqem9E?= =?utf-8?B?S3JTc3lmckVDQWRORFJPSmFnMVA3ZGFRRktOVkNlZ25ZQUdIb0s3WUhiVGFN?= =?utf-8?B?S2xuZHcyc3RhM1o3bkpyYm1zS1JRUFVKR3d0eHEvYmUrb2VqVkZsbVNvaEpK?= =?utf-8?B?UXErYmUwTWNpTkNOWWNDblZNcmtzb0ExZk1Jc01DME1vaURCTzBNMHIvdS9T?= =?utf-8?B?L1hubW5BaWVORzliMlBrV3VaTE82YUVsWmlwMGVIci9GN3RTdEtWYWpjemtS?= =?utf-8?B?ZzQ0ZG9rRnM4eDhsUGF5dU84bEVxSW1xM2lkOUp3VCtsd0Z0ZXdyQW56K1VO?= =?utf-8?B?OWVTRzRlUUs3U3dQcnB5TFdRTEd6L2ZUZGkrZ09pWFg2MjRtTlBFdHhidzRQ?= =?utf-8?B?WENDNG9sNUpaODJScVhrRXAyTmRGUXRNY1FMcCtZYkVEU0wwZHEvNStRcWtn?= =?utf-8?B?dFRiYm4rc3hWTXFzNTBmU29tekxKRE1xbm5oVm16RHJTVDZXd2NCNWhsSkRn?= =?utf-8?B?dmpENjNmMEloeUdKdjQ0eEh2UnBLekNxdU5QSjZTTjRDcnNYcVFhMVAyUFdG?= =?utf-8?B?anAyL1NRZnpBMkdQSjBFN1ZXNHNBOENPek9Dekp4NGt1U1RoQzl0QkZ4UzJo?= =?utf-8?B?NkJUUTJPQU1qaWNFQzQ0YXRoVThpbXpDVytJOXA2NnhZeE9HdG0zeDZHaU9D?= =?utf-8?B?bGgxY0YreEVPK09GMGNBQ0tzNC85M08zZ2w3SGhVRTNHaFRhcVdFeGRxdkdM?= =?utf-8?B?a29BN1RkUG5VRjBqUXRKdTFqc1g2SFBENld4akFlcWNCTXFaV0hNeCtoS0dW?= =?utf-8?B?RjZtVEtUckhZeU5KWVl4THptTytZUFlObGlTbjZwd0FHaHBuUFFtZUdVTFIy?= =?utf-8?B?Qnc5YlIxeTVtYzJTdGhreVVEdkxkSXdTaVdvamh4enJ4cmpvUTJ4Mk9SUDZO?= =?utf-8?B?MThYZE9ONDdENGZZTWZ1N1JZRzlORW9HUkxqQ3RvTmFXNzVCU0NsMkIvRUlh?= =?utf-8?B?NVkzYTVwbGFTR25HNmNFUkpPaDZWSFJGMFZFOG9zZ1Fsb2k3R2NudGNhRTVG?= =?utf-8?B?elJjejZOT0xZaGlsVVZyYnJSb2ZEc25WRDlpVTBzNGxPbUtPU2FUMEw5UEk3?= =?utf-8?B?K01KYndCVjJHSkRGb1R6Z0JaTnZzaWFZWVNHeTBBQWY4VXlITFpzdVhGUmgr?= =?utf-8?B?aFRXakg1NVozUmU4c0ttWk1KRFdBaXJOOVZ1SGpDQzVNMWZkMm5aeVk5eGZ0?= =?utf-8?B?SFcyQitPYXNTSWdnMTM2TkIyT0ZFSEo5MlBlbWduOWtsZXZ0QS84OVd5ZW9v?= =?utf-8?B?d1FSUU5Ja3d5clZmTGtpbVJwb1QwU21iMWxoZE16VEF1YmNzTHVtYlA5U2d4?= =?utf-8?B?V2JCOHF1NHJ5UkxOY1hPQlJvL0MwaFB0MnNyZFNvYytPWGdNVTNlMGJzaW1h?= =?utf-8?B?Q0E3MHlkaWlGUktMbmFERW1jZEZvbWFMQnJ0b3FqQU1LMFZtZHBDR1dldG45?= =?utf-8?B?citHQ2VyL0xHaEJUV05KWFhJNGVQNEtvUE1Bdm1zM2IzVnhoY2FsSjBoZ0JW?= =?utf-8?B?MmZHVFJEMzl4c2NSZ1doUWV2QlVINTV2NERGbFZUMnlyTGhodEdHODk2ckpj?= =?utf-8?B?M0RlSnl6NzRvNW41WEN2UFRkOFdXMUk2L0F1N2h1dDNwZlZjT3Y2ZFRNN09m?= =?utf-8?B?Qy9SRkRDQUhhb2JnT2ZaYW1DRGZxQklXdkNXeWhPcEc1T1haLzZtNU5rZUxE?= =?utf-8?B?SkMrUGZ2b0JEcUdYa2dOVFBuZzN1Q2xHSDU0ZFY0RTY3M2p2Y0ZnNzNVMmVQ?= =?utf-8?B?cXp1Y0xKTFo0RWVRV0xXQ21OcVhhWFZyV3pkeWpSaThOMkNZazdWd3VUKzhM?= =?utf-8?B?L0szV3UvK3dkeGRrREh4cG5qUXlQUUpBcVo4MWt5WTRqdER1N1BBQmhRbXFP?= =?utf-8?Q?pOmeTRe79aR1iZazWGpjAatsP85FTJGo0/YwbymXVxq0r?= X-MS-Exchange-AntiSpam-MessageData-1: F4M4iyklXTGSfw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0bccabc-be9b-4b6f-91c5-08de8b4b7f6a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 15:22:31.1535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pw26fY7ySZgGV9CdFtMkRmQ0OZwffkOyJeh8LGU/lJwiz8HHLuaFvSbWx2G6W4Ft9AeI+9hj4bGJ+oisqMmilw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219 Replace the nova-core local `DmaObject` with a `Coherent` that can fulfill the same role. Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/falcon.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/falcon.rs b/drivers/gpu/nova-core/falcon= .rs index c49ec6ded909..e0315fda576b 100644 --- a/drivers/gpu/nova-core/falcon.rs +++ b/drivers/gpu/nova-core/falcon.rs @@ -10,6 +10,7 @@ Device, // }, dma::{ + Coherent, DmaAddress, DmaMask, // }, @@ -28,7 +29,6 @@ =20 use crate::{ bounded_enum, - dma::DmaObject, driver::Bar0, falcon::hal::LoadMethod, gpu::Chipset, @@ -504,7 +504,7 @@ pub(crate) fn pio_load = + FalconPioLoadable>( fn dma_wr( &self, bar: &Bar0, - dma_obj: &DmaObject, + dma_obj: &Coherent<[u8]>, target_mem: FalconMem, load_offsets: FalconDmaLoadTarget, ) -> Result { @@ -614,7 +614,7 @@ fn dma_load + FalconDma= Loadable>( fw: &F, ) -> Result { // Create DMA object with firmware content as the source of the DM= A engine. - let dma_obj =3D DmaObject::from_data(dev, fw.as_slice())?; + let dma_obj =3D Coherent::from_slice(dev, fw.as_slice(), GFP_KERNE= L)?; =20 self.dma_reset(bar); bar.update(regs::NV_PFALCON_FBIF_TRANSCFG::of::().at(0), |v| { --=20 2.53.0 From nobody Thu Apr 2 20:20:48 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012027.outbound.protection.outlook.com [52.101.48.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF4BA40824B; Thu, 26 Mar 2026 15:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538567; cv=fail; b=Ey5f+hIzUK8Nql1jUerlh6VghNvydZ5a9Ee48uq/7SnArepo6JRsuwA5ydpGlk4uq2pK3eRlOOGIyIJXddInyGhWTKQ6w/ymlt+sMJDQa+QBUBDoVLNvnuY+5c9ckCfHPQnzCB+fKpvZ6Ctwmz9Bkj9P8umZQZRcaBlDXXjp47A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538567; c=relaxed/simple; bh=IiFuazPrFSiTwrAcnSyRvBlVitV9FD6C+KScjaRewxs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sGJ3mHQroLvwrFYJrmOjgY+bfxuhD60rXCH1GaG5tCCoaX5aCyIgTWI575fZ1azrNRDiCaHMpliN6ivlzEnM6MdHS1w+ri9sjr4cC35dQiBgx2dinNGWj4Ml396/JCg9kjMdjf8vKyCtbwwYONfMGG940O1Bla+KO4+0CbLQvE0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=dXyhYfUu; arc=fail smtp.client-ip=52.101.48.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dXyhYfUu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qHeu5T564wJOHwm9nH6hiesl0rvsl6UjylfyGsLRhxZksK52RSNyyotpmbBQ29DOfvUClk20hMcOohaeGYSH4Jxr1fSgRhBFN6YTvUpb8/m2rHKPydVCEnA6MsCxxicEse2HFXOxWstWLPlylyGN36JdnsPedEknoXMpzMPtlTZGchWavrx7naaNIEEDDUvk3XKmoIVvTA9E12dXPFs62ay2qTM/5da2UnlH2Eg6hdtP6ttzm9jjJQ+K75oHxKKxf4ChBRNsBcomhECVt8esu4KuSWGX96DTsJeIK6f05vRi5omAFwzLacMmxnHEg5Y5H32YJKS7MIshT0xlmgwm8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xEgO/1iBQU1ZYeyITf+fDxAPsLrMzsxOL2d2oTeOM1M=; b=UFUsiI102eeyHdRXubqL65xwIVjYtvtriOnJEPs+JDhitEhLkZXLijFBZi3XpE+iNv76wa4HGg70hak69UQARzrkQ5/HXYb9w0eamdmFPjoXSUm6hldAjyUcMDiPFDFZBPjcKrHSLZxmiianWvmE+gUEHCtqM0hbeag5m8owXm/k5FOyhruQJzvP/ttseIaCIWj5olqxHn7qUlfLRRpErbmyxhPk1ykKMKxwDeeLBXls/G99Wu8MGTgxWCmL5gcYWjZyC68/q8T8obA3PJVqJi+JXntxHdsBdnDD48KgeveRgFoxYUehtoda1m692VZ4Y6xDKRZbwUcg4t/nlsaksQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xEgO/1iBQU1ZYeyITf+fDxAPsLrMzsxOL2d2oTeOM1M=; b=dXyhYfUu6Wi1NCU4f+a0rZdAuLlAgP68cywr76nniWNlAVLmu5lpItczlEvEVE1RqnDwycCeG643W/HWoun36C9UE9B8OYDwv1F8Wq0Mp2WGL2tqTq+eCoTn+GCAbrsYnXtkI+U4sTkCttGOkpkMHYHLs844Z0A5be2LtTta7JVrdxhadpJGuyA3R3A/wKaI91UaUh7RW7DtPhpsWOARwlkst/1QgrcTG9268Axal1bm+L3bJbNGMC0cnNHZeU0a3TC5+wqotZWvXogeCu3PH9Cwt1Jphl1fBG5zb4fnegS0VHnopDXq8ExgzY4n05T3eCSQdh2UvCTrUm1V+O2tJQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8219.namprd12.prod.outlook.com (2603:10b6:8:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Thu, 26 Mar 2026 15:22:35 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.004; Thu, 26 Mar 2026 15:22:35 +0000 From: Alexandre Courbot Date: Fri, 27 Mar 2026 00:22:11 +0900 Subject: [PATCH v2 5/7] gpu: nova-core: fb: use dma::CoherentHandle Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-nova-dma-removal-v2-5-616e1d0b5cb3@nvidia.com> References: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> In-Reply-To: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> To: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TYXPR01CA0051.jpnprd01.prod.outlook.com (2603:1096:403:a::21) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 9fc7046c-70f8-4ed2-0c66-08de8b4b81f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|921020|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: dZsWHvsd6L68Kg58AtBuBwx9uuvel3r3Gdm8KL6Q+zdx1gvRA0gerOSuOfF5qND5dwO+RbVOP9yWSFGPUOrBK5MMXhro9r7+nXlXnSbRhzWQV84/X+Zp0HokObfMsiiYGWIRVicSvQoLLPUe4Vq386uRAg8kXXtQjZlRQmMOHS1TeRIeZqhvhK+Le7covOltPQjto6aVtCK+Hzt3Hae0CqsbZqHanoVPQ6lEXnHsvamaDjHzb8viOLL+Pq0AHXjhE85ggkjDsSJyHj2RefOGE+CE2V5W2K7Xd+eMlKe/2jsZFPVNjm112ObaH3CZtwXaRwHyVfSj34+LTrWE4u/RqoQbI53RjWU91++AKh+SXXSlNKsyS/DTUSbgTabeDYTPXwc3rCUpRY8i1NxKKLWNgJuD6XohzIz/yLGQD29hYahtUQI66FdOeo4e2WBAr/0br2LTPPJbvgQzcE64il7GteKKLVoCYbpWp7vn/PnJOKyl2UaByvNWecsOAhcIyfLD5CB0cRduEgQcJrKGm9E9ZospG6kkgwZpgu96DtBk/w5D1/Xb9WqxJ9++vyYtKX8ukfQOxt1Cbolp5t4feZNoNZaXTkywUWs+yeO4RY0DQ/IJL7QBfpR7TOEZAMGQIzVtZn6TZz7SaHEf7FXcv7P5OI3/X6tuBQAYQw+gqzdfYcaBYG0hLs1dICu6Jp79ibFRwDgJjP0RPuCq9ZjDV5vpeRq0M/8byqwnRVm4nGvoU/D48EzSdWQNo0IOqaXeUXS5r2JxOc1hPEak0ZYAY/cdAg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEJJOVhOSnVZdVY4UmhPVDl2YWgwWDE1VHptbzJ1R0JyODRLSkVvQkZhZkp1?= =?utf-8?B?UWN5eU81R2F1andhZUk3UFc2bzRnc3EzKytpSkxBMXV6Y2xwaGRVa1BNcVlW?= =?utf-8?B?UUhkVDMwbWxRYk5aSUQzSldtZVFoZ3pnY1NkYzJkZGVzT1RTc2dBNVNGRTBv?= =?utf-8?B?UVd0YW5ObFREbWg1dTN4c0lJZ0RsNldhc1NpdlFSU1RFbXRNaURnRHg4L012?= =?utf-8?B?L29HaHpFVW4zc3VoejVoem9YU0M4aE9Hd2kxb3laNXRwUjYzc1NvWGozN1Iz?= =?utf-8?B?R0tVbXA3TEVkRFBIaEtZNVNKUWFKU0kycHpFWWk0d3BLRGlva1B3TEdhV3Vv?= =?utf-8?B?ZnBGaS8rNkhlQUEzTVZUbnc1LzBKU3UrQ2FqTTdONDlaWUNUWkh3Ky9tNkc1?= =?utf-8?B?aDZWQnRjWENKbXAzQmQ5anVoNEVzWFFQb0hDOTZRbHNzMWhoRGFJM01Id0k0?= =?utf-8?B?anMzUlcrMXlCdE5xTUVyaHowaHRGUkI3Qi9SeHFRSTcxakFBRi9GUjU0ZG81?= =?utf-8?B?UjV1KzVma1BBZEtYQ0c3Kzl6RkhSanowQnZ5YU10TEZJUnd4VVN1T1EvdElV?= =?utf-8?B?bUJNcVdlYzFBK0pJK1d1MmJncWUyQXI5eGVHZ0d0bFVEVTlZci9XK0VSSTFX?= =?utf-8?B?cVdkWDUzUzRUQ0lPR25Ba2w2WEh1allMaVhLK2hSa0loTllOYzNOcENaNWov?= =?utf-8?B?R2RvRGR3OUdOWXd5Y3h2ZldzZ2k4Zk5CRkxQVHZCR3VITk91Q3VTTnRHdGVj?= =?utf-8?B?Qm1xMUhyQmkzcE9OZ0ZGM0ZnalBCWGlKRGswRHJ3YXROdXZRY3VERUJFUmJn?= =?utf-8?B?L1ZVSytyRGtmOWxYNVZza3pOVG54S3ZjZ2tLMjAyenpIOEg3NkRvdVVRUTR5?= =?utf-8?B?ZjNUUm9SOWpoNGpiVjZYVEJ5T2kraGNqcUZVSUNGV2U2TnFzRUhZQXhVajJW?= =?utf-8?B?UGgrVUhhSWxhNEhRdlJ3RGVrdEZ3K29WYjM4U3JaQ25vU3Z3dWpLcFllS1d1?= =?utf-8?B?Qmw1SzFVT1lqZ2ZhZ3VqamZtMlJoZzhzUnM4Tk5FZlF1S2lqQ2xUZE04aU5K?= =?utf-8?B?OXFxYXFaNVlhTmNRZnMwUFdpSlZHYThlZFNVcURhT3g0Z041Nll6ZFZYRWlL?= =?utf-8?B?YmU4L3pWYnlnNVJkeStrM1doZVdhSVgwRVJOQ1dKN3EwcVVCeFErS0JRVjZX?= =?utf-8?B?VUhNcUFVUldnOEdjQU1pQ2pzOStGcWhkV05wTmNOdDdBRkVxODZWd3I2WXpp?= =?utf-8?B?NGI5cWgrdDdCT1l2SUM1ZkVLNThSRVZtbGJDS0daclFkZHFySW5HYkRzbGth?= =?utf-8?B?TVlvYjBWaExNRFNnZGhjSnkrM1RWNmU5MzlCemMxT0dFRm93ek8yUlBkMjBu?= =?utf-8?B?aHpkYkZRcUJ1VFFKR2V0WEFQN3BEMnRBZ2puMk04SFlFblY4enU5OUhaU1B6?= =?utf-8?B?VFk2ZDAwakU0TzVCRmgxeVNkNGlQaVJPT3cyNjhmbVRwblJCMytNcFVYVDJt?= =?utf-8?B?bVJqZ21ESkJGMVl1QXBaZXVXOUU1bkRYWDZzUmhSOGRzOGxCbjZURW9UVHZS?= =?utf-8?B?UWYrblhOQllkVVdVblZuYlUrelVQaG1HRmdUU08ramFzUm1WbE1XZm1IY1Ni?= =?utf-8?B?VGxwRm10YlZIRzBNeWc0NVNxN2ZBSU5Td2NOdmszRmFvaVMwRTd1aFA0T0di?= =?utf-8?B?amNVOEJsM005S0JaT0o2bGhyRmlRUTY0cEs4a3BUZEoyM2UvZGJtRjRkRlR1?= =?utf-8?B?Y1RSUU85QVlmWHFJMG0zcGFKcnBNVk5WQnEveDQ4Y1ZpV25wRXBzaDNURDNL?= =?utf-8?B?ZWNwcmw3ZW5scFBTcTNxQ2tMWGZKdXBNZk93TldpSTZSOU5oeitCZkZZT1ZK?= =?utf-8?B?RDJ2dnNrOVRGa0lzbEl5NXpURFg4dnBHYVl6VDRBeU5SQWMxR1IrYXVHVVRI?= =?utf-8?B?TitLUzVkQlFsMkQ2d0JyY3Zib3FvK3Brb0hnV205V3E0M0xhc2RjWk5hbU1u?= =?utf-8?B?UzNhQXF4L1N4bUQzRCtCRktEQjh6RUJPZzl3RmI1WWdMbXAydHNFdmlrZEwy?= =?utf-8?B?dzdGRlcwZ1FKOVVLUFdHejJidzA1SmNnSFdLdzg5OEwyaEIyeEhjOFcva1BX?= =?utf-8?B?SkRoTTJUNGsrMncydDhndUNZQW14eUt1ZXBRSjNEZzJhdDVrTThpWmZWQ2Rl?= =?utf-8?B?VFpETDZZcHhvS2d3a2lIR0Y0YlBKTVBYSGhpTFZPYTc4dE4ra2FvUThlQnFC?= =?utf-8?B?LzBNdCtuWUp2Z1FZQlZQZHE4VVZYL3BOUkxXZEVGSlBFOS85SnY0UkJTUzJo?= =?utf-8?B?dFZOZmRQRGliY3ZSNnYxakdlUzJUWXFOMGIyRWdOMEtMZzJYL3Y2R2cxNDZ5?= =?utf-8?Q?zYszcD+emp2ZFoQs+Uvvi0lEjgs3jFaBvaTOiMVnzFKIX?= X-MS-Exchange-AntiSpam-MessageData-1: lrn4Vc25tklzvQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9fc7046c-70f8-4ed2-0c66-08de8b4b81f5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 15:22:35.4334 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W7opoMUzE72E6E2r8WPCBGMeonEdO80OOVoDfN7xuZGTTrMJ7pJgpNZJqA1pqtlgrKSg//EhfgRxjtEjin+tIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219 Replace the nova-core local `DmaObject` with a `CoherentHandle` that can fulfill the same role. Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/fb.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/fb.rs b/drivers/gpu/nova-core/fb.rs index 62fc90fa6a84..bdd5eed760e1 100644 --- a/drivers/gpu/nova-core/fb.rs +++ b/drivers/gpu/nova-core/fb.rs @@ -7,6 +7,7 @@ =20 use kernel::{ device, + dma::CoherentHandle, fmt, io::Io, prelude::*, @@ -19,7 +20,6 @@ }; =20 use crate::{ - dma::DmaObject, driver::Bar0, firmware::gsp::GspFirmware, gpu::Chipset, @@ -53,7 +53,7 @@ pub(crate) struct SysmemFlush { chipset: Chipset, device: ARef, /// Keep the page alive as long as we need it. - page: DmaObject, + page: CoherentHandle, } =20 impl SysmemFlush { @@ -63,7 +63,7 @@ pub(crate) fn register( bar: &Bar0, chipset: Chipset, ) -> Result { - let page =3D DmaObject::new(dev, kernel::page::PAGE_SIZE)?; + let page =3D CoherentHandle::alloc(dev, kernel::page::PAGE_SIZE, G= FP_KERNEL)?; =20 hal::fb_hal(chipset).write_sysmem_flush_page(bar, page.dma_handle(= ))?; =20 --=20 2.53.0 From nobody Thu Apr 2 20:20:48 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010046.outbound.protection.outlook.com [52.101.46.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17DE8408230; Thu, 26 Mar 2026 15:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538570; cv=fail; b=LOuutwHITijYjRsTPhBCvCKU9Ubkc5b5wxCLKO9Bzkc9Uk4gNbBBGJO73hK2aBSMUT3rHqopFW+3hbLwLko2fYLJPsIir6i9MrPqtlRDxMQTLf3XFBLXcQ8cthtFsu+W6DOiEUrYZrV0UcasYZ/qXiOB6WvUx/6AFb+d1G5uuvk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538570; c=relaxed/simple; bh=Um6upCuw8NnFoleA6CZYSw9ui6ykpcIDxj4Ua76nuZY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=gpsK9TvR3C8b6CdIjFRm4ZEpbhHbUzbrK75zAQSKtItcbB8n8dy28ARAcv6jI3etyM/7qbkZr1AwrB83bdfIsID+ngsT01Llr0iTsCy/2zAzex0lmTG8leUd1gcVFSWl+lTO0Z/p+ZHHqhklmS6UHJAiIAQCYq7vj4b0nhf348M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=gimcCKsD; arc=fail smtp.client-ip=52.101.46.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="gimcCKsD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VjzOfF8Th0ZVAWRSClVSkJDT+/nQieMe4E5MRqrJwmDQTyIY+DFkfq2JkqDMBkecSaaCiaTJPuu6lyvMRXZcNsVQHbhrvIDaZXuYFnINVtKv2Jz0M6JIwQFXsUPE75Y1blhT6prVLHitRRMGxE23+QcUhuhxlMDN2drOSwRvijwoAkrjfLpTxGbnBlYDB1clDstwmXkh80qCQtee8eGxA3IHduZmT2oPvXPQrorLBqD5XELhEubH5Np3MEBmNSGOquXZw+lsbCwVzad+GZRMLbJXVkfLKR3KvYxTf+u1HtwVPDzAddrwVFaBnVH/kIFvq7srgnYR6bj0BHPrUnmp0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NX7GNH24NfNzWEucDo0mCUY9YlZ2NmVgYTKii4jCzbw=; b=LP5R/Ca/sBvpA08q0kU2Wr9fUdUEXBeHLIpzHuO6NiX58lwc+TBVaJlAbv8muIPrQ3VHKmtR5NvouUpRp5/GzRFkCaz05DU8id8YewLUleXSywbL+S3FBQKEwNvpuchgfEtzwD5JFIk1M16qYvcqvHv6b67YeRR56+uIRxH/pe+3aU+IeuVyq9gQq2LoAlvkgl0lBC2z13E/r7VrcqDHQsJnLrFR4O6bXJasuTFoP07kdDdK3svEPHmHzH2dZPZ93OSwsTGabLt0K3MyIPZ4eVaT4f8Z0yANVNVGZLiV+g5ztSpLuYn63xARTYPjBewioJusGSqQTWzcxxp0BHomHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NX7GNH24NfNzWEucDo0mCUY9YlZ2NmVgYTKii4jCzbw=; b=gimcCKsDLNzm5l16EN1+KCnir1WhvBwV4s0wzXKLtf1EqcvglmKs7ZNSJGqTdR5B3a/T1XwRSOiUR/BxN7JUci3SZvto0y/90DHh/2pf7SU2saSNZYt1KTCm9ILOMaIRi7nPe8ZKlmceD5UhpdcojQWupJ31+yq4HZUAHs++npcWmPZNwldcnEpjYSef4Y9E9SE4WViihXK9m69blNtMrbK6iCeO1luVqhxjT1TpxuvWzh3++TxmCe6N8mGrCpZviGMpPsPxydjmy7BCLAqqKbkByKjmOobu+mjn182P+Hh2Lu9tjC08Ux+qzkS/sDyiE2vxgM/eIKH0gvS1CkRRsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8219.namprd12.prod.outlook.com (2603:10b6:8:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Thu, 26 Mar 2026 15:22:39 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.004; Thu, 26 Mar 2026 15:22:39 +0000 From: Alexandre Courbot Date: Fri, 27 Mar 2026 00:22:12 +0900 Subject: [PATCH v2 6/7] gpu: nova-core: firmware: gsp: use dma::Coherent for signatures Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-nova-dma-removal-v2-6-616e1d0b5cb3@nvidia.com> References: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> In-Reply-To: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> To: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TY4P286CA0128.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:37f::17) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b20f81d-8fe3-419a-4240-08de8b4b844a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|921020|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 1jNFmmvSHH+fln4UwvK1/oxD2U+ItTeGQ2i0LWsDjcD/pxqITeFGWuX4R+Q4zjfEKHLZzmBOJX86gOMip1dWRZEH1Pgs+woQWomfr+ie1Ojrwk2VmUyjCOSelbGlR5ZHFJbfoFqpw+2JFWqkZGXbREvDOkgbqpuA/bw/upFxOIdCNJ8sAjgy5AIb65jum2t5N9c/cvNXUPjWzTiuBNEyAw/g4yqbX0ko75HT/WYf31s56lxVwtO03G1I8GNLe9oIDwEieC4HPY9/h6t5P5VQKMW4+/WMuXLIu9V6ujm0nRd9Bc/BOYtAhP9tcNmB11fuMMbpfk0jg0xRU/kiuLMdfriBoeRW6YsQe0Ig3DweVI1dvub9IjkqpCedB2VP9zdVpuyYvCmQXzcuH8Y4I0K9tVF4RVSdybiG7VoJjV8mdvBajgQ57i75unfupKcGD5oktFOlBKhKbcOuVY37a3nsOjJ3yRRgeo5A4N/pzYVrt60RQiLWAccyf2OHeNZMmfP0b0+3TXBLwO44wI1+BOJjn9bbxnBTTavURPiVLymBm3gMjD+HpBE8bXtZR+c152c9xfjMIfLMf97kQwaMTdJiEJ94XeXfZYHFUPfdWMV870wjfZc5rOFWfmeQ/qRmzYGXP3VN4nx6bZ2Zeq5PuOY1UK9aXgepRomuzix0INbzeo4bpjQbrTJU63oB8GdxC43pVnjngYpDjBU4DdpXQOPBan5ILflKWgqIQ7rUXo+0dmECZM2/20WZqGvGXApLy06RIrqq6oBRR54y4fwPHJCOOA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUQ4UWw1M3BpUUQ0Rkdkb3Rhd3hZMkthbnNxQTVYMkorWFZ0TTlGVThMZEVt?= =?utf-8?B?RnJoWVZQZTJ4cFdrTStCWUFyN1kxL2t5aEc2R0YveURBMThUV21MRHZ4QTh3?= =?utf-8?B?anFVaklmazg0MHU3VDJBOHR1MDNlVUFxWE8xb2hsZ1FRNmxaME5KQkQvSmRi?= =?utf-8?B?WmtXZ210QnoyNmt6dk1IeHY1S2k4TE1jQ0YxKzdGcXNvdTdjNFRmc01xb3BD?= =?utf-8?B?RDdtY2RQaC9EV09PRnhLekFVUHNkYUd6K01WaHNhazU4M2pjVGRtTENQb0VP?= =?utf-8?B?ZVhCa09BblRhREExUmFrbjNiRnBLVFpXd252WjZIcm5SUUJIcWpsckdNSnJp?= =?utf-8?B?Z3RqdEZZT1k0UTFybGd3QWtWNWZRUDF5VUhYNG0yNHB4czlzeVh5MGtURndD?= =?utf-8?B?d2EwUjZNWFpSa2RodXFvN2s2b090cmVud3NvQ3hlNGY0TGtsa2hkSEtqNmZs?= =?utf-8?B?WVJVZ2VIWnp2RHB4STJDdXQ5dXFNK2p3MzQwNWRFR0pZZUZTMjQvSWFneklq?= =?utf-8?B?Y09PSGxoRkROSFBQR3ZUejFQMmVuMWZ2c1pQM3lXSXlrdjM4SnhQcjNMNExG?= =?utf-8?B?YThQV0ZYeE5FSFUxSmRUUjhwbDgrZ0hiaFRrcVMrTEpyMDY2aTJSUDNJcFFO?= =?utf-8?B?SjJkM0FSOUE2aHNrb3EyZHlpeE5pN0NHOXJ4eGRBWnpZN01qTDIvTlQ1Z2xx?= =?utf-8?B?SGZMam0rMlZvMThMSDgwcTdEVmFsRSsvckZnQnA0TFRoWk1PdmxwdVFiQXl3?= =?utf-8?B?clh6eFc5R2kyeFZjQ0ZabG95c1c2WGpaR2pPWTJYMGs3Rnh2eXA5ZWV4OE1Z?= =?utf-8?B?R1JLWnJsTEhpMjNvOWFpUktVdjI2aThHOXU3MVJsY2lBT0ZvclhEZGh1SlJV?= =?utf-8?B?ZEx5aE93RHErK1lHVWFkd3JORUFXT3JmYUJUOWVWZ1RQNG5lTkRQbXVIYXgz?= =?utf-8?B?Z21wRThaMzI0U3pteEEwcmw5NERKNS9kVFNjVytLVGgzWXRlSzZ4UG0rZEhN?= =?utf-8?B?MVFoQXRQY0oyT09nOTdzdnZKcGl3Zk45cHczamx5SnV1N01LM0NIZ1dqVExl?= =?utf-8?B?T1IvR0hnT2VhblREYVFFQ3k4Q0g5bEhpRENpODdKVlJuNEdBSFdDcnBTN1Fs?= =?utf-8?B?eDBDdm1LNmNpaUw1aTZqc21JRDh5SnRYcHpQN1JoaDVYd0NzampqRWx1OEpx?= =?utf-8?B?SDMzSU5CT056cHdMRkl5MG0wL0wyMWRKdWJxYXVHeXRieFh1TkY4M0NtZXFS?= =?utf-8?B?TUNTV3BndEQ5RitZaWwvSTd2WFliQlhldEg5UERRWHpJNkVYaUtrUkUrTFV1?= =?utf-8?B?emZnTkcraUl3YUdlNkU2QTdTVmRsY1BKc2hHbW5ScEdYOERBZzdFWnlPWi90?= =?utf-8?B?a3ZvMktMLzUxU1QxTUtFdXhIbVNMVkFMbWRpMVRmb2crZ0VtQ1NuMGJIM3FH?= =?utf-8?B?ZU5ndTk5VHYyTFBPMEZRbk10Zmt5NmtINWszTVRRcTJkOG4yOWdod3JYSy9B?= =?utf-8?B?L0YvblYyOXpvOGhycm1ORkZ0TlpXOEdTZnRHb2V2RHh1ejhNVG85dVRJNDYw?= =?utf-8?B?akRqRXNER3h6azdEN2Y4U29ZeTJhNVUyNXV1RjM3V3VTL3NDd0NaRHNZTG1D?= =?utf-8?B?YVZHR29wV3o5RkEvT3NxeTVmbkdHY3R2TnU2OWx4aHBkVE5UeS8ybG10eFRU?= =?utf-8?B?elg2aFN0NnQwQlEweU5waDFMRitLUmE1NHhCRG0vdjhVRVp6dk03TUlhRERT?= =?utf-8?B?ZGhYN2NLR1Q1TCtBbUowcnVJby85bUtPUEVGVGoreTNsTmxhTlRjTWZXazAw?= =?utf-8?B?WmR2a0RlUmU2ZUdvd0dvaDJBVndNdDVlSmxvQWJTRnlobjhJUGpURHExNEt3?= =?utf-8?B?dnErcnNOUzMweUxrTDY0M2ttWnpEOVNrZTZKUnltTGx6Z2FtODBoTEtRWVZD?= =?utf-8?B?dlBIWGU0aE41MlFUVGM2OEhmRzZRZ1JxUmMxNlFHZENNVmhwWXdRcmlLSnEv?= =?utf-8?B?cFRnS2NOLzdPWXdVci9hcUxGVVdPTHpKR1RnaHRiMGt3Y2xFcVlYUlFPdWRw?= =?utf-8?B?WERtbGNSdjNSam5oeitWSWhHSkVqOEtQa2pUbmVjelpWWnlBbjZ6SjRKVloz?= =?utf-8?B?RGlmY0tlS29Db0F4MVFZcEF0TXNjNEpYaHNYMnBIMENValNyeG02LzNVaUQ3?= =?utf-8?B?NEpIbzdudmZFaTNnNGFlUk9CdWpUVklaUE5pU1JsODhDdm9nZi9zUVp0bitu?= =?utf-8?B?c0JJdWI2M25HN1VERUtKY1VTcWRiTnl5dHlUd0lrcitBY1VDZ0NvcGhIUHRn?= =?utf-8?B?cXRrZHR2NTlFZDFDdHhOZWprenpsY2srSjRhTDNoQnJ5MnBEZmdsUzRNT2FE?= =?utf-8?Q?Hm8YaSpWFSWAwR0gGzSOj36nlpYAD8izjg+ExqMl8OcDq?= X-MS-Exchange-AntiSpam-MessageData-1: 86SqsxAUeviSPw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b20f81d-8fe3-419a-4240-08de8b4b844a X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 15:22:39.3119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E4p45itTUrJavr8Ugbfyjv5BdCG9h+SomQH0qYDlkLIBpwaFfsrTeJ9EAfYqAbXpy4iFIKe2sYqCiMtFx+/k5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219 Replace the nova-core local `DmaObject` with a `Coherent` that can fulfill the same role. Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/firmware/gsp.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/= firmware/gsp.rs index 9488a626352f..1e0d545a74fe 100644 --- a/drivers/gpu/nova-core/firmware/gsp.rs +++ b/drivers/gpu/nova-core/firmware/gsp.rs @@ -3,6 +3,7 @@ use kernel::{ device, dma::{ + Coherent, DataDirection, DmaAddress, // }, @@ -140,7 +141,7 @@ pub(crate) struct GspFirmware { /// Size in bytes of the firmware contained in [`Self::fw`]. pub(crate) size: usize, /// Device-mapped GSP signatures matching the GPU's [`Chipset`]. - pub(crate) signatures: DmaObject, + pub(crate) signatures: Coherent<[u8]>, /// GSP bootloader, verifies the GSP firmware before loading and runni= ng it. pub(crate) bootloader: RiscvFirmware, } @@ -226,7 +227,7 @@ pub(crate) fn new<'a>( =20 elf::elf64_section(firmware.data(), sigs_section) .ok_or(EINVAL) - .and_then(|data| DmaObject::from_data(dev, data))? + .and_then(|data| Coherent::from_slice(dev, data, G= FP_KERNEL))? }, bootloader: { let bl =3D super::request_firmware(dev, chipset, "boot= loader", ver)?; --=20 2.53.0 From nobody Thu Apr 2 20:20:48 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010044.outbound.protection.outlook.com [52.101.46.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F61340B6F0; Thu, 26 Mar 2026 15:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538573; cv=fail; b=noW+H4/n4iB9+3lfQ4pe47bxFidfmZqJJQh+DiU191WD2orYs5eLVpEd0kJJu0SrXvrWDxB50VAtiVgs8ay8L+vmc9XMx0JsbcJy3CK5DQSlRCPV2bCtJgFNpf4gHtV9u2h/D0fQt+AR/uavQOWDTanrHhe805R15neK63RzyiA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774538573; c=relaxed/simple; bh=N9tOzynec3u59QnipEkvP+TqlTEyb0dWIunRBkJrbgw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ZaLV4inhVnxxYY0qdUprKXiV1XlHI9fHU6akR8YudHJZ4pQ7XOGkRiVlIWKH6rxZXHXzMQ/9oqPcgiX+08j3jI1YFQ0sf8XUCeiVBXYaoxG/Wv/0pBvf/hGYBFECFpJgcEpvfdLzfczXRfMdjhC+jNlRdOjCi/Fuo/itCTUBfA0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IVFRf2mX; arc=fail smtp.client-ip=52.101.46.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IVFRf2mX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=U1J7te6LxYoVz91VpandQKNTq7Ao28zDXAU4+j9Fna4+K48kt2vqxJEYvAJd+J177B2onoRjLTcxJKR8CXW2kIBavn0pXaQHyA3YRi6h9uan05LNUXWPRB/NJjsS2La84grfmX7lHXE2o3nymDc9f+H5KD6zHfoxcgtm4zMd4qu90fXuB4uY4qihSRWK3S7rojq/59u3x3ovZarNI2zYiX612y37MiqNFJt7P4cvKc2MDck+hqJqIvnn/+KJhKx0rWtkSzihl11y5aGazqQUwIsIlWlBNpFkW21MiVwpOqTiAdYGKO3gmCnnThOVxaPo4+9OfSNd8y6EQ2nn5lra5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ISbY7jPRrk6ha1zZm5Mf4tfRAfsMOr2J0DvoSqCAo9s=; b=x4dfIb21J5ovPhEsEweXfjZpnbt7nAzOyg0YL4+iz82T9GLQokX67+YsHXTo+sxjMV+99m1t7Qystg6GUE6qZREw67YldrREYR8IimkRFQ++UnMSFMK/IPjkj9hCdVyxGweRhpZXLTcm8ZbwU+vd06gM+Luy0RaUlt5NblG8+6k8G0cgOaJ0HZDMPZh8jZIKtCwUw5rObs9vU8+NBGZxYl3ATvjK5kVGyDqMlsDuoxYDccGFm/zQWWsQ93P+ko1f85DijFbGIrjqEntV3k91VEwUy8R+nP3T8GmoaGBAVKi2ANDy6cwHsmohtBw27Awm7fPYnAJlz+W4USulTP/AIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ISbY7jPRrk6ha1zZm5Mf4tfRAfsMOr2J0DvoSqCAo9s=; b=IVFRf2mXT2MPD9GHusJAx/9si3uD9VtKfb30PjpPeakaTDjgyEBLX0wBYoJZxRZM7QbfCig6gdM48nVbQnB4RRUKfwQWtAWHRYNBPCPDU3eUeezF3OpxadNWw0sRtodI7FdULgi07FXIUWwbuLk6FK6LtxZ/9nzJDjB/9WC98Lv/Nj9HjyJyNlvSYVNJrM1IbzkRDX+2fnV6OdNs8D94aLeuGb0FqoT1dgLThnxUTocX+9wtnNVhXFXdQu2C5WZHrYaJFM5zB4vUf3Raf1v9dn24YILmdte74Pb6Lqc/mJ4ySd+WiI+V72nsLeossBCozAxObMZaEGovqX0/aj8vfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8219.namprd12.prod.outlook.com (2603:10b6:8:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.7; Thu, 26 Mar 2026 15:22:44 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9769.004; Thu, 26 Mar 2026 15:22:43 +0000 From: Alexandre Courbot Date: Fri, 27 Mar 2026 00:22:13 +0900 Subject: [PATCH v2 7/7] gpu: nova-core: firmware: gsp: use dma::Coherent for level0 table Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-nova-dma-removal-v2-7-616e1d0b5cb3@nvidia.com> References: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> In-Reply-To: <20260327-b4-nova-dma-removal-v2-0-616e1d0b5cb3@nvidia.com> To: Danilo Krummrich , Abdiel Janulgue , Daniel Almeida , Robin Murphy , Andreas Hindborg , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Trevor Gross , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Zhi Wang , Eliot Courtney , driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.15.0 X-ClientProxiedBy: TYCP301CA0044.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:380::6) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8219:EE_ X-MS-Office365-Filtering-Correlation-Id: 10c2b25e-5931-4e7d-60bf-08de8b4b8690 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|366016|376014|7416014|921020|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: jGO07/R+UYYwrLyfJDy8ZoNhtl0ts8nDgdmaWcofIGoWIecJvm3pWw4iBiBP2TcB/FPz/IIsO8ryfRdzmCToxKURrtKB4dYS1DWbaLArlBJ47ku31ciE4tBTEP3ZtDaRu2xtCdUeSzMwRB6VcNvoeJtWb+HEJqt4mI9ckhqRFYnXqGnlup2UDFU2yv+8WX7GcOiIH86WKCpqNSJ5E7Flh8k4Rq9ECard0cq0TBiozDpVnw24T0Wu3nKt/aM0feRrfHkp1VOmy8VQkUe54si1Tbz//80eDx/m1l7WHn0GhLR1H/6DaTOPypFfeX8aruSmj6WMfSbGGiVp+QP58lhY4mE8l16m8d6uU+MCEcsAo0KP0PPq06kx6Tj1/XGqZuvEwmWCWMdfr7UAXox/XVqcFq8tVrTW6EsI2rTYpTRp2JcctJZsZKKtZ5QpOs4ThaXYiDOqBQ182fQg/gYKz2TokjQ68mA/GWDTuj9kONGFypBK+T4ZiQvYlTVR3Bp5qZsHHZO6hC7nKn1MzEzPGGfR68wKJHawefqnzOjsa63pMrBKEAEK+Ju0qauS9sHnV8EqD/m0TZ6S51cTFXYHTeFFYtEfmJJO1yu0OlvjGlnUjKAtUrCQvAaMl0oRVVpoMb4PhKXVoRlQsN+E17PMgTriEC7mSw7RUxH3b5gcaxHZJ1eBRPF0q6SbFGFH8Sr45hqH38NxWSWFBl7yFrKUyRrP5WwHoYmHs23HsjkDoSDiT6riUq6n/0SkfO3INB3KuImwkSGbflBdEiVNunHoPbkkoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(366016)(376014)(7416014)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUhONnB0SE5hTUR6YjZmcnpoT2pveXJhQzZVam5IZzhEaUJGcWUzSW96V1ZR?= =?utf-8?B?ckIzalhWQjFaYWZ0MnQrNEpBbElBeEwrV2IvUnhqWDZwRlF1cVRQcWlScnlN?= =?utf-8?B?RSs2dW9ySkNBQ3grWkdOSDUxUm9XcHdtSVo5MjBsMlR2cXF6UFhtREE2NjBw?= =?utf-8?B?cWwrdzhQSTFmRDFqUmRIVTVLWlQ2dTF6NTVPb3lIYXpEaXJJa0hVSW5Bdncv?= =?utf-8?B?Z0l0NVg3eGZrUENid0FpdHZYeDhZOEg4ZXVZSFk3bFE3aFJ6bzhkT2Z5Tjd2?= =?utf-8?B?RlJiSmpLTU9ibGdoUzF2TUJySC9TQlYwOTh2cUxYeUJPakhwZjUyNmZJSm9O?= =?utf-8?B?WldqZmw4cExnaUVKc2dpN2Z5TUNkc25ES2pvVElacXFheWFiNEVSWkZrb0JW?= =?utf-8?B?b0xmWFFJeEFPbmpMR1lRM1hJQlI4VXdOM0Uyck1sS01zUUNOZ2piTjlQUm1K?= =?utf-8?B?ZnlDbVVCOVpBWWVVSHhkcUFlbmdTdVc2dmdjNXVheWdOaG00U1N3NW9tQjZK?= =?utf-8?B?YUsrdVMrcS9jTWF4R1ZUd1lVeTQ0Y3RnampValI5c0RWNTJuSXlobG5VVFMv?= =?utf-8?B?cUlLNExFNGdZck52SzZ1eEFKUmZIZnRvKzVYazUwSHR3QXI3Q0k0TzZwQVpu?= =?utf-8?B?OHRHcXdoSzcrUmtNcThIR1FVUXdDdUI1OHhoUGZRSjY1aG1KNDFzMldyRUhE?= =?utf-8?B?Y1FEd3FQOFFvSjQ5RWxMTS9PdFFGdnZQcVR2cW5aQ2hPWXhKTjJkc0JYZEph?= =?utf-8?B?UGJsdkhaUDJ4akJ0U1NhM01zRlFwenNsbTJvSWFwZVlVQzlJWkY3T0ttU1pC?= =?utf-8?B?dXdzVVRIUmRVZXpJZ1lDZHlXUnhCcWI3enZHeHcwV0M1eit0em54ZzZMNDh3?= =?utf-8?B?OGxVbVlaRFBwa3ZoVExvdEJVMXRMUkJSM25yVzBYR09IZTRWSTk5c1VjS3Ri?= =?utf-8?B?SGord0xWTjgrSXZJZkI4VU9JcS9OWU0wSzFDcTVaMmRNK1lmME4rQTYrakYw?= =?utf-8?B?QlR4SjRnZExlRFpHQVZvT1F1Q0dqbmdGakVZVFpFS0ViTkJWQWRVb1hNbURL?= =?utf-8?B?dTVvMi85MmMrWGRyM0dtQ00rOFo3b0IrdzJNVW1NR1hkZDJHdnpPaXRKZlls?= =?utf-8?B?SWRyMTNPbG9QemtNdlVUcmtibDZxNmY3UHFTU3A5OWV3OVRTM3Z4TklFeGNX?= =?utf-8?B?TGROa1kxNjhMN2ZKL2dkaUZQM24vTGU0cmlXREhCODkxWERGT1FIQW5WSXI5?= =?utf-8?B?OWQ3MUJXMlBxMU5iMXJGcmNqeGxrYXBuSE4yTXhkYUlCSXk4NTJmeXhvTWtE?= =?utf-8?B?bkdUUm8rUHJTbGlCeERzV2dDaXNveHZGQlRLZXZ6SHJZNVBjVC84Tkw0eXJ4?= =?utf-8?B?U3ZncTNlY2NwckFuREo3V3NnUHE2bFVxM0pkUFFQYU1sdnZBQ1A0dmpnZ3Yv?= =?utf-8?B?N3JoVUNIMUc4L0ZnTDZkRHFoZEd2TGpqeVpNOEEvYUo0WWp1eDdmRGNmaElJ?= =?utf-8?B?KzlpMmc3ZENaZGR6VStvb05TbWQvMXRaYkFZSm9McHN0Nnp3VytoQ1dlYnly?= =?utf-8?B?KzRhMmVSZ1B3OFg5aUxqdEorK1hCdzh3UXNYWHdoNjhpNGtWZElHWHNpdkZo?= =?utf-8?B?dmRzcEhnL2dnZFdCN2FoRVlFRXBVcHkzREZUNFg2WHVRVjB4Y254d2NwWFJD?= =?utf-8?B?ZXh5ZDI2dVEvWUY3V3JSZ25odW1FV3QrVUtTMVJ0cE5IbzZZUSsvclRPN0Qx?= =?utf-8?B?cnBVU2RCemJuQkZrVk1tNGNIbTBoS2J5amc0bTc3ZkRiaHJVWFN6RFZUVnZq?= =?utf-8?B?anZ5UkJKdXJtM3lxazJhWUEyMng2ZGVPbjloMlVrSWEybGhXQUdLQ0dVZFJp?= =?utf-8?B?cUcvZDFEdndYd0MxcjVXZmV0aXVKZmVCWkpuOEczVkxCQ0RJTHJBMUxUQ25i?= =?utf-8?B?Z0h4TFFYMG9CS1ptYWdzcEJncjBjenFHUFRlejVQQ1Q5YTZsS3RiU1I4ajcv?= =?utf-8?B?UWVpT1FwMlNJMWVUTWVCdkc0UDQ4emd5ZnJmTGdBZXRwc3ZlKzdsdG44dVNR?= =?utf-8?B?S04vM0Jac0hWQkszdUNXL1dkZXYwY1Z5ZHBmU1h2QTdLWGdyS2hobW9HL2lZ?= =?utf-8?B?cDBWVDQxWmcwYUwycGlESzlQM08wSUoxVk95TWJJdHBtWExmZCtFT2YrM05z?= =?utf-8?B?UzhUSHZqbnV3dnhXVlQyZ2xnS1ZES0RvZkJPcmpJT3hscE55Qi9WTks2czF1?= =?utf-8?B?c0ovVlVVenl5bW1hYjNCWjBKam85MGV0MGZBNkRJT2I2amhscDAvMElZMlEx?= =?utf-8?B?bklUcDdVVDlxZTkwcUxQRHhOdXRGb2FtdzM4UVIyRW93d2dPOTRIUHhmY1Fm?= =?utf-8?Q?bFrFkMExVkKmIJ+AIMeirvtYX4nJ+1PObNtAs+7djhzur?= X-MS-Exchange-AntiSpam-MessageData-1: w3ZWLpDPOqQ9bg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10c2b25e-5931-4e7d-60bf-08de8b4b8690 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2026 15:22:43.1415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kNUzbgXKF9bNHEvQb0SbK2erPMtVeZFIRZtJpx/W0xFSSQFTLCYiVSyYz2UMEHF+I3Usgv3ncV9MktFp8dsptg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8219 Replace the nova-core local `DmaObject` with a `CoherentBox` that can fulfill the same role. Since `CoherentBox` is more flexible than `DmaObject`, we can use the native `u64` type for page table entries instead of messing with bytes. The `dma` module becomes unused with that change, so remove it as well. Reviewed-by: Gary Guo Signed-off-by: Alexandre Courbot Reviewed-by: Danilo Krummrich --- drivers/gpu/nova-core/dma.rs | 53 -------------------------------= ---- drivers/gpu/nova-core/firmware/gsp.rs | 22 ++++++++------- drivers/gpu/nova-core/nova_core.rs | 1 - 3 files changed, 12 insertions(+), 64 deletions(-) diff --git a/drivers/gpu/nova-core/dma.rs b/drivers/gpu/nova-core/dma.rs deleted file mode 100644 index 3c19d5ffcfe8..000000000000 --- a/drivers/gpu/nova-core/dma.rs +++ /dev/null @@ -1,53 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 - -//! Simple DMA object wrapper. - -use core::ops::{ - Deref, - DerefMut, // -}; - -use kernel::{ - device, - dma::Coherent, - page::PAGE_SIZE, - prelude::*, // -}; - -pub(crate) struct DmaObject { - dma: Coherent<[u8]>, -} - -impl DmaObject { - pub(crate) fn new(dev: &device::Device, len: usize) -> = Result { - let len =3D core::alloc::Layout::from_size_align(len, PAGE_SIZE) - .map_err(|_| EINVAL)? - .pad_to_align() - .size(); - let dma =3D Coherent::zeroed_slice(dev, len, GFP_KERNEL)?; - - Ok(Self { dma }) - } - - pub(crate) fn from_data(dev: &device::Device, data: &[u= 8]) -> Result { - let dma_obj =3D Self::new(dev, data.len())?; - // SAFETY: We have just allocated the DMA memory, we are the only = users and - // we haven't made the device aware of the handle yet. - unsafe { dma_obj.as_mut()[..data.len()].copy_from_slice(data) }; - Ok(dma_obj) - } -} - -impl Deref for DmaObject { - type Target =3D Coherent<[u8]>; - - fn deref(&self) -> &Self::Target { - &self.dma - } -} - -impl DerefMut for DmaObject { - fn deref_mut(&mut self) -> &mut Self::Target { - &mut self.dma - } -} diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/= firmware/gsp.rs index 1e0d545a74fe..86fb3f074195 100644 --- a/drivers/gpu/nova-core/firmware/gsp.rs +++ b/drivers/gpu/nova-core/firmware/gsp.rs @@ -4,10 +4,10 @@ device, dma::{ Coherent, + CoherentBox, DataDirection, DmaAddress, // }, - kvec, prelude::*, scatterlist::{ Owned, @@ -16,7 +16,6 @@ }; =20 use crate::{ - dma::DmaObject, firmware::riscv::RiscvFirmware, gpu::{ Architecture, @@ -137,7 +136,7 @@ pub(crate) struct GspFirmware { #[pin] level1: SGTable>>, /// Level 0 page table (single 4KB page) with one entry: DMA address o= f first level 1 page. - level0: DmaObject, + level0: Coherent<[u64]>, /// Size in bytes of the firmware contained in [`Self::fw`]. pub(crate) size: usize, /// Device-mapped GSP signatures matching the GPU's [`Chipset`]. @@ -198,17 +197,20 @@ pub(crate) fn new<'a>( // Allocate the level 0 page table as a device-visible= DMA object, and map the // level 1 page table onto it. =20 - // Level 0 page table data. - let mut level0_data =3D kvec![0u8; GSP_PAGE_SIZE]?; - // Fill level 1 page entry. let level1_entry =3D level1.iter().next().ok_or(EINVAL= )?; let level1_entry_addr =3D level1_entry.dma_address(); - let dst =3D &mut level0_data[..size_of_val(&level1_ent= ry_addr)]; - dst.copy_from_slice(&level1_entry_addr.to_le_bytes()); =20 - // Turn the level0 page table into a [`DmaObject`]. - DmaObject::from_data(dev, &level0_data)? + // Create level 0 page table data and fill its first e= ntry with the level 1 + // table. + let mut level0 =3D CoherentBox::<[u64]>::zeroed_slice( + dev, + GSP_PAGE_SIZE / size_of::(), + GFP_KERNEL + )?; + level0[0] =3D level1_entry_addr.to_le(); + + level0.into() }, size, signatures: { diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nov= a_core.rs index 98675c69d2b7..04a1fa6b25f8 100644 --- a/drivers/gpu/nova-core/nova_core.rs +++ b/drivers/gpu/nova-core/nova_core.rs @@ -13,7 +13,6 @@ #[macro_use] mod bitfield; =20 -mod dma; mod driver; mod falcon; mod fb; --=20 2.53.0