From nobody Thu Apr 2 17:18:52 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DD1E3783C1; Fri, 27 Mar 2026 17:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774631450; cv=none; b=qzS2RB00/w3doef8F2edU5KVz3x6dzmj+NMm2gBaaURJISaYMPE99yEsHKUWQF1bUt+t6lpxWJawXPxXuFxW1JoU8cWZ0TxP2dXpfDcgwNtx2dU4kbjRi9dr4NiewqUQ+XGklP8H07tPyirXQR7xVI//bdQzPVS2iM49OYi8+4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774631450; c=relaxed/simple; bh=MQiAPF1tif77KMDMhwXiTjAr/WzA0OTXN4b2NjGMcMo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LSFCgbsAbBS/iwKT7/VRVw5SDDjJ6v78QtrSvZVOkHQ/WiyVL6LE/ekOL1D6l10dAD1MPPIEsgvQvcfEAswuYXM9UlnunCD3Ijm8vmYtNlwffT/0sxnBpRg5CjrYvuwlMkjE8QVgycu2M5zToPi7C7v2jWAMoAM6a9qoLsg7LRQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=O9fLSfv6; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="O9fLSfv6" Received: from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DDED6304F; Fri, 27 Mar 2026 18:09:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774631360; bh=MQiAPF1tif77KMDMhwXiTjAr/WzA0OTXN4b2NjGMcMo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=O9fLSfv61KFKskYmk9Wvnm3kfaeN8wzeKz++vh6E2dOCDVIs8P+SB1mzIPcjD6/e8 3w816CyYdTP6JWhKUpCJ1vzCsrMK+ofogXq/c+LYr6RgLKrydDOCO6echakneiS2nu 77SV2IUt7E9fJPwYw0gInUShLuwz+RQGtEUx/ONo= From: Jacopo Mondi Date: Fri, 27 Mar 2026 18:10:11 +0100 Subject: [PATCH 06/14] media: rzg2l-cru: Do not use irqsave when not needed Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-b4-cru-rework-v1-6-3b7d0430f538@ideasonboard.com> References: <20260327-b4-cru-rework-v1-0-3b7d0430f538@ideasonboard.com> In-Reply-To: <20260327-b4-cru-rework-v1-0-3b7d0430f538@ideasonboard.com> To: Mauro Carvalho Chehab , Laurent Pinchart , Biju Das , Hans Verkuil , Sakari Ailus , Tommaso Merciai Cc: Daniel Scally , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Lad Prabhakar , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jacopo Mondi , Jacopo Mondi X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1328; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=bF40rZD3TQUHYDp7/ut1kp/JjJgaqy4ZgCBLyzy2Fgw=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpxroJz/+q75G02YrIYat6AXa6xwPNfcBVeeM2R TIrTbv71u2JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaca6CQAKCRByNAaPFqFW PGwLD/wKDFYM2658ug8Cs3QWkR5cjIgm6H8qbVc4yidppiKxTDqLp9sy4p64zq10+D1aVu47ltd uey3PzUpu9xlML0Z0SqZbjqKhO1kzVEza3qYxvLdtPA5+c9yK5wM6RRflP1dorPTSXKRJYXYkeo 5xFGn5AOjQODSaTxvYchgtiFW0ULNI5Y+yalWmvB3+f0mxWopLif7Q8PR8Aa7SfvJ57/EE1FODp ChmwE8agEi/EsORrB2oIEIcZ+smyOk2S0sHd7ua5AJhxMwJ22IP+cwIKrfxVzdNzRczXzLoFBPb GGmgBOyWeBgj9HGFMTChtqy3+P9cRrIJ4U8POS35+gpG+oO7TJT1BpM9cZ/rEGtNcBAHNW1hGTK 3eiwug7+w7B/hy+7rbln+cS9blUT9Zp91du0WAVve0hTKvly9cCj1OvR4q5fUlCsQ16eaKj9SH2 Y/pLjXdhihQK4IuwcMoCZ0mWI8woka60zCiy14UwruMR3mFQX9ndIbrs6w+BdYue4Oh0e3ULuUk MCeTYRhdADwNG7MiXx/eahUTanCfKLUeiuOgvHThC1CaIWnpQ68c2GDnfCH885fON9NThGAZscN 9FAexQT4XCRi/PnKi5C9/aeSufY3Kv+q9fGzADTp8IYUwArIPkhLjeqWzbBcosHnq3E3/j9PFkT 5yFCAgu1z7+vZAg== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B From: Jacopo Mondi The return_unused_buffers() and rzg2l_cru_buffer_queue() functions are never called from an interrupt context, hence they do not need to use the irqsave version of the spinlock primitives. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally Reviewed-by: Lad Prabhakar Reviewed-by: Tommaso Merciai Tested-by: Tommaso Merciai --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drive= rs/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 43b1d35fb963..2e94788c3a13 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -113,7 +113,7 @@ static void return_unused_buffers(struct rzg2l_cru_dev = *cru, struct rzg2l_cru_buffer *buf, *node; unsigned int i; =20 - guard(spinlock_irqsave)(&cru->qlock); + guard(spinlock_irq)(&cru->qlock); =20 for (i =3D 0; i < cru->num_buf; i++) { if (cru->queue_buf[i]) { @@ -166,7 +166,7 @@ static void rzg2l_cru_buffer_queue(struct vb2_buffer *v= b) struct vb2_v4l2_buffer *vbuf =3D to_vb2_v4l2_buffer(vb); struct rzg2l_cru_dev *cru =3D vb2_get_drv_priv(vb->vb2_queue); =20 - guard(spinlock_irqsave)(&cru->qlock); + guard(spinlock_irq)(&cru->qlock); list_add_tail(to_buf_list(vbuf), &cru->buf_list); } =20 --=20 2.53.0