From nobody Thu Apr 2 20:09:08 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF72F23BF9F for ; Fri, 27 Mar 2026 00:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570528; cv=none; b=KrTYCa8W2ly91W1cs0vpt/AzvBuWvYttSb86FDRY4LQo45VmlE6fm6LFlvSAtxacHVcvrBpSHYiLn13blKlGi+kVZKX57KbcHAgLwNKpw6gTDDdH1CwIO0KUBul2cYNhgvh0tWjoWspIo5rOvxwLX4ibK9DVQpHFy/WZE4+n3WY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570528; c=relaxed/simple; bh=N4kCetZH2HDTf/FdvbViMjUNsCitiWXOOSAJsJSRvT0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ufmz4bLfJNx04Kd9rT+nMQni15UKTM+glFRczkajZTG6o8CRiHjke8+ngnxT7LWqbN+eZM2xcwQ9LTRhqTGnc7M8Hf2ozgRbiNNzNeJFNqx+rPrG8fbsmgyQmIT7ed19BYMkVf86Toinc8e4xekKUlSzh9cqS7Kpyxitmwb3KsA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I1iQnVTu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eRltMQab; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I1iQnVTu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eRltMQab" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QKXwWd366419 for ; Fri, 27 Mar 2026 00:15:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= saJ7Utd8t6mFeiP8csyuhBkVXNGBrgBMuOZHTEwxtIg=; b=I1iQnVTuAgVNNIs8 psTxdsIaYIkohScy1kIdhDVaNiEmUDrvdBU07G48U1DVC+doyZRasM8OUumr6RWM VeLoKJPbXhtZ6IYXtUfhMeCid7E66ovovRpWYL5cm4qlonRyUknXAxvdj7U+xjW7 hMUELGDjX6zOoF4bvzfRfyfrGzv+iYzGraFnHpJmDOJImGbZg4nh9d3JaJi2YQhv 4T/FUVbsdlMrKo5lDAQoHvHEgjlcT3hjQ9log31zDVQSpM8CD5afp1n1xCiXS+fK MlYzumUhG4aZQgcfNsnGBBsy/ua1gF80Ml4cifa4cPMb0t77l/WlSfHsQ4D1dceK +Up8iw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5bxvghr3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 00:15:26 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35845fcf0f5so2064987a91.0 for ; Thu, 26 Mar 2026 17:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774570525; x=1775175325; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=saJ7Utd8t6mFeiP8csyuhBkVXNGBrgBMuOZHTEwxtIg=; b=eRltMQabiKMO1u54Iz7nGohUzzcvzM3HSKkwC5thOwcVI47nU/PKwUUUCVMdBdd3jz 8A8XpMjUZrJ0b6glRGuni/NNrNL9SwQOsnKrlbwkKA4iPx19oHE7Ky1s0QhfQ58REUff 4kHuYd9B1tS4rtnJ8diqzxo3xHzT6Ptt8H9KlU/vupWqL59yZG2SbvyhfFS6NSetxTyj yYMuqrcJ667SdMUNpjnKi2XB+dV/ahoTq3MTtYVxbRu5JGf19Aq3P2HpxfoHFGVAOMRh iQy9vzMUdpTChoVV3/A3Pu/kwcKSi7hpAtjHtF7CwEe9PDcwGZOvszVPgQRIOVSI3sud XxKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774570525; x=1775175325; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=saJ7Utd8t6mFeiP8csyuhBkVXNGBrgBMuOZHTEwxtIg=; b=KaT4gFClk2sp/R3MeO7F9tG9+iKGqmWQg0kNwIROaJzAv4X8dQnClsP6LFpL5AoaDm 7PyY7ACZy4B6eQU/YuqhG3SC2o3hnqq/1pdYxLa4hr3jqzCfmpSHQ9qEFNssiyt89l7w 5FkD5zwBXu7oTK2GWvKVuYLpxnuAcwGwbPSlH5FNoiU0UE8WjfXbaylSPH688L3kryzV 7aoP7wXdoWJ/XOMQaUU3SCzQJaKUlRA9nJ3LZjsfjKf9qvCwtOzNNo4OOKJFX6ix4sOi 8VG+/Al+XbZoVAveESG7rliOA8xDeRbCUWlujqMll3PU5V8HtZKAAGVYDcrWxJYz1Teq f8ZA== X-Forwarded-Encrypted: i=1; AJvYcCU1di0OE1rPtjiM9aJxNcV4N7HTUWqKvyIIzoViKq3vJpJX7U9clwSpufBOF5kluvR4sT9REHmQG39uulM=@vger.kernel.org X-Gm-Message-State: AOJu0YyIEZgw0XnHguP+/DnCXJEzE0aSB32yuGoUbWmnZB22urKI39im NPXd7ieMD7UGdIp2cfqx/mJFNeYCOg1uWfYyogRKcLSZKImzAAQtZ9KiIS0QPMpeeqzsX5HdeWd bgv7h9iEtyVcgLamC/wGtJQjpnhqm9wYTmQbIe51/OuPJTxK3RHzuTyUUhe3l4sqjoaPviaQgC7 I= X-Gm-Gg: ATEYQzzynJ+z5v9/TMTj8xgdv0SdwEXYtBsKOT7+OJQsXqSdkzVwp02jopOOCmRabyL UAg+3uZMnsD3bJzoD1BZF1GjRgWz99LAQbDCsMHqOHDhrfxxTdk13NbCUupqBbwMgGGocno8CtL NL1SaRn28ygjxXyyE+ZfC+F4Xg4cKNXNfq0pjn74VNJmdM3LPG5S3MOjOGhezzclaQaD197RXMN aY+19lPhuZIWhgs+4m2zoMgwGrZru2psL2GDXZ7qmJ9YcfnbdufJUo1fQKl3mx4zMQmkgC8DbpK tEUF+SXdU9wQifKJwcxigWJ8ofTFMAdVcR+N1/c6j8CCg6TiYnV1rD6F9Q3mCeaOtEyXZyQZ2mx HKlQ7HYRsTRYcIheH/MYbrTsDVXfxfhF35Mkd3OZS/2Ca2w== X-Received: by 2002:a17:90b:3c0c:b0:359:85b0:4023 with SMTP id 98e67ed59e1d1-35c30e090b0mr195788a91.16.1774570525396; Thu, 26 Mar 2026 17:15:25 -0700 (PDT) X-Received: by 2002:a17:90b:3c0c:b0:359:85b0:4023 with SMTP id 98e67ed59e1d1-35c30e090b0mr195773a91.16.1774570524866; Thu, 26 Mar 2026 17:15:24 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2ec799eesm163155a91.10.2026.03.26.17.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 17:15:24 -0700 (PDT) From: Akhil P Oommen Date: Fri, 27 Mar 2026 05:43:58 +0530 Subject: [PATCH v2 09/17] drm/msm/a6xx: Use packed structs for HFI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-a8xx-gpu-batch2-v2-9-2b53c38d2101@oss.qualcomm.com> References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> In-Reply-To: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774570466; l=3961; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=N4kCetZH2HDTf/FdvbViMjUNsCitiWXOOSAJsJSRvT0=; b=PkRqHaDv/tazcfoBKv78PInYJbYNQ1ikGld9XVE1uh7mnf8ElZ8qG6+tWTgA8FYz3/lBI09PO QLiacQkGVLeA9cOPvyL0yM+mu8fIlD6dTJyKQl32YPmfZkC/37wExdZ X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: 3JKtzHBseh1sTs1FSZVoVd3pZIf7eBds X-Proofpoint-ORIG-GUID: 3JKtzHBseh1sTs1FSZVoVd3pZIf7eBds X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDAwMCBTYWx0ZWRfX8Vgul9ino7QP e1ePE4uG1wbhaRNXTPsHwnojhqNYC23BXC2YwoEJTbCL4kUJsflnadooVoUBHrRpBX4ju/Uxi/M QgXpqCZlw04KCgIHMG5ni1p4s01KxVl8Ow3+93LmrW/47u8h4eQ+TCJ1aYzuScxxBFyx+GIk8sB 2Re1A+Yp3rAVT1cUzwgpEV89BM+W28k2kKzzhb/DKbUcF798GYDk8Mi+g4mv+4a7gnRrTTbc+y/ gdJh3af8LTvrg05VX0SzrbtISJ1MEPnYw2lTYvdafrAa61NJfyGOSJZeelPip3nPVlNVDxsUK8C BtuxiJxi6QoKvB9ljsbigC+rIBznRiNPaIxs0/poMugQ5N75gyZA2X3cHL/Fj4zcWSsUaGs+h+U 8CEOmKbw8C8XDGlbEAXfHaAtCvCRefFvBGim+bd1iSwK4MYSK97v9zmQKDL4kdJbdujg8klMPlJ qf72Blf4ViwzPCqYobw== X-Authority-Analysis: v=2.4 cv=ToXrRTXh c=1 sm=1 tr=0 ts=69c5cc1e cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=ArFqxpKCfli7nxZMP-sA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270000 HFI related structs define the ABI between the KMD and the GMU firmware. So, use packed structures to avoid unintended compiler inserted padding. Reviewed-by: Konrad Dybcio Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_hfi.h | 40 +++++++++++++++++--------------= ---- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.h b/drivers/gpu/drm/msm/ad= reno/a6xx_hfi.h index 19f6eca2c8c9..217708b03f6f 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.h @@ -13,7 +13,7 @@ struct a6xx_hfi_queue_table_header { u32 qhdr_size; /* Size of the queue headers */ u32 num_queues; /* Number of total queues */ u32 active_queues; /* Number of active queues */ -}; +} __packed; =20 struct a6xx_hfi_queue_header { u32 status; @@ -28,7 +28,7 @@ struct a6xx_hfi_queue_header { u32 tx_request; u32 read_index; u32 write_index; -}; +} __packed; =20 struct a6xx_hfi_queue { struct a6xx_hfi_queue_header *header; @@ -74,7 +74,7 @@ struct a6xx_hfi_msg_response { u32 ret_header; u32 error; u32 payload[HFI_RESPONSE_PAYLOAD_SIZE]; -}; +} __packed; =20 #define HFI_F2H_MSG_ERROR 100 =20 @@ -82,7 +82,7 @@ struct a6xx_hfi_msg_error { u32 header; u32 code; u32 payload[2]; -}; +} __packed; =20 #define HFI_H2F_MSG_INIT 0 =20 @@ -92,27 +92,27 @@ struct a6xx_hfi_msg_gmu_init_cmd { u32 dbg_buffer_addr; u32 dbg_buffer_size; u32 boot_state; -}; +} __packed; =20 #define HFI_H2F_MSG_FW_VERSION 1 =20 struct a6xx_hfi_msg_fw_version { u32 header; u32 supported_version; -}; +} __packed; =20 #define HFI_H2F_MSG_PERF_TABLE 4 =20 struct perf_level { u32 vote; u32 freq; -}; +} __packed; =20 struct perf_gx_level { u32 vote; u32 acd; u32 freq; -}; +} __packed; =20 struct a6xx_hfi_msg_perf_table_v1 { u32 header; @@ -121,7 +121,7 @@ struct a6xx_hfi_msg_perf_table_v1 { =20 struct perf_level gx_votes[16]; struct perf_level cx_votes[4]; -}; +} __packed; =20 struct a6xx_hfi_msg_perf_table { u32 header; @@ -130,7 +130,7 @@ struct a6xx_hfi_msg_perf_table { =20 struct perf_gx_level gx_votes[16]; struct perf_level cx_votes[4]; -}; +} __packed; =20 #define HFI_H2F_MSG_BW_TABLE 3 =20 @@ -145,13 +145,13 @@ struct a6xx_hfi_msg_bw_table { u32 cnoc_cmds_data[2][6]; u32 ddr_cmds_addrs[8]; u32 ddr_cmds_data[16][8]; -}; +} __packed; =20 #define HFI_H2F_MSG_TEST 5 =20 struct a6xx_hfi_msg_test { u32 header; -}; +} __packed; =20 #define HFI_H2F_MSG_ACD 7 #define MAX_ACD_STRIDE 2 @@ -163,13 +163,13 @@ struct a6xx_hfi_acd_table { u32 stride; u32 num_levels; u32 data[16 * MAX_ACD_STRIDE]; -}; +} __packed; =20 #define HFI_H2F_MSG_START 10 =20 struct a6xx_hfi_msg_start { u32 header; -}; +} __packed; =20 #define HFI_H2F_FEATURE_CTRL 11 =20 @@ -178,14 +178,14 @@ struct a6xx_hfi_msg_feature_ctrl { u32 feature; u32 enable; u32 data; -}; +} __packed; =20 #define HFI_H2F_MSG_CORE_FW_START 14 =20 struct a6xx_hfi_msg_core_fw_start { u32 header; u32 handle; -}; +} __packed; =20 #define HFI_H2F_MSG_TABLE 15 =20 @@ -193,7 +193,7 @@ struct a6xx_hfi_table_entry { u32 count; u32 stride; u32 data[]; -}; +} __packed; =20 struct a6xx_hfi_table { u32 header; @@ -202,7 +202,7 @@ struct a6xx_hfi_table { #define HFI_TABLE_BW_VOTE 0 #define HFI_TABLE_GPU_PERF 1 struct a6xx_hfi_table_entry entry[]; -}; +} __packed; =20 #define HFI_H2F_MSG_GX_BW_PERF_VOTE 30 =20 @@ -211,7 +211,7 @@ struct a6xx_hfi_gx_bw_perf_vote_cmd { u32 ack_type; u32 freq; u32 bw; -}; +} __packed; =20 #define AB_VOTE_MASK GENMASK(31, 16) #define MAX_AB_VOTE (FIELD_MAX(AB_VOTE_MASK) - 1) @@ -224,6 +224,6 @@ struct a6xx_hfi_prep_slumber_cmd { u32 header; u32 bw; u32 freq; -}; +} __packed; =20 #endif --=20 2.51.0