From nobody Thu Apr 2 20:09:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 813EC233149 for ; Fri, 27 Mar 2026 00:15:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570522; cv=none; b=hk5o6DUsuwLaVTuRH+0LerEgU2mh2G6hI+TXDLtYovAbhqSNnEK2ZRP6NTxinZCq2w8CWTGoasM5p7+JjbliHXnYWZXnxAXaE8Tw5DdHfUCmoGkypLV76ndunCGFvcz43CH3MCaYaQQ4pDMtIHweuPx5w/UufBTZLKtHCkKG2RA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570522; c=relaxed/simple; bh=cDGl0uZ6i5pv8Z8hV4IeFJXQL2XOvg9/tRM5E6JrofE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zd47sGFLfQvH21koyDGb8yBkEuAyS9YQD9DDQMZcIC5yrYwR0A0AbYb0sckMewu5G1qCZ2ur1btffLKDNGD8mP9Ck6+8gtlMJ659xtwteREe0YIxruR00F1en0KwnWjjjIZ/Nbl1U03av/36AKiP0K6UfJ2Dccb9DmEfS5iWz28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BkQKI2eP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ch8yI/Lm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BkQKI2eP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ch8yI/Lm" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QGKbG0638709 for ; Fri, 27 Mar 2026 00:15:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4kDtSY8iHEY7m3Ukm8JBULMqvnEiIsXdddnR6CXPwVU=; b=BkQKI2ePX9jkrdJq cS2DPjvKBTTHTet6Viw3M8o04tvFXXrZDFubkakug5j9N7HLvIfnVIttXR0gHh/y l3ZhGVcazY2khpjVvwGR4uoiAEreWW+VwlgwHg9+xZi77615yn2fiDKRm9n+z4cp HpMwmbLTS1T4dV8hAwCwR8fe7C/xSEmodwgmwuZz4TivAbPWGMEBrA4bO4PjpjGo 1uIi2pJeyixZRhdaqZQIAY/H6VptI4RfnoUroKLyS3izkuNKjD2qvFZe6lOcuCJL P9Rkg1iOxWFa7SHQxGFMZLMBbHamYrzNwLKsPmINvK3jli2sSlfmyPZ2ACYJqK8k Afq4+A== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5883hfk5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 00:15:20 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35ba4bf54beso1513038a91.1 for ; Thu, 26 Mar 2026 17:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774570520; x=1775175320; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4kDtSY8iHEY7m3Ukm8JBULMqvnEiIsXdddnR6CXPwVU=; b=Ch8yI/LmoNewIOmW650i0fFsSDaho6SkoxLC7YScVyKYe6DsRDW9gqcCYKs9882o9g rjgmdDi6yW2u+UaeCV6IHvZUcQI1/e8wZkWY5E2I2/ExRlqiiTXRpPszfs8HQQwJerAe O0kyaSp/WbFPfxu7BuiDppGz3Xby6o72dxktms1CZbmPsvgqNuuG9qTGOOnFZ5LduBMp KcwFFPTNiX/1grPOttOlxVTbELLVJ/94E6O4rOBs6FAZXIRI+JOnLKKBh6HKURULZazW 4l1o8LMWK8mg+6Haa0OKnfWEirT5iDqcVToutFdPGjl1KM/BPNSgZNEt229JPKav8+as JzSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774570520; x=1775175320; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4kDtSY8iHEY7m3Ukm8JBULMqvnEiIsXdddnR6CXPwVU=; b=B3JhNDLJfCLcIx/jYmfn7A2JTH4HV8goo8nSWKiaqshaoJw8K8bqSR0P1U6MVgvIKR fw/2aNYtpAF6+naqwwvschsD9NJ9RN1z3JekIh2ExzAJTbB69z6qbiCvvyZjGMVrSNQU tn45Op/x/+2oNv/bAohXmkgu+pCyJ01PVYcsPS9izd7xJBr4bsTUPZyYBqZnEw8IWZ0s rteyB+ZMisVIgB85mfFU5oGIPUbdsSTz60givXIZy1m22gE/CDArh60nNTaRjMF+NL4R xJdIDqLEs/Cgz+uiJSO4tf5JjKg0g3MJADyAIS3fLGpHykKjniavIUHochPIxnHUzMiS l1PA== X-Forwarded-Encrypted: i=1; AJvYcCXS1srQLwFro2EIh9Pvce0ewgsqrsOr3CpE+zigU5zCgKJLlarvCMYcbcy+CdhuEA3xVwpDMSiHui1FS40=@vger.kernel.org X-Gm-Message-State: AOJu0YwWEtlDbN9tbVbkt14gIOy24SolX+RgTBwcIDaN2bLEYO21sLhA zKERxVhx3aKhjpESamuNZaHdZB//pdhfkaoTq/jroZ3v1aNPp49LuhWrDAZ1ZNHMP9W9AOODA2h d8ldk1xahSa6IdB7lCO2IfBXS3oS317LTRTXhSeoquxSpFE3PjbqVAyIcjLYv0220KcNNUv/SSy E= X-Gm-Gg: ATEYQzxixHLeXCR2A5Ik1dwB72+AXyGA0jXU7VjX8WT16W50+WTnSuc/Eg4Q/FHFmKY DBv1EjnMcTIG8NKpi2NW761aDpHY2YdFXPRWYVfaJemNr7Now8+RW8rkdz5z9qvvpEExwhRKqbH gaGoBhLpKCD4NX2c+Ma4IJi5zfjiHgilVmzPv07pctZ07gZ3KuBs/KAfZjtgvnahW2cgcb+XCtZ +tyr/urzG799FLAzQulkhYsnZFQ3XRVK2t7unli+qhDQBr10R+cqDvQCuoRyC0747MGJMfLmHx5 AbNWltG4zPN1UeAdscAtgarHQenXKQYWSx3udiM4bqcUYjI229csxKyl595t942TjU/jewxTA8V aYRV9Gw1Odi7AepIJunZb6cWxfvGrPxdtVCQLOC6Vnvtctg== X-Received: by 2002:a17:90b:4c8b:b0:354:c593:b1a8 with SMTP id 98e67ed59e1d1-35c2ffa93e7mr556465a91.13.1774570519386; Thu, 26 Mar 2026 17:15:19 -0700 (PDT) X-Received: by 2002:a17:90b:4c8b:b0:354:c593:b1a8 with SMTP id 98e67ed59e1d1-35c2ffa93e7mr556422a91.13.1774570518865; Thu, 26 Mar 2026 17:15:18 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2ec799eesm163155a91.10.2026.03.26.17.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 17:15:18 -0700 (PDT) From: Akhil P Oommen Date: Fri, 27 Mar 2026 05:43:57 +0530 Subject: [PATCH v2 08/17] drm/msm/adreno: Coredump on GPU/GMU init failures Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-a8xx-gpu-batch2-v2-8-2b53c38d2101@oss.qualcomm.com> References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> In-Reply-To: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774570466; l=4176; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=cDGl0uZ6i5pv8Z8hV4IeFJXQL2XOvg9/tRM5E6JrofE=; b=KuwoFLu8wFJBzBvS5WU+a3ua508Y1HlGEvylT+oTxL8oSjs2seOL0RsQs2vvZVmZCs8OMEuwH c5qpp9fSiY6DYgovCfhkpMyIYU7YedArZTHe6XQYMlniAHtntGpDC3P X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: YkGoYhKx4P8P20JcQryIjAWWGFvGsSrX X-Authority-Analysis: v=2.4 cv=bopBxUai c=1 sm=1 tr=0 ts=69c5cc18 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=yqx-ntKogz8YgV0l4v8A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: YkGoYhKx4P8P20JcQryIjAWWGFvGsSrX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDAwMCBTYWx0ZWRfX72ZSPxmwWYK9 C7teYt1En7rc63w5XNMcCHsz/TIonFrw8uHJ9D0xS5PfFh/cn8q1xYwE8Ztd7UNMwUnr/nhOFlr tIsTVcjIc67+YeGz0z4/cp9p7x0Aav5RbDZc3ABUtfUXOtvZhpSM2ma4JxLXRddmDorh487YL+P zOmgnTvz1XeDr3VG3u4uVa406FEBNUiYP4Hd+pe+OBXL4P9MqNcJDzbeAvxzhP8wAPdTTg9yZwA p8sWopXWAShoJ9FmLmQ0qlIw62LPpc29ykW1PbrzPosJgA8VDPWnI5kLY7XcoSUb9H2kOvtK3DT A3p2AvWAwW7sbp4MK8yGclm+kf+XAD/msOxHC1Y5RDkY0D2rn4q/gKy6tNEXMSshxHEOvYFC1+V 19boA8T9+oZ3xd8y/IZqX1Yoz4w95Eo/gFJ9Yy2tjV3dlnK0ls6HJACjVBoWjHmXbylxJMxpoKn DuOyM8tbuiq9aK8Sd9g== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270000 Capture coredump on GPU or GMU errors during initialization to help in debugging the issues. To be consistent with the locks while calling msm_gpu_crashstate_capture(), call pm_runtime_get(gpu) always with msm_gpu->lock. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 1 + drivers/gpu/drm/msm/adreno/adreno_device.c | 5 +++-- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 5 ++++- drivers/gpu/drm/msm/msm_gpu.c | 5 +++-- drivers/gpu/drm/msm/msm_gpu.h | 2 ++ 5 files changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 1b44b9e21ad8..916c5d99c4d1 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1335,6 +1335,7 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu) =20 disable_irq: disable_irq(gmu->gmu_irq); + msm_gpu_crashstate_capture(gpu, NULL, NULL, NULL, NULL); a6xx_rpmh_stop(gmu); disable_clk: clk_bulk_disable_unprepare(gmu->nr_clocks, gmu->clocks); diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/m= sm/adreno/adreno_device.c index 4edfe80c5be7..ca5f96e16870 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_device.c +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c @@ -105,6 +105,8 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) */ pm_runtime_enable(&pdev->dev); =20 + guard(mutex)(&gpu->lock); + ret =3D pm_runtime_get_sync(&pdev->dev); if (ret < 0) { pm_runtime_put_noidle(&pdev->dev); @@ -112,10 +114,9 @@ struct msm_gpu *adreno_load_gpu(struct drm_device *dev) goto err_disable_rpm; } =20 - mutex_lock(&gpu->lock); ret =3D msm_gpu_hw_init(gpu); - mutex_unlock(&gpu->lock); if (ret) { + msm_gpu_crashstate_capture(gpu, NULL, NULL, NULL, NULL); DRM_DEV_ERROR(dev->dev, "gpu hw init failed: %d\n", ret); goto err_put_rpm; } diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/= adreno/adreno_gpu.c index 785e99fb5bd5..8475802fdde2 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -391,10 +391,13 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_= context *ctx, return 0; case MSM_PARAM_TIMESTAMP: if (adreno_gpu->funcs->get_timestamp) { + mutex_lock(&gpu->lock); pm_runtime_get_sync(&gpu->pdev->dev); + *value =3D adreno_gpu->funcs->get_timestamp(gpu); - pm_runtime_put_autosuspend(&gpu->pdev->dev); =20 + pm_runtime_put_autosuspend(&gpu->pdev->dev); + mutex_unlock(&gpu->lock); return 0; } return -EINVAL; diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 995549d0bbbc..472db2c916f9 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -361,7 +361,7 @@ static void crashstate_get_vm_logs(struct msm_gpu_state= *state, struct msm_gem_v mutex_unlock(&vm->mmu_lock); } =20 -static void msm_gpu_crashstate_capture(struct msm_gpu *gpu, +void msm_gpu_crashstate_capture(struct msm_gpu *gpu, struct msm_gem_submit *submit, struct msm_gpu_fault_info *fault_info, char *comm, char *cmd) { @@ -886,7 +886,8 @@ void msm_gpu_submit(struct msm_gpu *gpu, struct msm_gem= _submit *submit) =20 pm_runtime_get_sync(&gpu->pdev->dev); =20 - msm_gpu_hw_init(gpu); + if (msm_gpu_hw_init(gpu)) + msm_gpu_crashstate_capture(gpu, NULL, NULL, NULL, NULL); =20 submit->seqno =3D submit->hw_fence->seqno; =20 diff --git a/drivers/gpu/drm/msm/msm_gpu.h b/drivers/gpu/drm/msm/msm_gpu.h index 666cf499b7ec..eb5b3a7b81f9 100644 --- a/drivers/gpu/drm/msm/msm_gpu.h +++ b/drivers/gpu/drm/msm/msm_gpu.h @@ -747,6 +747,8 @@ static inline void msm_gpu_crashstate_put(struct msm_gp= u *gpu) } =20 void msm_gpu_fault_crashstate_capture(struct msm_gpu *gpu, struct msm_gpu_= fault_info *fault_info); +void msm_gpu_crashstate_capture(struct msm_gpu *gpu, struct msm_gem_submit= *submit, + struct msm_gpu_fault_info *fault_info, char *comm, char *cmd); =20 /* * Simple macro to semi-cleanly add the MAP_PRIV flag for targets that can --=20 2.51.0