From nobody Thu Apr 2 20:09:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 543A3234964 for ; Fri, 27 Mar 2026 00:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570516; cv=none; b=qOo4LSqxdaG0MmZPvQnsRGyr8jn4ffZ1oAYPyP1WxVtM9b5WGlcajvQ1nEd+xYOPyAgz1yCDUu4gBHSd59Mf3Ampw3SWWIYayo6enHp3PsO5Np4r290TqupgKyqpbQnAw1Suwd+soYFuDx129kz06kmm83wO4cDr/5B4cBSFPms= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570516; c=relaxed/simple; bh=sxPn3k2wukfo2f3i1QdTe9EbnZ53Hjix+2O94acfs2A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TmyjKCVjGv/HUYrEZh8OC+W4sz6pkDB758sDB6seToM7DeGQvhr/5JJ90Rv476yRcmNF/VwjqbFptdtaj5cwtAdBHf+arcq+o/N3lG4VAFrC6VQ1SretvZmXohQ01Q85lu0pLk0hWIbqUBwmRVaqEJa83cqsLK0Bmp3shq9JETA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=H8Uz+LSZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PGdXLMTz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="H8Uz+LSZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PGdXLMTz" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QIeXoe3341228 for ; Fri, 27 Mar 2026 00:15:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CpT/EooedCDv5+FigI376so7QARJ90o8abqnkH5Y1Ho=; b=H8Uz+LSZ0hFcCP2C wcjvhzYB2tQguhvM31D7SyMDslS/aX4YB/8VJ7G7tFCRJiKANeHPpwA8n72MLn2L wJc6lFu+DvBUr4w4uLk/QlR9pv5IzNvEPfC7UZt/jeW37mr6eG+6mdkgw/4HsTVp bZN8mW/RwCNKqyqvl0cOOc3ZcrZByPgPTAGdHOKkhtE1g+aOS0Ux+ruqxnsnD3Mk ScqlAzyoUoxxL1g7gH3NqKuQmSk4AErjxC/UxHBWl737UpY4qhuAbLhX2SiEVAav DiGQpZE7td/jHu510cA9BBzfh7XJvdNAcyAeHREVU8kebf0mAXP1qhLZrJYLGOdd aABLvQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5a9q0vx1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 00:15:14 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35c10c2d890so2254263a91.1 for ; Thu, 26 Mar 2026 17:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774570514; x=1775175314; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CpT/EooedCDv5+FigI376so7QARJ90o8abqnkH5Y1Ho=; b=PGdXLMTzoxj6lX5bFkXgr/BCibipIJuzBRWlIQ6S0DDytRXaQZGY6U/iVis4HkNAh6 qxejhel/SujX+tiXXX1EbAkILmRrwzNgdtS8wd9XuTXO8vgk7+HAFdl3yJDi4iLiKJsD ZZlvKBYtwRQrzptHDPrGQzG0uFlHyZO5BLlbLkWDHuy0RGpgGrXkmKzFGXKlR4AR+s3j FfEzqPLy7P9TxXFvT6+1//SBoAjtNnrip07jnGRi7LTAAlo+U/qfch0PpipydsT/8vSA GlwrV0T4nlmR0cPRezoJlQwdK/kpc/py5zQe/UmG2G8sd7iVdtIpTHFMmTzXVAljF0XM 6B0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774570514; x=1775175314; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CpT/EooedCDv5+FigI376so7QARJ90o8abqnkH5Y1Ho=; b=VUQmiNDmuRWtbqaFqfDmaYZHi6mMq/HbvOUsbNIZurtFtrC8eqrXVHo37pKEHuAyLt 5o/bIdh1IoIS5yPlhc0EUMjBL6Yf8IUoCcCkhIB3Zaxn8dmxXQDnDWNt3gKr9DxBAH4+ Ob689BgEloxEmMHvcIkdTqRpEEe4amkg6v4HFs6RlEIuT9ymOSy9USQ9TcxmGYTm89Q1 B6S47urcFxKtnFJ7lfrYdUHReXT35VwJdSgoyC6wTm5U0MpLeVIHv4ReOvpLXGejvoR9 ATJbuvW074rVB0T6ggzpEo0u20o7UaMrXb74bMg9ehnljeI8YARCkDMw5lGHBo/i64Kq 9n4g== X-Forwarded-Encrypted: i=1; AJvYcCUCw8jRyvNv3WfhuRvRG2HpldnNyZUshZVv3bb5S4fg4b0EbUfGc4aPovAmjSu+/DV68dOAp9IBYutDVnA=@vger.kernel.org X-Gm-Message-State: AOJu0YyXTFzqfbj+lx7mZwZD2PCh8BnWU0L9wCssPAX7XIKBC0MgsbNM gGe39QTMbkYJ2IHGjtzRhdMe1UoCvF/JV6iVYxoLcLGsCG6H8S6hk3WhMH0T85UEbs1S1qpNkKk RXWdeFxj1BeranCM8DP3poaIjrwpX7pKJB92t4ewgVs2pDyAYTv6hKKssWmc2lnyUxNZU33JpwX 8= X-Gm-Gg: ATEYQzzzmSTO16vATtsckzJakeCPwZ9ujBxhYN6gvFXYkV9MTB2C+sJYUOzxq52CzPX QsWeLNhgBOSmmTrSQTu5Bm3Px1LyRGASHbCIWgRvmYpwEfZXEyhKkoWCYuYPvCRxMS3FIKgoEYb YIYTx9WyL2MdJpYqa50VYk2Bb/j0Lt8F/qM5WWzexeoCrAko3oWAxQZaQEy65nu7R7Tjtyo+Im+ sMm7fJB3hs9YqbRYddC5l6pcYKqDtvVa38g6VfzRCzziX6Fw3IAEWMS2Pchjys01HUZhbfMKQiO 6xPTG2a3gjti7Ad+rWcV2VbE4W6ORbButvQFOaFTiMMbllO43UyGX++SI5XUstZTsEUGQfbhjcS 7Z2n/wYo9z5KNvXYP7HGCnqtlAMDtccxuY5yVo6GFlpddsg== X-Received: by 2002:a17:90b:3f4f:b0:35b:e844:3bd with SMTP id 98e67ed59e1d1-35c30124eb5mr454887a91.31.1774570513661; Thu, 26 Mar 2026 17:15:13 -0700 (PDT) X-Received: by 2002:a17:90b:3f4f:b0:35b:e844:3bd with SMTP id 98e67ed59e1d1-35c30124eb5mr454842a91.31.1774570513061; Thu, 26 Mar 2026 17:15:13 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2ec799eesm163155a91.10.2026.03.26.17.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 17:15:12 -0700 (PDT) From: Akhil P Oommen Date: Fri, 27 Mar 2026 05:43:56 +0530 Subject: [PATCH v2 07/17] drm/msm/a6xx: Add support for Debug HFI Q Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-a8xx-gpu-batch2-v2-7-2b53c38d2101@oss.qualcomm.com> References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> In-Reply-To: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774570466; l=3294; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=sxPn3k2wukfo2f3i1QdTe9EbnZ53Hjix+2O94acfs2A=; b=YeKnM2v6ry4IWiNiIn1nn8ghwud3UWgHQjMKvhrWwokL4jfoJRlC8nUGt5hPGARhXjSx+b1uQ Qbu1f5ZunewAI12ln09UT5rw81I7vli0/ZaW9iPsY0dHjcJSWssPf9O X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-GUID: 3pZqsNzV0cyEvHksxPPRA5w8C0gF92Fi X-Proofpoint-ORIG-GUID: 3pZqsNzV0cyEvHksxPPRA5w8C0gF92Fi X-Authority-Analysis: v=2.4 cv=J4GnLQnS c=1 sm=1 tr=0 ts=69c5cc12 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=a1WYpzXZzT6O6UdPSaAA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDAwMCBTYWx0ZWRfX0iIjwInykWV9 kzImF1K+JVOE1537CXjdN4nn4/ClHIabieodiVqBBo3QqsuoI8vzEN4WrYVgAZqrqWGCw85vOsB Nfkgii84YfI4b1IoG6lE5TIeWIdyvnvD3J4ZZCAJVbTvzU1cmSSo2tAk3HoM4+/WnP75DceKboh 2KDtwX8qQYQrodBn0LMt0tcBKNr2lCCkYoIeiI7YsNE36VrBMkIPdzjznlnGhNIn0cEiX1ww0jX 9oR1XoNB/Jmwx9hJAYtCFaY6g1veXLSpjAKmv2cHMsvZ63ZE2RAHbXedDci3E0un41+W8zLXaoS 6XUncXzCw9smolCDjTuLsCi15dCxMRzHjIyLa0PX8S3WIJdMQ0KAz9P3T5Sx7IfGYCeA7h2kfRx 6O/4PxWVTW5HYLEQAI+6ynlaW0y05W/5EwiJvbWKGbIUFuWWX9W57cIXcRos9IN0uvUYS7n9wif G1SziCmIFvo4LWlBMqQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 phishscore=0 impostorscore=0 bulkscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270000 Add the Debug HFI Queue which contains the F2H messages posted from the GMU firmware. Having this data in coredump is useful to debug firmware issues. Signed-off-by: Akhil P Oommen Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 2 +- drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 +- drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 16 +++++++++++++--- drivers/gpu/drm/msm/adreno/a6xx_hfi.h | 2 ++ 4 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.h index 0cd8ae1b4f5c..3f96b10b5f61 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h @@ -111,7 +111,7 @@ struct a6xx_gmu { =20 unsigned long freq; =20 - struct a6xx_hfi_queue queues[2]; + struct a6xx_hfi_queue queues[HFI_MAX_QUEUES]; =20 bool initialized; bool hung; diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/= msm/adreno/a6xx_gpu_state.c index 7bec4e509d2c..c0b9661131e8 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c @@ -57,7 +57,7 @@ struct a6xx_gpu_state { struct msm_gpu_state_bo *gmu_hfi; struct msm_gpu_state_bo *gmu_debug; =20 - s32 hfi_queue_history[2][HFI_HISTORY_SZ]; + s32 hfi_queue_history[HFI_MAX_QUEUES][HFI_HISTORY_SZ]; =20 struct list_head objs; =20 diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c b/drivers/gpu/drm/msm/ad= reno/a6xx_hfi.c index 4f5dbf46132b..09b6bc464b47 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.c @@ -1062,8 +1062,8 @@ void a6xx_hfi_init(struct a6xx_gmu *gmu) struct a6xx_gmu_bo *hfi =3D &gmu->hfi; struct a6xx_hfi_queue_table_header *table =3D hfi->virt; struct a6xx_hfi_queue_header *headers =3D hfi->virt + sizeof(*table); + int table_size, idx; u64 offset; - int table_size; =20 /* * The table size is the size of the table header plus all of the queue @@ -1082,12 +1082,22 @@ void a6xx_hfi_init(struct a6xx_gmu *gmu) table->active_queues =3D ARRAY_SIZE(gmu->queues); =20 /* Command queue */ + idx =3D 0; offset =3D SZ_4K; - a6xx_hfi_queue_init(&gmu->queues[0], &headers[0], hfi->virt + offset, + a6xx_hfi_queue_init(&gmu->queues[idx], &headers[idx], hfi->virt + offset, hfi->iova + offset, 0); =20 /* GMU response queue */ + idx++; offset +=3D SZ_4K; - a6xx_hfi_queue_init(&gmu->queues[1], &headers[1], hfi->virt + offset, + a6xx_hfi_queue_init(&gmu->queues[idx], &headers[idx], hfi->virt + offset, hfi->iova + offset, gmu->legacy ? 4 : 1); + + /* GMU Debug queue */ + idx++; + offset +=3D SZ_4K; + a6xx_hfi_queue_init(&gmu->queues[idx], &headers[idx], hfi->virt + offset, + hfi->iova + offset, gmu->legacy ? 5 : 2); + + WARN_ON(idx >=3D HFI_MAX_QUEUES); } diff --git a/drivers/gpu/drm/msm/adreno/a6xx_hfi.h b/drivers/gpu/drm/msm/ad= reno/a6xx_hfi.h index 6f9f74a0bc85..19f6eca2c8c9 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_hfi.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_hfi.h @@ -4,6 +4,8 @@ #ifndef _A6XX_HFI_H_ #define _A6XX_HFI_H_ =20 +#define HFI_MAX_QUEUES 3 + struct a6xx_hfi_queue_table_header { u32 version; u32 size; /* Size of the queue table in dwords */ --=20 2.51.0