From nobody Thu Apr 2 20:09:07 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EF921A9FAA for ; Fri, 27 Mar 2026 00:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570500; cv=none; b=cTtShyRg+feMBPOS6AENWuMaRDIiZ4naPVq6YSSaUTg6OaKsr03Byw2N+cITIyr21H5VZxHl8W6Mw5pbF+dIWYNtbHQdFzSinD/OAw9/gPHv0H2OEqGmjE5N4q73lQVCstQBu9XANhIHHDGCsa5XQPXhF2VzoUTojZb8nMMVRig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570500; c=relaxed/simple; bh=hO+tlaP9kUuhCPlMZ4rX5r+rbJqELgijDL/FNh3qLxI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lNCWrXIoXatL6qVWHGiy8WEG4rv5Z5ifsyk/x6cZM0ln6J7q81+5hlLYmE2r8F1CokAmV2OKk3q7QowpEq5ESqPn0XOjH/bJvI4OcWvouxJHBJEDocDExU1THrcTTma8k/9f11tq0VfuksKTj6yCH3/Z8qk6qdbNFbF4IPUv048= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FRXC9saY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TULNUqJb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FRXC9saY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TULNUqJb" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QJuNxk3075403 for ; Fri, 27 Mar 2026 00:14:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0IHyaMl4RjylqIprsqHQxbLvzlvJXxYU0f//3lLX3fI=; b=FRXC9saYRLYoZj8J n9NZCUoOMUVQzHozBLTaH2Zgk9pFeKpqiXzdAanXMMitnw3LR8aTNKly623ZKozN oDQS9xdyZCo+Lnq1rWWQ5kCRou03wit2aEMQCbLzW1qtIp3jSoX1jOv0XtEfFFF1 0A3YsZYYjHOmKd9HgHKFnCb2/2RuYtM7HaijPtdKgPMMYv+XKIzRNJlkldTJOJhy MAW6DjMhCtsryYhLMK5ZJwm2mZHPIs7b/gi2gbdM3Dnimtnwt03HBl6EzkybUu9S WKdmEqikaioc9CzBJ/8Y32vSFbTfpyTLf6BimpZARUv8LQ7F/xWhnD2RlhAXiywB LF7zmA== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5bd8rmy0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 00:14:57 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35449510446so1988525a91.0 for ; Thu, 26 Mar 2026 17:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774570496; x=1775175296; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0IHyaMl4RjylqIprsqHQxbLvzlvJXxYU0f//3lLX3fI=; b=TULNUqJbraaY6UcPsTjQHhdPEXITD/3eOUCIOWa9eR0p1NSuO599+pvuwkua9kwK0z sX/cbDm8vWvVpu0oGayKAzwhZr3dsTOpYzrDUJQtkXe5MbMQ5c5VEBceyb98iBxxg08n aA9iGDSlO7HtPw2HK88borRgJVKf2WgE8iteZZVMYKjGgc7GOlkijBGQJYGTWBLUYgFG MrMQ0RBW+iimksrngWUxnA0O48dDHrWA6THiCYoygXErfdfqaYTKtOpmXkvGCbpMcXZC C5QndUU8YyJcjB2iObeOwYVAy9j/678RgthtvAVggC5tUp/zDSxX4gD3eGYVLp4JrTwg D8xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774570496; x=1775175296; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0IHyaMl4RjylqIprsqHQxbLvzlvJXxYU0f//3lLX3fI=; b=lvEEJ1oF1GHKVJqVmmQ+znw24pzEBkJdutzCpvgCPbIla0sAu9ci3qndZVh4J8OAkQ mgoWkYNKpBMh7lw4laqhwAZY/yr6l/8tgghcz+QxrS6fm5+mzSWXeMa9+2q2a+dUhQpn BNhGnOFomdYaHDJxtGraVbfX+EahaTwM8hwSrf7mzhQIgTWIfWBuKlDsEwPKd5z8bITo PdVcQ6kSxF4/j5EQUaVEgNm25shT2Bt9pV3USfPg8EeDeF3m0sQFasA+pGX8Bu12S1fC 7IR7O3p0xQqqzxE2grBddyYUTkKlnTrwuKkCM19WmVqQbxr1hpo5mOjYVJB88bB/ZeEz ht3w== X-Forwarded-Encrypted: i=1; AJvYcCVCQGbVG5ginsToot/m0MSDhtGhXltUgEOnyG1RdJddUjHVD33GSIBX/OnkeRPdHTFsifEMUy+4cq95zsM=@vger.kernel.org X-Gm-Message-State: AOJu0YyKjhDjed4I1sNr8Nb8FwdSypSLgPXQE9cF5Q+ULBe8VB8JX2y4 QrxKQBih0zej6igXHggVP6xEO67rDNWSye2tsBPkpcONDaQrqnDnXDClthaEQVW0en163sHSBm2 aYehNFXpzF5JaBbQrIc/NOvAh0mBYwcHMgAFN9xhvS8gz9jIcxqYvyMr/Rg/B/66MrboPkoNoK7 s= X-Gm-Gg: ATEYQzzZ9am5CTqq/zCz0GVt0SfuQru+wqXpo2ZHOOnH1SStEMFz98MzppMP6GhDGLD 4S3g4j/YP3ifjxW6dMznfqf74zeLHw65VVWl+3dgLqqjwwbwVt/QsB/FSEUfet4+gpOhA+bxJ7/ TMxet+a8DJ1C6Mf4IZRNjnoMja+3fu/HSCkDeZLAeQQSDCYwC2aiKcD8sD/wsH9HQjBTkilse9Z Pyt0K5pjYOJDXHagyvRt5YtgpQjL9fHaMVYOKgdAVjd5NlCvaIO8c5Q2bCIR/i5RMivowYfCjhI EyDomHh988gBpqMpp3zsBCZubmLYjOxpvIUoXiI4k96K9FTOLDKIHavC4QW29M/YeYDEbg4E0CI bO67NN2kOcZ+aRWKQ9af1YMdq50O1N9oVOhsp4Kni6mFUQA== X-Received: by 2002:a17:90b:3fc7:b0:35b:92c1:8a3a with SMTP id 98e67ed59e1d1-35c2ff86566mr573955a91.14.1774570495964; Thu, 26 Mar 2026 17:14:55 -0700 (PDT) X-Received: by 2002:a17:90b:3fc7:b0:35b:92c1:8a3a with SMTP id 98e67ed59e1d1-35c2ff86566mr573943a91.14.1774570495519; Thu, 26 Mar 2026 17:14:55 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2ec799eesm163155a91.10.2026.03.26.17.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 17:14:55 -0700 (PDT) From: Akhil P Oommen Date: Fri, 27 Mar 2026 05:43:53 +0530 Subject: [PATCH v2 04/17] drm/msm/a6xx: Correct OOB usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-a8xx-gpu-batch2-v2-4-2b53c38d2101@oss.qualcomm.com> References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> In-Reply-To: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774570466; l=2386; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=hO+tlaP9kUuhCPlMZ4rX5r+rbJqELgijDL/FNh3qLxI=; b=JCCRY+wFjZC/dv8RmXTmyHSKxHHivJNqeDPy4Afv4r9gjuOs+Xovo22uISFWIponXY/StqtNm nVcxRp/yh25CZn3k15pPBqmr4JskjaJp7L7xIHrdDgai8j3aCvLzxXB X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDAwMCBTYWx0ZWRfX9wkkEqEjh0Fx OKBEKtFIzAJrZ7ThxBLXtbNqu0Pextbw4JAx2Kfe2k1y8geCRrXBMTRH4purNO7Ynd8uESWZRV3 V9/vdllep4PnKLoljveJP84lzOM182RNBh67qOuOUQ0n5m+42hp0Hnnkk2aWv8v4o1x41Te0WUA UKSXyWON17otcsCS+ecArZauyvOW7/tIqffFxIfW3RV2DX2+lyFdsNdp/gZzr21zSH8mf5tPPhf Hcq9U8BNWQAI1ZGy72XiQkfAC8henoKLZsxeD9WfeOpXJq6GJvv7O/XA1JVz9veffgx7uETnsf1 F495NdkzNTBw8+xqwYh+Rebp73AIn6FZ3dFH4iSHcI5MS7jwt3BdeyXy5R/N2UVjpWAge3jZbTh NXzedu8HK+Y5K9cBFaU9WqE69CTFdLylRTu3PfeCTx2gdiFEGECuZrmXLkpkyperertLTMKW2xE BGX9kwe1xHXMVN4MgKA== X-Proofpoint-ORIG-GUID: tm3PPJtaLuOTMZbclaDIonr5rSVCDFpk X-Authority-Analysis: v=2.4 cv=BZrVE7t2 c=1 sm=1 tr=0 ts=69c5cc01 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=pGJFX0Yo-_9-baE-uFMA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: tm3PPJtaLuOTMZbclaDIonr5rSVCDFpk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270000 During the GMU resume sequence, using another OOB other than OOB_GPU may confuse the internal state of GMU firmware. To align more strictly with the downstream sequence, move the sysprof related OOB setup after the OOB_GPU is cleared. Fixes: 62cd0fa6990b ("drm/msm/adreno: Disable IFPC when sysprof is active") Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 5 ----- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 ++++++ drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 6 ++++++ 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gmu.c index 9662201cd2e9..690d3e53e273 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -1236,11 +1236,6 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu) /* Set the GPU to the current freq */ a6xx_gmu_set_initial_freq(gpu, gmu); =20 - if (refcount_read(&gpu->sysprof_active) > 1) { - ret =3D a6xx_gmu_set_oob(gmu, GMU_OOB_PERFCOUNTER_SET); - if (!ret) - set_bit(GMU_STATUS_OOB_PERF_SET, &gmu->status); - } out: /* On failure, shut down the GMU to leave it in a good state */ if (ret) { diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index f8cb8b578661..f4b7fc28b677 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -1605,6 +1605,12 @@ static int hw_init(struct msm_gpu *gpu) a6xx_gmu_clear_oob(&a6xx_gpu->gmu, GMU_OOB_BOOT_SLUMBER); } =20 + if (!ret && (refcount_read(&gpu->sysprof_active) > 1)) { + ret =3D a6xx_gmu_set_oob(gmu, GMU_OOB_PERFCOUNTER_SET); + if (!ret) + set_bit(GMU_STATUS_OOB_PERF_SET, &gmu->status); + } + return ret; } =20 diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a8xx_gpu.c index 840af9c4d718..fafeac62aebf 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -711,6 +711,12 @@ static int hw_init(struct msm_gpu *gpu) */ a6xx_gmu_clear_oob(&a6xx_gpu->gmu, GMU_OOB_GPU_SET); =20 + if (!ret && (refcount_read(&gpu->sysprof_active) > 1)) { + ret =3D a6xx_gmu_set_oob(gmu, GMU_OOB_PERFCOUNTER_SET); + if (!ret) + set_bit(GMU_STATUS_OOB_PERF_SET, &gmu->status); + } + return ret; } =20 --=20 2.51.0