From nobody Thu Apr 2 20:09:07 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70BCB1A9FAA for ; Fri, 27 Mar 2026 00:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570493; cv=none; b=kpOTm1cCPvXRSXLEbrEeSGY5yp1LlvacmIKD6utyYv70xZjnhVwenNn4YN/Zn+kLEvciOzmQZlS8bf6Lr3Ee/pqfITpcLYkTRtZ0K2x2OhCwFnKCnV6ixwF/IViyqY95GDcgvGBGC6Bj8a059tnG1aJ2ogg183sURYEUgdDiY1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774570493; c=relaxed/simple; bh=U5fwvqTvmhxC9U5Bv8tyvwyqOYj/HJbmdaC+3G7oXm0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=npPPgZs3wL8jl/D2eFZ2H53QYiCOo1NH69e/bwwFzxJFa0SHuC5pt2RnDgAom3lqV5K/keVkAbKANO8Uw9aHg2cUVld0okHShbOoUxVDjVSy1LUXJjP9QZEd3BWL2DmiI+X/FpjHNlCOE7wZU7EZ38pnDHXrbTdhWlxiPxe0j28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aO1xPDNk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VWP0XebC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aO1xPDNk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VWP0XebC" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62QI2mSW3757370 for ; Fri, 27 Mar 2026 00:14:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lWzxoxI1BoNjbMnzfK+mLddqJ9V6D8F7yAlBnaGh3Lc=; b=aO1xPDNkqEbv4+vM 02h63L2kgS3h1tjvBSVRbtD7qn3OdH2WjwSEEEBJ608Pgo9/XRcS8pdPmXL43jvm 8thtjL/aTl2hdQuLc4RKsNM94mI/n2RJArTm1YCMVWHoaDJ8oF5dl/i2GkOwx03A lfzLr3dobEN1vstiE90Uhjz2rHCpeAGLcuNc9IZ0vZvvapYH9ONl/43gAxvQZZih Pm9srRRANWg1AKbIabkImDwqtKnpvtlz0HTVs5bSrmf0l0sIZzsahweE6kP142m2 IcQ0ro17lOaz1L1rqUSxpVxFA8i/LcRcwGec7HNdEWCdM4YTPFwyVz9YZybuRhk4 9qCalw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d59r191uu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 00:14:51 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3594620fe97so5498789a91.1 for ; Thu, 26 Mar 2026 17:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774570490; x=1775175290; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lWzxoxI1BoNjbMnzfK+mLddqJ9V6D8F7yAlBnaGh3Lc=; b=VWP0XebCqM+I42ULn+3RX9eiTVTy0c8m+AXP0O0vdaT7VGqNa/xgQZjesRDQuc2H7T q1aGDyIsxhckOMIN7pFQxjZLDvlgaTZoAwvYy83eX+r0N4V1mmj2q+9Rxf2FlJPVYGDl pkjZmG2MXGU0zTfXtwnqJfMixB2CNlRjwDUzlw23O9ECREEGpgS6ajMUUMG4IZXZdDKf 335PqYu/WXtneyKfdeddMyuS6exnRQ/neeAjYepEHk5R+8LkFimm7FILWMu1R2bXPm27 uKXf0f7zCCgBHIc2iY1UVmSX72k0+XbJkNlwOyOHZtxXkLwpo1sAc1bEy1DH/aFsBhjI KYrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774570490; x=1775175290; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lWzxoxI1BoNjbMnzfK+mLddqJ9V6D8F7yAlBnaGh3Lc=; b=VNlITo8ISJ1hdORwvj/8K2+0LYL9WvDsse5e4dFCRHBlgzCt7ROW5j2zQcDpNsUM3M T4Wpl8Nqvpj+aIVDceC4Laecgdqz4JXxw8MLIHJnMl9CJcZYjoyi36qDfofso9pQbwWI jRlH8wUAg1rdFCtVaurCgEVdMMmUJ5pK2EdiiM8kqTUmJMLndiQggnObERLiQcPXHAiz 9BvgrJf3U7Wa/woDnJLlWbuXpQH/YqHG/kX+Lg4R7f+nnHQ9NYs8NfS1Kx6z9eIHdYy+ 26OT2v93gDq94gZL1au2mUd40xXowRZC1d492CGgmz4NTOA1yvF+3BW3eR52aGUysb15 lDVw== X-Forwarded-Encrypted: i=1; AJvYcCVnKh1emhtj+KiCfSF314rVpCun7onnULy4Ay0VR7XKKbvSL2620GBqaQjBh3P5mtET5sQ90iZtRi7K9ik=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf6r6Va1QgWAxbiAu1s3tjPIbrs/oFq+NhfEENOUrQgtSBkljX ipPvhXkJwVCGPj9tg9rnyhTg/xCjyD9+JT6I2TkaRIlQJb6YmvcaD1U8Mg5U2Yom7T1/Xs04Fxb difKWAeoKNVyUGR8YWlRkUYq9v5nWhjzvKL4B3BTt4xzlAu963PWJGcr2N9AiBvmJAc7z6lcUcf 8= X-Gm-Gg: ATEYQzyY2Hij8Ej5MSFqBRxV2mb+ZHXStmvpeMp7b9oQU+6195CPH4PTvbF2i/PeNap cWhr2+CQa75EKPHTVgikWD6bKKDwfaBzDQlRVBRx3oZAR7MAi0X80nIG9L8I/f1jLfxaJQWibqz /cjIuWYvHEk3yKPmsm3IbQrRtnzlK9vulVktTxejtki8fihWno46IhfAQl0kk8T/7vyHBxPsSSe EOy/RkMulJRfwnfZfyrvit636Ox1aQA9K5rri8Bl3QJGAFGFbBlQ/bV0QQzRnwtwviFOLI+LbXA t3nia7HPoexYSK1uzozTEOyuJzaUx7qAw6f9mp04L7lW1O4kNWNpQOz01IzQcgGnLR9vLv5Xn7R J7iWtLy6lG/3e62OASJfhAoKwya5ES1YWcrBdmiru31dR1w== X-Received: by 2002:a17:90a:e7ca:b0:35c:f82:fef2 with SMTP id 98e67ed59e1d1-35c3002fc51mr480853a91.14.1774570490293; Thu, 26 Mar 2026 17:14:50 -0700 (PDT) X-Received: by 2002:a17:90a:e7ca:b0:35c:f82:fef2 with SMTP id 98e67ed59e1d1-35c3002fc51mr480825a91.14.1774570489808; Thu, 26 Mar 2026 17:14:49 -0700 (PDT) Received: from hu-akhilpo-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35c2ec799eesm163155a91.10.2026.03.26.17.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 17:14:49 -0700 (PDT) From: Akhil P Oommen Date: Fri, 27 Mar 2026 05:43:52 +0530 Subject: [PATCH v2 03/17] drm/msm/a6xx: Switch to preemption safe AO counter Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260327-a8xx-gpu-batch2-v2-3-2b53c38d2101@oss.qualcomm.com> References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> In-Reply-To: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> To: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Akhil P Oommen X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774570466; l=3298; i=akhilpo@oss.qualcomm.com; s=20240726; h=from:subject:message-id; bh=U5fwvqTvmhxC9U5Bv8tyvwyqOYj/HJbmdaC+3G7oXm0=; b=Sidpep9VrsVhXmKIRsMrCsxM9lVnQeKh3M83V7ET7hyl3L6Q2czyJWoCujkX06x2zL3k4BeNV QV7C9ktpR7RDSzKmRcOThPkVNP7ivyR0mV4Yr6WSswrTkEwVdgqFi3C X-Developer-Key: i=akhilpo@oss.qualcomm.com; a=ed25519; pk=lmVtttSHmAUYFnJsQHX80IIRmYmXA4+CzpGcWOOsfKA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDAwMCBTYWx0ZWRfXzRpT2dtqENbC RnmH60UYdkMO2vN9LjaU4j8HyNB6FW86YRJB+VSu5Lb+LGO4IIVXyGB0fdWnqBz8Io7++Vtgqjx NTwFUFiJlLANAC3wl4A8fi5jUB93vkibyzKfXumz0+8xrBI45b+KtkWBmn940kIz8RwmxoMcv/o 2GMX/y5l4n1PlDVqHrPWWyncHMoir/rrbHr8dTiCiM9kpmdHtCd6Tj71i5YMqmRkZu8deMIcsor mSlX/f1d0JVYJ4nyFpcq95fgeF8dMMcDni5Z1kg0RaqPRH5cL0swy8cEpAJ4kD6flyn6tyHoA5D jhdFtfxRz7KKe5UtMefCLBFerlXGD5wRDbXfb2SV6XArN59uZslWBxrCcMn3PKyoiQw4kWdD34e rp4GuXHjp72tPQ5TXeztYIF/L1rBUqOkWpK0DvzhAwdA4mPQ40M637nN/8iEJOiBuNNYRuh7FKs J2VGkPQuTBaLwORPGHw== X-Proofpoint-GUID: 088UEHD7hlzEioDl8krbtEDJiStORV4a X-Proofpoint-ORIG-GUID: 088UEHD7hlzEioDl8krbtEDJiStORV4a X-Authority-Analysis: v=2.4 cv=JaCxbEKV c=1 sm=1 tr=0 ts=69c5cbfb cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=IjstctezsF06UAORExcA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270000 CP_ALWAYS_ON_COUNTER is not save-restored during preemption, so it won't provide accurate data about the 'submit' when preemption is enabled. Switch to CP_ALWAYS_ON_CONTEXT which is preemption safe. Fixes: e7ae83da4a28 ("drm/msm/a6xx: Implement preemption for a7xx targets") Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/ad= reno/a6xx_gpu.c index 50bd7aa4e792..f8cb8b578661 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -347,7 +347,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm= _gem_submit *submit) * GPU registers so we need to add 0x1a800 to the register value on A630 * to get the right value from PM4. */ - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, rbmemptr_stats(ring, index, alwayson_start)); =20 /* Invalidate CCU depth and color */ @@ -388,7 +388,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm= _gem_submit *submit) =20 get_stats_counter(ring, REG_A6XX_RBBM_PERFCTR_CP(0), rbmemptr_stats(ring, index, cpcycles_end)); - get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_COUNTER, + get_stats_counter(ring, REG_A6XX_CP_ALWAYS_ON_CONTEXT, rbmemptr_stats(ring, index, alwayson_end)); =20 /* Write the fence to the scratch register */ @@ -457,7 +457,7 @@ static void a7xx_submit(struct msm_gpu *gpu, struct msm= _gem_submit *submit) struct adreno_gpu *adreno_gpu =3D to_adreno_gpu(gpu); struct a6xx_gpu *a6xx_gpu =3D to_a6xx_gpu(adreno_gpu); struct msm_ringbuffer *ring =3D submit->ring; - u32 rbbm_perfctr_cp0, cp_always_on_counter; + u32 rbbm_perfctr_cp0, cp_always_on_context; unsigned int i, ibs =3D 0; =20 adreno_check_and_reenable_stall(adreno_gpu); @@ -480,14 +480,14 @@ static void a7xx_submit(struct msm_gpu *gpu, struct m= sm_gem_submit *submit) =20 if (adreno_is_a8xx(adreno_gpu)) { rbbm_perfctr_cp0 =3D REG_A8XX_RBBM_PERFCTR_CP(0); - cp_always_on_counter =3D REG_A8XX_CP_ALWAYS_ON_COUNTER; + cp_always_on_context =3D REG_A8XX_CP_ALWAYS_ON_CONTEXT; } else { rbbm_perfctr_cp0 =3D REG_A7XX_RBBM_PERFCTR_CP(0); - cp_always_on_counter =3D REG_A6XX_CP_ALWAYS_ON_COUNTER; + cp_always_on_context =3D REG_A6XX_CP_ALWAYS_ON_CONTEXT; } =20 get_stats_counter(ring, rbbm_perfctr_cp0, rbmemptr_stats(ring, index, cpc= ycles_start)); - get_stats_counter(ring, cp_always_on_counter, rbmemptr_stats(ring, index,= alwayson_start)); + get_stats_counter(ring, cp_always_on_context, rbmemptr_stats(ring, index,= alwayson_start)); =20 OUT_PKT7(ring, CP_THREAD_CONTROL, 1); OUT_RING(ring, CP_SET_THREAD_BOTH); @@ -535,7 +535,7 @@ static void a7xx_submit(struct msm_gpu *gpu, struct msm= _gem_submit *submit) } =20 get_stats_counter(ring, rbbm_perfctr_cp0, rbmemptr_stats(ring, index, cpc= ycles_end)); - get_stats_counter(ring, cp_always_on_counter, rbmemptr_stats(ring, index,= alwayson_end)); + get_stats_counter(ring, cp_always_on_context, rbmemptr_stats(ring, index,= alwayson_end)); =20 /* Write the fence to the scratch register */ if (adreno_is_a8xx(adreno_gpu)) { --=20 2.51.0