From nobody Thu Apr 2 20:22:03 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED7AC3A6F17 for ; Thu, 26 Mar 2026 23:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774569179; cv=none; b=reiPNqkDUY0XeQLeCMCr1poW3EypW9yN7VciO29vBY545BoSPNw7GQLsjb5lmjgveqQRsjLzDzvQafvl/g+Gibuz7SffR5F7Ce4sFOAtBGx5sviOrpsJValWTaJ2uupPKx5iZjdX54IP7XY2yaKUTslOwl6J68CF0D9XNYxF3mg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774569179; c=relaxed/simple; bh=Nq5UYxxNFmSt5vepIgZmRBNNU7FqKFEBLG1AqkhZO/4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q0+JnzOevHfDAqFriYqvMRP69LEBLRy7FFfe/lz+1vxAW7oG4xJflkjttR5bneYGs8WoWI62mw66oxt79BBzltnTRXxwg1CcYgkNWX/60xxuYo2GJD9M2KOOu+2bVhpA5Dg5ySIajtGR7Rqdek+PfuBB8r8DpgLSGAQuFM3jNDM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=dTOCrYbf; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="dTOCrYbf" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2aaed195901so6721365ad.0 for ; Thu, 26 Mar 2026 16:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774569177; x=1775173977; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5UPYFeaXBCTnwUC9U7Rpioh/CF/owhvrx8QKdsJhO4I=; b=dTOCrYbftR9lgorQnL33KUWCP5FCHDi1W8VZFHCROvrdurdRZNI2iozgFC4LkKKhIb C0rLC+PLKCk6Doq498p/MH5MDOAt2T0uping+cXVj6sB4sFlgqgF9/Zbs25NQ3Q8nVV/ 8m8SARgYXpdlkS3KRj9eAyKKLnR6m1VcxslVm4azp2yHQscsytK9oxihvHeYpGK+MBjT yBdOU/o2NubeLjUVCmFbj0VqRnf9+7uFbNIfxLBgoVFn8SvHgUD947sJpZBV1XpCCSBs I28nA84IFeB++AgDA6nqZ0y1XP9jsjj0l8uLyQcT9izgWyU39Fdyb5IPxAstUVMK4Prd 3Jag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774569177; x=1775173977; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5UPYFeaXBCTnwUC9U7Rpioh/CF/owhvrx8QKdsJhO4I=; b=flVx2uDCDLzFBuvK0j+xLjPh8WQOIdKgJ0bXn62hGJPxKF1gdKrGXEyy8LTuLLYTg9 3v0dlTA+GHg56KFF81pMEstfeBPFe/1Z3kGrMd35M08RotzR3H4yupMn0uG53h5Lf3Yi buwX7kqf4eBUyikqCuqQLICdhmvf3V5MHqQ3rN8fKXyFSTrdVAYswiEvK2MQezgwHgqN vlTlpQHphq9lR6aGDwMxCZiEqqAeZ4S62AoifOW2vvyUYBmUlJpjiwKe6qEyBQAy/y/8 sY7W7fStexUR4+lvIyTEuKwiYh+kpsqRkl4HPx47j/W33XhzGZCVVp+9cKwnujl9QRXN hnFw== X-Forwarded-Encrypted: i=1; AJvYcCVNdjH0OM6OVkaJqfhmJ9+zBxe9PQ4TxQhzgKikl8vnYucAh7/pdRmM01lnp74wRpMDhwTj+ZNyzYPy8jY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/urZSQty4w3CtHm8SC0jwBrPsaYdDs5stLNL/F6TaiTweymr3 C3h8EDMbIHA3e0W/jZq6CG6ix1PZncoJfBXo2H83yfVQpUtzCG1pZO/EpJRlGiz+EX8= X-Gm-Gg: ATEYQzyzmcAs4HLIJAuuj+V+wcAE7qoQXuDJJMnw1MMfB9g/84E6pYwK9gnEUHQD1mr GUfcIsT+kOPAJ0bpsIU7zN5SJbVcLLFOJVnp0YNdL6yRzXbRDM6JSc0eQeaVNfKuPdldyF4kyEn 1LMskxYqX9p8z5GAfBrn93Xb7bsQEXCSp163H3Q9Z5hjr6jqxFtqitlW6IJf7tMhpNASmxBDagu SHXd4kBeilrJYi+K71UXdzIfLhLYdR0+brQbXRja9MukDFnoLt5qNDnjZxWzO7sAQo7GfoFWwfQ 97lqW47mCDJYMFGc9R5BmJ6rpB5X6jQMkReKAZH155ncwwmjqPj12znNShOQVOUfbVEzd30hey4 IYnXhfLpQYyeG5Cmyu6B6KDqPfvK0jyqwEwD5UJrkzK/r4PI3g/Q8nI9tICvXIWjHiYsObIYu3D usfvf2 X-Received: by 2002:a17:902:eccb:b0:2ae:5752:af82 with SMTP id d9443c01a7336-2b0cdcf5b8emr4290015ad.49.1774569177241; Thu, 26 Mar 2026 16:52:57 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:5f::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76736e54e4sm3263806a12.0.2026.03.26.16.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 16:52:56 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: andrew+netdev@lunn.ch, horms@kernel.org, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v6 04/12] net: bnxt: Add a helper for tx_bd_ext Date: Thu, 26 Mar 2026 16:52:23 -0700 Message-ID: <20260326235238.2940471-5-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260326235238.2940471-1-joe@dama.to> References: <20260326235238.2940471-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v4: - Added Pavan's Reviewed-by tag. No functional changes. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index dcc83ccc3bb0..8515cd6e82fc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -663,10 +663,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -693,7 +692,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -706,9 +704,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index d82b0899b33d..a6b04652600e 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2834,6 +2834,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0