From nobody Thu Apr 2 20:21:59 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0AB43C4556 for ; Thu, 26 Mar 2026 23:53:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774569197; cv=none; b=onJ7KZAevviprl5nhYoK0gw9riCkuxjB0b1leO+oEdSSMJUcjFDY4hwy1/2rZQ/AT+lwzQCfaDf/dKTocPHM1NMCQDX2hbqGkljC/57tSZMR88YE38MZhgtByprUhBrS3lb50QKTZIWc85/x7DX/0HUJmUjw4T1FM5DiotL3L+8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774569197; c=relaxed/simple; bh=uWnYZfxpXWzMEdoD4OoQj78mYr7rYihNxdLMDApkweE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mpOiaM+oBamacYWNu84bNpui873CAh6Wfz9PmC5vkpMwoP1SEDXFcelZ9GYvFVGorikVXwUIaU5wEVRl5ZoU1kdcD5n93Tctj2swYLBI0SFNI7ylv7j64AO8ZYfAQS8jX/6jiEsvFnBXONp7v4suqbVgv15opLOJFkIPfhXTins= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=rtYAUz1S; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="rtYAUz1S" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b0c8362d93so5833355ad.3 for ; Thu, 26 Mar 2026 16:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1774569190; x=1775173990; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lGwTwQhNH9Rzs+EHOpg8GEhPLriykUGXInx1g7lVTBM=; b=rtYAUz1SqOlo8UK0hQgpJEeyQJoG4AReT6crtCujEHQd7PfnfHqepLv3RznAvdysJj oanqLPh4BNyzZWaN73p5d5i64tKgTeQe2V4AlHrrlIcnUhRPmExgW52eXXF6Yz9kwUsn Lc4UBfZ7pIvKHGZTw7djU0K/AHnmhAeIrgcalnTzHZza4kGI7oKF2aJChu9Fp860lIII C4/eE5FsVohrH/snN/xPB8AXhp7YiNnnuuQA358orNp2Unu0ICJPXg8UBuur1XBOZvv3 4qTKg6T1ykz6IaI4K7WKRkZbtwqcitEbNg9avgd0wtmyk4+pXNKT5+nlLpBC/eSHtBtL ov+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774569190; x=1775173990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lGwTwQhNH9Rzs+EHOpg8GEhPLriykUGXInx1g7lVTBM=; b=LamkRdHZNAOl7T2Kc3yldwcYRl/K8suIWK7NQ7/CUDwiJBYGEQNqRrbIF3Q/gFjSIu cQ8Ylfi7AgQ0di+w2RG2yLODY0MkUKHD8qFS6qeDWabbF6OTkxH9SvTSyigS4Wxew3aC ywJmlQSLk84D5qiXdqjH6GlQMlQvtTUs+/N4THwd1hmtrngooor0GuThqj+j2L2026Ug MHXaKeXTI3SGFS35LiGBvimGSzvtycIbeWyHczxMO2VUa0v4XMBK1g/aJhJTS8vyOe5F tXv+y8Xxf/6yGaL6JK36Q8yk2naiNvcUiI+1EoXGTTcE0wzerxjIoE+uSjsRG68WpKq0 /1ow== X-Forwarded-Encrypted: i=1; AJvYcCW9NLkX1PR+GsIiLJF8fn8an0b/tUNOKQLCo977lvDV0VoqkRafGxRcppZWRmW+6f0ZvzvNtnIi/BCZtTs=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7t98miJYjXqdnN2UnOdHiVINFfb7D/YMp5l6Y+T0eW57EL0my FnVCEvQ9FIywB+TuxL336DjChmY7K7D4RxIlrVEpbvuISu4a1/L26SF/tUj5/Tu3qKM= X-Gm-Gg: ATEYQzzwb2dIaGGE5dIO3konQJrjXAsOZoFkqGboe1ZyHGH8RtnKU6ckp7pVzzd02EI bzSWqFXNZKAZxpjOYzd3ZMKHqnjOEZTiJizloc6y7LHaS7tuvRAn6hL4Q89AuP57wN1OTrIWm45 C1FY7FZ1+H0yoLInghZJPsorYG3oPMGu42+C+f2ha46Eqts2qGRqF4N1Z1lHeCwqGWQWRc97lmF 7EkgxeA61ELQgO1lbXH+tTpXzhjIFJioMpBefNZGGE3sIWekOz3EInSsPaegBcbYZs9tQd7IUe5 uD8kZhw9TLt4DtKCnPfLTcaBzFT81rPVS1/5pvM1qqO7QpYdMEjZJi+0HKjRyP/6RHfTr4J7bnJ tKymZQESIH8AFGr91SAj6XOeX7ZdbEPBlp9aSazPZazAAR20pGCOIIDxlpltYvzyP0O1zJOVKom Viq+MPBqJPxqfBLHM= X-Received: by 2002:a17:902:e809:b0:2a9:e8b:5326 with SMTP id d9443c01a7336-2b0cdc3da4emr4232045ad.23.1774569190139; Thu, 26 Mar 2026 16:53:10 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:5d::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc881fe7sm44411865ad.48.2026.03.26.16.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 16:53:09 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni Cc: andrew+netdev@lunn.ch, horms@kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v6 11/12] net: netdevsim: Add support for SW USO Date: Thu, 26 Mar 2026 16:52:30 -0700 Message-ID: <20260326235238.2940471-12-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260326235238.2940471-1-joe@dama.to> References: <20260326235238.2940471-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for UDP Segmentation Offloading in software (SW USO). This is helpful for testing when real hardware is not available. A test which uses this codepath will be added in a following commit. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v5: - Added Pavan's Reviewed-by. No functional changes. v4: - Added parentheses around the gso_type check for clarity. No functional change. rfcv2: - new in rfcv2 drivers/net/netdevsim/netdev.c | 100 ++++++++++++++++++++++++++++++++- 1 file changed, 99 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c index c71b8d116f18..f228bcf3d190 100644 --- a/drivers/net/netdevsim/netdev.c +++ b/drivers/net/netdevsim/netdev.c @@ -30,6 +30,7 @@ #include #include #include +#include =20 #include "netdevsim.h" =20 @@ -120,6 +121,98 @@ static int nsim_forward_skb(struct net_device *tx_dev, return nsim_napi_rx(tx_dev, rx_dev, rq, skb); } =20 +static netdev_tx_t nsim_uso_segment_xmit(struct net_device *dev, + struct sk_buff *skb) +{ + unsigned int hdr_len, mss, total_payload, num_segs; + struct netdevsim *ns =3D netdev_priv(dev); + struct net_device *peer_dev; + unsigned int total_len =3D 0; + struct netdevsim *peer_ns; + struct nsim_rq *rq; + struct tso_t tso; + int i, rxq; + + hdr_len =3D tso_start(skb, &tso); + mss =3D skb_shinfo(skb)->gso_size; + total_payload =3D skb->len - hdr_len; + num_segs =3D DIV_ROUND_UP(total_payload, mss); + + udp_hdr(skb)->check =3D 0; + if (!tso.ipv6) + ip_hdr(skb)->check =3D 0; + + rcu_read_lock(); + peer_ns =3D rcu_dereference(ns->peer); + if (!peer_ns) + goto out_drop_free; + + peer_dev =3D peer_ns->netdev; + rxq =3D skb_get_queue_mapping(skb); + if (rxq >=3D peer_dev->num_rx_queues) + rxq =3D rxq % peer_dev->num_rx_queues; + rq =3D peer_ns->rq[rxq]; + + for (i =3D 0; i < num_segs; i++) { + unsigned int seg_payload =3D min_t(unsigned int, mss, + total_payload); + bool last =3D (i =3D=3D num_segs - 1); + unsigned int seg_remaining; + struct sk_buff *seg; + + seg =3D alloc_skb(hdr_len + seg_payload, GFP_ATOMIC); + if (!seg) + break; + + seg->dev =3D dev; + + tso_build_hdr(skb, skb_put(seg, hdr_len), &tso, + seg_payload, last); + + if (!tso.ipv6) { + unsigned int nh_off =3D skb_network_offset(skb); + struct iphdr *iph; + + iph =3D (struct iphdr *)(seg->data + nh_off); + iph->check =3D ip_fast_csum(iph, iph->ihl); + } + + seg_remaining =3D seg_payload; + while (seg_remaining > 0) { + unsigned int chunk =3D min_t(unsigned int, tso.size, + seg_remaining); + + memcpy(skb_put(seg, chunk), tso.data, chunk); + tso_build_data(skb, &tso, chunk); + seg_remaining -=3D chunk; + } + + total_payload -=3D seg_payload; + + seg->ip_summed =3D CHECKSUM_UNNECESSARY; + + if (nsim_forward_skb(dev, peer_dev, seg, rq, NULL) =3D=3D NET_RX_DROP) + continue; + + total_len +=3D hdr_len + seg_payload; + } + + if (!hrtimer_active(&rq->napi_timer)) + hrtimer_start(&rq->napi_timer, us_to_ktime(5), + HRTIMER_MODE_REL); + + rcu_read_unlock(); + dev_kfree_skb(skb); + dev_dstats_tx_add(dev, total_len); + return NETDEV_TX_OK; + +out_drop_free: + dev_kfree_skb(skb); + rcu_read_unlock(); + dev_dstats_tx_dropped(dev); + return NETDEV_TX_OK; +} + static netdev_tx_t nsim_start_xmit(struct sk_buff *skb, struct net_device = *dev) { struct netdevsim *ns =3D netdev_priv(dev); @@ -132,6 +225,10 @@ static netdev_tx_t nsim_start_xmit(struct sk_buff *skb= , struct net_device *dev) int rxq; int dr; =20 + if (skb_is_gso(skb) && + skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4) + return nsim_uso_segment_xmit(dev, skb); + rcu_read_lock(); if (!nsim_ipsec_tx(ns, skb)) goto out_drop_any; @@ -938,7 +1035,8 @@ static void nsim_setup(struct net_device *dev) NETIF_F_HW_CSUM | NETIF_F_LRO | NETIF_F_TSO | - NETIF_F_LOOPBACK; + NETIF_F_LOOPBACK | + NETIF_F_GSO_UDP_L4; dev->pcpu_stat_type =3D NETDEV_PCPU_STAT_DSTATS; dev->max_mtu =3D ETH_MAX_MTU; dev->xdp_features =3D NETDEV_XDP_ACT_BASIC | NETDEV_XDP_ACT_HW_OFFLOAD; --=20 2.52.0