From nobody Thu Apr 2 19:00:06 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5305A34EF10 for ; Thu, 26 Mar 2026 23:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774566721; cv=none; b=QN/7a6vi7UfIZFRgGn+Rrh+LkTPT1dTfPaBQaYzvswZ8VquycKDZdUcj5tgPMk5ruQf/I8ZbgYmsS1kPoDBljpbAvt8UPOOKqRugwU4dL1+J8o7wbtveRoulaJfsHsZx5Wua543aM15dBYLGFCHB9rCI1mTUIFSLltQzGMRT8vY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774566721; c=relaxed/simple; bh=CHLw8W8no9w2IzF23NQVWCWYxh7Byp+1DM71Jw8m5R8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hXaR3pduTkkvm5j2fmJRtIJjsbCjGSXspdSKdLd7nn4tLesTuUtx9WFoYQgj/IDdPN9+yDm1kRyZ6tLG845LHnXKzhS2ol5cVayZUHTtusYRBuqVoZtI7o6aDE1rOg327QVfJelZn3afd3PFp2rjRUJiSn7s+7UuFqF9CqyXQ/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UE4T8ipD; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UE4T8ipD" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-79885f4a8ffso15323627b3.3 for ; Thu, 26 Mar 2026 16:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774566719; x=1775171519; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qFkIExd9ilK/Mb5afUnvkOrSHhNZHUt6VUdY7xzMApc=; b=UE4T8ipDl9ay8ShOO0Rmtoiv6KQyydjAhopHr/s2Wrqi+FEsL8Hqwi0fSLPkQHOg27 QHmobEgUxMlTAUTukhqHGp+1xU0HWRaYgGjCu6dHk8lAViJBDoMTPz9U+0bRmLiwJYCI NybRIePrBuQ//lw38fYQEXdWCdIetK+PRAZqoo9sRXd7dc4jzR4CXatYqc9O0YaAisWT G5E8b6SCO6nI+Xhu1OmRBGKKqGj9ZWCV0ceS9RI4EbZOFznCkdTyMpTR3FojJQSiey4u 4JUZ+dnxTs8LgkKCLCgZlDmxVeyQXnz+SX884qVhR1r9RhA/bvEgCECLK7Fr6iGKSzKy 6sag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774566719; x=1775171519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qFkIExd9ilK/Mb5afUnvkOrSHhNZHUt6VUdY7xzMApc=; b=PVB4YNEt+nPSvzVKpvvCK6dJw4lndz02eLBcrNmFqY5j/giRCA0xALr5sroDrZHCAV edAU3i4NJ7cuCymIPg8ERKHGO4q1BYtEj2jxYWjR62/uvoVZboEdtHqpI7JDPWaX8es2 a9Zz1V59VHR+VF4x/YjPSW9zn+NURwzsbrAlJamD+uMI6gBdIWsr222lZ4aFfTh1ajow iY4I/9rasLQT/zOisZ2T4BP+YuGQ1Qo8iWqmbLKGwflO7bA+++VnnfDmTieyLp6kzGHu 9y7ka54m4kqsh+GOYzkyh+aaDiQy9uZAC8zA23VKNOyEQCN91Si8cbuKi16ZYvGZBLHH am8g== X-Forwarded-Encrypted: i=1; AJvYcCVIkRhqnIrPjPU+sEXwoPzwxC+UoQznw7EiMir/DUe2AwKE07gjzkAhFNoGUu8kg85aLkh9/Y4XUbUmPig=@vger.kernel.org X-Gm-Message-State: AOJu0Yxzhk1JhBzilzh5xxwfdgfR1HG3eXxi6U6Gubkqk5mP4Vc0mWpM c0HFfX6/8lLQA73XVGmq+2JaL8aCa/zrjd3P0NtiIvXKCHvFZ7rlY7XR X-Gm-Gg: ATEYQzzNwn6GmlUvmcLXiM0cEZcjwaFEGgMlRjjKvkfMrttT/AgenDbwFCwhCpqzFbw 9XnbQ3syxtKIQVpmSSDpqiojovunD2KZ26LXeOG7sUOmraZ7yclAcpLHBGDrZ/wb9d8tyuXfVlK aTDQ2RTCvACMO2rn5auDuIicgv8+49HJd2E5T1DUL3BIDbG14rV63usBdlRfLUzLJ12cLWao2tz sy4ujERBG5wpNykE6Ks6clvU/pOEKVOPoi6pzY/RL2EDp0UZV+Uqyy0iBFXZDUHWcF5FFjx6ji4 IenqLg19lBS3xd/bvSa+8Fy2mn0xOx2A/k+xyIkTby2AmPcJFOiHY+VLJubVu4PuYEmrA8Gw1sf ZAKG9FP0QgGIGqaX+hPIjQObgBF6gEXVG0ETbHBbVSmAtKXJWSWSkufFtlCYfUzn5EWNxBjsv/e 80/ejSCrQmivQdzguf76LtzzHBa7Cl2jAVZzytNP3iR86Ewlz+4T03gmjTMz5I92Ifkl83nY3pV 5edCUJtTnIpMsmaP18xv8RC X-Received: by 2002:a0d:dc86:0:b0:798:bbc8:bca9 with SMTP id 00721157ae682-79bde010a95mr1447217b3.31.1774566719323; Thu, 26 Mar 2026 16:11:59 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79b1e3fc9fdsm20925527b3.38.2026.03.26.16.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 16:11:59 -0700 (PDT) From: Ethan Tidmore To: Corentin Chary , "Luke D . Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 1/2] platform/x86: asus-wmi: Remove redundant condition Date: Thu, 26 Mar 2026 18:11:53 -0500 Message-ID: <20260326231154.856729-2-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326231154.856729-1-ethantidmore06@gmail.com> References: <20260326231154.856729-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The condition (ctrl_param >=3D 0) is always true because ctrl_param is an unsigned integer. Remove the redundant condition. Detected by Smatch: drivers/platform/x86/asus-wmi.c:4427 update_screenpad_bl_status() warn: always true condition '(ctrl_param >=3D 0) =3D> (0-u32max >=3D 0)' Fixes: 034f5efd362fb ("platform/x86: asus-wmi: adjust screenpad power/brigh= tness handling") Signed-off-by: Ethan Tidmore --- drivers/platform/x86/asus-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 0b87214ddd1b..80144c412b90 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -4424,7 +4424,7 @@ static int update_screenpad_bl_status(struct backligh= t_device *bd) u32 ctrl_param =3D bd->props.brightness; int err =3D 0; =20 - if (ctrl_param >=3D 0 && bd->props.power) { + if (bd->props.power) { err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); if (err < 0) return err; --=20 2.53.0 From nobody Thu Apr 2 19:00:06 2026 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2324F351C33 for ; Thu, 26 Mar 2026 23:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774566722; cv=none; b=BXx/LmLaZWv9eCGzka8C7FZBFJZtNYvSPFfD87sPiqiolPIE90vr4djsMBqL34DDl4uL3v9FOrDr2SDkO/hiw/utUrBllc35MloQc3D/plS2lbDmSngJ+S1HbjX+n5beJgIIBpZl6JnUlY4I8Vb2ukavs/Ogr2p14wSlhhlR3/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774566722; c=relaxed/simple; bh=K+AmH6uNRG+7A1J9LZNzt7+JaTmY42V47ueykQUe/Xc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NYYQJKkJN1BmkjKmfuwkRN5n0p9tq6DOqDWUqkiyhaq5LVktw5T9A0gNlw1KtIr7dirPwOM8D8aHuIESdWlJyEe/Ztw9oe6B/8rIKk3WyZc5idhe9dWzgLZgDKcPdYlPsDhp+RGqiH52lONjqS+zFDi9A2xgqV1R7OtVE8MkmlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U521ICKK; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U521ICKK" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-64f48a5c3d8so1928656d50.1 for ; Thu, 26 Mar 2026 16:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774566720; x=1775171520; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1j8lzZoc0P5Ygbunqje4X/HjCJ1j8htOSchckU7Arkk=; b=U521ICKKwndUr7tJVBS/ezNvE2AGZ0ASsorDneQSFNtzZWa8x3ks+xzLqpj07nTaZr GJzE7X1QpRliS/B86fquZ3NI41L1lTiHJMmM+SsCsk7d6WPZTNjNcdDWMCR1Q4WIbMYM d+j3tT9Ib5cyuwhiSgk4ouFrw2y2v+7qdBbBtOovO0YiI6wpPYPZcvKpGRMWe4K3/GcX Zf57D6MqtCninWtQVY5SSjIfvUVBO2gZ34jqvhd53oPMFjTWW9lbS+3ynl5IRh6XlbyK C0376KJbarNCi3Snarhsk0OiVRmOBs97jG3NHFAFp3UE1tSuJxlH1RxlAE9LUE1fvWgO +d0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774566720; x=1775171520; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1j8lzZoc0P5Ygbunqje4X/HjCJ1j8htOSchckU7Arkk=; b=qthzKIRHr0xeMNjf67eSJTeaydyo4NOpVRtnfQMAez+d8PfZr4xK4jKUEWfG3j1ra+ alJl1/aIQfbdj0brq2DxZpA1Ffvp5ee6VA+NoP84/UctS2sd6247nnNYqnks+n8HgZlr yVHULsId0I4oHMBc/KuEPZMap4oU0BF56/vbc4G4fWA36x4ZTVijf3HsOQgCzYnQj8g3 UWgycQ4z8MyX9HBWE1ODQd6uZGMq7yrRAweg1z+P0BUYjjVRtcAa6dV6Wi0JY9qXE326 wOB/zeApt1c4ycBy7YHVFXWScS5C9QHANbtmsHHBOLCkb51Vcos6zPeC6gM8oXfnL4dz dCkA== X-Forwarded-Encrypted: i=1; AJvYcCUexiQHgKN6PhEEr7exYe1axmYMpDE2HeBRcJcdwEik5x4H3QY+Aq2wK0xasf/nTi+Fy2IGyv2V0pRqJ+M=@vger.kernel.org X-Gm-Message-State: AOJu0YyC4DZ/vG2imlX/bu8AkQyZHO5zJbraxGL4YaUs4yhCf6zenNNG N20jzPOzK4vYyDIX0OJFN6Ai9/IMyiLkEX0s8bBnAczqCNy5mGq0cwwQ X-Gm-Gg: ATEYQzwRzbxVjcYAgHetnjZfXPuw1hnXABJ8ZnwNehvJY1oCWsOvkgN/caKIEGTC9OB NSDh5kfKRXwrH8Ai3vgkg7MwH8MvF9iQvI7/OuOnD4XvEGpRI/xSRW6Vsg/5sUIHfdZ0dnt1FIO /W+OdlbymNvYzFvs9sXj4yrTxDxyrIQCTggv9pgWb9uh/tjxasEC+Hji1AwVfQqwjx+apRVJnZL sbco4UlI4yylaWxbG+V4TVOZjy0b0XeUE8GRcmf+Efx+7UiwfOYInLymT7q0rXgzYY0Dsn0H6sF q0+Go8orrZvr6xXrEwfUvyOsd6zwi/2xbMtEsAV2+0VV/tNJ2sljsS2qRw9hcFe7OUbeM5qJ0wL y81YI210u1RzMSsPpRAEMGuW5VuQ6+uB0leSEuRiyzzavb5uRhJV9/g1r11TcwgllixXgu0rpwq tGtg1LoDmDpR62ZXQCVFttXWHojYytNCrKoH28YjKGyn9g5XFnynDT14k8Pl+/gipE3NVI9OTqQ 766zp3CqCNs5s6vqo5gO06i X-Received: by 2002:a05:690c:60c6:b0:79a:d2ba:3c24 with SMTP id 00721157ae682-79bde0e66b5mr2037137b3.41.1774566720157; Thu, 26 Mar 2026 16:12:00 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79b1e3fc9fdsm20925527b3.38.2026.03.26.16.11.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 16:11:59 -0700 (PDT) From: Ethan Tidmore To: Corentin Chary , "Luke D . Jones" , Denis Benato , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/2] platform/x86: asus-wmi: Refactor control flow Date: Thu, 26 Mar 2026 18:11:54 -0500 Message-ID: <20260326231154.856729-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326231154.856729-1-ethantidmore06@gmail.com> References: <20260326231154.856729-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Refactor control flow in update_screenpad_bl_status() to avoid unnecessary if statements and error checking. Signed-off-by: Ethan Tidmore --- drivers/platform/x86/asus-wmi.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index 80144c412b90..f8e389c54fe4 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -4422,25 +4422,17 @@ static int read_screenpad_brightness(struct backlig= ht_device *bd) static int update_screenpad_bl_status(struct backlight_device *bd) { u32 ctrl_param =3D bd->props.brightness; - int err =3D 0; + int err; =20 - if (bd->props.power) { - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); - if (err < 0) - return err; + if (!bd->props.power) + return asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 0, NULL); =20 - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_LIGHT, ctrl_param= , NULL); - if (err < 0) - return err; - } =20 - if (!bd->props.power) { - err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 0, NULL); - if (err < 0) - return err; - } + err =3D asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_POWER, 1, NULL); + if (err < 0) + return err; =20 - return err; + return asus_wmi_set_devstate(ASUS_WMI_DEVID_SCREENPAD_LIGHT, ctrl_param, = NULL); } =20 static const struct backlight_ops asus_screenpad_bl_ops =3D { --=20 2.53.0