From nobody Thu Apr 2 18:47:36 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEDA533D6EF for ; Thu, 26 Mar 2026 22:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774565897; cv=none; b=fw50SoC0XhTlweHQrVu5dlYwJkYSsY3PuMIY8gs5o4sTwadkm/mB3h+eSoFBrai8RnLq+AtFWYwzuNKrfTQON6CWqmelbw4QITt4ftdq14YqBXZHEis/vZcd/6bFk5a5mhk4KEi603AfOEkRX9O08TuB2U6pGJ7BB8kOTTCfvog= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774565897; c=relaxed/simple; bh=u7L0vFhq8BRibG/5OH2Hp340qI56c2c2addeuVbeDtE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=lnF92VuDk9zL8yWZQuXby8VHQE1jGvBbxxEhtqP60c3EwbTvs1ANWQti/WT45dSPKZ6i9iyE9BWPeapT3pfNe2ZjA3Kgwaxi3qLUlyjIw3gN3eupzOZLyHutHFsKJo1JVfP/XFp3gl5IWMYleF1IGIl/yij63POnab2VGCuuSpg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TzLy2i6C; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TzLy2i6C" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-486ff201041so13352685e9.1 for ; Thu, 26 Mar 2026 15:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774565894; x=1775170694; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=ZF5QwTXW0it83BlX45eDb3Cus84yuaXHUnb6NVnQYmA=; b=TzLy2i6CbbBkFDHH+oK/fELi7n/UvAm+Ziht5LYTKbyGHq6S3xBskneWGjbRZZ6gG7 yJjhc/AfDvgMKEmKW2K6XFFzS9dj7iPN9igTjJIBErvj6Zc1WbFKvS3VPQSfkOZF844O Nk93XPICrJpyiANKTQ8yMBQePunp6A0+V/OFSvG1V10yiA6Od8kcrdKzlk054HVUcZiq so69gStIYm8gwBZ1VSSNzieeXVxYh838NLMFxSY+gAWgdQ8WHI4rIrbhNRLXPcl4G5mY HiVALcgrMcyXKzFk35lU+aPvW1LpQLBkxHoCVRxcyUfqh61hgAixY9occqOtWD6ab4su h3pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774565894; x=1775170694; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZF5QwTXW0it83BlX45eDb3Cus84yuaXHUnb6NVnQYmA=; b=gefB1BF6jICZYGnoe3PlTtgUDqTLM+astpBp4HO69VL6qKo037Rekojq9HF4iW6VCH NrGFl7G+r73cWK7iIq/nL0/TLQW4pv37ScwGsL609itE1g+VZlwMrWM8U0wUf8DVId68 iJPMcEw05RtcutNS17fLlEJ6DGSmOzlPeSGbozlp7/dOEjrzEo6wH9kEKMTFzgTgaEZE nDlc0Fl0yLXOXaxob5l508HPyr2EUJL4AOGfy/mLH4FXealkDzxbod9pFlR75PAQSGQ4 P0ZOXONGYORbQnMmx8C8SienS9i1oCuARP2sY7DIwkpu6m8TbCLsZUni0pylkIvdYPV7 erUg== X-Forwarded-Encrypted: i=1; AJvYcCV5eBFvBWtRDAvAtXkLp/+6XrPUysEdP9LMXb09SnCFpNIVnLyAeU7LeeBklqAHBmBZrQyMV8p78aib5I8=@vger.kernel.org X-Gm-Message-State: AOJu0YwxNJ4VP9UQiEf8DAiFexNd8HGfS3bx6iK3RhipXDo8vVRpvieq w6PJuDFNgcvloxIbqr8meCNcCTZpn7jxEPQrv0q3W3z8UbI61jTKmlvc X-Gm-Gg: ATEYQzwyvT0FRHm1xa8xAWIFWz89/1Wsl6HHpfGR6W45XSnAyXLTf4ybNWeZEkfUv2L 9iTAhcEr4siK2Tcpe5ro+z7ak34SaxuVBCbme6puvLXZNJiGOsoOvUQTMzNUtSP/x0yqcaDQdmF BtL80cZE/rzBFExQdS3SuA66CZTXiu8wJAOt69U9MGufHpMUJ0+feFUzgW+1KcjXKRHFp6ZOOBt qSQgJWyOqAbu420azhkr89AphKFmRSiFkI0pNkDu4OCeXmQMSzbyUvIdPrgFdaWTfsrp7WKNRhN MIDnP1X/kg67zy9pZi9cXjzmXRw2gRPv2BR3nmNlbZRB+pLx4rrUz5PMBBv+FGM0dGodbU751gV qdDDRxpHW0OxQTwHgCJc+9oZLH60gqnaVYlj0puvsCtAp90OQ5BuPRaj1FGugk/ZmIt2dhVBK7M mOW0XEiZK9gFcG+Fv/KmLoIXw2vHCMQYbM58eL0SZnuetfdDjmzbPq9JBRuvXr X-Received: by 2002:a05:600c:c87:b0:487:338:b4eb with SMTP id 5b1f17b1804b1-48727ede22fmr5969135e9.28.1774565894147; Thu, 26 Mar 2026 15:58:14 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:8cd6:6329:c43d:2fcb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48725d9bca0sm5579365e9.2.2026.03.26.15.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 15:58:13 -0700 (PDT) From: Osama Abdelkader To: Catalin Marinas , Will Deacon , Ard Biesheuvel , Ryo Takakura , Breno Leitao , Mark Rutland , Osama Abdelkader , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] arm64: panic from init_IRQ if IRQ handler stacks cannot be allocated Date: Thu, 26 Mar 2026 23:57:52 +0100 Message-ID: <20260326225755.50297-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" init_irq_stacks() and init_irq_scs() may fail when arch_alloc_vmap_stack or scs_alloc return NULL. Return -ENOMEM from both and call panic() once from init_IRQ(), covering per-CPU IRQ stacks and shadow IRQ stacks consistently. Signed-off-by: Osama Abdelkader --- v2: - Add return -ENOMEM from both init_irq_stacks() and init_irq_scs() - Call panic() once from init_IRQ() if either init_irq_stacks() or init_irq_scs() returns -ENOMEM --- arch/arm64/kernel/irq.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/arch/arm64/kernel/irq.c b/arch/arm64/kernel/irq.c index 15dedb385b9e..9fafd826002b 100644 --- a/arch/arm64/kernel/irq.c +++ b/arch/arm64/kernel/irq.c @@ -10,6 +10,7 @@ * Copyright (C) 2012 ARM Ltd. */ =20 +#include #include #include #include @@ -32,34 +33,43 @@ DEFINE_PER_CPU(struct nmi_ctx, nmi_contexts); =20 DEFINE_PER_CPU(unsigned long *, irq_stack_ptr); =20 - DECLARE_PER_CPU(unsigned long *, irq_shadow_call_stack_ptr); =20 #ifdef CONFIG_SHADOW_CALL_STACK DEFINE_PER_CPU(unsigned long *, irq_shadow_call_stack_ptr); #endif =20 -static void init_irq_scs(void) +static int __init init_irq_scs(void) { int cpu; + void *s; =20 if (!scs_is_enabled()) - return; + return 0; + + for_each_possible_cpu(cpu) { + s =3D scs_alloc(early_cpu_to_node(cpu)); + if (!s) + return -ENOMEM; + per_cpu(irq_shadow_call_stack_ptr, cpu) =3D s; + } =20 - for_each_possible_cpu(cpu) - per_cpu(irq_shadow_call_stack_ptr, cpu) =3D - scs_alloc(early_cpu_to_node(cpu)); + return 0; } =20 -static void __init init_irq_stacks(void) +static int __init init_irq_stacks(void) { int cpu; unsigned long *p; =20 for_each_possible_cpu(cpu) { p =3D arch_alloc_vmap_stack(IRQ_STACK_SIZE, early_cpu_to_node(cpu)); + if (!p) + return -ENOMEM; per_cpu(irq_stack_ptr, cpu) =3D p; } + + return 0; } =20 #ifdef CONFIG_SOFTIRQ_ON_OWN_STACK @@ -109,8 +119,9 @@ int __init set_handle_fiq(void (*handle_fiq)(struct pt_= regs *)) =20 void __init init_IRQ(void) { - init_irq_stacks(); - init_irq_scs(); + if (init_irq_stacks() || init_irq_scs()) + panic("Failed to allocate IRQ stack resources\n"); + irqchip_init(); =20 if (system_uses_irq_prio_masking()) { --=20 2.43.0