From nobody Thu Apr 2 20:26:42 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F7530DEB0 for ; Thu, 26 Mar 2026 21:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774560907; cv=none; b=t/KNtVbGyIja1/fw+4iKFZM8fOfZuieUpYAz/f1KTMAPAA8WB91YG/UDNrjDbOgHziYnTLZlAVhw2SEawWY2GXxRp9sWIuqmIt7oSikfj8q6+46muRTJbqVl6lTnbACDKx9GRHZUVxri8MMtf1OjERj9sIZE9WDAPQfRqYPpHyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774560907; c=relaxed/simple; bh=wsgHtGMsL0z+O6CPRZuHTu3FEglSadQqIuS8210B1hE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W9HcKfAY3G6/3XMvn1OEO5gpmluj7X7gmV4M64nasS2/14EKr8lj5CRlAzAELnurtvbjxi8MAA2xRCOw4sehMEKvdaoJIM7PyK7oEMeB6cX/hKR4uRYfLlxjP98lN5hp0H6claGBbw1BFHlW81xJ+c7qw/C3rY+eeDVYbRnNE3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lPLU4xig; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lPLU4xig" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48557c8ad47so10915845e9.0 for ; Thu, 26 Mar 2026 14:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774560903; x=1775165703; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E8VUbdY2qRvrHENEWIeYirIdqjJOGNjoUNh/2XerUPo=; b=lPLU4xiggr674XcEQtD8m2F6fBBqAB/BU8hnm9Wee8oT9taqkcuIML+NpjtNgFBTgz lD+RRT5HE0HUWo2owGnsPf72EkV+5N3hPB0DFpqqGIAWaLbZaSwPi0WeyC7dglv/OnbQ C6M4qkzoJ+PZMRjj7Q+9Kv3HPSH9r0ItM+tXwQKYzx2yLxFgYQCxWLkFAlxCZl+s3q29 ubhK0VPx7vTOgZXyJF+sZ/0kf/iaFe/7ofhvLOpPVxBIJorURk/elrFwvMEPSQKeOdUO jlbga0X3W+V6F+AJhcCVCGTI7anVWFFEx5fzavHjIB+7QktJL/skIUNB+0ultuIx5wSS +zbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774560903; x=1775165703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=E8VUbdY2qRvrHENEWIeYirIdqjJOGNjoUNh/2XerUPo=; b=SxSRHvJ3smrrGmLvPFFgkrNyMgy0N51Ezseut1bQJGK4BoDNbrstuaCLpUYa/dcXJg K8j1UrPahAycbc/kfRBS6fGQffRMca6gDTnhyDg66vO4LJfJLGxFoJKCsOX0iznbJLo9 e8kJftmxPkgp4HTKjrgnzESH2ZP7o1kE6MUP5zjx+y6wCk85aPzKTMaASSTW+ekErb45 UThcFoRVJKFwZvJrSTtA83CGsUXO0UUnM+ffvjKHvvbYQaNAYssczgq65MXTp//NYEdZ nGAQERPgfcT3fGPCnN/Y2EdFcyTwRuNCUhem8dHEYnPyogglmLKRYU4h1V1PrNQPssp2 Mkiw== X-Forwarded-Encrypted: i=1; AJvYcCUCGJbUSF3h6bwam02TwSbjpzkOk4Hj8S63UVXqdCIpylb3nNX68oUbbETdxX964rAoy3RpSFPIDzeaqVU=@vger.kernel.org X-Gm-Message-State: AOJu0YyArd0eKTw8IAtZnu2EHmKy+E0vAwFuM19Ivxq4ylt6UHKJcQdJ 6ia7D0yu+WNHEei+yiEeDqxaPjymZzrAweyXT3YZ/Z/3Q7o4x5dCNlg4 X-Gm-Gg: ATEYQzx/ldJlMP/YmGyGw9W0MgnOBai4/RtSJTIb9RjPTGhaeNpMjXK4dr0DCCsVCUs 6lE5Rk04fxjFEx+oyETdC/OTyajO6MRUC1RMMenscM2A+8Krz2lt3aUJyyo4xG+VdP6iiiEbqWi g7n37vVWd5nyvUn/38fBznwbqjK+imGhKi/d4Mcwlw1EKXJx2TtwYewVOYcOsOLiBMtIPwK6QGp cZP+r0QiPk5okXJXQ+nUR0qrU5MZLPeXFZ6q8R5NXtLrOapzoMYVBiI1DNQCcq8l5eaKItfP63z MAtg4pz12gkTvITb8i4ICUzPupSRzi6+t/mpNEjXdtiSYw5G4RVs1N6Cj2iyTHldkF7I4Ydi6Sh aQZgNytRe6a6wiAQjgmOBi1T3wgmPk9+lZpl/LTDrFR5LD8tejxYghR9MjW/qk7JL/LhDXRP1py CUO2cnNb5g+183h5SN5gfRmsP+kRt7oCGwYlyFNeAU1bKjGg== X-Received: by 2002:a05:600c:4ed3:b0:487:2b7:18d1 with SMTP id 5b1f17b1804b1-48727f0eb50mr3476355e9.33.1774560902310; Thu, 26 Mar 2026 14:35:02 -0700 (PDT) Received: from localhost.localdomain ([2a00:f41:1855:4ab5:5c9b:17ff:fe26:9b2c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722c7cec3sm51106825e9.6.2026.03.26.14.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 14:35:02 -0700 (PDT) From: "Jose A. Perez de Azpillaga" To: linux-staging@lists.linux.dev Cc: Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Kees Cook , Kate Hsuan , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] staging: media: atomisp: fix loop shadowing in ia_css_stream_destroy() Date: Thu, 26 Mar 2026 22:34:07 +0100 Message-ID: <20260326213442.876745-2-azpijr@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326213442.876745-1-azpijr@gmail.com> References: <20260326213442.876745-1-azpijr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The nested loop inside the IS_ISP2401 block incorrectly uses the same variable 'i' as the outer loop. This shadows the outer loop variable and causes premature termination or skipped array elements. Change the inner loop to use a new variable 'j' to prevent this. Fixes: 113401c67386 ("media: atomisp: sh_css: Removed #ifdef ISP2401 to mak= e code generic") Signed-off-by: Jose A. Perez de Azpillaga --- drivers/staging/media/atomisp/pci/sh_css.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/m= edia/atomisp/pci/sh_css.c index 6cda5925fa45..8d8b82dc59f1 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -8192,7 +8192,7 @@ ia_css_stream_create(const struct ia_css_stream_confi= g *stream_config, int ia_css_stream_destroy(struct ia_css_stream *stream) { - int i; + int i, j; int err =3D 0; =20 IA_CSS_ENTER_PRIVATE("stream =3D %p", stream); @@ -8223,10 +8223,10 @@ ia_css_stream_destroy(struct ia_css_stream *stream) sp_pipeline_input_terminal =3D &sh_css_sp_group.pipe_io[sp_thread_id].input; =20 - for (i =3D 0; i < IA_CSS_STREAM_MAX_ISYS_STREAM_PER_CH; i++) { + for (j =3D 0; j < IA_CSS_STREAM_MAX_ISYS_STREAM_PER_CH; j++) { ia_css_isys_stream_h isys_stream =3D - &sp_pipeline_input_terminal->context.virtual_input_system_stream[i]; - if (stream->config.isys_config[i].valid && isys_stream->valid) + &sp_pipeline_input_terminal->context.virtual_input_system_stream[j]; + if (stream->config.isys_config[j].valid && isys_stream->valid) ia_css_isys_stream_destroy(isys_stream); } } --=20 2.53.0