From nobody Thu Apr 2 20:20:42 2026 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8B5C3A7F72 for ; Thu, 26 Mar 2026 18:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551326; cv=none; b=mwxV3GXnVujkGsTYf1tyMizPyjO/Sb7xT491O3YekmhJn7Z9x4Xuk4FQGDNudQruKszt6VlQ8zicFGRjArvxx2OrbLtubkc4kgRJlsUwsndQOG7OMNnQYC2/Kvf4xi6U9O6gOvlZunvpKQWIVXWsLAtOTcJUF1VSyXBBZp+IwU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551326; c=relaxed/simple; bh=g/R4mNpoNQFynh3xzppOxNaEKQ8esIfVn/96Jwzn8vA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aCOEc/MttiFmAyv/DJOJLpbJpqk8trz07cKpLgZkCobmw0krh5XibSC/9x/n19/zWFYwPUktsLn2ndULsItqxZeBW+6cZh0yK47mYxmc9IMpJT8Lc1q42y9UDIoNbxUDRcJTzVv30xPVavroUTpnrTurlrhpEUGHdVnwXTmQwS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EDipy9Np; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EDipy9Np" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-40f1ffba6a0so828773fac.0 for ; Thu, 26 Mar 2026 11:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774551323; x=1775156123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PHBDIqz9/qVForB86mGxoTdQjucG23eTecUbThbELwQ=; b=EDipy9NpyGleghqv+pdHtOsMEl3wjBPR5DlwReJU7GBDszL2bRjZCqbyk3JlfWV7jW Gt53zwsKpeRB2LHK3se0H6B511HGo4QK5aFyR0Dedf3Ihm8p1VsFlHcHMWWbgiD2Ztl2 UhDdUeaWL07RuhDIZszh7QzL6+TCVc1Fe+eVnlUcZSks65IgSbV2Wbt8JWsZkpsJoHRX xTuXMoIqAS1RlK9Gn//i0giLOkt/is3rTlemvAGzrsZMGJA7ofqe85Pfsb4JBzxa/AEh cJlNikwwJjbNSCU28JGULGWSxehTEVZdDL4cvwk/h/DEplladR+GKCWU67b0ZNoga09b d4IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774551323; x=1775156123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PHBDIqz9/qVForB86mGxoTdQjucG23eTecUbThbELwQ=; b=he5iw2DjBmXgjsBjEsOjdm8+CQfcgzLuxcJqE575ZcU6A1GXmOimd0fji3z00xPv7T ZVw4aAl4ilgG+7NLFXNVhv4f4WghyJt4HSQndeGlrhlH4vNISi765j/UxhF9pOoT5BRn /gVg3u87fEhf4Cio/zCCNg/Zgc2WljabBlIWVWSa4rLs4bXPNSqdGrbMMJlO4w/Bat0s gybS4RbxkNycMXqN6WghbfkVZkVD+jcSwQ5cf8fVEJ7umJQBk+oY2A3op/XOub8/8APQ PRORrmapQo4tj8uIlmWkuvbNA+kaaRf0nB8U1H38B/SqaPy+uf2prnE1kyHekZk3EHBK bt2Q== X-Gm-Message-State: AOJu0Yz4kCIoos8w+ZeMJ5Bx6QdoXNmamBPVsKcHY2Ut+U2Dnd8gJ9bY 1pB57II1oybMfWqqUQGJ48tQJtI8qI/uh+vHh1yGTpKmuA44m7YLrmQ0crjOwA== X-Gm-Gg: ATEYQzzaTe0kVtS4nuJa+xLCg4+3BUSIOWaRaflSqjP/qo8VWjX5hpMES/FJz0qPbij VDxmYxsX0mzjDbCPkpPXgUm6pQMMIBota+gMVj+rj+p7NpqamqcLuO7pmWHrMKten4fwMAk8YmO Cm72KlykcNehyp0ufaMjfbSJFxVsYWS0L2oN1qq4NPKu41m+wuktSszVVc65dexygvcsuiNElCm 360f28PRKVdAYKTB9uxi0xOC1nckSGsAnAjlRpJG9YBmjnWxqAACcjiLfxqnVE5nu6WCRMMuUn9 esEY3JUBTUi9h3j3fhoTtGwjv+66trIYAuFGx3+R7iGVZOYf9q9LpoVfWxYHGJNrndSh1C8D0Kx 53Jf9C3fvfOJb7ipt9viC3W4o10OPImh5AvkdlejZym6FZy4h+EeqBxVhlJq4hlt0hiiJeo3d2Z uy0DVIa8Yze/rKqFgw8o278gDr07nF5EP1X/EZm+HlgSm0P8Ey X-Received: by 2002:a05:6871:520d:b0:417:5970:28ea with SMTP id 586e51a60fabf-41ca715a2acmr4330662fac.51.1774551323554; Thu, 26 Mar 2026 11:55:23 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-41cc7760c08sm3075171fac.4.2026.03.26.11.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 11:55:23 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org Cc: jim.cromie@gmail.com, mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Philipp Hahn Subject: [PATCH v12 36/69] dyndbg: Ignore additional arguments from pr_fmt Date: Thu, 26 Mar 2026 12:53:40 -0600 Message-ID: <20260326185413.1205870-37-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326185413.1205870-1-jim.cromie@gmail.com> References: <20260326185413.1205870-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Philipp Hahn pr_fmt can be used to add a common prefix to any output from a module: #define pr_fmt(fmt) KBUILD_MODNAME ".%s " fmt, __func__ But adding additional arguments breaks dynamic debug: > error: macro "DEFINE_DYNAMIC_DEBUG_METADATA_CLS" passed 4 arguments, but = takes just 3 > | pr_debug_ratelimited("%s", "Hello world!"); > | ^ > note: macro "DEFINE_DYNAMIC_DEBUG_METADATA_CLS" defined here > | #define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \ > | > error: =E2=80=98DEFINE_DYNAMIC_DEBUG_METADATA_CLS=E2=80=99 undeclared (fi= rst use in this function) > | DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, _DPRINTK_CLASS_DFLT, fm= t) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > note: in expansion of macro =E2=80=98DEFINE_DYNAMIC_DEBUG_METADATA=E2=80= =99 > | DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, pr_fmt(fmt)); = \ > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > note: in expansion of macro =E2=80=98pr_debug_ratelimited=E2=80=99 > | pr_debug_ratelimited("%s", "Hello world!"); > | ^~~~~~~~~~~~~~~~~~~~ Add an additional ', ...' to DEFINE_DYNAMIC_DEBUG_METADATA_CLS to slurp any additional argument, which `pr_fmt` might add. Signed-off-by: Philipp Hahn [pr_fmt change on _submod] Reviewed-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/test_dynamic_debug.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 1b401f398a3c..49f37d6a4eab 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -344,7 +344,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor, dump_stack(); \ } =20 -#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt) \ +#define DEFINE_DYNAMIC_DEBUG_METADATA_CLS(name, cls, fmt, ...) \ static struct _ddebug __aligned(8) \ __section("__dyndbg_descriptors") name =3D { \ .modname =3D KBUILD_MODNAME, \ diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c index db555f5f8ea4..779309898422 100644 --- a/lib/test_dynamic_debug.c +++ b/lib/test_dynamic_debug.c @@ -23,7 +23,7 @@ * the usage clearer. */ #if defined(TEST_DYNAMIC_DEBUG_SUBMOD) - #define pr_fmt(fmt) "test_dd_submod: " fmt + #define pr_fmt(fmt) "test_dd_submod: %s " fmt, __func__ #else #define pr_fmt(fmt) "test_dd: " fmt #endif @@ -214,7 +214,7 @@ static int __init test_dynamic_debug_init(void) =20 static void __exit test_dynamic_debug_exit(void) { - pr_debug("exited\n"); + pr_debug_ratelimited("exited\n"); } =20 module_init(test_dynamic_debug_init); --=20 2.53.0