From nobody Thu Apr 2 20:20:44 2026 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8257A3A6EE1 for ; Thu, 26 Mar 2026 18:54:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551296; cv=none; b=k/2CPBvM4D8O0Y7wavtzWgbYXt+XbbnKHn9IEJBltWSUSj3yPlAJcu+G0gCIUSIc4n1b4oToXkHCh3y44t42EL5tq9KMCFPhTNdSY7EfRV2P8LKseERtXh3B21AnPU0yYsCblgZCXMSwVXMORGDWIb/rFOhORzraQKbC2POVObg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551296; c=relaxed/simple; bh=PBAFi7y3YRuwq9TlfBtroorgB24BQAwGr2rvA4abp3A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OHen1COIXftWQGUOahmRJuBUr6lKIj9f1I9t6Fz4C3drXv2lMxQbbvpk5VJYaXyehMzSIjACImjE8yLt158MhlXSVpj59YAiaVIcepKZ1q+Zd0AueTbiWqh7ssOF2Y3MfyuZxyVaY1kBajmbtYCHvwoNmf0fCD5b6uZ4PK1fAL8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PcPUiRc2; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PcPUiRc2" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-66f3e7d9eccso778806eaf.1 for ; Thu, 26 Mar 2026 11:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774551294; x=1775156094; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lr3BXrtiuAvHSgc8/DPsjTxu/hA/+WXgrNkg64S657g=; b=PcPUiRc2aXV+PakgqCE14BtsaG/gVKVDzpYEXnVoPuWZNpbPz7tnVMixBJcaEK6sbD HyGKVCEpGaUSCKAKIm+ucvhncPFY0FqsGt/z13JpNQwCLH7MOTwWR+8RKwgf9U/5SQ+m i27rh+npiU4ps2t8w+yXpdmydX2atI8yChPhoscM6Zf0mJGEJqJod9bKXMjiwcnPeSRg +xUv2fBb2jbML7pVrBTwyAehOrRdYsSCjM9KrrGVgXn8vuIU9K6y+lXaXZSgIWJjxz54 SykzjjBhlWM5E2pJ3CBwPODdISTOiVcoxubcxiipabBveTkgjnG/Bj/anAyL8fYHeW0f lbBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774551294; x=1775156094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Lr3BXrtiuAvHSgc8/DPsjTxu/hA/+WXgrNkg64S657g=; b=cq2fRrL/kzqdeGVgvIKW7x8wawr3vXRT5yQL5OWUpOTHRB4MvzY2N4NaAaexNPTnrB H2HcS93Ub0qswBiJqc+x3Rv9+dn48YeLQtJuuUmjRfm6S2M6ga/ZXC1Q4FWIb6ECAWwJ 0vwmvQ0YgwwMKtTvHb6FMj0o+15c7Apz5rdX/0BwNyhoNTxy72jLA1JsrF0mYu15jjrN Qoe+bNZSy3fvFZNx9XT4eWlep1ZdcpOZNaq/lAcLTp6V1/9HQJnL+k7ZJA6W/g68uaGS QCxbJ8MoH+zvi6O7ss8TGCBdNR66QyOBQ4E1R34N4v0Sa2xL722jCH1UiPjTnRiC/yqZ 8tJg== X-Gm-Message-State: AOJu0Yzb4iimHLmuXmY7b3UyDJb9uS+SYTRZo+Vsy15tmngzWPO0wMmb 08FVeY93lb6Fw975aKdGuIPxzAcB07NJYNKecuWgXpsHEzCieSLKOx5GjHyEGg== X-Gm-Gg: ATEYQzyQoxwib4wgi0B8Foq2tvR4quuwK5s7tPUegfwatYJnkP7jSGIdsdjcylnbAi7 +olNslihT1QkRMTr6t+zothNIqqgYb9srDm1BQH6OJ230lGQLdpxMHpcgUF9NMgZGgdTmHcOnYX Pu2pBgd7m7hZv440NX0aVgW2yPkpN4rdyhxA0sb1v7D6/IJCoydJkAzpH+1dTdgHz+eO26Njxbs ftMtXSWTFZPJbqqqONYSqVvcS5TVOKETqGQhV0nrXOrvOYNLyUgv2NbJ2uH2IOImXproN+HnbQ8 uuPmSovnG+0w/7c6KfNkunem+czn8oVqXlHc4c/sXHm+UU9ofb3qP6ISCQwayecLXKM7lgmpr9Q SWkq9p2CjyXgGYAkXoHrnVKC4OHYZo9Wu5CJ4YVhH99nnGWvnO3pLMkKdlpPpZxXbeq3ArmfQdK OLGWVojiG3AytoFffUIPzTYi7RsEo90gDcJTARF2QON9009FSV+WJ6kmeylTI= X-Received: by 2002:a05:6820:210c:b0:67c:1d90:3949 with SMTP id 006d021491bc7-67dff4fc06dmr4216223eaf.48.1774551294126; Thu, 26 Mar 2026 11:54:54 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-41cc7760c08sm3075171fac.4.2026.03.26.11.54.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 11:54:53 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org Cc: jim.cromie@gmail.com, mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v12 16/69] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Date: Thu, 26 Mar 2026 12:53:20 -0600 Message-ID: <20260326185413.1205870-17-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326185413.1205870-1-jim.cromie@gmail.com> References: <20260326185413.1205870-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 4313c8803007..a18f4bc63473 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -607,7 +607,8 @@ static int ddebug_exec_queries(char *query, const char = *modname) =20 /* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits, + const unsigned long *new_bits, + const unsigned long old_bits, const char *query_modname) { #define QUERY_SIZE 128 @@ -616,12 +617,12 @@ static int ddebug_apply_class_bitmap(const struct dde= bug_class_param *dcp, int matches =3D 0; int bi, ct; =20 - if (*new_bits !=3D *old_bits) + if (*new_bits !=3D old_bits) v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); =20 for (bi =3D 0; bi < map->length; bi++) { - if (test_bit(bi, new_bits) =3D=3D test_bit(bi, old_bits)) + if (test_bit(bi, new_bits) =3D=3D test_bit(bi, &old_bits)) continue; =20 snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], @@ -633,9 +634,9 @@ static int ddebug_apply_class_bitmap(const struct ddebu= g_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - if (*new_bits !=3D *old_bits) + if (*new_bits !=3D old_bits) v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); =20 return matches; } @@ -691,7 +692,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa continue; } curr_bits ^=3D BIT(cls_id); - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits, NULL); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, *dcp->bits, NULL); *dcp->bits =3D curr_bits; v2pr_info("%s: changed bit %d:%s\n", KP_NAME(kp), cls_id, map->class_names[cls_id]); @@ -701,7 +702,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); curr_bits =3D CLASSMAP_BITMASK(cls_id + (wanted ? 1 : 0 )); =20 - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits, NULL); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, old_bits, NULL); *dcp->lvl =3D (cls_id + (wanted ? 1 : 0)); v2pr_info("%s: changed bit-%d: \"%s\" %lx->%lx\n", KP_NAME(kp), cls_id, map->class_names[cls_id], old_bits, curr_bits); @@ -755,7 +756,7 @@ static int param_set_dyndbg_module_classes(const char *= instr, inrep &=3D CLASSMAP_BITMASK(map->length); } v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, mod_name); + totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, *dcp->bits, mod_name); *dcp->bits =3D inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -768,7 +769,7 @@ static int param_set_dyndbg_module_classes(const char *= instr, old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); new_bits =3D CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name= ); + totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name); *dcp->lvl =3D inrep; break; default: --=20 2.53.0