From nobody Thu Apr 2 20:20:43 2026 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A57DD3AA50E for ; Thu, 26 Mar 2026 18:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551294; cv=none; b=lUeMcS68VYKsK3GG9l7g5U65/8AG66/LCbWJ0DdQyN9DVFAAZH0d42/lomNkJs/Nos6Y4G/l1O0u5c+M/82hiWn/fnxKcXz/5x0BlHnukrTA3agQs/1K4L/JILenhp4vlVCoh8prLk0cAvCGH+V5q/AN6kMRoCz6gKmuMMIUqyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551294; c=relaxed/simple; bh=S6gUrn6AElwN551VfXZR8sAzEWfpnwUQMkcCkNtZGhE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VR3W6oOpKN7/juefeooElgHZNSOqpU3X12GeBwUlTAiNbP1SRluJ6iPCPHr3pbY91r3EVCoiaZvRqxHvcL6u/+Jn5uIZwvNtKciiMMiOmRO20sbiCooUpqLAm0Z6TEYPS3kOTuWWDMA0gOeeyvQUpr5nyPLSyrR8qofOwXwAuLQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eGA7D/nq; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eGA7D/nq" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-4043b909ed4so844140fac.3 for ; Thu, 26 Mar 2026 11:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774551291; x=1775156091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sNdSdlXltBKavjCpq8HaVo39jGQFAT2gyMj0g9RRu6w=; b=eGA7D/nqr0yFBSOYMlcL+Oq8QMo41opDt0KKp7XBPrqtYwYdB8M8/OBz4QehMJJcLs paQO3GnItCCSwWvJ/XiXzLNv/hZ+NeYb5hRXfmYQN5uTiKRvoYUiuwUZnv/HQBqaN5G2 ajmvQFBcpAbrzH2+juFveoLLRdZbVGyD5vvws/DW+kbXWwIJJAuxE9RdhjgiY/kh1ypM mIVTjkXYeLwtM95xy1srdELROAYHhgu5g1WDbIzA/Nk3aWJZWpnSN2iDEjloxDMqW7IU UTidjru2ru8xjft1IYZloYNXhgdTGNI/QgClBv+cXuhURu0gETEo0xlPTtixFAl1UMJo 1ibQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774551291; x=1775156091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sNdSdlXltBKavjCpq8HaVo39jGQFAT2gyMj0g9RRu6w=; b=DqQCcpp55vWgtPZusStONb3PG/13nX1XqHVJxiWwWAdGM+HHuORWsdjJoBv5CjHAQL GZeDyCtJP8/Wl9WWB+Y6Hm8QZV1ecNnPCsNnAv82mkt8fQCpI+VWgsrYLfkGAb5fXNHb xLbb0TB1+Ci8SEQLgC70NNG4uv4Ffnuc0+5ycgu0TSigwRTS/MDH5mcZmADC5fTWRbz/ FGANm1g3zX6U5FyVZUebmaQUbGqEuoPiW+yHcBMj3SVgeSthVNNsIEQok3AyLwSvLu1K kb/XBsMw7G+O/TzC4LMkc4QFvQLfpBr7CFMg6O/gTknxnEUmLHZaNb29dshTC92wN8WW ofQA== X-Gm-Message-State: AOJu0YwE26qbtPuq6cfKTebVsAYNQac5hHSb5R9/SKa4U/nyLTGMKnxn 8sTXxJT9c2DvMwDhInRhkHUACBW+ZrcsO46X20yLoVkIS+Oo6mKBZp0SQBKx8A== X-Gm-Gg: ATEYQzwnIpkeV+mb7YvxvMm7BuS1bYNLCbHUQruMZwW6vA/do9nbskzV5PUG25R1fQi +RC+CDN5nypyynoPHi3Bdgk5A3t8Rtq6y9qLXAy0XsYo6bzOKMkDCrITXX6Acc5oQBC/U697AoZ L5KOiOfYanZGaWP69PfQFUY2ghtkcWRx5F7IbPDxy1EUJljrItyarOlzXtlYamp8wA8m31xaMXR VYY0ffetK28vObsRI4WD1/e6pJ82aEbErnIbYkcRWFDoOOeEa/DnRdz5ygVDgwFWlR/BdkffcnP PyjovuXVJXAiY9gRfzW08lp8ISQ3ksDomRcGfbhnPbMEcuZA1WtBkIMSmttuW9eUUPt1Cn5Vg15 R1/eDkhBUBOpNBbEYkJ7kmIu1WQ6QT6GKfmEFY1XnLj5u5gPrOS0AvfpsHiNTt/5wqz4e8iwDAK fl87WxZ5aY9/eNBOP0ODJSg9NxNU5FUhUwVz6zxUAVRFtKCxWnZo/TvrcHl44= X-Received: by 2002:a05:6871:520d:b0:41c:47b7:1f24 with SMTP id 586e51a60fabf-41ca6e37d7cmr4505067fac.21.1774551291322; Thu, 26 Mar 2026 11:54:51 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-41cc7760c08sm3075171fac.4.2026.03.26.11.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 11:54:50 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org Cc: jim.cromie@gmail.com, mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v12 14/69] dyndbg: reduce verbose/debug clutter Date: Thu, 26 Mar 2026 12:53:18 -0600 Message-ID: <20260326185413.1205870-15-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326185413.1205870-1-jim.cromie@gmail.com> References: <20260326185413.1205870-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" currently, for verbose=3D3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' dyndbg: flags=3D0x1 dyndbg: *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: parsed: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0 c= lass=3D... dyndbg: no matches for query dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' flags=3D0x1 *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs Also reduce verbose=3D3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 9575b92a8deb..3ae9ecabdad1 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -276,9 +276,6 @@ static int ddebug_change(const struct ddebug_query *que= ry, } mutex_unlock(&ddebug_lock); =20 - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } =20 @@ -511,7 +508,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op=3D'%c'\n", op); =20 for (; *str ; ++str) { for (i =3D ARRAY_SIZE(opt_array) - 1; i >=3D 0; i--) { @@ -525,7 +521,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=3D0x%x\n", modifiers->flags); =20 /* calculate final flags, mask based upon op */ switch (op) { @@ -541,7 +536,7 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) modifiers->flags =3D 0; break; } - v3pr_info("*flagsp=3D0x%x *maskp=3D0x%x\n", modifiers->flags, modifiers->= mask); + v3pr_info("op=3D'%c' flags=3D0x%x maskp=3D0x%x\n", op, modifiers->flags, = modifiers->mask); =20 return 0; } @@ -551,7 +546,7 @@ static int ddebug_exec_query(char *query_string, const = char *modname) struct flag_settings modifiers =3D {}; struct ddebug_query query =3D {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; =20 nwords =3D ddebug_tokenize(query_string, words, MAXWORDS); @@ -569,10 +564,7 @@ static int ddebug_exec_query(char *query_string, const= char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound =3D ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } =20 /* handle multiple queries in query string, continue on error, return @@ -1246,11 +1238,10 @@ static int ddebug_add_module(struct _ddebug_info *d= i, const char *modname) { struct ddebug_table *dt; =20 - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); =20 dt =3D kzalloc_obj(*dt); if (dt =3D=3D NULL) { --=20 2.53.0