From nobody Thu Apr 2 20:20:43 2026 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B8F3A7F6E for ; Thu, 26 Mar 2026 18:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551289; cv=none; b=YNsktPHr29wtL3X7HfkZoAd6fM6twOp/cV6hzn+cQlBL/II0LYeLYuTpdgpy1hieC7ntnM5D7y2XhL+E4+nMCzbsxQ+jYyUtJ6aX9xsYW3hjSPfvKVxHchXaxK419TF19fb7HNpeQuPDlW60Yq8BjICtzFjbhbToLGif3lvSus8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551289; c=relaxed/simple; bh=nT2X+0ltTDZpc2Ke/Nts5WB2aC9+0FZsv4JIXPNa2T0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DX8w4QwCsxACEMNbe7cwKSmj/ii2gT6/hVgnC4BJI0i6adX2zKCD9Mnq015SXHL/t9CsrFa1+RtoM/qPORNE45flqsbz+2o5mWv8UdElReMUdvYGYQouBbMVyR5eAKvUmNXGrfxnC8rx4qfJ5SfFUR2eTWvOUVV6Z7walP+tBsg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XKB1zx2k; arc=none smtp.client-ip=209.85.160.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XKB1zx2k" Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-41576c5c01cso890807fac.3 for ; Thu, 26 Mar 2026 11:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774551286; x=1775156086; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6DJe7q9AzKIA5JE9j9dS7BkLMe6yLjsp/ulkOtgleYM=; b=XKB1zx2kMPW93WrVNtCmYH0d9eWAcywiqswqOIt1bluU8LLOdeX0FBGYEuhbW+V9CY 0TznFWvKaoNHxJBwBanzM77p53DCwzilH6t8IAQQde+NfGAp4yLy239cueRQJ8YxX8m+ Em683GqOI7d+sMGT7355tct6drmoFWKg3TpCRY6TpwxkbOOCzIWj9LenknW0lI8WAXSa A77fqaX2IHMVqGOzu1bR7r1SuSSlsnNvOEdzUZte0W9wVhkwlDAdw0K94ACNs53TkrRd Xy8SbgrS1HkYQ40vjfiEBVJz82HuTTgLxxGLTVeVtT5iWm+as2oWZiUXY9WYu+pw9EmA SHxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774551286; x=1775156086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6DJe7q9AzKIA5JE9j9dS7BkLMe6yLjsp/ulkOtgleYM=; b=LYWbEoY5w752SyfVTDRujs1T6rY1PyTtYmRCIGXksjeRtEPvyEE63PpHV7MQ10z6Or wIrlOu4CMTNx2uwRiQ8uytlzJEbsILQmb05koDa4CARr2uDspau4904B4NorRXjGbBDw tc6lAEaXHzMkrVezQLzbzUQFzsJALt/4f6yAHSwQ7ZtJjN6QyzgzWXhxAhoQUWeSK6y/ Asf8ne8tibqYOY13T3UNE5Tn7xC9B9WdbaMwSgoVaiKYvOgBg3YUqWHwFXTyguEIbbHl 4ad6sU/vVQXytHZ4vVX8fmoXzNM/OdM2GnUqE7LUceDYcyI/I2IBT9+6+cH9uUP6rWSC DeWA== X-Gm-Message-State: AOJu0YznnziYSMbkkLqM3k8deleYC69t8s6HLLHd6ooFkFJuCpkw63it +ml4JiSZEVZNOI+yob5RwLCmuPxl02sFanOJXpEgWYGDkSr+kGvMKoRA3lbotg== X-Gm-Gg: ATEYQzxiclkVY7/b5sTFy05EanLQEDyvTmk+rzrwIhDRSwBLpH5lpWbKgxCRPM0mUKR cpcqgSq04ND39w7+0j8Ug1B1giWps91K88o8eZ868vPyaVHipRLLyTrUhyTbN07mETwPsNVbeVb wZvfq9edhMNlmUWjtCYp+dNDhUTCccDZwGMyviA8ry4mjncDJu8/t8l3O2n9vB4Qati7zha05pG B+zbWTS7n+FMg4yj2gVzVdqUhT1sEIRwjF6L4iT99GKm25Bmiq4zZTEOMxYY2gikkh3lduoJHY9 zHdSE+UGdPYLlmxF4GwooRh4uztAKYxeZ9GImxZ5TQMFlkhMOyX1K2uUmHkbgmTInwOmC/iNVw4 bMfkAOWmeDM0TotEU5J9lWayDcA9RnzdBXZrze3EpynExPjdmbRniWiDWIJ7dwchBVnSl0R5DtV MV2OLzdzYj77WWyZfjleVI8Zm8LrRKJD8ZXoK/Lkq4OXXR5AFf X-Received: by 2002:a05:6870:458c:b0:417:4c0a:1ff4 with SMTP id 586e51a60fabf-41ca6d15f6amr4828699fac.10.1774551286631; Thu, 26 Mar 2026 11:54:46 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-41cc7760c08sm3075171fac.4.2026.03.26.11.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 11:54:45 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org Cc: jim.cromie@gmail.com, mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v12 11/69] dyndbg: make ddebug_class_param union members same size Date: Thu, 26 Mar 2026 12:53:15 -0600 Message-ID: <20260326185413.1205870-12-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326185413.1205870-1-jim.cromie@gmail.com> References: <20260326185413.1205870-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index a10adac8e8f0..441305277914 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -104,7 +104,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index a9caf84ddb22..ffa1cf7c2c72 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -811,7 +811,7 @@ int param_get_dyndbg_classes(char *buffer, const struct= kernel_param *kp) =20 case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } --=20 2.53.0