From nobody Thu Apr 2 20:20:46 2026 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C4703A759F for ; Thu, 26 Mar 2026 18:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551285; cv=none; b=eCRJ9vIWDhOT5jAuowBa2D45agHkA2o8cNqxblanl/rn4ahDyNukVyc2sdS07spluN8TsTq5H3p2F28vfIXf9LVYanEGB6P6ak748dCY8ItfthAjciFKvunuh32CM+N15z8GOzavpOW9qEm6t8Jyka5AkH9sqgsrmbah0VguUsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774551285; c=relaxed/simple; bh=6qEnUlc0QW37ApD+4VV5gg8sRlLcSuU7c6UrMPZMZns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KDFEhxStfM8sY2OfIiqSV5mkKrZzIwQtr419VtWjs6FooeVLDbTiVswG3D8O/2HYZqEkYEnaWbtKUOHPzMzG4goE1MHol3ffD1WN47HS5sXHypEWxGg4Fw/XLUQrh94uUIQrhUGCZKcfdUHCSMYl0DfFdtyqps7KEL7NIhTrBN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G4okRFer; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G4okRFer" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-41c0aae84e5so969916fac.3 for ; Thu, 26 Mar 2026 11:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774551283; x=1775156083; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R/SjSwC+RMF8YRDI51sil3K6xHtCNjZlX0uljPPVd8o=; b=G4okRFerHQlKToG4DisDiM+MjCdMEvFtbaehJRmTfjomCAcjKMGXtKwpuXv6xlygIH X2rcoqpFJt/TycUBG0HAq9etVktPDwTo6K3Yqx0+9u7w9w+I7MCrxenHAcAnTJZ39M/c HX/AY48HHNgHrb+j8ZvNrJej7lzNDvD2MiyDiocbW1xoej3Ds/6JFJM9meSxJEsACYgQ 0nu4pgvf4i7orPsdHPrphxzBWyz2AFiJUt6seiZRYASAwddQBkw8OuCyfPMSTysEFeJ9 L8nV9Z3sJXXEmaM7wr4SzIhm5PKYam8hgOAJ4IOt5+BNuZnxTIfXnVt1iizhbEONzI6F UB/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774551283; x=1775156083; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R/SjSwC+RMF8YRDI51sil3K6xHtCNjZlX0uljPPVd8o=; b=aPfio+4hlUh/hUsud5kxxEnVRgr+Mdl0H4c4KO4t1RBqLwyryms5jy/B1Xxd2coRiV WaN/GA58XEh7mkbjL211GRCvdHvdWaMi586rg9xqQoCPI/btevcTqP9zgKZNQHohxvyA Ce3VwHIJCVbH+xQ1cff3P4tehHptcZEry+AsXcWkygZwYixdiuLF4nSRtUuD32FowqwD fFH5Gs9ySUMBeA5Wq57VrY3LxtNpBtr3xZH5GAv5YEc0P2kQd8LogrPh7CDXgQn5bpgO 2ebiFa4V4ACqbp70W9LdecCTl+Aizaa/Xnm1pj2NrGdXpQDN8murP1otyIrnWiCsdi1O 5t7w== X-Gm-Message-State: AOJu0Yz3t+vV37Cw703112BhIGAAModCuREyekrHrtPszfoXcora4FlH DRfYy6jU2X5CRzWEdpbhXteU3cZ9P99aGcfGleMWcH8+mlBo1Hb0C6vEQNQKBg== X-Gm-Gg: ATEYQzxu3Jz/dQRgaxChF8kvFkkKPGoGQrLYuDTnlHRAXIfvzcCgww+F0YhjShA66/S m4haylUrGGKALhNHggbXuOiJPjL82auI5gN4BQ8mbRSmqPatyG7FlPeM3sVT1AzhUNV3csT1Y7t eL+lyFBAD+df4pOOmhbtLmoRzRloA7N6qh+8IVF6Ug55uEnLrlxsqqaiSZ+jaNNNSP7dy3TA8Oq QwvIpiy0pHvSWj/g7KCkM50cQkS0HUshnNxNsTDzrOCB/xbbvg0Wki1Je2SxGlUeOPNyvLsANuZ z2HEvCSunMag1e4JY83jZqRFLufXPzkOX/UfU3vg44QLc18suRiDCIEDqW+CDkuXlsrZl38acqd QW5k68aE3FBmJuQvKOJJgGBTwhwEn2cNxQ4CIPBgBiaMSwVUU7oeYA8j9N3tExSXS2vZrQrjMCf eCo9dvbKuuNKDi3qLLc4Z/z9V2NsUtRFfa7u2DYqB2yT3SRFSA X-Received: by 2002:a05:6870:f28d:b0:417:c2d1:fc2b with SMTP id 586e51a60fabf-41ca6e86dcdmr4692709fac.21.1774551283268; Thu, 26 Mar 2026 11:54:43 -0700 (PDT) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-41cc7760c08sm3075171fac.4.2026.03.26.11.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 11:54:42 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, airlied@gmail.com, simona@ffwll.ch, jbaron@akamai.com, gregkh@linuxfoundation.org Cc: jim.cromie@gmail.com, mripard@kernel.org, tzimmermann@suse.de, maarten.lankhorst@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com, christian.koenig@amd.com, matthew.auld@intel.com, arunpravin.paneerselvam@amd.com, louis.chauvet@bootlin.com, skhan@linuxfoundation.org, pmladek@suse.com, ukaszb@chromium.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH v12 09/69] test-dyndbg: fixup CLASSMAP usage error Date: Thu, 26 Mar 2026 12:53:13 -0600 Message-ID: <20260326185413.1205870-10-jim.cromie@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326185413.1205870-1-jim.cromie@gmail.com> References: <20260326185413.1205870-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit 6ea3bf466ac6 ("dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes") A closer look at test_dynamic_debug.ko logging output reveals a macro usage error: lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =3Dp "LOW msg\n" c= lass:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =3Dp "MID msg\n" c= lass:HI lib/test_dynamic_debug.c:107 [test_dynamic_debug]do_cats =3D_ "HI msg\n" cl= ass unknown, _id:13 107 says: HI is unknown, and 105,106 have a LOW/MID and MID/HI skew. DECLARE_DYNDBG_CLASSMAP() _base arg must equal the enum's 1st value, in this case it was _base + 1. This leaves HI class un-selectable. NB: the macro could better validate its arguments. Reviewed-by: Louis Chauvet Tested-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/test_dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_dynamic_debug.c b/lib/test_dynamic_debug.c index 77c2a669b6af..396144cf351b 100644 --- a/lib/test_dynamic_debug.c +++ b/lib/test_dynamic_debug.c @@ -75,7 +75,7 @@ DD_SYS_WRAP(disjoint_bits, p); DD_SYS_WRAP(disjoint_bits, T); =20 /* symbolic input, independent bits */ -enum cat_disjoint_names { LOW =3D 11, MID, HI }; +enum cat_disjoint_names { LOW =3D 10, MID, HI }; DECLARE_DYNDBG_CLASSMAP(map_disjoint_names, DD_CLASS_TYPE_DISJOINT_NAMES, = 10, "LOW", "MID", "HI"); DD_SYS_WRAP(disjoint_names, p); --=20 2.53.0