From nobody Thu Apr 2 20:10:51 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 157FF423A9A for ; Thu, 26 Mar 2026 18:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774549093; cv=none; b=VRcNogVkH8GBNJrAnlTCMzUzB44+ySSHe70K3l1Fcjj5T1gg+HjnoE7SbqEQ3JyQel/wH8Th4gpG4Q0NVJTCou1UZ5gl2hr/eOI2RfoVgz8pRjQTha/ZyCM71QdFd2UB3BwuRMwEYE+Htb0pUXYIsh27lI91B6Qlw79UllAz0gQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774549093; c=relaxed/simple; bh=iqpR+ue8PSAxYdmD9sNdud7LYdT3dwh4I8hHcO4//yk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f+LHo23p9xaPNsXU6WjeUfvIkCSAM9dlhIMwomdAN4R4VZaC4SFdYEgR4POz3GvRtpbwLSF/wxckPNbJddRfR8oCG0S+A0aq2hddwyOKMrNV8/Sdov/X7zKNaqWbfWU7XbEa9C5pXA8Q+gSqVLthpniU8kTjyW5NWdXWUzrs41s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ElKZCmwe; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KrHLaaMV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ElKZCmwe"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KrHLaaMV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774549087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iMmfmDl/+uM6tnVT+23fk4z+uPIH04GvDwC4CoL1dMo=; b=ElKZCmweDtw4T9/3ClRPCDhpEkkUvV5HC0ZBSVuTjs/T+6rPGndUFVcK4CoKJnNPA34/px mMTqZs7FwkKx4nKhFsuKrYiEwXGv+BezRknP6Cmz3t3e5wgfUoITyoVJdsKxdMV8GNvIfI 7Q7Eo48QKfa37u5H/4nzjTz/PNzLsV8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-pRye-_CKPvGUsAiVJn3RpA-1; Thu, 26 Mar 2026 14:18:06 -0400 X-MC-Unique: pRye-_CKPvGUsAiVJn3RpA-1 X-Mimecast-MFC-AGG-ID: pRye-_CKPvGUsAiVJn3RpA_1774549085 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-486fcc05b20so7803325e9.3 for ; Thu, 26 Mar 2026 11:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774549084; x=1775153884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iMmfmDl/+uM6tnVT+23fk4z+uPIH04GvDwC4CoL1dMo=; b=KrHLaaMVKWZaTuPGtPlejqAT2wQeKNDk4jpcrEf+OuyyuxvWyByFRgm6DQROKCw9TB EUB8a1BdIVibqe+Trq6akvPcw1VXjkX00EuWssttY18vW0dglf41na0fD5R2jzYOpjUx XiIpaHOgnZLwr/ICB24bvMiR7J+xwaNoWd5A7tKZJWt/Vbqe924BpHI8fps6eZhu0dwf 62cuFy1BgCQ2HUQZLAZOnUfXJpIQxZZuPRHfdqYAkCKYYZhex3W8BlIXPKC0o9PhoEtA epPSgGb8z/8orSZ/lJmr2Exj8yCic5zPwWqPBjfX5WTILu/BstAXX/hMZjUW32QDhLXb VYqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774549084; x=1775153884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iMmfmDl/+uM6tnVT+23fk4z+uPIH04GvDwC4CoL1dMo=; b=ase7SBJcvG0CJOjBwCFisSS57W41fU0RVS+/u0Dt9Qq7teiFoumLfFSsdzlci+gZr9 4Uh6xJce/rdevy3NUFup7NAjfkOaC+du5IioT5gh47Ve0QdRlBAZRyyjMgqWqp8qhbmp uhsFwHdQva1YeUaaNylySINZxrMiHramKIf9/jenUFyIGPrltxJlMcN7b9Mkh1uIpf3w Eo4uP+ZQtABhtO1cCxt+ZDw0kJKLMFdmMgfCHj9ynuqMwWD8WECxH/1gUYkSSFuGAwJd hAH4Gq+X3q7aAsPg3CpC4ysVdpqM5l7xItqNrA0EGFhPjMlJq5xiq5XghLGurISotFom +pfA== X-Gm-Message-State: AOJu0Yxf6HIDoVhBB18I9dtIWDjalo0jW5F4jOXPk4s5YgvqyABLIuz6 FoN/tTmYmRvENm/WBtKaz7nVyiUIGoYhrOZFP39HOLZPk+laLkx0y3+wWGSBqT5uVDB9GOs0h9a 2vx9qOg8y6ATPNWYXWyDaFL9k4usDcdkrlUOmfNMsDtMKWoLl0Iu7g/Aj7cXDbakYyY28uxHBcz ClRADCcN5n2xDsisGDdr5eoZm2ysLBfyUOblE4JxegC+El3GJ+tA== X-Gm-Gg: ATEYQzzgexU4tJdrA0IzOtp096aL+NqgDilC2UjMQZdUBSQzg2yYNmPdCXYzaYtW6tm r/HcpIZhr1N5LUHRDJAaiLXhcT7v597mkeU18T/6husZ1ctLeiToGQi6R7CcVon/xfC9tmLjdCP 46jHm0KVu8ey1iPuSNlixbnqe9QPoN+9g0Wtv4ajG7kIVXAlh3MEGGwYdQa0Ydi4MvGKwqWAxR5 FroCYTAM8Nxbbag/JdYW3rxrvPqL7Yfkz81K2vlHAUxnasNgjOkE6Y60uWb81Q1J3WBqC51w92g KadFDdErb1CP/LD+0hP2vRktGvhoaQlSpMnyh+OINYX90d7ng+r/rTVfFBJXXKE11b9vgZrTnsy jjUenxrMlO4DW4mQeXerzQWgeXsIP0LTyyiQA9eMUKFuuBoVQiqLRkzPDjskS/xlOJPd4O+KcBC B8c6XRSVZX9Efnt5A00naVzkby X-Received: by 2002:a05:600c:3516:b0:485:3bc7:a231 with SMTP id 5b1f17b1804b1-48716084829mr139187265e9.29.1774549084391; Thu, 26 Mar 2026 11:18:04 -0700 (PDT) X-Received: by 2002:a05:600c:3516:b0:485:3bc7:a231 with SMTP id 5b1f17b1804b1-48716084829mr139186425e9.29.1774549083697; Thu, 26 Mar 2026 11:18:03 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722d2366dsm42456935e9.10.2026.03.26.11.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 11:18:01 -0700 (PDT) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Jon Kohler , Nikunj A Dadhania , Amit Shah , Sean Christopherson , Marcelo Tosatti Subject: [PATCH 14/24] KVM: nVMX: pass PFERR_USER_MASK to MMU on EPT violations Date: Thu, 26 Mar 2026 19:17:12 +0100 Message-ID: <20260326181723.218115-15-pbonzini@redhat.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326181723.218115-1-pbonzini@redhat.com> References: <20260326181723.218115-1-pbonzini@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For EPT, PFERR_USER_MASK refers not to the CPL of the guest, but to the AND of the U bits encountered while walking guest page tables; this is consistent with how MBEC differentiates between XS and XU. This is available through the "advanced vmexit information for EPT violations" feature. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx/common.h | 6 +++++- arch/x86/kvm/vmx/vmx.c | 10 ++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/vmx/common.h b/arch/x86/kvm/vmx/common.h index 40fa72f31fc7..48520fa1c8e8 100644 --- a/arch/x86/kvm/vmx/common.h +++ b/arch/x86/kvm/vmx/common.h @@ -100,9 +100,13 @@ static inline int __vmx_handle_ept_violation(struct kv= m_vcpu *vcpu, gpa_t gpa, error_code |=3D (exit_qualification & EPT_VIOLATION_PROT_USER_EXEC) ? PFERR_PRESENT_MASK : 0; =20 - if (exit_qualification & EPT_VIOLATION_GVA_IS_VALID) + if (exit_qualification & EPT_VIOLATION_GVA_IS_VALID) { error_code |=3D (exit_qualification & EPT_VIOLATION_GVA_TRANSLATED) ? PFERR_GUEST_FINAL_MASK : PFERR_GUEST_PAGE_MASK; + if ((exit_qualification & (EPT_VIOLATION_GVA_TRANSLATED|EPT_VIOLATION_GV= A_USER)) + =3D=3D (EPT_VIOLATION_GVA_TRANSLATED|EPT_VIOLATION_GVA_USER)) + error_code |=3D PFERR_USER_MASK; + } =20 if (vt_is_tdx_private_gpa(vcpu->kvm, gpa)) error_code |=3D PFERR_PRIVATE_ACCESS; diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 0c25c6865f91..65892dc6f478 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2826,6 +2826,16 @@ static int setup_vmcs_config(struct vmcs_config *vmc= s_conf, vmx_cap->vpid =3D 0; } =20 + /* + * Virtualizing MBEC requires advanced vmexit information in order to + * distinguish supervisor and user accesses. For simplicity and clarity + * disable MBEC entirely if advanced vmexit information is not available, + * this way mbec=3D1 in the kvm_intel module parameters implies availabil= ity + * to nested guests as well. + */ + if (!(vmx_cap->ept & VMX_EPT_ADVANCED_VMEXIT_INFO_BIT)) + _cpu_based_2nd_exec_control &=3D ~SECONDARY_EXEC_MODE_BASED_EPT_EXEC; + if (!cpu_has_sgx()) _cpu_based_2nd_exec_control &=3D ~SECONDARY_EXEC_ENCLS_EXITING; =20 --=20 2.53.0