From nobody Thu Apr 2 20:26:38 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BA53914EE for ; Thu, 26 Mar 2026 18:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548353; cv=none; b=IBHsg4EGHcO96LOKBtAQVmkeyD2kzmhGYLcwYWWGYnG7etPPfsi3Oz1ueybQFIZrXVnoMN5tZs4ip4D8mcP4VKaoH+VSH/Oarj0dVfK+hiacLgmNyuQY426I7eCSxmRBmSibYyjTBG8bPcl5esqmC0A6Nf9cwYcvZkeWMRN+8Rs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548353; c=relaxed/simple; bh=YeA5NTit+vRgO6O7UM7usIAyOEi9ktUs3te+RyJJPCc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fPG+5KewlOOz1oh1/KofdsamS81hyNr9qy8pb6gw/ZUMhnyRc3nxNrb+Yhvozzcl4+iNofXrQidDGYMtT83aunGuIUVkyqQXGhc5c0HImiyWhrbW9jkH9ai2v1vNqJMYRPXdSyjVCGuJHWT2cJ+LFz2jUBq28i/liW5nzfrg2u0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gUtIZ72c; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gUtIZ72c" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2b0ba3bfe16so12419555ad.1 for ; Thu, 26 Mar 2026 11:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774548349; x=1775153149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V7lW8LFGu1hdwVKAacX1pBoH1829SaNw1Lo72wdjeU4=; b=gUtIZ72chmMyqjTbKYpcVGZ6skdr4B2igol8sK977Ov5Gqj0qrD7KqCBK6LIuzAbj/ 4DzOUeu9tyCnS6ubxCrRnRYHRa1kx1UbG2jlu1QBilvJxxm0AYCuZbL9yegLOSm6htxn yS0PDMB6yUrx6MyNNq/gPHclb3ACtCyRNnR4IY0MeVpvSR3ox9ZB20J98lzyfyDosYGk P7s/ht0TOAs2W6EOl2fHNaKYbHAGY1eNVkffPfpiUoOBkAFrSS59uDOIuLhIJVCxH+iH Rt57kGHiKb+rYNFRjRW1kbsQl5e7Dc9gGSqxsWGIRySaXUPZ4epxIpXSa5sGjT4kDDJy 514Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774548349; x=1775153149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=V7lW8LFGu1hdwVKAacX1pBoH1829SaNw1Lo72wdjeU4=; b=MKozhHLDDUHdt6ccwk7fr2BPoen7UbVDDNkzFsd4znZ7qbEE0p7moUojcYZ4oQZsN9 y6oUQPDaEtH3nvWOq7mgVhLc59++xtN8NlqJbLMvToILTTu8oJvSG2d1xJOXA5Ay26G1 1TXt0HZeRsnI5Y8wCkoE7LphxC6f+oFZonO6Hvx5WMefKf/d/JmfhOdJEAAUMql6dsm8 //H45G3bZQLwD1+jU2uGFbdKCXHtCzgvyd06n1joHlZDU0/GY7OyzX4+Vw6sJtHhYICd 03AvbnS1qrpRX1VHqeLlDokDt3S84TvgnmFdBY08WFClSrLA6EJGLGBIrQTX2IClYK5v Gw1g== X-Forwarded-Encrypted: i=1; AJvYcCVlKtvGfsU52mtXkb6QyR/XN/Igqon9FglkjMd75Nio54lS619ahFFHmzZXP9gMAeJI67rTg8cerFOUvYg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf6J/KcyeeGy3+3+IAV+fcEW+OkBHtcK7mMItwXNtMX1Er6VVy fxsxWBxWi+z6J3awqgaSZ7aln2ORc73IPP/MODhtjBJjw9DNml0yxpi3 X-Gm-Gg: ATEYQzzkqc1K7vduPYxpOoqh7IswawGy88s+DGq/vqxPggJdPsm4yi828mQbHH6tp8f 9Dw0Bt9pgVgX9e0Oj88538YHNvgjGPvhd82j51aTBi3dXPp7I1YkEVc2xaVHC/bod01FZxMKdvd GS5eIQagPsfHNdbaRq/HYFTtnXbELWjgrlJNMTBteg2WuOO7ws8YXrPfGuNkf1ZUeywhT4mISGI pG3p93hbpSfmDW8riCVBSJrNF8gfBQSXPnKR9f2j2rN9mPw1jseFiy1es1oMmJB2L/tEddU+tOr iDPW/MqRmBfOKNBsGYIpJA0GMGdO5/ZkgOvWxNO76y9Aygyj4UCydna5nSbvrpwuY6WSgucIF2D PUG3J9mn5djLlLGNSBEQ+G8jquk1ZAkB3Asn47S9NGM9N1G/5VvC+fcsnMJ8wJTAyGdS+ui9mvM K2mX8kz5qa6gpGSIw9wsN2v7AFkalaI/trq9pKw5gMLAacApXvQiT317duTrOjSd3IVM2Zq6Xbm bc= X-Received: by 2002:a17:902:c950:b0:2ae:5ab4:f4c0 with SMTP id d9443c01a7336-2b0c488e16cmr25741765ad.13.1774548348811; Thu, 26 Mar 2026 11:05:48 -0700 (PDT) Received: from debian.ari ([47.30.237.79]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc7a17c5sm43823545ad.26.2026.03.26.11.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 11:05:48 -0700 (PDT) From: Archit Anant To: jic23@kernel.org, dlechner@baylibre.com Cc: lars@metafoo.de, Michael.Hennerich@analog.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Archit Anant Subject: [PATCH v6 2/4] iio: adc: ad799x: use a static buffer for scan data Date: Thu, 26 Mar 2026 23:35:27 +0530 Message-Id: <20260326180529.19154-3-architanant5@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260326180529.19154-1-architanant5@gmail.com> References: <20260326180529.19154-1-architanant5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, rx_buf is dynamically allocated using kmalloc() every time ad799x_update_scan_mode() is called. This can lead to memory leaks if the scan mask is updated multiple times. Drop the dynamic allocation and replace it with a static buffer at the end of the state structure using IIO_DECLARE_BUFFER_WITH_TS(). This eliminates the allocation overhead, prevents leaks, and removes the need for manual kfree() on driver removal. Signed-off-by: Archit Anant --- drivers/iio/adc/ad799x.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c index 9825abc9285d..7504bcf627da 100644 --- a/drivers/iio/adc/ad799x.c +++ b/drivers/iio/adc/ad799x.c @@ -39,6 +39,7 @@ #include =20 #define AD799X_CHANNEL_SHIFT 4 +#define AD799X_MAX_CHANNELS 8 =20 /* * AD7991, AD7995 and AD7999 defines @@ -133,8 +134,8 @@ struct ad799x_state { unsigned int id; u16 config; =20 - u8 *rx_buf; unsigned int transfer_size; + IIO_DECLARE_BUFFER_WITH_TS(__be16, rx_buf, AD799X_MAX_CHANNELS); }; =20 static int ad799x_write_config(struct ad799x_state *st, u16 val) @@ -217,7 +218,7 @@ static irqreturn_t ad799x_trigger_handler(int irq, void= *p) } =20 b_sent =3D i2c_smbus_read_i2c_block_data(st->client, - cmd, st->transfer_size, st->rx_buf); + cmd, st->transfer_size, (u8 *)st->rx_buf); if (b_sent < 0) goto out; =20 @@ -234,11 +235,6 @@ static int ad799x_update_scan_mode(struct iio_dev *ind= io_dev, { struct ad799x_state *st =3D iio_priv(indio_dev); =20 - kfree(st->rx_buf); - st->rx_buf =3D kmalloc(indio_dev->scan_bytes, GFP_KERNEL); - if (!st->rx_buf) - return -ENOMEM; - st->transfer_size =3D bitmap_weight(scan_mask, iio_get_masklength(indio_dev)) * 2; =20 @@ -896,7 +892,6 @@ static void ad799x_remove(struct i2c_client *client) if (st->vref) regulator_disable(st->vref); regulator_disable(st->reg); - kfree(st->rx_buf); } =20 static int ad799x_suspend(struct device *dev) --=20 2.39.5