From nobody Thu Apr 2 18:53:29 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7178237D113 for ; Thu, 26 Mar 2026 18:05:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548310; cv=none; b=Y/nBfFL/OJKnyk3JCsIGPhkKgAPzDfVOWxepSyR0XS0lay1GUU+CXAtXMxFVVbM5QO0X6Ec+hOvE8MAmSrhEX3NAV6mqtns+IqCIHxzhspRD5oUlhrzFfVHjag7WMOX79iLUtwKrhGAA4ek5iiE8ZT0R3McDCeZ1TSvFK9M4svw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774548310; c=relaxed/simple; bh=ZsjqaDaklkgd8rMD1DRxJIEhBBzsboiL/LsoVwSpXfo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iVqaEnm7v8jlMFvQ1KqysJG1nmxNLHnKf8VkGna1qJAHj/c8rem+rPyuy6/nPCUfqTGfSoQ3DT4W76K64IzgGEfEgWkMyzHPtNTu9aspQueEbMvVLoDQ4zpySON38/Qh34gPhrJZ5nmyyJx4z9DrG/1TEPK2Fe0KxgI05ZqwHo8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NxfQrGj6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NxfQrGj6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B88C116C6; Thu, 26 Mar 2026 18:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774548310; bh=ZsjqaDaklkgd8rMD1DRxJIEhBBzsboiL/LsoVwSpXfo=; h=From:To:Cc:Subject:Date:From; b=NxfQrGj6wOpkGmHMwcdW8zHF+UMXhZAAKWJcvSheAh6Dhel0wjc6nRw60+nQYzgxZ vhjcbkAUcnGe9HVUBfkyCNsZ5lYKerlG7oXJ5xRyrlx7sVObb6kO93NByd/4QABfpo A+kEwREEOSAxgqmp6e/6vyMqxMa1bgHrUvYooNNb4tMOebrBkScnxZlUgpjqH5Germ CICFZfhqcSnyB+fj2fimhmh9//78D6ZGsfSNu/WrDar801n5iqp6TANGRETPvQKY6l YyH7S62voxRGtu+CQralzLTRJl/L0AyFDB54TJSzklhU//wiCudsmVDsKKY2ZcKteU 7oMlIDOuVhOyw== From: Ard Biesheuvel To: linux-kernel@vger.kernel.org Cc: Ard Biesheuvel , Eric Piel , Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH] lis3lv02d: Omit IRQF_ONESHOT if no threaded handler is provided Date: Thu, 26 Mar 2026 19:04:36 +0100 Message-ID: <20260326180436.14968-2-ardb@kernel.org> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1124; i=ardb@kernel.org; h=from:subject; bh=ZsjqaDaklkgd8rMD1DRxJIEhBBzsboiL/LsoVwSpXfo=; b=owGbwMvMwCn83sBh/rljoYmMp9WSGDKPlppsSTgkfeTYordb/e99u/jzat5D/Wc2l65Mav51R vrQdyPfso6pLAzCnAyyYoosO5Vzul+7iL7TV6jMgZnDygQyhIGLUwAmctSasd77zibPw7wqvQrP 0nZWCYQZXynf2mGeVfNpotu00zH9j4IVO7a8s/vtuflc9YwXO/t99jHWh/ycu9iO/UjXyr/bhPb 6+qvlzj4z4UZ/7XVBjlmRwTPXr5q1rczP25vh4ZtH59IUvq6MBQA= X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The lis3lv02d started triggering a WARN in the IRQ code because it passes IRQF_ONESHOT to request_threaded_irq() even when thread_fn is NULL, which is an invalid combination. So set the flag only if thread_fn is non-NULL. Cc: Eric Piel Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Signed-off-by: Ard Biesheuvel --- drivers/misc/lis3lv02d/lis3lv02d.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/misc/lis3lv02d/lis3lv02d.c b/drivers/misc/lis3lv02d/li= s3lv02d.c index 9c68f8b1d5d6..21e8ad0a7444 100644 --- a/drivers/misc/lis3lv02d/lis3lv02d.c +++ b/drivers/misc/lis3lv02d/lis3lv02d.c @@ -1230,10 +1230,12 @@ int lis3lv02d_init_device(struct lis3lv02d *lis3) else thread_fn =3D NULL; =20 + if (thread_fn) + irq_flags |=3D IRQF_ONESHOT; + err =3D request_threaded_irq(lis3->irq, lis302dl_interrupt, thread_fn, - IRQF_TRIGGER_RISING | IRQF_ONESHOT | - irq_flags, + irq_flags | IRQF_TRIGGER_RISING, DRIVER_NAME, lis3); =20 if (err < 0) { --=20 2.53.0