From nobody Thu Apr 2 19:00:04 2026 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8769C3A5E63 for ; Thu, 26 Mar 2026 17:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774547868; cv=none; b=NvECgcZhITrGjEp2Kt6NvWHLo/wH4I6Fh+TZjkyelcSxUiVGsMbNYO66gNVA8VQsgoaH5R1VgbEi7IDqtLqpKiz4D6AhGgohd5NJnZlepDkm5yrDLhCMjK1JQTGoMDcmcdYOcJQ0avfzVVxTRKLcebJ8jKQs6q40U4MiyYaNUlo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774547868; c=relaxed/simple; bh=vzSR8hdQ2QitcErliYm0rJHjNJoGlNZognK+JPn3/Ug=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lgq8sZQgQ0FWjLnDvnDEsYPUaZB7FNUdcrQXeCtsVr1iHNtlXCAc/MG49RvXZ8hAWLeL0K4/7o4V8ZlLQVoH50Y8wuhaT3bYV5GCQ12qSo6J/YUG2DBKr0lbxwFQ+IRD50E1OaTtByVGYIhwxQzignzI2Avjw7/uQAQ9ufC5zPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bKuIPAJ3; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bKuIPAJ3" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-79a46ebe2beso12545207b3.2 for ; Thu, 26 Mar 2026 10:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774547862; x=1775152662; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DkV/sS5NXQeiPjlp9UyXTqzIZIBKvql5Nx/cBjkpGbc=; b=bKuIPAJ3DWAH+cPZQNUJO7Lli0M6l8wxBoxDP6V/wSi6BZl8CowXJeYf5S5CAZniHa UV7LUYiapdPjzHvtXUXD4fD5jqUhipK5TrK7pASJrkWDIBO841fOgF8aunT29OBvw9DS SEVyEtynnJdVISGzJcxAcND0t7G44LhUWvF/1gNw7umWLK9WO79TOK0hp60JzWIykJ7T VZkOxK9VBTfXoUnowjdD0ynpniR5XBj+0MI9qSLvOxNgDXwtWKYg1S2gbu9ToBgpoBrk jxDmlmBol5/6OasvDS9yD80UHDsx1WePAWdzpgBYr8EZaO27W15OGedGpWwPz1aUysCM EC7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774547862; x=1775152662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DkV/sS5NXQeiPjlp9UyXTqzIZIBKvql5Nx/cBjkpGbc=; b=mpyN2b5IT45Qw5PNir/YMouQp0zwBDFTVz4b223tw7NIqkoO/zag1TXDDxnnk3WZMU LPxeqigGxroy1A55YemwhZaBW/luhNONPFdRRWNXHjlkicJe+hqKUO4+6QWLHa5ivocD IRXsCgRLlgDymsYtV7pKxBmvhMyjp0Jl5LYzaftqu+/SMcMCzB8fv/teA4VN3UzLR+85 w7S2/5QIV2Zd+ZPma5FQObHpNfluJy5d1AyhO7L5OVMY8W7ox5IkjNUdnjhLhp/CKZAq WVPuqZT+eT8+pO6ZTxHz3HfsK5pHJ+L2HKxX7jfqg9NQh0i04TvVKEC4a0tOgQyByrn0 7ZSg== X-Forwarded-Encrypted: i=1; AJvYcCVm2Lg06UTftGdDyHSDBNizEUbI1mWBJl2kjNGH5HtjoMq/5aJMSk3qg9BRycGEy39CFrrNcTKov189PGU=@vger.kernel.org X-Gm-Message-State: AOJu0YyrQYJNaAC/l+SNP9WkphlQw+zKVHaz7BAdwYwqovrbj7+raVLS PNlui4eR/4Dq88Fq8j2EQY/ICmWbo7eQOcBnI3ysNgvlVY+SUNC9Nzzp X-Gm-Gg: ATEYQzzS8CIUownrs/QIXZtRE8ZNwDA7ASge/cknkDnMooG3Bgz1yGMyu84lZPZEN7M 1qA8LCF4LoTPP1wWkPf8a7FgrC+H/UtoPlDfFMtYjtsIFzTx1U4hJ9nBJWnEt3l8Yn5Qh1YqTLK COpZBJWwBPhKkKl4wZ++kq1/uKbeIRn98m/ALWgt0hw91cIeaEj1KHQTXJX/lKxOufmwSIWUMt1 RDRtaQxhdhZ2nfrFpPqc+n/qHm5fOD9Mi2rlaMVSCNOM1IWF98QiFjJNK9wGVx4zDWIbP2H2oiC IVpQZ8Aag+pS4MtK7TaAs1Yul9k+Z8Ebawx79wi6Yj6/ZIOLJ6jU5ayiW4rz2dWwkr/MH1E+UDG CYGZdcePbR1uKu60WGnPdHedg1JLMdlDPW9IiVh8OQsx11s45P3hTTb+afbhRlAjUetr0ECnx8Q fDQlfBsQxshfCK/oUIOLrfDf27c0FeSg3SCw4lK9axA+BiVmA9EX+4c+t2nZe9J8R7gs1d6oRFo B35M6CUfdzsT+ZR+KRKuwbh X-Received: by 2002:a05:690c:e4e7:b0:79a:ad57:f93f with SMTP id 00721157ae682-79acf647c7emr72115717b3.39.1774547862224; Thu, 26 Mar 2026 10:57:42 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::17e2]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79b1e3bdd89sm16277137b3.29.2026.03.26.10.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 10:57:41 -0700 (PDT) From: Ethan Tidmore To: Tomasz Jeznach , Joerg Roedel , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Robin Murphy , Alexandre Ghiti , Nick Kossifidis , Sebastien Boeuf , Andrew Jones , iommu@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2] iommu/riscv: Fix signedness bug Date: Thu, 26 Mar 2026 12:57:38 -0500 Message-ID: <20260326175738.750060-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function platform_irq_count() returns negative error codes and iommu->irqs_count is an unsigned integer, so the check (iommu->irqs_count <=3D 0) is always impossible. Make the return value of platform_irq_count() be assigned to ret, check for error, and then assign iommu->irqs_count to ret. Detected by Smatch: drivers/iommu/riscv/iommu-platform.c:119 riscv_iommu_platform_probe() warn: 'iommu->irqs_count' unsigned <=3D 0 Fixes: 5c0ebbd3c6c6 ("iommu/riscv: Add RISC-V IOMMU platform device driver") Signed-off-by: Ethan Tidmore Reviewed-by: Andrew Jones --- v2:=20 - Add correct Fixes tag. - Add RB tag from Andrew Jones drivers/iommu/riscv/iommu-platform.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/riscv/iommu-platform.c b/drivers/iommu/riscv/iom= mu-platform.c index 8f15b06e8499..399ba8fe1b3e 100644 --- a/drivers/iommu/riscv/iommu-platform.c +++ b/drivers/iommu/riscv/iommu-platform.c @@ -115,10 +115,13 @@ static int riscv_iommu_platform_probe(struct platform= _device *pdev) fallthrough; =20 case RISCV_IOMMU_CAPABILITIES_IGS_WSI: - iommu->irqs_count =3D platform_irq_count(pdev); - if (iommu->irqs_count <=3D 0) + ret =3D platform_irq_count(pdev); + if (ret <=3D 0) return dev_err_probe(dev, -ENODEV, "no IRQ resources provided\n"); + + iommu->irqs_count =3D ret; + if (iommu->irqs_count > RISCV_IOMMU_INTR_COUNT) iommu->irqs_count =3D RISCV_IOMMU_INTR_COUNT; =20 --=20 2.53.0