From nobody Thu Apr 2 22:12:12 2026 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A60DB3F2119 for ; Thu, 26 Mar 2026 17:26:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774545963; cv=none; b=uRkk4hFdaE2SeJiP49THDKxdM8EeImYIvaHbZ5zRDzRAc8fxpwgAsM0kf4Csq2spesq+SDBeMBDZrqLJZDjlQiLxKfcEYXvrwCvJJ5KtLf8cU/DwFyZlB+Lt5WkGeVsODbfRIbYJUMDCUExtHSeI/sXtxsWfm+rLSBO3Bp4kpes= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774545963; c=relaxed/simple; bh=r3jS0iMVJKol5bbCcmZNRj72n5eFPLHhD7IuoyM7mBA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RSViTSVKNIogZ5woQroSbh2XRJJJHYWhnMW2tLT4ZVqc+RhPdZSE6bUDOIFw1MWakPSbvVPhTMQafU9DwEZD2+vKKMCc0hOwHGGOw9liidjMNYKz9ZjnEmTEGS65NtWruZq+gPSt/bA71xcKC5jEM5npEwZd2qpwAQUgE4qwQw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=oLzgbp0h; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="oLzgbp0h" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 265B72E96; Thu, 26 Mar 2026 10:25:56 -0700 (PDT) Received: from e134344.cambridge.arm.com (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4293B3F641; Thu, 26 Mar 2026 10:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1774545962; bh=r3jS0iMVJKol5bbCcmZNRj72n5eFPLHhD7IuoyM7mBA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oLzgbp0h2SRD3+RuvOj30K/fi5Z07SSrlFWrUCgE5WXteg0TtWjY/moctm1r+WoBf bbyafgapFx2ZO7zoJ/8WtV67ncL11wPwqGWIpeZZaZrfaffuD/YwNAM3LWECxeAIxT G+6ZI61mwKEDlKeWNQ7l035cBxZuSlnf1OOoyj1g= From: Ben Horgan To: linux-kernel@vger.kernel.org Cc: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ben.horgan@arm.com, fenghuay@nvidia.com, tan.shaopeng@fujitsu.com Subject: [PATCH v4 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() Date: Thu, 26 Mar 2026 17:25:45 +0000 Message-ID: <20260326172551.1553871-2-ben.horgan@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260326172551.1553871-1-ben.horgan@arm.com> References: <20260326172551.1553871-1-ben.horgan@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The error path in resctrl_mkdir_event_configs() is unnecessarily complicated. Simplify it to just return directly on error. Signed-off-by: Ben Horgan Reviewed-by: Reinette Chatre --- fs/resctrl/rdtgroup.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index 5da305bd36c9..4753841c2ca3 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -2331,20 +2331,19 @@ static int resctrl_mkdir_event_configs(struct rdt_r= esource *r, struct kernfs_nod kn_subdir2 =3D kernfs_create_dir(kn_subdir, mevt->name, kn_subdir->mode,= mevt); if (IS_ERR(kn_subdir2)) { ret =3D PTR_ERR(kn_subdir2); - goto out; + return ret; } =20 ret =3D rdtgroup_kn_set_ugid(kn_subdir2); if (ret) - goto out; + return ret; =20 ret =3D rdtgroup_add_files(kn_subdir2, RFTYPE_ASSIGN_CONFIG); if (ret) - break; + return ret; } =20 -out: - return ret; + return 0; } =20 static int rdtgroup_mkdir_info_resdir(void *priv, char *name, --=20 2.43.0