From nobody Thu Apr 2 20:22:02 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29EA52BE641 for ; Thu, 26 Mar 2026 17:14:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774545268; cv=none; b=U0PvGBAIl36CDB3dnqG4tCuog/6ZpJhCYyZtfQhalutg8Vg1/vFF3vefpJ4LjVZeVhVrJ/w5eGVhHn8T3p/GLtVWVACKbDQPF+9/RpjDbrhb/dVX8/i3VZuPwZCHLmwasKarQSKxVw1Vun80ZgT3u4cE1g5So0svYuBVU2eRCaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774545268; c=relaxed/simple; bh=kYbxmcPBnLD1OApRLqHNDk2P4GKrfRRDsbXWsTNsNY8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lxHRNkd7I+lUXMsKPcijYM9AOS+I8TnjG8hRCLpkuCuJSPz5n5wGIsD2pf/vDvOU5+SJGGJDJBku+r6sLO2bPW55K1acupsmENhyx3o7gGq4RvQ0HkpJ41OG0b756o4JZCDMzFRT5Do1062qWk2KST5NBBiczwjCTYOXVCpN59A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WIHi6Sg6; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WIHi6Sg6" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-82a655cfab5so1169382b3a.1 for ; Thu, 26 Mar 2026 10:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774545266; x=1775150066; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5EYLAxpZw5J+LWwefp85cIa/Oa997GC6rvGojvQhFXQ=; b=WIHi6Sg6petVIefVuDLB5XIYloIw6Kt9g4ByZYY3w7IGizJtLLKYnAmkZORYIbpEXX PV53KlNWzOxHXzkEhcUlH/KppuADhmuZjMr+MC0sTMiUiJynLrBcfmbLI6mGdJcg/2e+ OBE65143YZtEMyDsk1FWEUjPJM+f0Y6xdt7u7JDoFn9e5k2TtNJoS9rn8JRVLn9fX780 k1xKf8Q+QafM12o0v81RxikqhAmPhzx9kfSssEhPZfEY3Gi2ytfnMQ5B2wZq8Jb1SWtz 0R7w5G+RuTCM0XPvCdPna+8mXrQALusg9XaXqMlMGGEYDz4qKCEg6q4W/OJ/+uTmhx6o 5v1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774545266; x=1775150066; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5EYLAxpZw5J+LWwefp85cIa/Oa997GC6rvGojvQhFXQ=; b=FuPZovbe34tPvt5w7HgxQVMvcGFUlSKYQ5TXkn4owKvwthBCe/BK0Wxdqr01oMIx80 H88gVCtrudlp2N1hRoLsJJ6F6ppQGdWVTG1kxBR9ZTrI05Pox+KiNj1M/Xl6S3beP/Rn tjfJA5kZw0vI6aMwfH3iEIc0Rktky47FK7L7FT+soTsvuUDGvlxEs9oFgjomVAjtfvAY xG2099f56KlA8OZXB/CXsnMfDsWToCZ93ykdVtkkccFg+DiARVggmZ7WG4ZNuPL0ygaY 4Cfhuppv9vV0BvOkaY65PdaQwRK4r598vWcHcshc7HjwVRrrzPrIX8VlUJbA+ddCJPW5 +XKQ== X-Forwarded-Encrypted: i=1; AJvYcCVNXWuoUGbH67111G6IsDMPhxCgaxklBkq0M8tdgazn30EEkt8+OxQsa2CjDNYmWn13KH1UN4iC4Ou+Rqs=@vger.kernel.org X-Gm-Message-State: AOJu0YxAAPuSH0rkMBknWUOAUAUo+NB4IuVRMl9psGK9neBRUgRDw52N wQkzroo92We8GQGOjJYA+HHiRLr2mDzH+MR7z3CLCE79mniDF94AEVGX X-Gm-Gg: ATEYQzzaIliafQaqc/3Sy2JWubb4129FgCyyAekWWkp/Nm6LjtPUnv5BqBAL+fbrblg iCv+j8NJK9bvUSEP4ZU5BC4IaVYNimsm60ALO3WoQ+MNQa04NNxX/WxG4V69v4ZcJsTZxaxSCKM lJHtG/9CdnDTqN+7FOkfSI9NPIRWuoM/xQ4VPTNyZKHZ8uKIWJi+QLq9OrwsKBQ2UFwRwYEG6ni VQppcCHtMowWPGngorhysRwOWhHb/wAeiCJOj3JWugb1S7rarZALarJplX4+1E7lLxqvJgEEYaJ Z3F86gbXwK1AWtzO/mPkeIA7r+hLuJ+V5PqSJGhuIEy4Uj0B82SIyi4dMirhUhMif/Y2NL3ebf5 DrQukFY6prSaSKOcArmOyfiHtuNaDSXeedIfJJstGADmrORKU6uUnUXNF+UhyuCBcOKjbrfTe5I ocG6Cbtw== X-Received: by 2002:a05:6a00:3e0c:b0:81f:3957:2772 with SMTP id d2e1a72fcca58-82c6de82b9bmr8842560b3a.3.1774545266478; Thu, 26 Mar 2026 10:14:26 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1002::c181]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d1e5ee6sm3119480b3a.7.2026.03.26.10.14.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 10:14:25 -0700 (PDT) From: Guangshuo Li To: Andy Shevchenko , Geert Uytterhoeven , =?UTF-8?q?Jean-Fran=C3=A7ois=20Lessard?= , Ingo Molnar , Thomas Gleixner , Guangshuo Li , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] auxdisplay: line-display: fix NULL dereference in linedisp_release Date: Fri, 27 Mar 2026 01:14:12 +0800 Message-ID: <20260326171412.1109402-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" linedisp_release() currently retrieves the enclosing struct linedisp via to_linedisp(). That lookup depends on the attachment list, but the attachment may already have been removed before put_device() invokes the release callback. This can happen in linedisp_unregister(), and can also be reached from some linedisp_register() error paths. In that case, to_linedisp() returns NULL and linedisp_release() dereferences it while freeing the display resources. The struct device released here is the embedded linedisp->dev used by linedisp_register(), so retrieve the enclosing object directly with container_of() instead. Fixes: 66c93809487e ("auxdisplay: linedisp: encapsulate container_of usage = within to_linedisp") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Reviewed-by: Geert Uytterhoeven --- drivers/auxdisplay/line-display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/auxdisplay/line-display.c b/drivers/auxdisplay/line-di= splay.c index 4e22373fcc1a..e80e94262830 100644 --- a/drivers/auxdisplay/line-display.c +++ b/drivers/auxdisplay/line-display.c @@ -365,7 +365,7 @@ static DEFINE_IDA(linedisp_id); =20 static void linedisp_release(struct device *dev) { - struct linedisp *linedisp =3D to_linedisp(dev); + struct linedisp *linedisp =3D container_of(dev, struct linedisp, dev); =20 kfree(linedisp->map); kfree(linedisp->message); --=20 2.43.0