From nobody Thu Apr 2 20:20:45 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D11433F370 for ; Thu, 26 Mar 2026 16:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774543095; cv=none; b=FN9LB/YtgfuwGHFJ2xLRljZ9+A8v4EMCQs4suWRBthekX6cf2+3/NlyT3tdrmCi269NTMhCn5MR6ka301q6i5L6nkKbs2RQtlVPSPcXBuaKaiYg3pUr74gbfOQ7DRCPvL+zLvdlQOJeOSqwhNVQ0smpJNDxJupaQ0P9KUJopgGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774543095; c=relaxed/simple; bh=gJi5eJfPbZOwrKwGfWtvogi2mRH4nUzmcJdMXEiFq4s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dA6JSD+w6+s0fMRtw+izMahPSy0/1SfFA9V7UE6Tod0eZ4Ty+1w9z2nsXo/XBGxl3qLP1Hpgxk2T/883fnYYAOMSGvSnFgaf4QRJxYha41RaE7Pr9LqziauY4bzZQteRMdW2sUfagEtHjGSPa3yyQ8xy6E0W6DXhSIEC9FpWwZ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/0FYZk5; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/0FYZk5" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48334ee0aeaso10750555e9.1 for ; Thu, 26 Mar 2026 09:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774543091; x=1775147891; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bmiT/zLXH0XNbRo012mXxoY2S9iYTJ549SWUrsIQVqg=; b=K/0FYZk50/jKkvtybBmZeTfI0Jg55zE6VXmQtikH2tR01/t0tIDhmNdJCVv86rNjKc OFYu3t20Z/VJlrzImWxrVu2pKJfG2cCnVAFKabEbDqWDoeydJx3bVjO/WhIYfpRl2irh XHUMaeozn0sLWESSpMN0OLbTnde90edk4cR5ZGkukZVGO4lqOIpmDxTfH9eDZkeB+y5m rslTDPFxMizjsOGjVN8Cn/BNz6zDfAV542wiXdApMaWzYjaMqD2mJzS2/fwCv+K7uyCI cw5Uu2soP5vgyi0bV25J7984AJx0p7E9QyEES5rzI7Xn0mm6a1IXov4PYbT9iYCREhz7 PN5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774543091; x=1775147891; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bmiT/zLXH0XNbRo012mXxoY2S9iYTJ549SWUrsIQVqg=; b=GcZKJybTYEtQ395jb70OXbSbawmxq6nAfqc2o5hEg1l8R+FkmmhaU485C7EOGgnXd/ qu092lvucK4XUHqVBAqH3qPrDntdjuK1JS66t7rRQqcz0iku0fBq9m2b8ccSl382YRmo alSZIeITtr1UhWgGH4HMoj40UBvbC9OSnosasT61fxa0prADMTtWylI7Ux4bxWSRyDel /8Epg8YrAWeg5Rf9RGcC+jjWlO+u2lHNKmZmPErFFqbd7vUKbpUm3fRJgKLdR7Soalyr n5hXgxtnO7ryPCQisRDUbqeXXUWplqSBreTrcz4ikiMVbLMCowvO3PplfucRtK1scjiJ L5gQ== X-Forwarded-Encrypted: i=1; AJvYcCWj10i8TLuDea5KFpJTC0fZEX5xqg99PmTikIZ/EPxShl9csYxpKOVb/HfUdwHCK1UJqy0n9jt1q1av5ko=@vger.kernel.org X-Gm-Message-State: AOJu0Yx01lGbt1SGkEpSu8h9+QzWhkgo5yBQ9JrwS4gQMYKYFGTythBE 2szQVDKfYPQyRxPRpnLqvmYZpevspGL3v1UenYzGBwED8xGmC4VCs35z X-Gm-Gg: ATEYQzx648mHdXqXg4YdABktUDsIgdl9IYW8EAVy7/pnF+l/jb3yFOuHlGPChG6E95J 8WzFRf4/8JBEAbAdPUykbualvVJZ7qBE/Rwl8dGsIlhfp6oiYH22b+i2OHhNVv8Hb1tr5gQUZC+ c/++ETcpthf7TCNi5VSbKx31NkgRyOU4rYCnqB9OY/sSzoHn/6WX3kadqgytOknlp46HAJzTcAW nt92bymkjAphSpiEOt2An78H3KO5j9kunDE71y/JsbbEOArppYgkg+mo7Vu8WQq2czlKRn+FM64 5Mp1XtOPtHp3h/UD/uDXO3QAMPdGfuz0c+too4icQTDPzu/cGO5Opk5YX7AOL2sH6O8PA3GCQ5K 0/mZiWGrSPSVn8Ftr0QFm9NV1auTzo5KrUvEvmyEEIMUNfxUWJWHrN1g9505zw/XxKdLWIZqdAn Z2P2HFieR8wBU0Ag5qpCO/f22VKU2/xYCPNHlr5zZ4txkGzB3qPaZl X-Received: by 2002:a05:600c:5296:b0:485:364e:9328 with SMTP id 5b1f17b1804b1-4871605ceb5mr131644045e9.16.1774543090349; Thu, 26 Mar 2026 09:38:10 -0700 (PDT) Received: from aldo-conte-t14.tailf68ad9.ts.net ([217.61.173.50]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48725eae727sm445325e9.2.2026.03.26.09.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 09:38:10 -0700 (PDT) From: Aldo Conte To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Javier Carrasco Subject: [PATCH v2] iio: light: veml6070: fix veml6070_read() return value Date: Thu, 26 Mar 2026 17:38:08 +0100 Message-ID: <20260326163808.21404-1-aldocontelk@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" veml6070_read() computes the sensor value in ret but returns 0 instead of the actual result. This causes veml6070_read_raw() to always report 0. Return the computed value instead of 0. Running make W=3D1 returns no errors. I was unable to test the patch because I do not have the hardware. Found by code inspection. Fixes: fc38525135dd ("iio: light: veml6070: use guard to handle mutex") Signed-off-by: Aldo Conte --- v2: - Fix correct commit in Fixes tag --- drivers/iio/light/veml6070.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/light/veml6070.c b/drivers/iio/light/veml6070.c index 6d4483c85f30..74d7246e5225 100644 --- a/drivers/iio/light/veml6070.c +++ b/drivers/iio/light/veml6070.c @@ -134,9 +134,7 @@ static int veml6070_read(struct veml6070_data *data) if (ret < 0) return ret; =20 - ret =3D (msb << 8) | lsb; - - return 0; + return (msb << 8) | lsb; } =20 static const struct iio_chan_spec veml6070_channels[] =3D { --=20 2.53.0