From nobody Thu Apr 2 22:08:50 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17C31413258; Thu, 26 Mar 2026 16:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774542798; cv=none; b=m5Izgzt/oRnQTMu4mD0wbmLFdP7hh5MNkCOPWBdocVDtlyM7yMi2up/sFtA1o1GvFhNx3O4c94zJAKNSnN1AybMiaLCtHLjYIFOsTNupgBMiu2K+0zMsrYoeuLQc8SfMODI4b3HcQyfp9nHpotaKU9oDcZ368TNEyaWm0n4QCB4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774542798; c=relaxed/simple; bh=2MZHnP/9cS14JCDWx6lZ3RRAkM3yTL2R5Dnn1mrIUqo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=j5aywP/dPZse1LSNzbRs6+g3sZrv0d0nSY0KR3CypKhrGUIQx1JXUThWfjJ/LtJBYEdEcY0L8f4rcpstQ+bLXAX0JV7173wNUXSoAfDj6bi2mZPoekRhJBZtWYtAjO82M7arOu43flx6vez6NeB6iEHrjS8zMw6OPI4D+sZt6W8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=W8W1+pSZ; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="W8W1+pSZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774542796; x=1806078796; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2MZHnP/9cS14JCDWx6lZ3RRAkM3yTL2R5Dnn1mrIUqo=; b=W8W1+pSZ655/vCDWRIkMO1xs5Z5GDl/Q3ZTjY+uViIVkZS2qZejQAHUD o5eOELANF620YBk5jM1Y7HCK0umNxdsZFoH/SI5PSF5Qe/Q9Zi0WGEKyK nFA4aeX4IAMaguY9tFtY9R8/TGQy5FzUdjcFlU0PWq7wPKRHeCFCx9YFq XH7tUgv7CUf9vYebTASGp9j4r+m4cccAy7KgLC4qj6fHz6R/GeWDBdCx3 Nn/OcTm9aHJkkwqYiY/ZQgJtAIzksnzSB6LuwnQuTrL3eddrV7gUGXZrT Ti5EBpE1o1NwedlI2Vylxsj1FecBB9PfvKs/Y/F3yWZNHd4ZEHRtLgdeI Q==; X-CSE-ConnectionGUID: EANywaBZSM6dZHtrX4fclQ== X-CSE-MsgGUID: 8K8WORsOSsWDhdQTiwO8vg== X-IronPort-AV: E=McAfee;i="6800,10657,11741"; a="74636742" X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="74636742" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 09:33:16 -0700 X-CSE-ConnectionGUID: eX5HKoH3SbyKGTplUSVCIg== X-CSE-MsgGUID: nr2VscN5RQO67pCuqqFE5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="225311294" Received: from gklab-003-001.igk.intel.com ([10.91.173.48]) by orviesa007.jf.intel.com with ESMTP; 26 Mar 2026 09:33:12 -0700 From: Grzegorz Nitka To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, poros@redhat.com, richardcochran@gmail.com, andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, Prathosh.Satish@microchip.com, ivecera@redhat.com, jiri@resnulli.us, arkadiusz.kubalewski@intel.com, vadim.fedorenko@linux.dev, donald.hunter@gmail.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, Grzegorz Nitka Subject: [PATCH v4 net-next 7/8] ice: add Tx reference clock index handling to AN restart command Date: Thu, 26 Mar 2026 17:28:31 +0100 Message-Id: <20260326162832.3135857-8-grzegorz.nitka@intel.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20260326162832.3135857-1-grzegorz.nitka@intel.com> References: <20260326162832.3135857-1-grzegorz.nitka@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extend the Restart Auto-Negotiation (AN) AdminQ command with a new parameter allowing software to specify the Tx reference clock index to be used during link restart. This patch: - adds REFCLK field definitions to ice_aqc_restart_an - updates ice_aq_set_link_restart_an() to take a new refclk parameter and properly encode it into the command - keeps legacy behavior by passing REFCLK_NOCHANGE where appropriate This prepares the driver for configurations requiring dynamic selection of the Tx reference clock as part of the AN flow. Reviewed-by: Arkadiusz Kubalewski Signed-off-by: Grzegorz Nitka Reviewed-by: Aleksandr Loktionov --- drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 2 ++ drivers/net/ethernet/intel/ice/ice_common.c | 5 ++++- drivers/net/ethernet/intel/ice/ice_common.h | 2 +- drivers/net/ethernet/intel/ice/ice_lib.c | 3 ++- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h b/drivers/net/= ethernet/intel/ice/ice_adminq_cmd.h index 859e9c66f3e7..a24a0613d887 100644 --- a/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h +++ b/drivers/net/ethernet/intel/ice/ice_adminq_cmd.h @@ -1169,6 +1169,8 @@ struct ice_aqc_restart_an { u8 cmd_flags; #define ICE_AQC_RESTART_AN_LINK_RESTART BIT(1) #define ICE_AQC_RESTART_AN_LINK_ENABLE BIT(2) +#define ICE_AQC_RESTART_AN_REFCLK_M GENMASK(4, 3) +#define ICE_AQC_RESTART_AN_REFCLK_NOCHANGE 0 u8 reserved2[13]; }; =20 diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethe= rnet/intel/ice/ice_common.c index ce11fea122d0..de88aec9137c 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -4126,12 +4126,13 @@ int ice_get_link_status(struct ice_port_info *pi, b= ool *link_up) * @pi: pointer to the port information structure * @ena_link: if true: enable link, if false: disable link * @cd: pointer to command details structure or NULL + * @refclk: the new TX reference clock, 0 if no change * * Sets up the link and restarts the Auto-Negotiation over the link. */ int ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link, - struct ice_sq_cd *cd) + struct ice_sq_cd *cd, u8 refclk) { struct ice_aqc_restart_an *cmd; struct libie_aq_desc desc; @@ -4147,6 +4148,8 @@ ice_aq_set_link_restart_an(struct ice_port_info *pi, = bool ena_link, else cmd->cmd_flags &=3D ~ICE_AQC_RESTART_AN_LINK_ENABLE; =20 + cmd->cmd_flags |=3D FIELD_PREP(ICE_AQC_RESTART_AN_REFCLK_M, refclk); + return ice_aq_send_cmd(pi->hw, &desc, NULL, 0, cd); } =20 diff --git a/drivers/net/ethernet/intel/ice/ice_common.h b/drivers/net/ethe= rnet/intel/ice/ice_common.h index e700ac0dc347..9f5344212195 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.h +++ b/drivers/net/ethernet/intel/ice/ice_common.h @@ -215,7 +215,7 @@ ice_cfg_phy_fec(struct ice_port_info *pi, struct ice_aq= c_set_phy_cfg_data *cfg, enum ice_fec_mode fec); int ice_aq_set_link_restart_an(struct ice_port_info *pi, bool ena_link, - struct ice_sq_cd *cd); + struct ice_sq_cd *cd, u8 refclk); int ice_aq_set_mac_cfg(struct ice_hw *hw, u16 max_frame_size, struct ice_sq_cd= *cd); int diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/etherne= t/intel/ice/ice_lib.c index 689c6025ea82..c2c7f186bcc7 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c @@ -3769,7 +3769,8 @@ int ice_set_link(struct ice_vsi *vsi, bool ena) if (vsi->type !=3D ICE_VSI_PF) return -EINVAL; =20 - status =3D ice_aq_set_link_restart_an(pi, ena, NULL); + status =3D ice_aq_set_link_restart_an(pi, ena, NULL, + ICE_AQC_RESTART_AN_REFCLK_NOCHANGE); =20 /* if link is owned by manageability, FW will return LIBIE_AQ_RC_EMODE. * this is not a fatal error, so print a warning message and return --=20 2.39.3