From nobody Thu Apr 2 22:07:17 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5523C2DA755; Thu, 26 Mar 2026 16:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774542771; cv=none; b=C39yWuGY24HHIjF/XqfsEalTuzz95SgUazpFsutwyKsUtVFZw2liZUSCOf9gUlVITB/xI8B89NJe2B11Lcj3Sn7vvlbYpmqRY/AFWCFb1fkmILJ67gRNAuRiE/7VxX7Uwwm+sVUDpwDKkwtmzWh68AxKMdHshOwFNtXs8BEkuhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774542771; c=relaxed/simple; bh=2Etx+rXvLgn5f8FbpTl8o586ChunxqUzp8NBTbrLv7U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=htrC5FKdP2/kTDYtYBzHXi05YoTd6bqhUDd23PgsdWRID9Wv+3zXGqh8jhQqhQTBQ6E1Wn0Nj/RRCs6s7rMMtGRhViE8vP061P4QoRoKIF/2sUecIYjqdnObPrtHYKWzk526eFS2mtrFxzw8onGreb3MUp+lBIaUedeYsxngpsE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=TrIwaliC; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="TrIwaliC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774542769; x=1806078769; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2Etx+rXvLgn5f8FbpTl8o586ChunxqUzp8NBTbrLv7U=; b=TrIwaliCzXXcfwdeXJx4ITyaMqJf2A3MXQWJ3VTw9zjYFs584Ca5W40x q/oHpvr0MSOlRKzT9a9l33D7ZePy2C/eWp3rE0Zoeu7mhJZwk/7rXwh/f ecctb0OXGhCWxl1/F3AMXXmAl2jfkWHT1Su21snaBvCYRdnxQiFkbmLE4 OdD73nLkZBGJBSWJQe96BxmcictMAZxUExnEiYAMwUlzMki9HQJxejQ+B YPDBuCUn+gjoT7HAvHNXKLU3kM/vdcKJHNrBXjHschPQfKAr/Z8Juw15+ rozj8kNpfL0jGNKgGe+Rl1PpKl24pnkG50ohshD6VSZZpXV0jga5k7yaK A==; X-CSE-ConnectionGUID: Mq3TMWYISY6Quzeg3/zPEA== X-CSE-MsgGUID: 4WFpi8i2Sh6/ORrfor/9EQ== X-IronPort-AV: E=McAfee;i="6800,10657,11741"; a="74636647" X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="74636647" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 09:32:48 -0700 X-CSE-ConnectionGUID: P5wfBzOnRNqjHANLEEwfEA== X-CSE-MsgGUID: OJIESRsLStekGtbRsc35ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="225310978" Received: from gklab-003-001.igk.intel.com ([10.91.173.48]) by orviesa007.jf.intel.com with ESMTP; 26 Mar 2026 09:32:44 -0700 From: Grzegorz Nitka To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, poros@redhat.com, richardcochran@gmail.com, andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, Prathosh.Satish@microchip.com, ivecera@redhat.com, jiri@resnulli.us, arkadiusz.kubalewski@intel.com, vadim.fedorenko@linux.dev, donald.hunter@gmail.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, Grzegorz Nitka , Aleksandr Loktionov Subject: [PATCH v4 net-next 3/8] dpll: extend pin notifier and netlink events with notification source ID Date: Thu, 26 Mar 2026 17:28:27 +0100 Message-Id: <20260326162832.3135857-4-grzegorz.nitka@intel.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20260326162832.3135857-1-grzegorz.nitka@intel.com> References: <20260326162832.3135857-1-grzegorz.nitka@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Extend the DPLL pin notification API to include a source identifier indicating where the notification originates. This allows notifier consumers and netlink listeners to distinguish between notifications coming from an associated DPLL instance, a parent pin, or the pin itself. A new field, src_id, is added to struct dpll_pin_notifier_info and is passed through all pin-related notification paths. Callers of dpll_pin_notify() are updated to provide a meaningful source identifier based on their context: - pin registration/unregistration uses the DPLL's clock_id, - pin-on-pin operations use the parent pin's clock_id, - pin changes use the pin's own clock_id. As introduced in the commit ("dpll: allow registering FW-identified pin with a different DPLL"), it is possible to share the same physical pin via firmware description (fwnode) with DPLL objects from different kernel modules. This means that a given pin can be registered multiple times. Driver such as ICE (E825 devices) rely on this mechanism when listening for the event where a shared-fwnode pin appears, while avoiding reacting to events triggered by their own registration logic. This change only extends the notification metadata and does not alter existing semantics for drivers that do not use the new field. Reviewed-by: Arkadiusz Kubalewski Reviewed-by: Aleksandr Loktionov Signed-off-by: Grzegorz Nitka --- drivers/dpll/dpll_core.c | 14 ++++++++------ drivers/dpll/dpll_core.h | 2 +- drivers/dpll/dpll_netlink.c | 10 +++++----- drivers/dpll/dpll_netlink.h | 4 ++-- include/linux/dpll.h | 1 + 5 files changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index 55ad03977d6d..c7fcae76c3f5 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -71,7 +71,8 @@ void dpll_device_notify(struct dpll_device *dpll, unsigne= d long action) call_dpll_notifiers(action, &info); } =20 -void dpll_pin_notify(struct dpll_pin *pin, unsigned long action) +void dpll_pin_notify(struct dpll_pin *pin, u64 ntfy_src, + unsigned long action) { struct dpll_pin_notifier_info info =3D { .pin =3D pin, @@ -80,6 +81,7 @@ void dpll_pin_notify(struct dpll_pin *pin, unsigned long = action) .clock_id =3D pin->clock_id, .fwnode =3D pin->fwnode, .prop =3D &pin->prop, + .src_id =3D ntfy_src, }; =20 call_dpll_notifiers(action, &info); @@ -847,7 +849,7 @@ __dpll_pin_register(struct dpll_device *dpll, struct dp= ll_pin *pin, if (ret) goto ref_pin_del; xa_set_mark(&dpll_pin_xa, pin->id, DPLL_REGISTERED); - dpll_pin_create_ntf(pin); + dpll_pin_create_ntf(pin, dpll->clock_id); =20 return ret; =20 @@ -946,7 +948,7 @@ void dpll_pin_unregister(struct dpll_device *dpll, stru= ct dpll_pin *pin, return; =20 mutex_lock(&dpll_lock); - dpll_pin_delete_ntf(pin); + dpll_pin_delete_ntf(pin, dpll->clock_id); __dpll_pin_unregister(dpll, pin, ops, priv, NULL); mutex_unlock(&dpll_lock); } @@ -992,7 +994,7 @@ int dpll_pin_on_pin_register(struct dpll_pin *parent, s= truct dpll_pin *pin, stop =3D i; goto dpll_unregister; } - dpll_pin_create_ntf(pin); + dpll_pin_create_ntf(pin, parent->clock_id); } mutex_unlock(&dpll_lock); =20 @@ -1003,7 +1005,7 @@ int dpll_pin_on_pin_register(struct dpll_pin *parent,= struct dpll_pin *pin, if (i < stop) { __dpll_pin_unregister(ref->dpll, pin, ops, priv, parent); - dpll_pin_delete_ntf(pin); + dpll_pin_delete_ntf(pin, parent->clock_id); } dpll_xa_ref_pin_del(&pin->parent_refs, parent, ops, priv, pin); unlock: @@ -1029,7 +1031,7 @@ void dpll_pin_on_pin_unregister(struct dpll_pin *pare= nt, struct dpll_pin *pin, unsigned long i; =20 mutex_lock(&dpll_lock); - dpll_pin_delete_ntf(pin); + dpll_pin_delete_ntf(pin, parent->clock_id); dpll_xa_ref_pin_del(&pin->parent_refs, parent, ops, priv, pin); xa_for_each(&pin->dpll_refs, i, ref) __dpll_pin_unregister(ref->dpll, pin, ops, priv, parent); diff --git a/drivers/dpll/dpll_core.h b/drivers/dpll/dpll_core.h index 71ac88ef2017..f684d9d4c4da 100644 --- a/drivers/dpll/dpll_core.h +++ b/drivers/dpll/dpll_core.h @@ -98,6 +98,6 @@ extern struct xarray dpll_pin_xa; extern struct mutex dpll_lock; =20 void dpll_device_notify(struct dpll_device *dpll, unsigned long action); -void dpll_pin_notify(struct dpll_pin *pin, unsigned long action); +void dpll_pin_notify(struct dpll_pin *pin, u64 ntfy_src, unsigned long act= ion); =20 #endif diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c index 83cbd64abf5a..afb778420b93 100644 --- a/drivers/dpll/dpll_netlink.c +++ b/drivers/dpll/dpll_netlink.c @@ -830,21 +830,21 @@ dpll_pin_event_send(enum dpll_cmd event, struct dpll_= pin *pin) return ret; } =20 -int dpll_pin_create_ntf(struct dpll_pin *pin) +int dpll_pin_create_ntf(struct dpll_pin *pin, u64 ntfy_src) { - dpll_pin_notify(pin, DPLL_PIN_CREATED); + dpll_pin_notify(pin, ntfy_src, DPLL_PIN_CREATED); return dpll_pin_event_send(DPLL_CMD_PIN_CREATE_NTF, pin); } =20 -int dpll_pin_delete_ntf(struct dpll_pin *pin) +int dpll_pin_delete_ntf(struct dpll_pin *pin, u64 ntfy_src) { - dpll_pin_notify(pin, DPLL_PIN_DELETED); + dpll_pin_notify(pin, ntfy_src, DPLL_PIN_DELETED); return dpll_pin_event_send(DPLL_CMD_PIN_DELETE_NTF, pin); } =20 int __dpll_pin_change_ntf(struct dpll_pin *pin) { - dpll_pin_notify(pin, DPLL_PIN_CHANGED); + dpll_pin_notify(pin, pin->clock_id, DPLL_PIN_CHANGED); return dpll_pin_event_send(DPLL_CMD_PIN_CHANGE_NTF, pin); } =20 diff --git a/drivers/dpll/dpll_netlink.h b/drivers/dpll/dpll_netlink.h index dd28b56d27c5..082c2aea6d1a 100644 --- a/drivers/dpll/dpll_netlink.h +++ b/drivers/dpll/dpll_netlink.h @@ -8,8 +8,8 @@ int dpll_device_create_ntf(struct dpll_device *dpll); =20 int dpll_device_delete_ntf(struct dpll_device *dpll); =20 -int dpll_pin_create_ntf(struct dpll_pin *pin); +int dpll_pin_create_ntf(struct dpll_pin *pin, u64 ntfy_src); =20 -int dpll_pin_delete_ntf(struct dpll_pin *pin); +int dpll_pin_delete_ntf(struct dpll_pin *pin, u64 ntfy_src); =20 int __dpll_pin_change_ntf(struct dpll_pin *pin); diff --git a/include/linux/dpll.h b/include/linux/dpll.h index 2ce295b46b8c..ae4b146d7243 100644 --- a/include/linux/dpll.h +++ b/include/linux/dpll.h @@ -202,6 +202,7 @@ struct dpll_pin_notifier_info { u64 clock_id; const struct fwnode_handle *fwnode; const struct dpll_pin_properties *prop; + u64 src_id; }; =20 #if IS_ENABLED(CONFIG_DPLL) --=20 2.39.3