From nobody Thu Apr 2 22:07:16 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A167402443; Thu, 26 Mar 2026 16:32:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774542759; cv=none; b=nOtwWF5hp1X2P3wB3/ICV/M49JW6AuM6bzlzTdv/meH/MpkwdZeRnFTXXApYfG7/qBGSuUg/YB0xo82qd4VFtUw5N/FeiuSfNQOO07nOOE9OzyON1eqJ0wOF/JaMKVg6mB/vxaKvMmg8haub9Xjhj79sjRTmJm3tQWdVKbIB6oo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774542759; c=relaxed/simple; bh=mGVGmB9xUUY2QySpvbbDhKQd8FqE0QgLo4M6A/it0eo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=haWtTpgaOZ/9Xle05/cryNHIc8KBQXx184r1Rokc7UXmWwlF5yExva8nQYsKoREgHdoLd4iuZYJ62TA7qC/SgdCjoTCTGVGAFceskK/5j78qk0ejzf5qqkgfWzzEAUynaVzoSgLzfkhfuc/mmI0D5KifZo8mVO4H+91ze7PskJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BHyC0L0b; arc=none smtp.client-ip=192.198.163.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BHyC0L0b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774542757; x=1806078757; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mGVGmB9xUUY2QySpvbbDhKQd8FqE0QgLo4M6A/it0eo=; b=BHyC0L0brzRuoZDOd2+ICUkst4Lj0oGSkY94nrl5Fow6l11908APtb4t 12LwxqGmBFS3E8RRQhKYmRU1xvVy3d9fjfFsxgL+e/V26+6XL5s/vg3eP FJg3VMyebVM/SWiaeryPiXecxffP3m13tK4lRaQQLid3rZfHzchQQgRod DpvZzZgGV9Hup2HQnJ8JTnYlKAoFfdXPKzXzmWjoiRjOglTAQP5MYt6tu Kct0SvsUORk/Z3OSvI8gINRSaoxeAK0nLtsz1FZaD/Xec/buX97KVQtSL 7cXszxKMvHHrULj9zOmmxno/PQA36RM+9QnyDc9VGjFbwJ2/1iecMb33U Q==; X-CSE-ConnectionGUID: DogPyaHUTvSK62ip/Gs0fw== X-CSE-MsgGUID: Loh8GY6sQ8qlgXMweDCROg== X-IronPort-AV: E=McAfee;i="6800,10657,11741"; a="74636613" X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="74636613" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 09:32:35 -0700 X-CSE-ConnectionGUID: foKnV65nRIu3ObJ2/MVYhQ== X-CSE-MsgGUID: WidJjEn2TjqhHZjQQX+ElA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="225310908" Received: from gklab-003-001.igk.intel.com ([10.91.173.48]) by orviesa007.jf.intel.com with ESMTP; 26 Mar 2026 09:32:30 -0700 From: Grzegorz Nitka To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, poros@redhat.com, richardcochran@gmail.com, andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, Prathosh.Satish@microchip.com, ivecera@redhat.com, jiri@resnulli.us, arkadiusz.kubalewski@intel.com, vadim.fedorenko@linux.dev, donald.hunter@gmail.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, Grzegorz Nitka , Jiri Pirko , Aleksandr Loktionov Subject: [PATCH v4 net-next 2/8] dpll: allow registering FW-identified pin with a different DPLL Date: Thu, 26 Mar 2026 17:28:26 +0100 Message-Id: <20260326162832.3135857-3-grzegorz.nitka@intel.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20260326162832.3135857-1-grzegorz.nitka@intel.com> References: <20260326162832.3135857-1-grzegorz.nitka@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Relax the (module, clock_id) equality requirement when registering a pin identified by firmware (pin->fwnode). Some platforms associate a FW-described pin with a DPLL instance that differs from the pin's (module, clock_id) tuple. For such pins, permit registration without requiring the strict match. Non-FW pins still require equality. Reviewed-by: Jiri Pirko Reviewed-by: Arkadiusz Kubalewski Reviewed-by: Aleksandr Loktionov Signed-off-by: Grzegorz Nitka --- drivers/dpll/dpll_core.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index 3f54754cdec4..55ad03977d6d 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -880,11 +880,21 @@ dpll_pin_register(struct dpll_device *dpll, struct dp= ll_pin *pin, return -EINVAL; =20 mutex_lock(&dpll_lock); - if (WARN_ON(!(dpll->module =3D=3D pin->module && - dpll->clock_id =3D=3D pin->clock_id))) + + /* + * For pins identified via firmware (pin->fwnode), allow registration + * even if the pin's (module, clock_id) differs from the target DPLL. + * For non-fwnode pins, require a strict (module, clock_id) match. + */ + if (!pin->fwnode && + WARN_ON_ONCE(dpll->module !=3D pin->module || + dpll->clock_id !=3D pin->clock_id)) { ret =3D -EINVAL; - else - ret =3D __dpll_pin_register(dpll, pin, ops, priv, NULL); + goto out_unlock; + } + + ret =3D __dpll_pin_register(dpll, pin, ops, priv, NULL); +out_unlock: mutex_unlock(&dpll_lock); =20 return ret; --=20 2.39.3