From nobody Thu Apr 2 20:20:26 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A87A34252B for ; Thu, 26 Mar 2026 15:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774539389; cv=none; b=Zo45t8eMOZIaR1EVNVq+dU7GauSd1lXv8e2RIhWlTj1808F3BlpmFR9vqWfXONpdjUF33WemNJGyNNRhGXgTrWSKFm8ozjPFmm95qUbBXyKcjXCY/se5T7WZHktBHucQJOsk2ooLRhy+7U+lB8Vs/fNshwSGQ3iciVFrzwycthc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774539389; c=relaxed/simple; bh=Cxub38LQEZnp/P8NSeKse7/8OQRjXv7T6cJ+v2kaZxs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=in6DhSLGKCpt7puxr3IZK6QaBAYtBssg4YleSxcK7ApUjv1mI8ejGnGKMIoFxUhG9Gl2t3LixJ6ctKqObRIHr5CVkB8XQeGii9H4dQftYvp3GZLtx8dlAy6jR/jDMQBT8d4x7C0fiMTgtEUPjvvhxrMv3cHXLqmJXx1QSi+DIIU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lK8n6N3k; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lK8n6N3k" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2aaed195901so5120935ad.0 for ; Thu, 26 Mar 2026 08:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774539387; x=1775144187; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0r5aAUsCjDNb058qyitmFhLHtK1PctaqpFNaeMzbcgw=; b=lK8n6N3kJIC45dch3on+HmU0HruVwZaLFxAQDbx7llBH6SEEujsiox2lC9Z0VYYpsM Rmt4FHxWbbLb613W6eCcI99QnZWxvIOAFGrDpaWrQFGJcyKisqmkACKLA4oQB7x9Hn6+ vvH2SkIQ+pqPqgxW4ghcOA0sr7LYD2dAUtgmkJ9Y0EjVvAov5tX9DqMhOPnXwTVNOQjj BqsZlKjb2SKYOcB5xNOKteGxUUbnlMGmLok/hl1P3yY8SPBC0A2LFLnBiBSeUdgW6mdx aU2m+cWX9rjJXrwVKSl5rVfOskbCtgDEGxdAnR8MZHOPUcUPzjqdCr1TSeBK3cN67Bhr gQRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774539387; x=1775144187; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0r5aAUsCjDNb058qyitmFhLHtK1PctaqpFNaeMzbcgw=; b=eAbKnUSiSbZ/4v/5ED9HDcJc9PF39HTvObPCG46NYoaSMwSKeJQpSUKEMBfiQrrFPf O8rNlU9YGWPJBJcJtNz+/1pyRta+ALddj7ut/yN14Tg90kY2wF1qKMk1vuMKEpBkih9S +uhu3UpnsxTY5c5a0imPZE1VwR7RJajAL2lEcc6xnIcxhIwzyTfzIjSkeiVzOcPSlOD0 0WCHX/uT+VtpCdCMRIj8eVGDlwdEKdNBUKA6dNbnDDt09y8LxyON1i1UCrSQppY4QQTw pM7gg5sfugHELoB9jLavnGnwbUL5BEdwsOI+BJ4UGLUXY3uSGyUu8FlRco4XN3w42PY6 dpkw== X-Forwarded-Encrypted: i=1; AJvYcCVZSYuGFbJfJMO/FoUnI+r58nd7m+SbP8cNFUm6Cjkhc9O1Dfp6AaAlfAh9Xl/bSSsOyNn8jXS3HFm0ff4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2+tpalddI+XxRkRUh2od8SI3uuT9YEbiJlQRcMS6deHpDqk8k Qu9DZOisZ8ohu0N8HOSYLTfz0WOHGH34FkX2NCnrjnsKwi4JDy/04GAO X-Gm-Gg: ATEYQzzB4QxLoQMvfobYg8GdqGBDZ9TbNc3K4/w8sfCuLgixxQjaBQG404CAVoMuFLH OpviTU/OER6O+l24NU0FcF0pzp0XMs3/BPghnIFi8jU6WjvskYjoIXfhbwlJaUhuBHfg04jkTq2 Sj6EDER5ZPsh5xCb93kOMffDeeYvRFWVsG3rUyelw1QxpzO2gd6lbtIYGdMTVsejsm3DqPQsz7w NHWwoHHnDaYsMFCMJM4cslJZVzx8qgTHzgposLIQayeuD7I1On9GHnqRWZ8djUr5iqMrpHRpqBW NPu2KXm5XfEBiqGxbC3BgdJcrboPK0TZifdkQYxTqHjhksCeTa3BeA/QhPA4h/iDgqIKKosE3ll 91vB8iLcHCfDAAYqZKo1PKtmKhiZnBw1qzDDruPcQgLrzLlmyJIFr32SPvKJdwXUVL7eAvLkB51 ftVwaaa3d9aobXoYv0ADf3FaAb7i/IvIDuKPeUeOvxB2q68HROfsl7FCYt/ImhkJ0PyGkm8do7p rmYg02VH6/eQ9PaEe7Z/Q== X-Received: by 2002:a17:903:38c5:b0:2ae:c7e6:a13b with SMTP id d9443c01a7336-2b0b0a0fc4emr86705225ad.4.1774539387366; Thu, 26 Mar 2026 08:36:27 -0700 (PDT) Received: from localhost.localdomain (124-218-201-66.cm.dynamic.apol.com.tw. [124.218.201.66]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc90c845sm31688835ad.77.2026.03.26.08.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 08:36:26 -0700 (PDT) From: "Lucien.Jheng" To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn@mork.no Cc: ericwouds@gmail.com, frank-w@public-files.de, daniel@makrotopia.org, lucien.jheng@airoha.com, "Lucien.Jheng" Subject: [PATCH v2] net: phy: air_en8811h: add AN8811HB MCU assert/deassert support Date: Thu, 26 Mar 2026 23:35:18 +0800 Message-Id: <20260326153518.8387-1-lucienzx159@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" AN8811HB needs a MCU soft-reset cycle before firmware loading begins. Assert the MCU (hold it in reset) and immediately deassert (release) via a dedicated PBUS register pair (0x5cf9f8 / 0x5cf9fc), accessed through the PHY-addr+8 MDIO bus node rather than the BUCKPBUS indirect path. This clears the MCU state before the firmware loading sequence starts. Add __air_pbus_reg_write() as a low-level helper for this access, then implement an8811hb_mcu_assert() / _deassert() on top of it. Wire both into an8811hb_load_firmware() and en8811h_restart_mcu() so every firmware load or MCU restart on AN8811HB correctly sequences the reset control registers. Fixes: 0a55766b7711 ("net: phy: air_en8811h: add Airoha AN8811HB support") Signed-off-by: Lucien Jheng --- Changes in v2: - Rewrite commit message: The previous wording was ambiguous, as it suggested the MCU remains asserted during the entire firmware loading process, rather than a quick reset cycle before it starts. Clarify that assert and deassert is an immediate soft-reset cycle to clear MCU state before firmware loading begins. - Add Fixes: 0a55766b7711 ("net: phy: air_en8811h: add Airoha AN8811HB support"). - Change phydev_info() to phydev_dbg() in an8811hb_mcu_assert() and an8811hb_mcu_deassert() to avoid noise during normal boot. drivers/net/phy/air_en8811h.c | 105 ++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+) diff --git a/drivers/net/phy/air_en8811h.c b/drivers/net/phy/air_en8811h.c index 29ae73e65caa..01fce1b93618 100644 --- a/drivers/net/phy/air_en8811h.c +++ b/drivers/net/phy/air_en8811h.c @@ -170,6 +170,16 @@ #define AN8811HB_CLK_DRV_CKO_LDPWD BIT(13) #define AN8811HB_CLK_DRV_CKO_LPPWD BIT(14) +#define AN8811HB_MCU_SW_RST 0x5cf9f8 +#define AN8811HB_MCU_SW_RST_HOLD BIT(16) +#define AN8811HB_MCU_SW_RST_RUN (BIT(16) | BIT(0)) +#define AN8811HB_MCU_SW_START 0x5cf9fc +#define AN8811HB_MCU_SW_START_EN BIT(16) + +/* MII register constants for PBUS access (PHY addr + 8) */ +#define AIR_PBUS_ADDR_HIGH 0x1c +#define AIR_PBUS_DATA_HIGH 0x10 + /* Led definitions */ #define EN8811H_LED_COUNT 3 @@ -254,6 +264,36 @@ static int air_phy_write_page(struct phy_device *phyde= v, int page) return __phy_write(phydev, AIR_EXT_PAGE_ACCESS, page); } +static int __air_pbus_reg_write(struct phy_device *phydev, + u32 pbus_reg, u32 pbus_data) +{ + struct mii_bus *bus =3D phydev->mdio.bus; + int pbus_addr =3D phydev->mdio.addr + 8; + int ret; + + ret =3D __mdiobus_write(bus, pbus_addr, AIR_EXT_PAGE_ACCESS, + upper_16_bits(pbus_reg)); + if (ret < 0) + return ret; + + ret =3D __mdiobus_write(bus, pbus_addr, AIR_PBUS_ADDR_HIGH, + (pbus_reg & GENMASK(15, 6)) >> 6); + if (ret < 0) + return ret; + + ret =3D __mdiobus_write(bus, pbus_addr, (pbus_reg & GENMASK(5, 2)) >> 2, + lower_16_bits(pbus_data)); + if (ret < 0) + return ret; + + ret =3D __mdiobus_write(bus, pbus_addr, AIR_PBUS_DATA_HIGH, + upper_16_bits(pbus_data)); + if (ret < 0) + return ret; + + return 0; +} + static int __air_buckpbus_reg_write(struct phy_device *phydev, u32 pbus_address, u32 pbus_data) { @@ -570,10 +610,65 @@ static int an8811hb_load_file(struct phy_device *phyd= ev, const char *name, return ret; } +static int an8811hb_mcu_assert(struct phy_device *phydev) +{ + int ret; + + phy_lock_mdio_bus(phydev); + + ret =3D __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_RST, + AN8811HB_MCU_SW_RST_HOLD); + if (ret < 0) + goto unlock; + + ret =3D __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_START, 0); + if (ret < 0) + goto unlock; + + msleep(50); + phydev_dbg(phydev, "MCU asserted\n"); + +unlock: + phy_unlock_mdio_bus(phydev); + return ret; +} + +static int an8811hb_mcu_deassert(struct phy_device *phydev) +{ + int ret; + + phy_lock_mdio_bus(phydev); + + ret =3D __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_START, + AN8811HB_MCU_SW_START_EN); + if (ret < 0) + goto unlock; + + ret =3D __air_pbus_reg_write(phydev, AN8811HB_MCU_SW_RST, + AN8811HB_MCU_SW_RST_RUN); + if (ret < 0) + goto unlock; + + msleep(50); + phydev_dbg(phydev, "MCU deasserted\n"); + +unlock: + phy_unlock_mdio_bus(phydev); + return ret; +} + static int an8811hb_load_firmware(struct phy_device *phydev) { int ret; + ret =3D an8811hb_mcu_assert(phydev); + if (ret < 0) + return ret; + + ret =3D an8811hb_mcu_deassert(phydev); + if (ret < 0) + return ret; + ret =3D air_buckpbus_reg_write(phydev, EN8811H_FW_CTRL_1, EN8811H_FW_CTRL_1_START); if (ret < 0) @@ -662,6 +757,16 @@ static int en8811h_restart_mcu(struct phy_device *phyd= ev) { int ret; + if (phy_id_compare_model(phydev->phy_id, AN8811HB_PHY_ID)) { + ret =3D an8811hb_mcu_assert(phydev); + if (ret < 0) + return ret; + + ret =3D an8811hb_mcu_deassert(phydev); + if (ret < 0) + return ret; + } + ret =3D air_buckpbus_reg_write(phydev, EN8811H_FW_CTRL_1, EN8811H_FW_CTRL_1_START); if (ret < 0) -- 2.34.1