From nobody Thu Apr 2 22:05:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29ACD3FB044 for ; Thu, 26 Mar 2026 14:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535190; cv=none; b=JDIfmRpBEEuf2tCmYMUqAPuUG9zNUCyWYVQ3giQu7gkEIe3K93PffR7HLtj8QCqxQJYVO5BmisakMkMCB02oRKraAI47y368NP6XIoigg51qee5CMCRc8P+MIYfmrKFeOcfKMuy5MEZl3El3YQNIrTddg2mR4r7hgEGnq7DUxIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535190; c=relaxed/simple; bh=emVsdbxH1gETPmcQ4E7Fjci/kpiDTa+ULuaDf/TIRfI=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=g/13BlxVft50vhhgo+dFjpKAlbd+i4SghXmmM+kiVa8CYPJFjQS9BQtG3bNPvI2kt0aMtcpShvTfz+kNJSbsY2wjSOi8VH/3lV0bVvBosa89AOSpaKCuX2PodqilXmChgZStPcQztrgvWatUqCDCf+u9nmbVbBqn2+rvCYMJ0og= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hx7ZYPaf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hx7ZYPaf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBA31C2BCB0; Thu, 26 Mar 2026 14:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774535190; bh=emVsdbxH1gETPmcQ4E7Fjci/kpiDTa+ULuaDf/TIRfI=; h=Date:From:To:Cc:Subject:References:From; b=Hx7ZYPafnnwaXFRkxhai8829zmP4JTo82NEWUXvtF/LZqssW5ZyJXQdQJc00lfDpo WpmSxWDeQ54gqPxcbhaqlFkto1sIVQcAqNM9oF0mpOUuL7r1Ev2VMKkVHw+XBfiI74 LULQ1A3GFe/wN40/WUNhBLuirIjPZ//aewn1NKUpcanLEJvC+AA/3ayiIzbtWnlOYI fc7n++oEBv8qxU6U8OOUWJVg/QZf95EYhS4oZpXY59w+Nfsj5hb9Us1dkF6NnjoNxT 8XanQZc3sitegLvbskbUz6b0RjvHsp1km6SKPO498799jYoOFHXmeU+nESKP2+k/Ef QNj6NHReGR0fA== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1w5lg4-0000000DuBT-3Ega; Thu, 26 Mar 2026 10:27:16 -0400 Message-ID: <20260326142716.644352953@kernel.org> User-Agent: quilt/0.69 Date: Thu, 26 Mar 2026 10:27:00 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Tom Zanussi , Petr Pavlu Subject: [for-next][PATCH 04/13] tracing: Free up file->private_data for use by individual events References: <20260326142656.794462952@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Petr Pavlu The tracing_open_file_tr() function currently copies the trace_event_file pointer from inode->i_private to file->private_data when the file is successfully opened. This duplication is not particularly useful, as all event code should utilize event_file_file() or event_file_data() to retrieve a trace_event_file pointer from a file struct and these access functions read file->f_inode->i_private. Moreover, this setup requires the code for opening hist files to explicitly clear file->private_data before calling single_open(), since this function expects the private_data member to be set to NULL and uses it to store a pointer to a seq_file. Remove the unnecessary setting of file->private_data in tracing_open_file_tr() and simplify the hist code. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Tom Zanussi Link: https://patch.msgid.link/20260219162737.314231-6-petr.pavlu@suse.com Signed-off-by: Petr Pavlu Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 2 -- kernel/trace/trace_events_hist.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index a626211ceb9a..cf48fe23e71f 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -4050,8 +4050,6 @@ int tracing_open_file_tr(struct inode *inode, struct = file *filp) event_file_get(file); } =20 - filp->private_data =3D inode->i_private; - return 0; } =20 diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index 73ea180cad55..67cb92310864 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -5836,8 +5836,6 @@ static int event_hist_open(struct inode *inode, struc= t file *file) hist_file->file =3D file; hist_file->last_act =3D get_hist_hit_count(event_file); =20 - /* Clear private_data to avoid warning in single_open() */ - file->private_data =3D NULL; ret =3D single_open(file, hist_show, hist_file); if (ret) { kfree(hist_file); @@ -6126,8 +6124,6 @@ static int event_hist_debug_open(struct inode *inode,= struct file *file) if (ret) return ret; =20 - /* Clear private_data to avoid warning in single_open() */ - file->private_data =3D NULL; ret =3D single_open(file, hist_debug_show, file); if (ret) tracing_release_file_tr(inode, file); --=20 2.51.0