From nobody Thu Apr 2 22:05:13 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF76D3F99EA for ; Thu, 26 Mar 2026 14:26:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535189; cv=none; b=Dc56iuk/26L8uegxnSOf7OrRAdPdRjW0c6NfPZ1NLVoR49jzyO/S4mdjyv1dx9tFaFwGxyx7PMD3joVI77fm+goNc2b3Ty4CG8hNPtMSSaRPyBNVgcLA/7IG7OrtCaqFzazUr+TUVkVX61+4pV0aMo3ZmXaiWAb0BheUw4rS46E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774535189; c=relaxed/simple; bh=fH18RRJLVtt2AkQHsFTHXn4+EvWyOFsLmcuEKxKsC0Q=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=HPXDzJaa2ug/y62L2X7Dkv5MrMg7hGi49BXwI1CYCzCKUOB5SwgpfMYdozl0xC07PAube5kkzchqBmVo2/be+hTqZDBpbc9DN3Q0S8rBO/ItXGFnf2p10UZZMHAD0OpwE/uyIKTT2Gj/LtR05SlYiTXRrSHz6T6q0m+v56T+ngk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bny7jicS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bny7jicS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7CE6C2BCB3; Thu, 26 Mar 2026 14:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774535189; bh=fH18RRJLVtt2AkQHsFTHXn4+EvWyOFsLmcuEKxKsC0Q=; h=Date:From:To:Cc:Subject:References:From; b=bny7jicS2kothtKOArpaDsmoM31eQ+QtHcQT7kk9isbXdLCAsUn980rVYpSP7cNqT zF+akBOEYSEX8qDm2kzNkFGGEq08JjSceYcHhwJ/eDHEBSqv6sjSJ/FujPZVi4E5YY fnDR8zfj94baCF9+5q7DZpIMqs5gUAXXatukojyuG0ZeHj+6Dlm3AQcmicLTjzHoC4 eBxrJMKDZqf5yc9/I252iRgjwoHbHz34tjwIPVVy9p22mkqq7Vj5/iFpHLv3SUnaar CmhyVFwl+nRqLBB3YINNKe6K4uRalRFU+AWmhUMBq3+/TfzoQyEGyU0/IwGRL693hV HtfmTN/RJiL3w== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1w5lg4-0000000DuAT-1vzi; Thu, 26 Mar 2026 10:27:16 -0400 Message-ID: <20260326142716.325097418@kernel.org> User-Agent: quilt/0.69 Date: Thu, 26 Mar 2026 10:26:58 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Tom Zanussi , Petr Pavlu Subject: [for-next][PATCH 02/13] tracing: Remove unnecessary check for EVENT_FILE_FL_FREED References: <20260326142656.794462952@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Petr Pavlu The event_filter_write() function calls event_file_file() to retrieve a trace_event_file associated with a given file struct. If a non-NULL pointer is returned, the function then checks whether the trace_event_file instance has the EVENT_FILE_FL_FREED flag set. This check is redundant because event_file_file() already performs this validation and returns NULL if the flag is set. The err value is also already initialized to -ENODEV. Remove the unnecessary check for EVENT_FILE_FL_FREED in event_filter_write(). Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Cc: Tom Zanussi Link: https://patch.msgid.link/20260219162737.314231-4-petr.pavlu@suse.com Signed-off-by: Petr Pavlu Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 249d1cba72c0..26d1e95a55d1 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -2247,12 +2247,8 @@ event_filter_write(struct file *filp, const char __u= ser *ubuf, size_t cnt, =20 mutex_lock(&event_mutex); file =3D event_file_file(filp); - if (file) { - if (file->flags & EVENT_FILE_FL_FREED) - err =3D -ENODEV; - else - err =3D apply_event_filter(file, buf); - } + if (file) + err =3D apply_event_filter(file, buf); mutex_unlock(&event_mutex); =20 kfree(buf); --=20 2.51.0