From nobody Thu Apr 2 20:25:33 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3AB42C1595 for ; Thu, 26 Mar 2026 13:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774530814; cv=none; b=FV2REwVsnbVztT8ZutH9bUW0BPzXkSFDhkHYJ7jYWqprjj0lTkYNtKKH2CnvMppdGTnRkLTYfNP9wk80FZJUMe2OZu/CUYnfs5QiBemJYFzPEcPvnZa2Y9A1+aDU+AOaOLQzUCwpkqYPB4TfEm1KWVKq4s85D91GGpke18wf1Q8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774530814; c=relaxed/simple; bh=I9tBacM1sVt0ZrQ08j85FVkHC6i8NNybjOivF/oXzv4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AT0nhWqvlICZ0Hue7qX31d1Zi+5Lv1KXyG6wPSBtDonxRnmIXft83JYJLOoh01nfR+CDs5SnLnwEx+iQ+DS8owLIV+EyuiPF0Hbm2xDnhO22ERIDUgWhakNjRsuD9yINW/lyWxwC87BzQuDYsHhzFhbVgU9oGeLVNGqUGkpSwdQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gx9KKhzu; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=m3Tt2JfL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gx9KKhzu"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="m3Tt2JfL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774530811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=6XOdSqnlhARlJuK93tpHkO3fOPRdC+gIhjKB2r4D38A=; b=gx9KKhzuj5YQs/AvfPtFo2vFMlntTrI8Zc0hJzjI/mB0KFQvo04t+Bb6BIgZXmNcbjyOF1 ynjYUbLiWFqyJ19T7DOL/07C5GK3ddbrTeGGmvJ94qP/8T725UhjFAEVF/rvTilWj/LiaG PfiEC4RJxLQXASEgG4mFouWUpuHvwjM= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-1MezPvPLNnyr1nK1ReAHSQ-1; Thu, 26 Mar 2026 09:13:30 -0400 X-MC-Unique: 1MezPvPLNnyr1nK1ReAHSQ-1 X-Mimecast-MFC-AGG-ID: 1MezPvPLNnyr1nK1ReAHSQ_1774530809 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89c56300e64so31736686d6.3 for ; Thu, 26 Mar 2026 06:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774530809; x=1775135609; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6XOdSqnlhARlJuK93tpHkO3fOPRdC+gIhjKB2r4D38A=; b=m3Tt2JfLqGqWjDDote2qM1dMwn+Wn917LJIThgMbbrPqD4sY9EMUMJKzrurx74mCjR OeSjQUP5ln0uTQqwWclRUwOa0N4XA8hsf14A7QI4G7W5LBCtSjTWFeTxGvu50pWTsHl2 HjUwLBX/aH4VASV/qjwW0+MnbzUBh9SwGrNM+YQ9KyqeZJbaG1yRZpGxr+gbul3pFl20 lZ52KovEjb7of2h+gfyGfh6Ozd9JLqlnRMnvm3iSsWbXDX6sd7lumcZ9QPlR04kM/h/F pztrgvPDZ/CS83jQVYPvspMvsWQCZrDJqFkAUuQ2DoTMox632sRfLWgrzroUwx9VPc5y HysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774530809; x=1775135609; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6XOdSqnlhARlJuK93tpHkO3fOPRdC+gIhjKB2r4D38A=; b=GfIa2qBBwma9/m18n3dyQSAiLBUF7OJ/fZy3buWJbM6NQXpiVxtt5UqB/rBZhQP5+c kvQtOTTOD2wmMMwTztO2QsGxz6kQ19Hc4mPMPaMrVH2KCyEGhYGoL2CmkqWD6otUqvR2 +vw6posPDmef+0TB3Q4p/+HIgkON8GII8Qo+80GbuZ4Wew67MoXFG8UN2cyrs18eCZtO lUYdi5T9M3MjCpEyZx9OXekwfX+91nud9fFRePoUe5kUI9zM0UyklrBIhA/oM9wbd9Fd O6KXMlXzAVg0LCF2/g6Y5FvuiwP/taUrNd/7kbUsW6zCGVCcHsFPRnScm/ciQ4v9CsfD Hfow== X-Gm-Message-State: AOJu0Yzm7ZHLLEufPuTFP39yC+YJdGq7aiot9/W0f44fXcvuXH7W2Hui HQ9nLr4rFqYrsDYJREjH5x+EwI4IOGZTG5OpkxDsToqPmR4vu7840g4hFDoM75a9YnEH+U9Tdck FDjSl4/nJX9/cJ+oAupzZvkfctKAhuS64eUVM24lhMriglammoKBgPJveV1ZsT5uLoQ== X-Gm-Gg: ATEYQzwjD7qRgKx8AYEekQpBrifZOAVb3Qfuyiino6Ds6waUOo/dClQj/OL6umPz9Np 1c3BGjR9KMwii935I4JqKVrmZkSMyHp/q8vA9Ra4MuwstK9RIBluUSJpqk9M3soP29qxzwgbKRq CcBaW26I26q0jy29AYAHoY7LxjV/UjdWtZL5MarpjwDA2kB5u7pjQ7psvi0ngaomJbb0sZQ2MO+ RjiWsMsM85IdnoXShOq/ifATiHy3uH22KFKARh+UHwCu1VFMkS98CjuB2k6yOwTfBWNBowLJUyz +phyUNR8QBNdo54JV2uOlTY0gP/+3YGQAy2/Ex/HKg3ZfNEbMnwHbhBDqMpNEJd/HKuL7LoQwij hLoIklsbH2LwYaTR2TBtqegSuXpT17orhgA8sHAO3KRml X-Received: by 2002:a05:6214:dae:b0:899:f741:5aea with SMTP id 6a1803df08f44-89cc495ebd0mr116018346d6.8.1774530809541; Thu, 26 Mar 2026 06:13:29 -0700 (PDT) X-Received: by 2002:a05:6214:dae:b0:899:f741:5aea with SMTP id 6a1803df08f44-89cc495ebd0mr116017826d6.8.1774530809051; Thu, 26 Mar 2026 06:13:29 -0700 (PDT) Received: from oak (c-73-148-124-98.hsd1.va.comcast.net. [73.148.124.98]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89cd5855269sm24605716d6.8.2026.03.26.06.13.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 06:13:28 -0700 (PDT) From: Joe Simmons-Talbott To: Dave Penkler Cc: linux-kernel@vger.kernel.org, Joe Simmons-Talbott Subject: [PATCH] gpib: agilent_82357a: don't check a NULL serial string Date: Thu, 26 Mar 2026 09:12:56 -0400 Message-ID: <20260326131256.1758014-1-joest@redhat.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The agilent_82357a driver uses the USB device serial string for device matching but does not verify that the string exists before passing it to strcmp(). Verify that the device has a serial number before accessing it to avoid triggering a NULL-pointer dereference with devices that don't provide a serial number (iSerialNumber =3D 0). Similar to commit aa79f996eb41 ("i2c: cp2615: fix serial string NULL-deref at probe"). Found by Claude:sonnet-4.5 Signed-off-by: Joe Simmons-Talbott Acked-by: Dave Penkler --- drivers/gpib/agilent_82357a/agilent_82357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpib/agilent_82357a/agilent_82357a.c b/drivers/gpib/ag= ilent_82357a/agilent_82357a.c index e1349afbf933..da046ea40f11 100644 --- a/drivers/gpib/agilent_82357a/agilent_82357a.c +++ b/drivers/gpib/agilent_82357a/agilent_82357a.c @@ -1298,7 +1298,7 @@ static inline int agilent_82357a_device_match(struct = usb_interface *interface, if (gpib_match_device_path(&interface->dev, config->device_path) =3D=3D 0) return 0; if (config->serial_number && - strcmp(usbdev->serial, config->serial_number) !=3D 0) + (!usbdev->serial || strcmp(usbdev->serial, config->serial_number) != =3D 0)) return 0; =20 return 1; --=20 2.53.0