From nobody Thu Apr 2 22:18:36 2026 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98D4D388E7D for ; Thu, 26 Mar 2026 12:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774527552; cv=none; b=ol8tUViiLaR6fS2EMKD6VClr/G50ZSgxXG+zTL4PYdlz/NqTaVoYiydDGKjMdPBreKNrOELixEiolDbC5B4ALKYD9E1HcfiHv2vxxRPWp8WeXb+Us+ZQSQLMlfaTZ/kfePFGJmFDf86Td9CS0kjI/08a7B8mavR+BWU9BAAhrFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774527552; c=relaxed/simple; bh=6QxCbieJJleZEWz03PvwCXWOh6SMITR1YbIicVfha6E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nD5ywz2LUvuZHB/ViWmYPBFbncPkOSvlwRwKsCYbcwfd7oyTjYJlc1DQLXK/8ZebF7D9i10ZOMkwT4l7dqLKPsrAptGB00aHH678lkXo6vB2wFvivFjV0qYKd4G70upGlJLkMVSKin9T5E5O5D2SJ8GkYZSY5fxHE4zcs+DcKM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cp7OwJXk; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cp7OwJXk" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12732165d1eso1379354c88.1 for ; Thu, 26 Mar 2026 05:19:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774527549; x=1775132349; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G29ArKF84b4SeGetKeNGKRAR6Wyr/iQ+64xYn6vES30=; b=cp7OwJXkeX8ZrguPRm6SJc116/R76b0tmxRSslXRgvCkEmqaxU1aFqm0epSfZPxSz2 yDO4RQ/eOa+07xqGdupAArpO5xLKShkQXi5D46/OVh80jNdMG+7feiKZGu4AKddZ7WXv 5ch1C3Lh+WUvelZOS5N1istCseryP1n8gMh3q+++SVUJzmmieMij+ix/u9OVk1OBJFm0 VvxBZ/BMkJ6yJkhJnfeHEHHVlTLreWW7VQO/sYszRp+W7TSOAg0NOnASvwd/bTiHckht XKVx3ViYuTwZsImp9Daq3R/EIigMGF4uWHUZnbgjhz4/tPgZ9BQhwU6tXcplOfgNjgkQ 01Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774527549; x=1775132349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=G29ArKF84b4SeGetKeNGKRAR6Wyr/iQ+64xYn6vES30=; b=Rm1FmTay7c+XvuhRgIGExabfrM1YtK1ZrA0wK0ndpZw5+x1PoXMhaYhbO4riQvxJgF z9GPpeuzWcP9TzlJwvawp+Th2h7OkKP+ar61cUrfORl5xhtpAH4OziDW6as3me9GUy+H CTWyrLy3cNDq93DDAWUdmc2jtjo8x9ISnGbrDo2yKNPlJazfc85s/qdWbx8aHRZ/976z ZABEcziDalw3AQEWleQif9ghHfEgrDNeV/U6t/sLjsJY1a8hI9BiJymWutd1S0Rs6EE7 GhhLZU2XJR33LIKKHNSHmZAk3PqKdMIduUHdsSC1dRIqr7UW8V9BF/qFZCWKEVkQIYPz 0CDw== X-Forwarded-Encrypted: i=1; AJvYcCUnHReEfmajfXCw+jjKC3bEZe+a7PweglphGzVNOBY2qDz5gk6nTgYruvaMpWX5ysx35OLT6z8fhCw4F6s=@vger.kernel.org X-Gm-Message-State: AOJu0YyC5sD9kt0afw2loEOG2Lk80W3cZ1dbvm0ptWFtQ7sn5v27mExS AT0AYpfNOlU2qQeHYxtRnxptP6pS4mTwXjr7BMkqhh7XquEt+bk+yuo6 X-Gm-Gg: ATEYQzzMwjZ5Wn0sNOnfriVEPSBkaDXbURSUKbwqvg8Bw2f7Hw9MqeXe6MdNTnzGCeG o/ALyL10ELY7yH7O6rPJNVMprwPcE7TsfYZtXCzrP8my7EgYHajekBXkZMdJ4mXO/kp7ELvkETB d7ttV4eWXLpWiPK22FEzYs34qgOaFBBP8CmHijot1DW6rqLOR8pHMS2tB8FK/5hsJN5IjkAs/p7 puoo7GIeCnCZfG6REJkld/gACoB7QL9pC38fDIPOFhKvDx2HLL8u2UPAoYwpU9yxXiKuLP0N16n GziZLm51Ce3WgOLaFVuwnZeVZ5YLT4QzMqdlcyAgo5klaPL8vTigOkGGto+HRKObH/J/XEJYSXL plUWbLkp8U12giNFaka3eNWBu+gJWmiHhhQb1EWlHuLG92gYVJu1IbCatXrAVmQWHAwQ1vvSM+W 4ArAuy1lDdeOvTcezs9gg7naa1wSLmnelv2/XNlUeQCmcneo3jffgzY6XhNyqDc1kJT4D+Vn5cO w== X-Received: by 2002:a05:7023:b0b:b0:128:d577:dc21 with SMTP id a92af1059eb24-12a96e68023mr3835481c88.13.1774527548431; Thu, 26 Mar 2026 05:19:08 -0700 (PDT) Received: from DellG15.lan ([134.195.101.67]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa72492e7sm2473117c88.5.2026.03.26.05.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 05:19:07 -0700 (PDT) From: Guoyu Su To: edumazet@google.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com Cc: willemdebruijn.kernel@gmail.com, netdev@vger.kernel.org, horms@kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot+1543a7d954d9c6d00407@syzkaller.appspotmail.com, Guoyu Su Subject: [PATCH net v6] net: use skb_header_pointer() for TCPv4 GSO frag_off Date: Thu, 26 Mar 2026 20:18:13 +0800 Message-Id: <20260326121813.457049-1-yss2813483011xxl@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Syzbot reported a KMSAN uninit-value warning in gso_features_check() called from netif_skb_features() [1]. gso_features_check() reads iph->frag_off to decide whether to clear mangleid_features. Accessing the IPv4 header via ip_hdr()/inner_ip_hdr() can rely on skb header offsets that are not always safe for direct dereference on packets injected from PF_PACKET paths. Use skb_header_pointer() for the TCPv4 frag_off check so the header read is robust whether data is already linear or needs copying. This also removes the SKB_GSO_DODGY special casing: skb_header_pointer() already fast-paths linear data, so a separate direct-access path is not needed. [1] https://syzkaller.appspot.com/bug?extid=3D1543a7d954d9c6d00407 Link: https://lore.kernel.org/netdev/willemdebruijn.kernel.1a9f35039caab@gm= ail.com/ Fixes: cbc53e08a793 ("GSO: Add GSO type for fixed IPv4 ID") Reported-by: syzbot+1543a7d954d9c6d00407@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D1543a7d954d9c6d00407 Tested-by: syzbot+1543a7d954d9c6d00407@syzkaller.appspotmail.com Signed-off-by: Guoyu Su --- v6: - Use skb_header_pointer() for both DODGY and non-DODGY TCPv4 GSO packets in gso_features_check(). - Drop the SKB_GSO_DODGY special-casing for IPv4 header access. v5: https://lore.kernel.org/netdev/20260320141459.9691-1-yss2813483011xxl@g= mail.com/ v4: https://lore.kernel.org/netdev/20260319005421.14908-1-yss2813483011xxl@= gmail.com/ v3: https://lore.kernel.org/netdev/20260312104351.185370-1-yss2813483011xxl= @gmail.com/ v2: https://lore.kernel.org/netdev/20260308083319.1255118-1-yss2813483011xx= l@gmail.com/ v1: https://lore.kernel.org/netdev/20260307162905.3697050-1-yss2813483011xx= l@gmail.com/ net/core/dev.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 14a83f2035b9..8a15ca67cfed 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3805,10 +3805,16 @@ static netdev_features_t gso_features_check(const s= truct sk_buff *skb, * segmentation-offloads.rst). */ if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4) { - struct iphdr *iph =3D skb->encapsulation ? - inner_ip_hdr(skb) : ip_hdr(skb); + const struct iphdr *iph; + struct iphdr _iph; =20 - if (!(iph->frag_off & htons(IP_DF))) + int nhoff =3D skb->encapsulation ? + skb_inner_network_offset(skb) : + skb_network_offset(skb); + + iph =3D skb_header_pointer(skb, nhoff, sizeof(_iph), &_iph); + + if (!iph || !(iph->frag_off & htons(IP_DF))) features &=3D ~dev->mangleid_features; } =20 --=20 2.34.1