From nobody Thu Apr 2 22:28:51 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2EFA347BC6 for ; Thu, 26 Mar 2026 09:36:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774517780; cv=none; b=XxQPWqg1ReWRzFY7YlVqvTyZMRAg1LU6SyH4Kb7gybr5SMld01Ua4gBCxvRM56kdbpZwSjoTIIdPDNzTZhtbsTRQuHH+OyMB3qcqiEIt1EfF9YzjK3dS8vX7p8JKdYvwav+lPCoK7nCQ4F/vf6ZhP69HFE7tmYztwoyLSpURt9s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774517780; c=relaxed/simple; bh=yMyzaFoknNuQ6pVvN+fu/ld64KkXbgcWoC8dH9PpS/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jWBKboPi+yT0lrG7LxrA2kf+Lu21GwW6CE+CuhiXdFNhUlbg8MTutMy22IgUs1VkuoVlY9eG6Wuo4hvwWW5xeYUDxgxgOKkSpUJtSRAm95+d9nVN+P4fA7ahjHivtrg9QIjMvBvlH1gac/qNNDmMc2ca3IzxEg1a9PxH5GdfmxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qn3BJ5O6; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qn3BJ5O6" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-486fba7ce4cso7561315e9.3 for ; Thu, 26 Mar 2026 02:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774517775; x=1775122575; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=Qn3BJ5O6sU/SpoiZtzZRmnzPS3jWkZUIefXJv1TEvPe+Q4//ZNGtonYPfVIpdjiAFq l6ZA1eqihK5t1qFsTUvXczS91wL57OyEl5keEZo09+9y14zT0BZwrsRgRRyiMbTWBHjB J7wjJWujTmnvGaiZmzmAIz6RhrxzK2Vf3u71E0t4xHwQLgw3qE13AIb5Q6RoTeWTtzYD 9D5MkzIsa10vMKHtgmPT/YiuWujZPaR+pcVRLE12f31Yn7eTIK2LwrxfrZqm9kmCC5Dq v+ILwFQVpEscOamq9Asr0RxY2muWch8MkQQPoCtEpNuiLGrPliXJjJPWqnt3oBMJ9Z5/ S9/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774517775; x=1775122575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=SFZCTXHjhLuo51xbiCivKM8eEgpRXYP9qdYLyej14YvfM73Ye1EnYHKLm7ducVhATg au9pDuqwWtcvMfzxJqJ0IrRTePMj1mISytD8E/uCZEwaiMoqHjcEbqm5rwcIrASlxjMC GqVovNEbz6aUnRSM/CVfhnDibKr7HKJMYV/P9y7R95y3sonE5aXS+OHt4aPLlDKkTQZS 9HdwpdFNEf7qbChlF7nyXW8eG7BTzCo+h/F220lhC89Zxz8qu/1e2wN1ubBJjD4cYLQh o9YEKLhFoL3W6C2zhHf8SCSe4+adBhUpvjKNuHnI6GcpXfxtYmAkCa2tujI4BuaSFzb2 JUNQ== X-Forwarded-Encrypted: i=1; AJvYcCXIz6x3uhS6M7Wg8qWtZ+CZ/eVa38ZDwK86eb/F8cNGhN8DoN/y9spjqRagOLR9EDZfRdjVpoOPGc6PFvI=@vger.kernel.org X-Gm-Message-State: AOJu0YzvQ4uYQ+i8LChFBvYU2soDszpl0qWwbhuhfz8GYbTCG9DnFw/R 6ucazSYJSIKoqxeUCEJpC9M1n2eipmJBuTv2I6PPsR5V/u2iuED5Clc2 X-Gm-Gg: ATEYQzxZ4aR2UgPYs2fg3iX8OTm728pHbmIJbomQxqI7XaJ8D3cqdsoXYnIaHPBrGJs T1EaaXiqTmAhRvCnptwYnZlAUbNczM5fFZxJnVnmZE7uiZbJsI/cHQ+wFAQIb+hLiaoU7jsiGVe Ba+kRrYYsG+atfkh247ilJNN3saVXbJ47xGh3OFmzAJb84fdCt5agzJj0VNZ1vfWU2ScLCo2+vb OkZUAjleMS3avtREL4kAXrSgJLdHU1ONATsKEoulHGyICSqchN7HXp+vHOw7fKQZTmw+BMsyS4t FpH9+RTgnr25dzX7zbl+bKwqAQPVZ4RBPAOP+pLmBkOAo15NZFbMFVK6GyvgG0sCqUwY4ppoBd3 lff1HWEvmsXj3gvRW3b+HK930DlVPoWT4vWzW1y5cA5ynA2rZpBXS4Q93tUtDnUzMF7ObDHZPB8 PhM8M0zOnqCc2VHV6jtPVSLaI= X-Received: by 2002:a05:600c:4685:b0:483:6a8d:b2f9 with SMTP id 5b1f17b1804b1-48715fc3994mr97475005e9.5.1774517775260; Thu, 26 Mar 2026 02:36:15 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722d236a9sm41224175e9.11.2026.03.26.02.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 02:36:14 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v4 1/2] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Date: Thu, 26 Mar 2026 10:36:06 +0100 Message-ID: <20260326093607.13011-2-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326093607.13011-1-omer.e.idrissi@gmail.com> References: <20260326093607.13011-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_dvobj_init() use direct returns Signed-off-by: Omer El Idrissi Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..358eac0837cf 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,13 +155,12 @@ static void sdio_deinit(struct dvobj_priv *dvobj) } static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) { - int status =3D _FAIL; struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; =20 dvobj =3D devobj_init(); if (!dvobj) - goto exit; + return NULL; =20 sdio_set_drvdata(func, dvobj); =20 @@ -172,18 +171,14 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio= _func *func) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); - status =3D _SUCCESS; =20 -free_dvobj: - if (status !=3D _SUCCESS && dvobj) { - sdio_set_drvdata(func, NULL); + return dvobj; =20 - devobj_deinit(dvobj); +free_dvobj: + sdio_set_drvdata(func, NULL); + devobj_deinit(dvobj); =20 - dvobj =3D NULL; - } -exit: - return dvobj; + return NULL; } =20 static void sdio_dvobj_deinit(struct sdio_func *func) --=20 2.51.0 From nobody Thu Apr 2 22:28:51 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED6A134751C for ; Thu, 26 Mar 2026 09:36:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774517781; cv=none; b=Irs6W7I9RZPPx58vEf4T866NIkVFlHlL9GhZB3aYEf81wh7naWWpTsonYQfPPNbRxjfoJQqgr42MqcsC/eriyskSnIXQyxIgk6asCzjMI3oTZkAh73+wQrLStFq5g+iTrcFe39ZpSaH8iDRTD1VXim9PebGWHuYlX04iLIZIsyM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774517781; c=relaxed/simple; bh=MqMK9VUVSlSSc2e+r1jsvapXJDlKU7Fd8c54Oa8aqxU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=O+/bGEgZJF73n/xuefGHjNykAoVcK7i+eFV+pBoTgDIDp91/eNNPLY5mpzojpp6DONKTfSQJdo44MNUgKdPT6WmKohGKDTyrwkbz1EPzF+b9/EYokmn5+QlO523IbNYIA+KvQun0vvZvz6kzMDn5mXgQON0UXHSndrvUpQ4Difg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hCOVkXFA; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hCOVkXFA" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-486b9675d36so6832565e9.0 for ; Thu, 26 Mar 2026 02:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774517777; x=1775122577; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3poub8+Fh0OV92kTHtG954iIg2TQ9IULJ9dkSalWiIM=; b=hCOVkXFAsKGcRFTdsbVfzuGgKikFlJzW1Q7sWsj3EUJw4UmgTLtFsGaTBcEXP5HI7X xQhMXt2VkyghmS5N0WWH7XobVThbMwCcKLZ6uVF1B+zZELXwPqjiHcKzekWoWzrtYtOv QwhcMA14Ewf9ndyJafsb4/3WM66IPCi7dDufQFYjxdv5UZNDMTNo3ue5hLBUKh6achLG NO35i8Pjov3cIr7UmBA+4PYqQt/8IjtC9/c/0DKsOzBpy6BHW63jIRTphDbYgDct3E5T 299Ro13ayWwGPhDEQqtugHV5g/TuG/xuJ8iTD89mfsrNecrGXZcIx0ZYfWOAvZOiTM8v UyYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774517777; x=1775122577; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3poub8+Fh0OV92kTHtG954iIg2TQ9IULJ9dkSalWiIM=; b=E2VLceun3Ea3OCwwKFDC2CzOFWS4AVKQH0WYXj2xgxY6SSwMejQhnEWEcsLqSshy2d IzTt0EbEHPK6POveLKM8+EcJQ7zggorfJIlDdgAoRv57JKy+iifsEwk8UaDpeyu7BF2C /BYOb33YAUfJctqe1Of28qWFiVXXDvpXhi32tiB0aS/tOaNojWbfm/irgUWwp4u2ntvB o/KRuQat2CALwqC2kjHPPSqWUkYT7iEbOXk5lTZs06PyDhORz55tdxFg7ycBCG38n+4K TmHjd0IXRXLdGr3Fk4592ou77kek/7PTuaG+lq+R4ZDYjD047rZIe2RZDGFaWWB/j2gI /tmg== X-Forwarded-Encrypted: i=1; AJvYcCWW3gjF1oncF3OwVpuxkOLNT8duyvdV67LpvwmHCkgV4v+SP2HjWUA8YJKmlvuKIlv5dOwI4MvuhqANt2c=@vger.kernel.org X-Gm-Message-State: AOJu0YzpNKkJi8rPabCUaWSc7hUfMRlSshnXtOTZMHcfk09sOr9Pg4tm nndh4c5ZeupS0tDfYPhmfUDsW9+6ppkqf4CAm9QUKau2UTY1jq8X8BCk X-Gm-Gg: ATEYQzzd1LOt99onJ6rFhHTEX4TcBj3O/ug6q33EGqYw+WQCHVa0o53qVgwNehgTLer d4oxXNag+1UsqjWxY365QvW4wKaI1mEqxrt9QLdbOXB+GOtZHZEuQgz3Xae7IymU2i/rQMMpUGm Yl1D5VOMGXAJqlkBHUQyDnE6W8mNciq2/JODRXT6j6V2vS2G0IWqdo9SXSK4j5ykKcIuZsorZky jg5RRdl/lLF1Ng98aiNt9feHzoVBRegEdfOIu7Tiy58ykkhcCePdcZ1XcdYaraR9LdRnWD3xrbw a6BNZaULh5s+OC+8YiwkFd1rn5WaQ128AF7Tes2/rpRKhnaFVxJJpzwIXfZYNmIZ+lzpBk7MrgD jpRN1qR2z8dcmnJI7V0octBOthkBiaXtTkcnl1WyhrngK1wxGcW4TZ4hPcSTHHx7liVXHmwtxi+ BmU+tURbXwlIbiHrnpoZNfZhlwmcnkBLB5qg== X-Received: by 2002:a05:600c:4e12:b0:486:fe83:8621 with SMTP id 5b1f17b1804b1-48716056832mr99615075e9.23.1774517776502; Thu, 26 Mar 2026 02:36:16 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48722d236a9sm41224175e9.11.2026.03.26.02.36.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 02:36:15 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v4 2/2] staging: rtl8723bs: cleanup return in sdio_init() Date: Thu, 26 Mar 2026 10:36:07 +0100 Message-ID: <20260326093607.13011-3-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326093607.13011-1-omer.e.idrissi@gmail.com> References: <20260326093607.13011-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_init() return errno from sdio_enable_func or sdio_set_block_size instead of _SUCCESS/_FAIL vendor-defined macros. Let rtw_resume_process_normal return errno returned by sdio_init instead of -1. sdio_dvobj_init returns NULL on error so leave that as is. Let sdio_dvobj_init use a slightly more readable and conventional error check for sdio_init(). Signed-off-by: Omer El Idrissi Reviewed-by: Dan Carpenter --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 ++++---- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..e943dcea1a21 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1135,10 +1135,10 @@ static int rtw_resume_process_normal(struct adapter= *padapter) pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ - /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; + if (padapter->intf_init) { + ret =3D padapter->intf_init(adapter_to_dvobj(padapter)); + if (ret) + goto exit; } rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 358eac0837cf..d0feb28b7043 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -131,9 +131,7 @@ static u32 sdio_init(struct dvobj_priv *dvobj) release: sdio_release_host(func); =20 - if (err) - return _FAIL; - return _SUCCESS; + return err; } =20 static void sdio_deinit(struct dvobj_priv *dvobj) @@ -157,6 +155,7 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_f= unc *func) { struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; + int ret; =20 dvobj =3D devobj_init(); if (!dvobj) @@ -167,7 +166,8 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_f= unc *func) psdio =3D &dvobj->intf_data; psdio->func =3D func; =20 - if (sdio_init(dvobj) !=3D _SUCCESS) + ret =3D sdio_init(dvobj); + if (ret) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); --=20 2.51.0