From nobody Thu Apr 2 22:29:00 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 828541D45E8 for ; Thu, 26 Mar 2026 08:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515331; cv=none; b=XzGvmaPZKY//AThvR0xz6jCGXS2ShKing+tPg3Iormdi83tw4DVTyNeePsNudOF4DnwQdKF76xZe9GeYMOK4cO8O/V8GUayOxbJ3uhu/GuNjUtDlwqMk7PgKMDE0RuZwT667gJT7SAkmNnN0CdZoxKboCy915dy3YwATsf9w2NU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774515331; c=relaxed/simple; bh=skiD2LRatgq99Q+wHiek1yiXgQ1EWyCFXZ4fub22ssI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lHaIZjfhcjkDtFut3qQTZX5PGjYLV5zo7ERMeZ/8sNnyjhmBv4KwOvuhoOkJvASZSG0x8N44rP8gUDurHOLjWk4aLZYCRGin0StLpaKvIWIZUffsEoLS6GjgQScY8j1CbugybL/r/w8rWM5Kph1hTTI5MBCCU5o1YQwA3dY8L64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VLOQeah6; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VLOQeah6" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c7412b07f22so840193a12.0 for ; Thu, 26 Mar 2026 01:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774515330; x=1775120130; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=p5BE8QcWyqyjRVBsL/ccLA5CXk9JkpfRl6Wk9fg7XJo=; b=VLOQeah6ruHbsNJ5klhll3HB6o6LmaCtW/K+jmGzhB2z1K4LigaAnM91ThTEUPxwSA nC7/sWrAWw9cF0c09n3Wq+RCAeGoPeoUSLoEZ66CIyMS1FGY6qDEZfDk5wGD2w+J2u8S EPeZsQnVUAxa0XcB3LZ2+eGpbuHhlOj3HLB/eV4TyTXQsY9/vtwNV16fy3NH9vJ01Ymv wX93h8vXRs8DhehOxQfFHXmWdD+lPz5/zQ5Lo1as9rEiubw3ZchdRsT9zM+3uUThL3aP j7SvMp8k931HSaZ8wRSL3nlYCJAgoTO+Vd2sy679vpLJCHh8V3mPbHN5A3JVtaxpRxN6 tl3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774515330; x=1775120130; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p5BE8QcWyqyjRVBsL/ccLA5CXk9JkpfRl6Wk9fg7XJo=; b=WanAz3y/YtVJCuyg0a51zFZi8Tl2HIRBWweSiLmTRfYSk6J9VcAl7bz1Nhi6GdXel+ yuN3lxTuVd+9+SDGLS88FSXlQdLwYHTD9vtyOKIxqf9uN+f0R9SCCdHHVglLXQXfW4mG Lo8XGzG3f1eRpU99A570lAnABWdtZ45e8bcpVlrEx/MgerAlLZ3O60neuYrTz38vDGe0 5qzb6BW1PuglaREHS9mD3/Vz5hQgnvdrWY0J7T4mzZEZRUrIwHjXOtuA/BeRAji7uarZ +PW19S8Ql23N+lp5jF1VBuAtjpbKy6CEuplM3gk22UkNEjE2PW1aa604pOIc0SFCBY9B vAgA== X-Forwarded-Encrypted: i=1; AJvYcCXnHoGFVnaP+ZSNSiMxY0tr/6+o+EkhJ5QST7V1BdYYEkpvQ8t5d7KBvT5hHIYbhHJ1HAeydvo9j27d/3w=@vger.kernel.org X-Gm-Message-State: AOJu0YzpAhXJHQq4LBfSMysHfhBGf/WUAgj60EhuM/UepsQQT6/TDMek C5cdu6s/RpJjoR+7Zuo2qlo5Og82dyZqwi+d1k9AMx7GA8Sn4CK56PUA X-Gm-Gg: ATEYQzwmCx3DkOW3sbzXEW9qZRFMSBqzKPtFcc311JzIQm5ZRxRKuJyN1zK11/kQbVB +EmpTqtbDHc5y4kTfHuvamD31aCCj2enqKiQuVnc00XNPLJYdys12GwaH+xSRakC7UYFC9FbYFO jQ0zazlEmsrhW1bDiZON1usezi1o7lkcYgKaIH49GezD/Jk24T+CI06adJkmCJYcr/wgrb7V6gH DXHjAZ9g/4/GmB6WPQqfIwKs+TN2UI1nyWWP6ngl3wIFKBQYX1f6B6j7p2sMkfwuYOuTdzfc1x6 kbdpgJk1/QUttdKB+jFkpi5b0JgzsoL4s3nq/D555SPua4xd2KfWM1faE9Gh/okSHfAnnkaNR0q y1bCN3OofGVxDfq39TqXwr9aj0E19BpdoCenWVgmqvcnl5/E8k2VHwzlwmoE9E7S1PXM/bk8sKU NIE5ukJ59SBURIyNMiv2ZOWKSwxNYdN73TEQdkoAfKLNDElPofXfsuag== X-Received: by 2002:a05:6a20:3ca2:b0:398:7796:7823 with SMTP id adf61e73a8af0-39c734cfa8amr918470637.6.1774515329735; Thu, 26 Mar 2026 01:55:29 -0700 (PDT) Received: from ZC-202510311500 ([61.185.217.216]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7673984a6esm1601436a12.29.2026.03.26.01.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:55:29 -0700 (PDT) From: Haoyu Lu To: Michael Hennerich Cc: Greg Kroah-Hartman , Arnd Bergmann , linux-kernel@vger.kernel.org, "haoyu.lu" Subject: [PATCH] misc: ad525x_dpot: fix macro parentheses and permissions Date: Thu, 26 Mar 2026 16:55:10 +0800 Message-ID: <20260326085514.14505-1-hechushiguitu666@gmail.com> X-Mailer: git-send-email 2.53.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "haoyu.lu" Fix checkpatch.pl warnings: - Macros with complex values should be enclosed in parentheses - Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred Signed-off-by: haoyu.lu --- drivers/misc/ad525x_dpot.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/misc/ad525x_dpot.c b/drivers/misc/ad525x_dpot.c index 57bead9fba1b..ee258cd325f6 100644 --- a/drivers/misc/ad525x_dpot.c +++ b/drivers/misc/ad525x_dpot.c @@ -511,14 +511,16 @@ set_##_name(struct device *dev, \ return sysfs_set_reg(dev, attr, buf, count, _reg); \ } -#define DPOT_DEVICE_SHOW_SET(name, reg) \ +#define DPOT_DEVICE_SHOW_SET(name, reg) ( \ DPOT_DEVICE_SHOW(name, reg) \ DPOT_DEVICE_SET(name, reg) \ -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, set_##name) +static DEVICE_ATTR(name, 0644, show_##name, set_##name) \ +) -#define DPOT_DEVICE_SHOW_ONLY(name, reg) \ +#define DPOT_DEVICE_SHOW_ONLY(name, reg) ( \ DPOT_DEVICE_SHOW(name, reg) \ -static DEVICE_ATTR(name, S_IWUSR | S_IRUGO, show_##name, NULL) +static DEVICE_ATTR(name, 0644, show_##name, NULL) \ +) DPOT_DEVICE_SHOW_SET(rdac0, DPOT_ADDR_RDAC | DPOT_RDAC0); DPOT_DEVICE_SHOW_SET(eeprom0, DPOT_ADDR_EEPROM | DPOT_RDAC0); @@ -615,7 +617,7 @@ set_##_name(struct device *dev, \ { \ return sysfs_do_cmd(dev, attr, buf, count, _cmd); \ } \ -static DEVICE_ATTR(_name, S_IWUSR | S_IRUGO, NULL, set_##_name) +static DEVICE_ATTR(_name, 0644, NULL, set_##_name) DPOT_DEVICE_DO_CMD(inc_all, DPOT_INC_ALL); DPOT_DEVICE_DO_CMD(dec_all, DPOT_DEC_ALL); -- 2.53.0.windows.1