From nobody Fri Apr 3 01:03:20 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C61E3B8D58 for ; Thu, 26 Mar 2026 08:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513123; cv=none; b=fA7NO38wA1r199kenH8Vtw0wvDrf5YCMesGD/H1P0a62Avw7gcGdF9cFwf+e2XyCXNcy7O9xFt21pS/tPdO/Z2OYAjfFiUGOA127OmFIy9VVQhshM8jp1s5pp9zYpvaU3mmAy/KHwNrMuDx5gc64f3jMhlO08lh4qyJgbdPl+CQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513123; c=relaxed/simple; bh=Bd/5OfzV7Sarf3QWBs7/bSDFPUaIF5mzDS/I9XfZQvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pCvD5U0Rkg62llDwJ+1iTIKNlSMUH2Cc7yfW+L4pyYjDXseJ2pwSB2tVPgclzHcVOuJtV7oQbBtdNOfs04wUS4MUrGCn0E9yRWnj1TueRi7KMzV9Cs+rgRyB0AZ6NKdVBVdOVbT/OLSz3jh9Jqg4uoDAQvZDYA4UbEsRY5lrEos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RxnPxqDC; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RxnPxqDC" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so371777f8f.3 for ; Thu, 26 Mar 2026 01:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513120; x=1775117920; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=RxnPxqDCDm8ijksfcyZ/NeBXmGlfZEwc+nktymjYVUHwlD5ZFZY33W//powvzo1giS g2h/oQYl3a1MFT6bWFr/cBA5Jr1l4EqQJBb9wo4wCSZWtMwawhZTGjixeZZM/lC6Gq+a O5IFtGOUmE3uCaEr6j8MeFAzO7ttHXJpAfybefJ3Z0Rm1Pa7Sy3WNa5COvLKVwsy0Wdw d61+gVuNFiJoSDX0jqcbGZGK5AY5IjFyCBnNRS3PkptuVX1R5kbCsBRYSCnBmL84TDVn /nYeydxQGtnyJcD0I3m+zEQ2xmJyi912RSy2Zr5EGZ74j97aiCIfTOm/GtLuxyDLBSQP ohlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513120; x=1775117920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=suwTHSqUkjMjOeqcn44w2Ja78QlhvDnlFkVwboaqCz3LoVtBl9emvgrrgoMyUFm2SA fMt9H/R1zrLbgGOT/nuhz4xAto9Qdwkfr7KKFRY7BWbcRJw8pe1zN5kK0TvUVOkd8Zxg fAQmQuPY0npnt7fqUUNJ4vfYFkMrzMWnyGzsrfaKgX9pXoic96BBJYR5KqX5yiUl1Kqg nedIg6udTZ+evNxkbO07CqMrBsmSEDVZEwNQguHExthR1+c3f742ZZ8Ak3lIc6NjGXA7 w1wFUth309vuj61C491xMAmLcBJ9X5Whm2A+d3Rdz2vt1LtG0L0jQOIG/1R1nKBDmMVy 3CZA== X-Forwarded-Encrypted: i=1; AJvYcCXFNdTgpRTm0RHwXEUvLxV4j47GtAcGxUoqykJLY/fMSz6NiaOWZNr+Of1b1SFwTfltVRiGQVnzPJ280I0=@vger.kernel.org X-Gm-Message-State: AOJu0YzcPE01P6PaI0eXArV7TknhiOgWjfr8P17+E/jBL2wVaNv++a64 UfHirQ1C+yskC7k0N+061QTjCIM853pqgGEsU+QaAJYNjIeYsL/KiuVq X-Gm-Gg: ATEYQzx/4EbANZt31SPOOHtGfbKe8T6AATRl94lnT4IZVyM5fSu06Voe0ceVmA+xVtv C6W/ID/WHWyyZnszlm+kCVIymClg0340Zoo80phClvxmjV5Co3/rLSWWX5OhKxg5xyFwyb57P9B IBURUzTWfYkMtwjztvbIBVgpl8tLehUiDmbPQ4Wls+CNUDMXPjh83s5VfUQeBSnnYgNmsFeyHOV FauXsiY+IGu/iEhemFcm428oDhK1DNavAhLSmuv+SD8l1SdS+pP87XLwA4V4jIPt3iTqb2c+fp4 7iitAXcCjiuCS2nnHBfDZQmduxwjCJCZJtjV4Mz4X33kpvqGPAl+I8V0wJVpQfeaySIcv6B9fJZ KJoSdePN0Ctl3nBSoCsW8Ba+vDYep0CW7XSetDk20Nv4igE1/SYNQOZLwDq5/ILfISiSACfv25o 0FO7Tr3JKxo4/9goIG2HEyNYo= X-Received: by 2002:a05:6000:4285:b0:43b:4136:1e76 with SMTP id ffacd0b85a97d-43b88a0d2camr10029074f8f.29.1774513119440; Thu, 26 Mar 2026 01:18:39 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cefd7sm6130521f8f.17.2026.03.26.01.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:38 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 3/4] staging: rtl8723bs: clean up callees for sdio_init function Date: Thu, 26 Mar 2026 09:18:27 +0100 Message-ID: <20260326081828.6314-4-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081828.6314-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081828.6314-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Let rtw_resume_process_normal return errno returned by sdio_init instead of -1. sdio_dvobj_init returns NULL on error so leave that as is. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..e943dcea1a21 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1135,10 +1135,10 @@ static int rtw_resume_process_normal(struct adapter= *padapter) pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ - /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; + if (padapter->intf_init) { + ret =3D padapter->intf_init(adapter_to_dvobj(padapter)); + if (ret) + goto exit; } rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ --=20 2.51.0