From nobody Thu Apr 2 23:32:20 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D51C53B7763 for ; Thu, 26 Mar 2026 08:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513120; cv=none; b=b7Qv2qXC8ERO+KFIt/tajmBEj+rZZxTUbT6nRysQujYCdO/AAFLLAkRgD1FcR16I41nDQe2rlnh4vZf9nb6SIpOp10bYhgNaOaBzMw+zxlPAIHYosz7KoUGlaajAWYZWQDYWW4An89VMRo+eFBlEz+O3+jIxTRxoPVFbozPKF8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513120; c=relaxed/simple; bh=yMyzaFoknNuQ6pVvN+fu/ld64KkXbgcWoC8dH9PpS/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V/39ELFvZBevmfhvF+JvpQYcUFfpNLNT/XPzDzSGj8F5PLEF/z3j3JOe95+oWjZ/01UtA3FI4jZbnI4+JBIaKNusquYn5jvqbc+0b1+oEgMDPjIrlFOu2ns+7Lcp70qpKAkeSuFGSQ1t+eCRI7EApvxsS6RVLu69qMvCJJSqyGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BTFrkNvZ; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BTFrkNvZ" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so371730f8f.3 for ; Thu, 26 Mar 2026 01:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513117; x=1775117917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=BTFrkNvZKKcg7Hw9HfBC7xlImfhty+zfaWWxesNOY7zgUaRE4Q5OYf2RE7svvVqbl2 nX1Ye0K0wJitNbkAmBOy8nGWQGfWcHAkvRhza4MnaAKGAT2b6n7NIJl1Fz8EaxPEt33w 8zDKz2jhm7Xq+7a3cr11TdjD3kbD3CJxIXW/98UiqEhZFIEHDiuQ7fsT/WsgFKQlSlPf EqcCML1wskhvwqPJX8WkC4XuJ1zLgwbLHzOaaqrYcUbEJOolQr7+SkT2wd8M1SLZgsv1 apShwj/4GZKxw/dAceBkvptcP+orGZZvgpr/2gKp50F9Ku24JjIWuR3jBf9rZcR8bsMa yLQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513117; x=1775117917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=KCYruDH26vwwrNXMxP1apUXcEXqJV3u6zcI6aB9SsbTWdV9uEanrO0rIDpPgMOFHFk mOVeMNicpmrekVbNF1AMDBFXfYmAE4XEEdk7rLmblTTtvmv/QhhDmnfVRr8V7mImz8V0 ai4FYj1nrGlCXVP/X1XmF0tsBtmFzlBlBRfkRwIqHRBRMnGLNgl2OAPYy4PUocBuJp3V yd8kz+NIB8aWBjwmBccMf4SFEdYtkOSiDTaEFG0kyTp476nMbEQ7Fx78wl6XbvbQht4x MKxEqB0O+jRE49SH62MggvPovrFT3Equ6Jnsy5SHQxp7viOts8z70XwKjWdaD7a376je 596g== X-Forwarded-Encrypted: i=1; AJvYcCUPvXV6tWomuMRk0MUNSZo/G1v2bp+RiH1INm+32sV6Q0BMgYuf4C1l6kwqP4BuHEFGvruHY9sFU9Bg+Ps=@vger.kernel.org X-Gm-Message-State: AOJu0YzCN06VR1kvfcooHR9YhrfW+02wZgasrqF+70Q+eA8ECQGS8TCS /1bgDFIYVNVcGR4LtMw31aStwlZDCl84u/B9Z6efhh9GAbqQaQmL3cihk3KPnLS9 X-Gm-Gg: ATEYQzxBompx1ZGDXAb1UuxGRe11siNEU5fWc5ij6Kk5i/xMiRo3zYa+WUrf2WaH2eP 1SkSDvFIDbugH3czaOe8FUA2i170Bv0uUhUSLdmnHqnaaqDemzNCJCA1VRZNMXpRgVJctHUFyFU 3WpucDupFbLGEXj0Oi5fbMd+OeshvVo/TU3ga/4pIwnModPCWyTVUCcxSzy7GzxflSDH7PVmtMT Dr6VR96qGcZr7dA4aB1f8wXOql/JrE8VnQMdFJ1ECmylF+nYCAVelcC9qplDvVWVhUiap8jPbR8 q4cU19BI7yn0eLEcdnMjS6kBgGITdCBFpJJI63pxUZpgkloaxfgzr145evlrU4F2laHqFCDMhw1 l1eH+9vkmReP3rMeeabRgxfPipSJgVGKGT1lV3z+leYtZfLH6zgMOzTV7dsrMgBwKOWVD11gj/8 6nqshnEwacggkbnHLtbaK/9Vk= X-Received: by 2002:a05:6000:4010:b0:43b:50e2:1c9f with SMTP id ffacd0b85a97d-43b88a0d306mr10229176f8f.31.1774513117102; Thu, 26 Mar 2026 01:18:37 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cefd7sm6130521f8f.17.2026.03.26.01.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:36 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 1/4] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Date: Thu, 26 Mar 2026 09:18:25 +0100 Message-ID: <20260326081828.6314-2-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081828.6314-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081828.6314-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_dvobj_init() use direct returns Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..358eac0837cf 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,13 +155,12 @@ static void sdio_deinit(struct dvobj_priv *dvobj) } static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) { - int status =3D _FAIL; struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; =20 dvobj =3D devobj_init(); if (!dvobj) - goto exit; + return NULL; =20 sdio_set_drvdata(func, dvobj); =20 @@ -172,18 +171,14 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio= _func *func) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); - status =3D _SUCCESS; =20 -free_dvobj: - if (status !=3D _SUCCESS && dvobj) { - sdio_set_drvdata(func, NULL); + return dvobj; =20 - devobj_deinit(dvobj); +free_dvobj: + sdio_set_drvdata(func, NULL); + devobj_deinit(dvobj); =20 - dvobj =3D NULL; - } -exit: - return dvobj; + return NULL; } =20 static void sdio_dvobj_deinit(struct sdio_func *func) --=20 2.51.0