From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D51C53B7763 for ; Thu, 26 Mar 2026 08:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513120; cv=none; b=b7Qv2qXC8ERO+KFIt/tajmBEj+rZZxTUbT6nRysQujYCdO/AAFLLAkRgD1FcR16I41nDQe2rlnh4vZf9nb6SIpOp10bYhgNaOaBzMw+zxlPAIHYosz7KoUGlaajAWYZWQDYWW4An89VMRo+eFBlEz+O3+jIxTRxoPVFbozPKF8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513120; c=relaxed/simple; bh=yMyzaFoknNuQ6pVvN+fu/ld64KkXbgcWoC8dH9PpS/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V/39ELFvZBevmfhvF+JvpQYcUFfpNLNT/XPzDzSGj8F5PLEF/z3j3JOe95+oWjZ/01UtA3FI4jZbnI4+JBIaKNusquYn5jvqbc+0b1+oEgMDPjIrlFOu2ns+7Lcp70qpKAkeSuFGSQ1t+eCRI7EApvxsS6RVLu69qMvCJJSqyGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BTFrkNvZ; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BTFrkNvZ" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so371730f8f.3 for ; Thu, 26 Mar 2026 01:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513117; x=1775117917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=BTFrkNvZKKcg7Hw9HfBC7xlImfhty+zfaWWxesNOY7zgUaRE4Q5OYf2RE7svvVqbl2 nX1Ye0K0wJitNbkAmBOy8nGWQGfWcHAkvRhza4MnaAKGAT2b6n7NIJl1Fz8EaxPEt33w 8zDKz2jhm7Xq+7a3cr11TdjD3kbD3CJxIXW/98UiqEhZFIEHDiuQ7fsT/WsgFKQlSlPf EqcCML1wskhvwqPJX8WkC4XuJ1zLgwbLHzOaaqrYcUbEJOolQr7+SkT2wd8M1SLZgsv1 apShwj/4GZKxw/dAceBkvptcP+orGZZvgpr/2gKp50F9Ku24JjIWuR3jBf9rZcR8bsMa yLQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513117; x=1775117917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/CAGNwD5mmaMNu8vFEx34UOd1uzUQMLsBdyRqg3s3DI=; b=KCYruDH26vwwrNXMxP1apUXcEXqJV3u6zcI6aB9SsbTWdV9uEanrO0rIDpPgMOFHFk mOVeMNicpmrekVbNF1AMDBFXfYmAE4XEEdk7rLmblTTtvmv/QhhDmnfVRr8V7mImz8V0 ai4FYj1nrGlCXVP/X1XmF0tsBtmFzlBlBRfkRwIqHRBRMnGLNgl2OAPYy4PUocBuJp3V yd8kz+NIB8aWBjwmBccMf4SFEdYtkOSiDTaEFG0kyTp476nMbEQ7Fx78wl6XbvbQht4x MKxEqB0O+jRE49SH62MggvPovrFT3Equ6Jnsy5SHQxp7viOts8z70XwKjWdaD7a376je 596g== X-Forwarded-Encrypted: i=1; AJvYcCUPvXV6tWomuMRk0MUNSZo/G1v2bp+RiH1INm+32sV6Q0BMgYuf4C1l6kwqP4BuHEFGvruHY9sFU9Bg+Ps=@vger.kernel.org X-Gm-Message-State: AOJu0YzCN06VR1kvfcooHR9YhrfW+02wZgasrqF+70Q+eA8ECQGS8TCS /1bgDFIYVNVcGR4LtMw31aStwlZDCl84u/B9Z6efhh9GAbqQaQmL3cihk3KPnLS9 X-Gm-Gg: ATEYQzxBompx1ZGDXAb1UuxGRe11siNEU5fWc5ij6Kk5i/xMiRo3zYa+WUrf2WaH2eP 1SkSDvFIDbugH3czaOe8FUA2i170Bv0uUhUSLdmnHqnaaqDemzNCJCA1VRZNMXpRgVJctHUFyFU 3WpucDupFbLGEXj0Oi5fbMd+OeshvVo/TU3ga/4pIwnModPCWyTVUCcxSzy7GzxflSDH7PVmtMT Dr6VR96qGcZr7dA4aB1f8wXOql/JrE8VnQMdFJ1ECmylF+nYCAVelcC9qplDvVWVhUiap8jPbR8 q4cU19BI7yn0eLEcdnMjS6kBgGITdCBFpJJI63pxUZpgkloaxfgzr145evlrU4F2laHqFCDMhw1 l1eH+9vkmReP3rMeeabRgxfPipSJgVGKGT1lV3z+leYtZfLH6zgMOzTV7dsrMgBwKOWVD11gj/8 6nqshnEwacggkbnHLtbaK/9Vk= X-Received: by 2002:a05:6000:4010:b0:43b:50e2:1c9f with SMTP id ffacd0b85a97d-43b88a0d306mr10229176f8f.31.1774513117102; Thu, 26 Mar 2026 01:18:37 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cefd7sm6130521f8f.17.2026.03.26.01.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:36 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 1/4] staging: rtl8723bs: use direct returns in sdio_dvobj_init() Date: Thu, 26 Mar 2026 09:18:25 +0100 Message-ID: <20260326081828.6314-2-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081828.6314-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081828.6314-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_dvobj_init() use direct returns Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index d664e254912c..358eac0837cf 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,13 +155,12 @@ static void sdio_deinit(struct dvobj_priv *dvobj) } static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func) { - int status =3D _FAIL; struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; =20 dvobj =3D devobj_init(); if (!dvobj) - goto exit; + return NULL; =20 sdio_set_drvdata(func, dvobj); =20 @@ -172,18 +171,14 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio= _func *func) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); - status =3D _SUCCESS; =20 -free_dvobj: - if (status !=3D _SUCCESS && dvobj) { - sdio_set_drvdata(func, NULL); + return dvobj; =20 - devobj_deinit(dvobj); +free_dvobj: + sdio_set_drvdata(func, NULL); + devobj_deinit(dvobj); =20 - dvobj =3D NULL; - } -exit: - return dvobj; + return NULL; } =20 static void sdio_dvobj_deinit(struct sdio_func *func) --=20 2.51.0 From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDB893A7F48 for ; Thu, 26 Mar 2026 08:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513121; cv=none; b=UuZL0vXKMv1LRShL+8L2C3qQQ0U2mMa6dkh//t/ijPBcOxL2jMxt0Y+oj0wCbrYuGeg7RVlIyqiygcncqn/LYq9Ce9jUFeZ/s2nVIf9ZAmv7G6dhsdJCCSoa3EYW7RxffHCwEKNJJGqAx6luq0kQ78dU9+YPSurGOLw6t1kZPS0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513121; c=relaxed/simple; bh=UoObvnnZRPgdvTgqoymjmAp+D17szqmEHwzVj+aDlXc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UQedEJfadn4tJG61BwaN/pjOceJu5R6y1uCQyS+tcu0e3G5T20c0I8x2cbR2gnW9wEqC1QFwKry2HdUtUKIVm8mx2BgUs3SVT7mZKlq/6mIUDiUgC2QFglu3UIYJPe5mEOUEu/rS68f7Itu51fxB+HmJrJ+hw5hyy7SvsRx0Gs8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O0mJS80g; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O0mJS80g" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43b88b7ca76so483161f8f.3 for ; Thu, 26 Mar 2026 01:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513118; x=1775117918; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=O0mJS80gSRp/BKpyeA+xCSZP0xWkpcUBK7IuAe3trfppT8dHLCxyH+cyRfflcfPLxR yYR/UamaAhyiTFJrUuUtM6z0tRy+0ecefQqra+BpjUBjxchMfq0sJ+kT3nIw3UkB6tYi hQ2Odab1oJs90vj+unmbHKIgt2Xy4pE6kZw0s//fHn+KKelPx3tImz+Gv91eG5VNR8xB DtYSo3vUfrfW9PJtmjbLgVgru7NCG9sbtmffH616bfsIobOOu4orxlYBEDYbUugOFhq/ nsb7ccBVjRZslYPokwqt9RH39ri/4ntuSs8m0hfz0U/N55QYHpwZIS19/k1MgDG+Eq+q XG8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513118; x=1775117918; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QxfMVpIjXpWEhI2DEdBaY44M11aQ1DT160hMDVvL9os=; b=LjyilTdDmKP3ZyY3BYzqzh+ky6tzQfIC+Xtfd2Y7Oq6K+rHWO8W2f+zBNcRtUiK1GE zfVWph9GIlcVzIORGojjoHdIO6O9RteMw0LoPxQPMP0YN+EBFoUESFVa/SFjQgT+Y4Ox wAs1miYaoYz6cDe7ozgEd21kfuPEDX5NS6XbeaVkkJnkaCv8/Q3mLoAH7mBa9iXzwl6W C2vNz9bRvJwNCV7jAAtP+n7iTvPcvvkYvd+iZWIrXjLvlPbGvAcR2gYdEBZscr/0vMu0 hLkhJUE4My+JboCpfTO6TwKhK6FVmYD0ASnAvNk9i+/IhZ7lKjk5M23TAcTD48D9So+J xg5A== X-Forwarded-Encrypted: i=1; AJvYcCUzjG8bfRA0s0octRsYQd+iVWf/uGBYSpI8iij5M5lgvmiL2bnbZvj3WMO79JeUOf/vx+7hj3bsBvAbu+c=@vger.kernel.org X-Gm-Message-State: AOJu0YzoZbeN4rAVDh1EFM/kTnKn3NlVRpP4zKrL6qS1udAU3JWA4hOf yKXhI9hTjs4YH97MnQITMrKNZyI5sQS4tK3Bb8aaY0GXPFMgsCfrkoVB X-Gm-Gg: ATEYQzxzIdL6r2kwLQVWPbQmbp0M51dmzUswiUBy2k9SZnw/Jv6vb2kvV55r0A8avO/ 8F0M+ILNfn1hu5nL593PwK5K0mSjpUrN80SFdpSh2EHU+cuOiUWuE0RZH6RIZvn0Tlz++n4xt0c uuGVe8p/1FH/bQon8p3kKB7YEq+ylk7RTJfvNRLAH4JXHH2KZ77AAVmJ8IGhCVqZllgh4v/uleI NHOpbTLnYzGQ2a+wNzVXJHb7GaGk3LpUxkrmNoLOp8gy2LN4xOhUEjMpob1HdgPF6dPNtOvoY9H qI+hfYtMl3J1UKQzg+GnIsYUYILkcXO0xFftUPxHM89f7Iklt8p3GaXxQGwUBOx0eNsuAL+y5vm mwYlvip9HAXGt7H6b5OjKGRKdMgpzfxovRKmEgVmtkQA3NFI5KBPJvV9V2lAZT156TLjHNwWrKN WW8q6Cbhq+7pqnFDWg12bZ1+8= X-Received: by 2002:a05:6000:40c7:b0:43b:4e13:221f with SMTP id ffacd0b85a97d-43b88a0ce95mr9170200f8f.47.1774513118252; Thu, 26 Mar 2026 01:18:38 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cefd7sm6130521f8f.17.2026.03.26.01.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:37 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 2/4] staging: rtl8723bs: cleanup return in sdio_init() Date: Thu, 26 Mar 2026 09:18:26 +0100 Message-ID: <20260326081828.6314-3-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081828.6314-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081828.6314-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sdio_init() return errno from sdio_enable_func or sdio_set_block_size instead of _SUCCESS/_FAIL vendor-defined macros. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 358eac0837cf..01b5d8a70072 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -131,9 +131,7 @@ static u32 sdio_init(struct dvobj_priv *dvobj) release: sdio_release_host(func); =20 - if (err) - return _FAIL; - return _SUCCESS; + return err; } =20 static void sdio_deinit(struct dvobj_priv *dvobj) --=20 2.51.0 From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C61E3B8D58 for ; Thu, 26 Mar 2026 08:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513123; cv=none; b=fA7NO38wA1r199kenH8Vtw0wvDrf5YCMesGD/H1P0a62Avw7gcGdF9cFwf+e2XyCXNcy7O9xFt21pS/tPdO/Z2OYAjfFiUGOA127OmFIy9VVQhshM8jp1s5pp9zYpvaU3mmAy/KHwNrMuDx5gc64f3jMhlO08lh4qyJgbdPl+CQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513123; c=relaxed/simple; bh=Bd/5OfzV7Sarf3QWBs7/bSDFPUaIF5mzDS/I9XfZQvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pCvD5U0Rkg62llDwJ+1iTIKNlSMUH2Cc7yfW+L4pyYjDXseJ2pwSB2tVPgclzHcVOuJtV7oQbBtdNOfs04wUS4MUrGCn0E9yRWnj1TueRi7KMzV9Cs+rgRyB0AZ6NKdVBVdOVbT/OLSz3jh9Jqg4uoDAQvZDYA4UbEsRY5lrEos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RxnPxqDC; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RxnPxqDC" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so371777f8f.3 for ; Thu, 26 Mar 2026 01:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513120; x=1775117920; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=RxnPxqDCDm8ijksfcyZ/NeBXmGlfZEwc+nktymjYVUHwlD5ZFZY33W//powvzo1giS g2h/oQYl3a1MFT6bWFr/cBA5Jr1l4EqQJBb9wo4wCSZWtMwawhZTGjixeZZM/lC6Gq+a O5IFtGOUmE3uCaEr6j8MeFAzO7ttHXJpAfybefJ3Z0Rm1Pa7Sy3WNa5COvLKVwsy0Wdw d61+gVuNFiJoSDX0jqcbGZGK5AY5IjFyCBnNRS3PkptuVX1R5kbCsBRYSCnBmL84TDVn /nYeydxQGtnyJcD0I3m+zEQ2xmJyi912RSy2Zr5EGZ74j97aiCIfTOm/GtLuxyDLBSQP ohlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513120; x=1775117920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eXqWD/J7jCnsXdMGUm54CWym6mF6LX/bj6037DcUiaU=; b=suwTHSqUkjMjOeqcn44w2Ja78QlhvDnlFkVwboaqCz3LoVtBl9emvgrrgoMyUFm2SA fMt9H/R1zrLbgGOT/nuhz4xAto9Qdwkfr7KKFRY7BWbcRJw8pe1zN5kK0TvUVOkd8Zxg fAQmQuPY0npnt7fqUUNJ4vfYFkMrzMWnyGzsrfaKgX9pXoic96BBJYR5KqX5yiUl1Kqg nedIg6udTZ+evNxkbO07CqMrBsmSEDVZEwNQguHExthR1+c3f742ZZ8Ak3lIc6NjGXA7 w1wFUth309vuj61C491xMAmLcBJ9X5Whm2A+d3Rdz2vt1LtG0L0jQOIG/1R1nKBDmMVy 3CZA== X-Forwarded-Encrypted: i=1; AJvYcCXFNdTgpRTm0RHwXEUvLxV4j47GtAcGxUoqykJLY/fMSz6NiaOWZNr+Of1b1SFwTfltVRiGQVnzPJ280I0=@vger.kernel.org X-Gm-Message-State: AOJu0YzcPE01P6PaI0eXArV7TknhiOgWjfr8P17+E/jBL2wVaNv++a64 UfHirQ1C+yskC7k0N+061QTjCIM853pqgGEsU+QaAJYNjIeYsL/KiuVq X-Gm-Gg: ATEYQzx/4EbANZt31SPOOHtGfbKe8T6AATRl94lnT4IZVyM5fSu06Voe0ceVmA+xVtv C6W/ID/WHWyyZnszlm+kCVIymClg0340Zoo80phClvxmjV5Co3/rLSWWX5OhKxg5xyFwyb57P9B IBURUzTWfYkMtwjztvbIBVgpl8tLehUiDmbPQ4Wls+CNUDMXPjh83s5VfUQeBSnnYgNmsFeyHOV FauXsiY+IGu/iEhemFcm428oDhK1DNavAhLSmuv+SD8l1SdS+pP87XLwA4V4jIPt3iTqb2c+fp4 7iitAXcCjiuCS2nnHBfDZQmduxwjCJCZJtjV4Mz4X33kpvqGPAl+I8V0wJVpQfeaySIcv6B9fJZ KJoSdePN0Ctl3nBSoCsW8Ba+vDYep0CW7XSetDk20Nv4igE1/SYNQOZLwDq5/ILfISiSACfv25o 0FO7Tr3JKxo4/9goIG2HEyNYo= X-Received: by 2002:a05:6000:4285:b0:43b:4136:1e76 with SMTP id ffacd0b85a97d-43b88a0d2camr10029074f8f.29.1774513119440; Thu, 26 Mar 2026 01:18:39 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cefd7sm6130521f8f.17.2026.03.26.01.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:38 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 3/4] staging: rtl8723bs: clean up callees for sdio_init function Date: Thu, 26 Mar 2026 09:18:27 +0100 Message-ID: <20260326081828.6314-4-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081828.6314-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081828.6314-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Let rtw_resume_process_normal return errno returned by sdio_init instead of -1. sdio_dvobj_init returns NULL on error so leave that as is. Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 7ba689f2dfc8..e943dcea1a21 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1135,10 +1135,10 @@ static int rtw_resume_process_normal(struct adapter= *padapter) pwrpriv =3D adapter_to_pwrctl(padapter); pmlmepriv =3D &padapter->mlmepriv; /* interface init */ - /* if (sdio_init(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ - if ((padapter->intf_init) && (padapter->intf_init(adapter_to_dvobj(padapt= er)) !=3D _SUCCESS)) { - ret =3D -1; - goto exit; + if (padapter->intf_init) { + ret =3D padapter->intf_init(adapter_to_dvobj(padapter)); + if (ret) + goto exit; } rtw_hal_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) !=3D _SUCCESS) */ --=20 2.51.0 From nobody Thu Apr 2 22:06:52 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C8753B9616 for ; Thu, 26 Mar 2026 08:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513124; cv=none; b=Vp29ovmUpEiaG20cE1A9AqeBD6bnEPBLj3eiQeeTkkeEFEe2vRZvx9ff+EdR2SA/CF8no9PkjEE+wa6nv270VTJ0LxOFIEgIcOVjhF/VXQ9EKWtOPkvFreBuO5/3DdQKn6w6Wqbaj8I5XxNFji+s8A32XCTWjgNu4DwU0K0zxmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513124; c=relaxed/simple; bh=mMeeJuaZNxecKvFROX7Q1UPzFZzGa8Hph6hnSmJw7K0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JeB0iIj5WOm0022x49xXIFwBXKc6u9yfW6B8LrQ6zdQQpw6CsfRWQA0LT7DMaVa1IrIZ6ouPMc7NM64NY5sKzsZl+CezNbS57Dn9L/Gc1KAhAFWlcZjpjJjKgiVqHJt8BlCh9+o8F6l7t89tkU11//onDbju8vSXcgMYACyXAkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qilv/IpQ; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qilv/IpQ" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43b4915161fso571204f8f.2 for ; Thu, 26 Mar 2026 01:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513121; x=1775117921; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l9cHpCwLSJWHYVjnLpxFvTWscwNHAujvygDF0mECPT4=; b=Qilv/IpQxS3z/uWP021MHg3fPLMXuN2Mi308slWUVdifctKkLW3fawWb96fISLDqV/ i+PWV51ln2sXzJm+S3j+T7fqgetTkw3j4kT6h2tDbMeTn2JWTZVfQjbNfjZwLAz1nFpx E30T02xkBifZzrnkLooE2JlcwUbneoOms6DtAgImEZReEWk7NvUNY88aB5s55eXYWTSh r4YEQ4Kkoze5XYHk0ZdqdQfBPgKh/SmabeC+8qjFLyF3x9uj5Ni77afTWKJ9WIKv0jbM 3iG6ro9PxuadBr81EFzQdegX+VpF2ldZn2CGWZyu1fU27HoaCXQObAt9SxjZt9lQy5Kv qnPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513121; x=1775117921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=l9cHpCwLSJWHYVjnLpxFvTWscwNHAujvygDF0mECPT4=; b=QfOIsOqy3bXP5if7ULdBm/67l5qJTlSD1IKwNZZb6XniPk0vWJdEybFJtoBeh4C79i RoxM2LA60N118yqCGI3u+pbMjf7KXGX31PYaBcSo2FJLZtBKSvX9wGAscgbT0zFWAAMN M5wV2Z6THZNfQYCANYnQ/b89LJv0r4vz9BXwaKLYfoU6NKGsiWQzlojdqV/agf5fp4O+ OR3l8hDbJUKoS7adt0rXDjW3eGTAHyGKgqip9+MQxG7946mh4TaftIInDSPJ0cSuInj8 jAOx6WP+JtBU3AREr6qKcJy+PfXpaS1Xm6zzypb/pB/myLassLRqBxSIYSLVn08QP8nX oR4A== X-Forwarded-Encrypted: i=1; AJvYcCVg2HkysITZLt4RL7O5JBLDXQCXhol47DSltaEBasj2OZrkRBT4sLbkFW8CHGhxuz+mSS2C1yAlAsaqnXo=@vger.kernel.org X-Gm-Message-State: AOJu0YyzRY8kD4uJgHD8MIEgnho0gaI2bcVylW4ueyiDkA03Qdcnr6n3 PdaYxCmopTDDf/x/SZBHq4Rz1drVlYPCZhIxqUw63O0s8KOIZPM6xYeSXQBgi833 X-Gm-Gg: ATEYQzw1Rp6U1dJfofUE63NiuMzP1cishjOMsuiXvnaELlYZfaW+9/NJyFvc0XJIki6 6fBgbxlgWf3ooa8omqEPri/yx5x/4qxDJb1W4h/h3jH2HU3flp27LII6hutID0GP2H0I6c3xnAR Pzi50lziRqeUd3Dq8ACBj6ZuqGdosu584b3PPpxM6IKxXyIR9dP10y4dmmYAOStNduIbgc3z3pj SllbZ3zJX3WWyDvS+dG7Le+cS4/bmU75aKMbtUASmQOziD9Wgm4ezOdZWMmIHwAU2e0HQ91T2fL fmn6NVsHbXmAzgJR/x7hehl+Al/5qgh9OThVGgRjE14QktQE+HsfSLipX7NLr9KTRNJ6pQMFDsM 1JpztLtGNBP94ng1WMivb4/wlFQtOqxxUM2Mf+/nP3NXcBsLEB5d4fHHGo8Cl+0X6dzMdEaUOPu u22uyutZBo1RJMKVhaBZJcxSQ= X-Received: by 2002:a5d:5f92:0:b0:43b:47bc:c147 with SMTP id ffacd0b85a97d-43b88a1d79emr9378781f8f.45.1774513120739; Thu, 26 Mar 2026 01:18:40 -0700 (PDT) Received: from potato ([31.176.167.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919cefd7sm6130521f8f.17.2026.03.26.01.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:40 -0700 (PDT) From: Omer El Idrissi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Omer El Idrissi Subject: [PATCH v3 4/4] staging: rtl8723bs: Choose slightly more readable error check Date: Thu, 26 Mar 2026 09:18:28 +0100 Message-ID: <20260326081828.6314-5-omer.e.idrissi@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260326081828.6314-1-omer.e.idrissi@gmail.com> References: <20260324220453.47406-1-omer.e.idrissi@gmail.com> <20260326081828.6314-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Let sdio_dvobj_init use a slightly more readable and conventional error check for sdio_init(). Signed-off-by: Omer El Idrissi --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index 01b5d8a70072..d0feb28b7043 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -155,6 +155,7 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_f= unc *func) { struct dvobj_priv *dvobj =3D NULL; struct sdio_data *psdio; + int ret; =20 dvobj =3D devobj_init(); if (!dvobj) @@ -165,7 +166,8 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_f= unc *func) psdio =3D &dvobj->intf_data; psdio->func =3D func; =20 - if (sdio_init(dvobj) !=3D _SUCCESS) + ret =3D sdio_init(dvobj); + if (ret) goto free_dvobj; =20 rtw_reset_continual_io_error(dvobj); --=20 2.51.0