From nobody Thu Apr 2 22:21:33 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F2293AE6ED for ; Thu, 26 Mar 2026 08:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513106; cv=none; b=bekw+/QWp/AfzzoNeOEtYfgiYuvf+8y9wu0oXCwVbdoke+PxUOw+YjmDHcYYj3UFg1oNP2HqlKVamTm4EZSWZs48e+lw88AVsXtTJUruG/rT1r13a66WJIFji5W1SHVFnhSHgy7B/3nh6k44OxGdCGTirqi/86d3aSbR2yXvaeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513106; c=relaxed/simple; bh=yqSb+xj+j+Zsm33QL0jScZhrcDvdKz/PHFkslCX+jao=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=o3GQtFUUiGkZyGsNzQAsIVW9CaFpUAvgwSAOADS6gwcjxrtxkJVZazXJ5nEaV74l3nmo+HVNnlsw650GIaC47KUrD02WUnAFm1vUhUhLaZDzYRTLKCJJ/JGafav0JWfb9hpPWhIhvk8yMirXV1lseYYv2Xyu+ZkbNnuoNPdsdO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RsS0iZy8; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RsS0iZy8" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c757a9251faso327505a12.1 for ; Thu, 26 Mar 2026 01:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513105; x=1775117905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WI8mxu0XOiC3NdF7Tl4p8eKdsZm/Gey97Qxo+LUKP1k=; b=RsS0iZy8iVY4TbC6XYaDvc6hIvYsZX14r0c3isU1FKcBfFJGLywR1dKcFUBKYvNoB4 kfHL/5B9CJXL8/5ubepQ5BkbXNp+m+s9GXtf9SnNaGhthqe6rDdRlk10NZ7XS30diXHm ydPoA6rO0aYtN10n5rhLwDR7LOC3Ouas3omqqplxp9JC9K2uNfJJs27hUenvvJKiXSyM dnddtcMLVF1Nno44Nj+gdnWqFj+6M74YIM7EYHaqHlB1I1Xe5g14RQJOTyOfX7oN5Jkt PzC1pa43sxTIztdtd9j4tT+bI2VP2/geCAne2OdzzcWz8B+uRD8C5NJ4krhDr/Nn0VSw h8zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513105; x=1775117905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WI8mxu0XOiC3NdF7Tl4p8eKdsZm/Gey97Qxo+LUKP1k=; b=hL3n1v6623digtSBosF/F0WfdFiONtIptBl9zlrl2wdI+Q2WhcPn3PGE2kloeKSH/N GSrwUv7eeHAT0Ff1wMnNin1IOy22v9Jc3o9efJRm0HyMjElSuk1N7c9WiHIIVQtyTljs 9I9ZMLdTHjJ0T95VIC+qhN6UVOofaxopyW9oQkYC8M09C1Q9+Eyku1Luo3LIbeQ+hq+O MdCdjS0x14N6NAY2Bd+PU1ju3zTg9ZfizCmLjk7UIwihSPBI7InpotHr2m68cv1aYruj Np4REIaa53ypWCUZxJToZbJslPItK7vpyzd9GwLSDvj5WWZKiFQeEO5XgcQshI6bLLig kfiQ== X-Forwarded-Encrypted: i=1; AJvYcCVnluYHppc+Moo13N+1fbvirk+r2k85LF3L3mn1KAlWpEK7091XJBbYzoJTQTrrQqDwILYboPGUXOfOa+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzrvhivhjLRSsIElde3bKFK6+VG94Ci6pXxE2JyyRVBHtcgEvPa r0fdkLpz7og+eb/JBkf7qtIrkAf9sCvEaOGaFNZ93zWGQDCHo6tD36Sy X-Gm-Gg: ATEYQzxvBA7uA65Ib0CPVJeU6072Mss4g+7ShxDS/ykNW4UAmp5ohAkECdln5OMeKj7 GMAXIAMZ7ihOr10XN3WwSmopIEHikje/EXu5pS+rirmaoEwrJbzWSkilvU5U5iYEHf2EvlWNG3p 0E1P/Dn4XH8UCoJErMn5xT06InL7AVKWK+7XzMenl1A3Wp2m2N3x3bUUsAfFWjpaKYeb1oRhvNM 1N0Yo2f+CNdwR+sn7oX2mIGeFc9geB94JcneTSYQxmSHIdRejIz37Y+MX+z1syd8r7ijVGR+YAB MvCnCE5mdqxQL0N9W+8ffn4qfImdZpCktTWahY9BrxQrnEo0g2LZmHzwtnfSkbkuqM1bkTlFuvo qZzdoCJQVTwK/sdicSe4zWHk8LyDYGT4DvSx7WiWn/+0bvpsJSnS5mAGTLaSMo8MELlegggtn4/ 02q9LU4cWbKQMQce8O3OrBJEw2DSKKhw7rqUV2TQAql3soSsWY X-Received: by 2002:a17:903:1b4f:b0:2ae:ba41:60 with SMTP id d9443c01a7336-2b0b09a7986mr78614015ad.1.1774513104641; Thu, 26 Mar 2026 01:18:24 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc87e6cfsm21855535ad.39.2026.03.26.01.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:24 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v4 1/4] iio: ssp_sensors: cleanup codestyle warning Date: Thu, 26 Mar 2026 13:48:12 +0530 Message-Id: <20260326081815.925373-2-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260326081815.925373-1-sanjayembedded@gmail.com> References: <20260326081815.925373-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Reported by checkpatch: FILE: drivers/iio/common/ssp_sensors/ssp_spi.c WARNING: Prefer __packed over __attribute__((__packed__)) +} __attribute__((__packed__)); Signed-off-by: Sanjay Chitroda --- drivers/iio/common/ssp_sensors/ssp_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 6c81c0385fb5..8c1e15d61db7 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -29,7 +29,7 @@ struct ssp_msg_header { __le16 length; __le16 options; __le32 data; -} __attribute__((__packed__)); +} __packed; =20 struct ssp_msg { u16 length; --=20 2.34.1 From nobody Thu Apr 2 22:21:33 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCD963AF64B for ; Thu, 26 Mar 2026 08:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513110; cv=none; b=FGvCj4CrqUtOeuFyZAJf/F4PBXVtgwl/qbtoncInAAnmq5TRhT7DNaAlXKB4dRxzLOVmuhzbVzbFCO+LbKzj7uTbuaN5c63IFSz/ll10mYdsL5eFcPRvWfYiwsSoCxw0uxpyTN2D1kLlV+xWt1b+trxUZMVrI9ZWOILY4DVHfZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513110; c=relaxed/simple; bh=IrfAI15OeYSzF7o8VJ7lq6QuUQJ761yxN1y3FeGgJ6Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qic4kP61Rbqi86Y4lxYsqbbBJ5BPayPN8r1YZB3d6eC18g3+0Qas8UkZ86FIktyT6nK48SVpKUv3u3fHV5/e1ReUDMLSzlvAgjTwGFywind5ypWjaWs6gN3xRY6OF+b3mu/woEx92czf65B5jVaO5bkhay8an/WC+LyO55ZSaK8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M0u9RzNE; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M0u9RzNE" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c736261ee8dso295295a12.1 for ; Thu, 26 Mar 2026 01:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513108; x=1775117908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bWDKafWykqmCst/+PGgYmIJsGhpBN8tnTlfr4qxhHLk=; b=M0u9RzNEBdTSSesIz4846gmCH9MkDTkEpkmDtYya2x/Y8oqH6kFAuLkle0Evp6/TRM SIMZPaJ5qppWDRB0+6v2bqUpa9TctPU4a/VIyTHbEIvv5i+vQXciBiDR/szCw9aPytR2 2pHpqja572Q+PAFRVM//nPreIS+dXuVm3USvqPuwDlZMPYAPmgrh1xrJJQoTnyGiRwRW 1w0PZDMRE7fc3/fSwEEiW7eLuM5lTVjEThZa2X4PP3+fXLLwVqC+oNDM8h20K60+981O xKXNRysXYuKEQ3YZEqmwmpt2bc0VluoH74Ae7lEt+wP0zZmnwra1a9Pc7setKSd0nhh9 ERWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513108; x=1775117908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bWDKafWykqmCst/+PGgYmIJsGhpBN8tnTlfr4qxhHLk=; b=dS2ezkkO4lud3GHwwZT8Pv6lPPwKT5lbnn2COcbDiuh/0r1Z3YHBW5Dzo6ngXfGXNy V2LB8GYUJPs/gYQXKqo2/lcwe/k2cNFCAE3HPkigWrzEvgXmpT7PFT0dlF+4hhZHBeAR izkpV/aje5bOkz5VqUJDPQ1NOAxwJS46JyrhNGpLpJ8gIYFTXj/Or+PoUOvfmxB/6xEJ 1ijN0IZvAsbHxL1IrCImm4NvG+V4wJedAg0ViZionYpJWfumvqDIGxX2vylxVMpIjdo3 4Z5+geO4zTle+JH7qN0Sgc1jgbLuk8xs8D54oxSAk7orULtgti679jPupvSJi3sXH4MR LJzw== X-Forwarded-Encrypted: i=1; AJvYcCVNkW1wovpwylW4aZkAAKqbUpvqJIZTQ0WeB9xg1PIWzV1Dqtm3REnZiJDaaknslIMrvryjZ1j0IQFYcw8=@vger.kernel.org X-Gm-Message-State: AOJu0Yxx6T7MTl8oGjLkWHi9pahqhOEkub/MlZ27y5zHauPufS8ooEub 1fygXkjaJKqmXsEecHho/TI/YieS6NFkaP15O1bxwH8i0ZD9u0QnUZA1 X-Gm-Gg: ATEYQzzFaDC3V/FZtWZpXWcqE1eerlMZqV0k/nxDhREvSNDn2QoqilbCp3szH4+H8Ko 3B/6bYPNkIo7mYlQvJ1BQQ3VNBDJJWy9InQQJ5ro4RQTxJJzBN4l/lub3/+KoCEqurl1NBjWoGE SpbSYqzhJFGwnDC0M5zhYWi+ScTL4ZkfkBecEISfsHijxHFXQ6Ca426iijCAf29W2Jfub6gPCEY VdEA6t+Lf9nq3aho0I5O5wa0Xq1gRMBl31pkgDI/xUNSaTJjp1rE8Vlkol7mH217HIvj6FVPawq ro8PfvlBRGPJ2jvR1sm/k0q2V3Al69pi9MrVQNarfVYhcQbIzzAtsCRWuoAOem+L3Tcx+Pq0Q5s 3QStxt0PjYBltnQ/dUF+IVE+W0QrgnFcaFsmMKYTGIW9Wy2uOQn11vyuahaFHbuw5Fqv3AAn8Dp AinVc1xH9JajLlQd5odUG2JV9o88tgmBKesTNjAfu2CEp7B3IK X-Received: by 2002:a17:902:ebc2:b0:2aa:d5e5:b136 with SMTP id d9443c01a7336-2b0b0af3befmr81291515ad.38.1774513107988; Thu, 26 Mar 2026 01:18:27 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc87e6cfsm21855535ad.39.2026.03.26.01.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:27 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v4 2/4] iio: ssp_sensors: cleanup codestyle check Date: Thu, 26 Mar 2026 13:48:13 +0530 Message-Id: <20260326081815.925373-3-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260326081815.925373-1-sanjayembedded@gmail.com> References: <20260326081815.925373-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Reported by checkpatch: FILE: drivers/iio/common/ssp_sensors/ssp_spi.c CHECK: Macro argument '...' may be better as '(...)' to avoid precedence issues Signed-off-by: Sanjay Chitroda --- drivers/iio/common/ssp_sensors/ssp_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 8c1e15d61db7..08ed92859be0 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -6,7 +6,7 @@ #include "ssp.h" =20 #define SSP_DEV (&data->spi->dev) -#define SSP_GET_MESSAGE_TYPE(data) (data & (3 << SSP_RW)) +#define SSP_GET_MESSAGE_TYPE(data) ((data) & (3 << SSP_RW)) =20 /* * SSP -> AP Instruction @@ -119,9 +119,9 @@ static inline void ssp_get_buffer(struct ssp_msg *m, un= signed int offset, } =20 #define SSP_GET_BUFFER_AT_INDEX(m, index) \ - (m->buffer[SSP_HEADER_SIZE_ALIGNED + index]) + ((m)->buffer[SSP_HEADER_SIZE_ALIGNED + (index)]) #define SSP_SET_BUFFER_AT_INDEX(m, index, val) \ - (m->buffer[SSP_HEADER_SIZE_ALIGNED + index] =3D val) + ((m)->buffer[SSP_HEADER_SIZE_ALIGNED + (index)] =3D val) =20 static void ssp_clean_msg(struct ssp_msg *m) { --=20 2.34.1 From nobody Thu Apr 2 22:21:33 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F5A93B19DB for ; Thu, 26 Mar 2026 08:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513113; cv=none; b=RbGRG7B4YyBTxTsySKWHa6w5Rr6s18+a9MDNLZqbHhoTfCkZ4SSCgFsBYLLnbN//mYxjibvwPyXzpImgap7Lettn997ef8wB9pRzBV5iQPKbCZVzTmbb53HgZS/OOS4IMC3nqtgqU6sDHltECyA78KNvRog3+LeKZwzut0JUHG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513113; c=relaxed/simple; bh=VuTAHHFI+jyiGmHc9+R6vTChQAN82qse0bKmbCb3qO8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=H+M2o8VWeeWh+cFPEs7yU+6rANJSdUtDuwTkrIPDccFyCJ+8M91ke+1iygiY7NMOtnoQLglAi/icmvnJxERDlFT/XAF47o28dpFIFhuqKmS8bunx8C41xzHmBQkQfkU4E2GXhTezEomQ0lsbqRT5kp0XwG1KcfzG/b5ipzIOmas= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LnOuM9O0; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LnOuM9O0" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a871daa98fso5663175ad.1 for ; Thu, 26 Mar 2026 01:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513111; x=1775117911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hW+MdHuk6SjYOPjp4FIdn/7nxTOhIxHKoo7bSolADB0=; b=LnOuM9O0XUGYM29jPfIi+YESXOqFH2C0xRs8NXFGWBT8VQWg4QoVg9XHW5UqZcXnhk anP4/bk9g+TRpzichchPdGaTgts0cTk+62HZ5cpwnIcYIe7IHA71fuNBhbk0jmN7o3RG 8jpDvGxH4CqWqq4EYVtVSIMZfZEgTs7SqhsfPxd6teGs+JCeekda1y662p7TutSsFCRq iLrutTNA1zQAN18rtQdhrC4zKMAGBpPFDdu5fxfDadNeJWpbDcTcc3ZRGxSNd3XlR3+z ecc8Ou4ZQbjLhcdKoyWqfY4V1T9vHm7/vrCazRnLkxvb91s4XMuKExaYtcbo9dOkaCT6 jYcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513111; x=1775117911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hW+MdHuk6SjYOPjp4FIdn/7nxTOhIxHKoo7bSolADB0=; b=cuR4LSF/BWzoahF+bSW0sHh0DvCNfUdT5i53XWiTpx25lLDvnuxHyTXAFClfnUD118 9MvkEH8JxehvlOSKt7WzHNMk7PYQlxbgLZ7HrWy3CEBHkHduAgkgaBY2LBoDZebFMixy Q6p6xoZu8/uNUWPuPTIzNw6ml2BYP3C+H+GNbW2DV/fcCHoZx85xI4APQnLrk3fhocp7 lDnMNuOitXDPgqf6Vj4kJL0nZUL2Sokz60XFjBB+N6OeoN3bzVHYgY5Isl7zQ0gajZYy DHNVxUceMt65nzsiNtQ52f7AA0jc4pEKG9Fh+k+kzVOXkFgjDa5T7ziI4gI7p910B28a WDTg== X-Forwarded-Encrypted: i=1; AJvYcCWuH5JYM/dZsoItI2UHUtPlkybW05OHmaS00JmvxchMgB1/txbn8bJre81SZIQTEihR5OeppgCm/oBsOXQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtfhbcah5tE0WjwM6vgT6qoBvyZzwUhfwxdwXv5wQketHlp+Nz abga8EmAI1cnzbeJ7oAfAeDGi9YWCHjAFIjWRz6z2DeRcqqmLweOjfTC X-Gm-Gg: ATEYQzx+pO3K4FXrTpCQ4JjMxfVd/SxSKjOX01cQ7Yz9hf0VSa9+sD5FSFR0Lzf/V+V K7oTBZiBajU01nzsBkDd5SEGEjAVdisL4N4rKU2tpc0d3421eGNse/YCbrObDL2uAeKh7cG0ydI 8CMF4kANOrZBJwCkerjrYLAbCbgkpA9no4RfAuCKbEd8ADnG12BNR7cnEHBSbWDk9RUp39kLsG6 NidSLQpwhzk/A04zNXShWp3U23q6p2WRnRUe4JGWnx7IPTZT0mY5yEWCu0RsmbQ9hRPpGrnhdBT y0i0+V6FTeoDlN6EOSrXLnsepL6O+qXgkStq/x8CdoZ1VaTFvrgziTbUe6E85KM6QHv+bcyFk88 KKvo+7mImfUPmGQGDtPdXQHCnMWDPRTQMZjMpqSgNPMHtomkq/ZHN9HXfQEgsfPrzb2+vFkMu0h pZ738IkjoqCnOKRutfPyhLFNVv2RxFWkYDp2YmGXSmOlIKrc+k X-Received: by 2002:a17:903:3890:b0:2ae:66c9:494f with SMTP id d9443c01a7336-2b0b09a7b3cmr71052695ad.2.1774513111268; Thu, 26 Mar 2026 01:18:31 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc87e6cfsm21855535ad.39.2026.03.26.01.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:30 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v4 3/4] iio: ssp_sensors: ssp_spi: use guard() to release mutexes Date: Thu, 26 Mar 2026 13:48:14 +0530 Message-Id: <20260326081815.925373-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260326081815.925373-1-sanjayembedded@gmail.com> References: <20260326081815.925373-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Replace explicit mutex_lock() and mutex_unlock() with the guard() macro for cleaner and safer mutex handling. Signed-off-by: Sanjay Chitroda --- Changes in v4: - Use guard() instead of scoped_guard() to avoid additional indentation as scope is same for both APIs and add scope in switch case - Link to v3: https://lore.kernel.org/all/20260315125509.857195-2-sanjayemb= edded@gmail.com/ --- drivers/iio/common/ssp_sensors/ssp_spi.c | 50 ++++++++++-------------- 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 08ed92859be0..61a4e978d9b2 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -189,55 +189,49 @@ static int ssp_do_transfer(struct ssp_data *data, str= uct ssp_msg *msg, =20 msg->done =3D done; =20 - mutex_lock(&data->comm_lock); + guard(mutex)(&data->comm_lock); =20 status =3D ssp_check_lines(data, false); - if (status < 0) - goto _error_locked; + if (status < 0) { + data->timeout_cnt++; + return status; + } =20 status =3D spi_write(data->spi, msg->buffer, SSP_HEADER_SIZE); if (status < 0) { gpiod_set_value_cansleep(data->ap_mcu_gpiod, 1); dev_err(SSP_DEV, "%s spi_write fail\n", __func__); - goto _error_locked; + data->timeout_cnt++; + return status; } =20 if (!use_no_irq) { - mutex_lock(&data->pending_lock); + guard(mutex)(&data->pending_lock); list_add_tail(&msg->list, &data->pending_list); - mutex_unlock(&data->pending_lock); } =20 status =3D ssp_check_lines(data, true); if (status < 0) { if (!use_no_irq) { - mutex_lock(&data->pending_lock); + guard(mutex)(&data->pending_lock); list_del(&msg->list); - mutex_unlock(&data->pending_lock); } - goto _error_locked; + data->timeout_cnt++; + return status; } =20 - mutex_unlock(&data->comm_lock); - if (!use_no_irq && done) if (wait_for_completion_timeout(done, msecs_to_jiffies(timeout)) =3D=3D 0) { - mutex_lock(&data->pending_lock); + guard(mutex)(&data->pending_lock); list_del(&msg->list); - mutex_unlock(&data->pending_lock); =20 data->timeout_cnt++; return -ETIMEDOUT; } =20 return 0; - -_error_locked: - mutex_unlock(&data->comm_lock); - data->timeout_cnt++; - return status; } =20 static inline int ssp_spi_sync_command(struct ssp_data *data, @@ -355,12 +349,12 @@ int ssp_irq_msg(struct ssp_data *data) =20 switch (msg_type) { case SSP_AP2HUB_READ: - case SSP_AP2HUB_WRITE: + case SSP_AP2HUB_WRITE: { /* * this is a small list, a few elements - the packets can be * received with no order */ - mutex_lock(&data->pending_lock); + guard(mutex)(&data->pending_lock); list_for_each_entry_safe(iter, n, &data->pending_list, list) { if (iter->options =3D=3D msg_options) { list_del(&iter->list); @@ -376,10 +370,8 @@ int ssp_irq_msg(struct ssp_data *data) * check but let's handle this */ buffer =3D kmalloc(length, GFP_KERNEL | GFP_DMA); - if (!buffer) { - ret =3D -ENOMEM; - goto _unlock; - } + if (!buffer) + return -ENOMEM; =20 /* got dead packet so it is always an error */ ret =3D spi_read(data->spi, buffer, length); @@ -391,7 +383,7 @@ int ssp_irq_msg(struct ssp_data *data) dev_err(SSP_DEV, "No match error %x\n", msg_options); =20 - goto _unlock; + return ret; } =20 if (msg_type =3D=3D SSP_AP2HUB_READ) @@ -409,16 +401,15 @@ int ssp_irq_msg(struct ssp_data *data) msg->length =3D 1; =20 list_add_tail(&msg->list, &data->pending_list); - goto _unlock; + return ret; } } =20 if (msg->done) if (!completion_done(msg->done)) complete(msg->done); -_unlock: - mutex_unlock(&data->pending_lock); break; + } case SSP_HUB2AP_WRITE: buffer =3D kzalloc(length, GFP_KERNEL | GFP_DMA); if (!buffer) @@ -448,7 +439,7 @@ void ssp_clean_pending_list(struct ssp_data *data) { struct ssp_msg *msg, *n; =20 - mutex_lock(&data->pending_lock); + guard(mutex)(&data->pending_lock); list_for_each_entry_safe(msg, n, &data->pending_list, list) { list_del(&msg->list); =20 @@ -456,7 +447,6 @@ void ssp_clean_pending_list(struct ssp_data *data) if (!completion_done(msg->done)) complete(msg->done); } - mutex_unlock(&data->pending_lock); } =20 int ssp_command(struct ssp_data *data, char command, int arg) --=20 2.34.1 From nobody Thu Apr 2 22:21:33 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D3173B6C07 for ; Thu, 26 Mar 2026 08:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513117; cv=none; b=PXZh4HPOtYzpk7s5juCRi9vXBBvtOTxGEtpJRRQfjfipqJyaqgCaIFTKOTLn+DPFbqp2R1yTH7bfadQRWwhidsCl9A0q5gCjQKTMDD1nzVwGE3NpnM98m+FZCURNuZpr8lXdUj1leZG9ngS7MOllPxUzR3JoIf0NoZ6L2cFOuNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774513117; c=relaxed/simple; bh=03TGsdT9IN22DWIa4T5/yk8qhebU5uz/xxamWSKzVpo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pFovhrJhkGqjhTQVSwbRC3O2BVkdSNETlORM4qYyK0nh8cX7PMINR03wy/+Q1Htx0xoDzt12o6HqsgoHgLcyz5XCfjLjxUYR9WTYJBsq1AnJeC2g83QEpwF0cKrYRa5fpZBGY2S22QACY8CB8OeMREWYUDX4o0cRmfNZ56UdpaY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NaRxx/km; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NaRxx/km" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b04e6a989eso4225485ad.3 for ; Thu, 26 Mar 2026 01:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774513115; x=1775117915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e+be2bfxKoFJe+3GjEg/OypoIWjV3Qxq5fDkIn81zME=; b=NaRxx/kmMkKBnOXXmNWrb3AONvUekpph4voEHXdcNntgbU2KS2q+G6B2k8L/ULfetT PBlXOCAIJv6oX6YUnG5IKo2yYLEG1/bJAXaOOlsPFD5geY84v+6CkTOgqiDvCQnWSORm ZTZArwVlHGCi2KWnZiwcxgpzF8A4zAL7QE47D4argcogLvFMbPyLIijnBQV2FmHwWolh lVdfx97gGdaNDwMKLE2aDGD387gcK0wE+0r6e7BYjTSzGx0tBAXuhuV4AxXbcOhbuOd+ FizBqk19nyLRpoiOoNl7BVeOh7lxNnTw+WekivkrE1Gcic3sVaAhZYzuOdlCENtrECf3 q1gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774513115; x=1775117915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e+be2bfxKoFJe+3GjEg/OypoIWjV3Qxq5fDkIn81zME=; b=BjZkNSsbU4bYFYrvwz/5qWtMR9uJ8EtJYt5b8s1zgKag5TxOGUdnpxmptlUkSuLKTM GSjG39auE6nJJkqVqt8gd4EHTSGVKatWOv9YgU/0SiFaDCeco1byRvKkJXdnHgIU4Ocr MDSvkFppyvge7QZ0ygQtlkxSL8/21Qn+03q9XhiJNMt+Wuhk9ZXtKEUiY3tJsNm8wB3z ck9JpzSpjj7smlr65eldvmJIOG6w2649+LSwRMl2J6ZCtVD1l/aXaJswUXbDD8qgOfc9 s9mwEwoh6e7Z7x/aT3ttJztlQUaH5DVByMag8ZvKMJ9enGAPVkBTmLPj8RNuohQaiPzB S5PA== X-Forwarded-Encrypted: i=1; AJvYcCXdvWVnkkuvFJcgzAJcDp/sF2XbcuXmUs2Y1meMSMsyRZ+XZ7W3xoU3N5XmMWr8igWTfsol9N1d9oCf5iU=@vger.kernel.org X-Gm-Message-State: AOJu0YxmAdNiSQX0nDPn8z4IVrpT/YM4mCdC9bp7xY7TGAwvQXQXdg8T kKO6ZBJ32NUF/OeOgQ8ByPBqx70elOqJn1LKpeJtoYphgv/NtS/6VGL7 X-Gm-Gg: ATEYQzzivnW9Y+8NkpBAppQdtUEp7bG4G44YrnTnuESOll7FTiRxXqhL+k0hM/2CwcB 312qik0LWmTCJ9D9WDdC83q2Drtc79RDzIb5Mr6sNqQo6baov2eeFuEK/+KiQ10cRzYbxHOBXyJ qRONRpffqQ36IVymwu8YuXTR8wsqmxXqnelnZAfBiZ+5VWorst11RJ8ys+tUsuk+cwC0bJA1kg4 w7Ro0uj1jcpDhKlZB2NB/xW/DeXZRMQJss6jlD3gaQFPunQZaooJh8ZYrQxevleIRR5v6VOouUc iWhMYG8I6b9k1mT0duYP3gixyNi7jQc79vmoP5JTBdP4LajM2VtaFr1E32NEtFqeerDDqUndohk wX4orkgAYA47iLSrJqfHSg++NvCOOWMgtRgaIFrHFEiDXPbTP/+EDL6/X2erIz+LZX+rmZuSs6+ btPrFQyskrfVFPx+ZVGw5N+OUPF3x9mwPpaqzGA7dw1Bj6v8kaPpDAxtV7S6A= X-Received: by 2002:a17:903:1aac:b0:2ae:5797:e082 with SMTP id d9443c01a7336-2b0b0a758ffmr78266915ad.24.1774513114611; Thu, 26 Mar 2026 01:18:34 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc87e6cfsm21855535ad.39.2026.03.26.01.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 01:18:34 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v4 4/4] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers Date: Thu, 26 Mar 2026 13:48:15 +0530 Message-Id: <20260326081815.925373-5-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260326081815.925373-1-sanjayembedded@gmail.com> References: <20260326081815.925373-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Avoid allocating a temporary DMA buffer in the interrupt context when handling hub-to-AP and AP-to-hub SPI write messages. Preallocate RX buffer during probe and reuse it for SPI receive operations. This removes repeated kzalloc() calls from the IRQ path, reduces allocation overhead, and avoids potential allocation failures under memory pressure. The RX buffer size is tracked and allocated using devm_kzalloc(), ensuring proper lifetime management tied to the device. No functional change intended; this is an internal optimization and robustness improvement. Signed-off-by: Sanjay Chitroda --- Changes in v4: - Use preallocated buffer and stash a buffer that gets reused each time ins= tead of a fresh allocation. - Link to v3: https://lore.kernel.org/all/20260315125509.857195-3-sanjayemb= edded@gmail.com/ Changes in v3: - prepare series to have all respective cleanup API support for the ssp_sen= sors following input from Andy Shevchenko - Link to v2 https://lore.kernel.org/all/20260311174151.3441429-1-sanjayemb= edded@gmail.com/ Changes in v2: - split series to individual patch - address review comment from Andy Shevchenko - Link to v1 https://lore.kernel.org/all/20260310200513.2162018-3-sanjayemb= edded@gmail.com/ --- drivers/iio/common/ssp_sensors/ssp.h | 5 +++++ drivers/iio/common/ssp_sensors/ssp_dev.c | 11 +++++++++++ drivers/iio/common/ssp_sensors/ssp_spi.c | 17 +++-------------- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp.h b/drivers/iio/common/ssp_= sensors/ssp.h index f649cdecc277..aa125fd1bed5 100644 --- a/drivers/iio/common/ssp_sensors/ssp.h +++ b/drivers/iio/common/ssp_sensors/ssp.h @@ -175,6 +175,8 @@ struct ssp_sensorhub_info { * @sensor_devs: registered IIO devices table * @enable_refcount: enable reference count for wdt (watchdog timer) * @header_buffer: cache aligned buffer for packet header + * @rx_buf: buffer to receive SPI data + * @rx_buf_size: allocated size of rx_buf */ struct ssp_data { struct spi_device *spi; @@ -222,6 +224,9 @@ struct ssp_data { atomic_t enable_refcount; =20 __le16 header_buffer[SSP_HEADER_BUFFER_SIZE / sizeof(__le16)] __aligned(I= IO_DMA_MINALIGN); + + u8 *rx_buf; + size_t rx_buf_size; }; =20 void ssp_clean_pending_list(struct ssp_data *data); diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/= ssp_sensors/ssp_dev.c index da09c9f3ceb6..35e07132c4a1 100644 --- a/drivers/iio/common/ssp_sensors/ssp_dev.c +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c @@ -512,6 +512,17 @@ static int ssp_probe(struct spi_device *spi) =20 mutex_init(&data->comm_lock); =20 + data->rx_buf_size =3D SSP_DATA_PACKET_SIZE; + data->rx_buf =3D devm_kzalloc(&spi->dev, + data->rx_buf_size, + GFP_KERNEL | GFP_DMA); + + if (!data->rx_buf) { + dev_err(&spi->dev, + "Failed to allocate memory for rx_buf\n"); + return -ENOMEM; + } + for (i =3D 0; i < SSP_SENSOR_MAX; ++i) { data->delay_buf[i] =3D SSP_DEFAULT_POLLING_DELAY; data->batch_latency_buf[i] =3D 0; diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 61a4e978d9b2..08cf31fe9dd4 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -369,17 +369,13 @@ int ssp_irq_msg(struct ssp_data *data) * but the slave should not send such ones - it is to * check but let's handle this */ - buffer =3D kmalloc(length, GFP_KERNEL | GFP_DMA); - if (!buffer) - return -ENOMEM; + buffer =3D data->rx_buf; =20 /* got dead packet so it is always an error */ ret =3D spi_read(data->spi, buffer, length); if (ret >=3D 0) ret =3D -EPROTO; =20 - kfree(buffer); - dev_err(SSP_DEV, "No match error %x\n", msg_options); =20 @@ -411,22 +407,15 @@ int ssp_irq_msg(struct ssp_data *data) break; } case SSP_HUB2AP_WRITE: - buffer =3D kzalloc(length, GFP_KERNEL | GFP_DMA); - if (!buffer) - return -ENOMEM; + buffer =3D data->rx_buf; =20 ret =3D spi_read(data->spi, buffer, length); if (ret < 0) { dev_err(SSP_DEV, "spi read fail\n"); - kfree(buffer); break; } =20 - ret =3D ssp_parse_dataframe(data, buffer, length); - - kfree(buffer); - break; - + return ssp_parse_dataframe(data, buffer, length); default: dev_err(SSP_DEV, "unknown msg type\n"); return -EPROTO; --=20 2.34.1