From nobody Thu Apr 2 22:23:02 2026 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2703D34EF15 for ; Thu, 26 Mar 2026 05:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774502947; cv=none; b=GmKhxbI/Yq3bb2guksVIEY+Uxn3ms54IXGn/tGTP+LB0rx/fBDsHzG7eTVXPoVbhWLcglyw76FEj6w8G4ApJhggZqdcX9J96IGVfD6Frw/c+43BDWrjRCBrOhitKodWtY1l7bnSllCUzFVdVKwfoltX6e/foAhmA/A0ourAAImw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774502947; c=relaxed/simple; bh=secipyXIFe5nKwWxQDiFSflV2qpjNZ5UEC68A4oj4Ik=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N9CAKZztQ5FW1l8PGwQcaivN1NbCWmkQFqcgoi75+lrgAkuI0Z0Asa4LWUoHwBfXvDk1t0pMPyQuphSu4tkIrrNbkLqKqG9JtARi6yPpxc0zXif6unze3qs7vh2u2MvveprP1dTz7M08gyM+T5M6XclAp3PwPM4kOnlCd1OrNFo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p6bZ2JnX; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p6bZ2JnX" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-1279eced0b9so763013c88.0 for ; Wed, 25 Mar 2026 22:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774502945; x=1775107745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+vj6+CrB7XzZSSoo0WZkVvcXGudvkrxFD+q5udVvUfM=; b=p6bZ2JnXNd4sm6qbImZEFNPmdgt66hyqPEyJeXFTyU4Co453P3A6RG4DJPqbpeQhll erdbi5Bjz9cKF7xCs549PhIMuugTPZ2zWAEFrH/NyoFXGbeQkhawfsRBAG8Gqd7WJ7ty 0QS8L4pK9MTUBBSW2zvBQMtt6sxSdiQKkhZHrMCK8fA9gzcu6NG75SdPKPgU3eeAD4kG E9Kfhn9WRiIuuy1gOv4RUtMN22R+yn1wKa8Lh7qKNb79v1HR8RmV1xiOC+6JUA6W8m5V LeSZbehPnMDa/HtyASPf89d+o+3snYH319+ODoxKiMxzjNQtbIVzlRj7w3OfPKCvKgxs TfNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774502945; x=1775107745; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+vj6+CrB7XzZSSoo0WZkVvcXGudvkrxFD+q5udVvUfM=; b=mqTVKNy9czK/P1NX0aeF5r70UlLyRP25snXabq5ar6st/i2km0ncGo3Zjk/QREvvcB ALU1pROev7slDxFr9oDUKzZEYV1+XSChN88uyRsbLpZRtAMGoXeKFLj9xYsiC+yJSlyN jJ78R/RMP60HmZxjr1W/wXadDss0VbvIxGTeR7h2yrFrQtL+JQqOX3fKM/ZaJY6j3Jep 3X9FdEerxbr0o+sD7TGmuRVvZIKqtqlX5ommeOi+PLCE/MbUU3MzPIdJvSNVKoP5CRgs Tp+Mo2BV/rQX1Poccizv3ly1HX3JTko5bZ5n3RTaLwF0J1gpEj5os02HEB7u8u6SQpK1 f3Mg== X-Forwarded-Encrypted: i=1; AJvYcCUe5vgNKByG4H6W17lQKVC6N4w/FWM1ApaXo0PyJSH88lTBBJMmWGg7Iv0iqoXi4WT1toO8iLhK6b8T8ns=@vger.kernel.org X-Gm-Message-State: AOJu0Yxmx/aDrTUaw+n//ITUFlZBZdweXb1qqdMXxQYL5p6Alu616f2t hv+uXU/VuBkijxhX0N5ZQASlAb77jyAzhpq/UPW73RBc0CKNLx+R1j9Q X-Gm-Gg: ATEYQzzDd+Y6wVqn+lDRanFxEJ7qlYHzz6nrDtMy34wcgAI+OJR599b4etf41XWg7Hs rCpTUMFyz62lxK6c/K+MSntKfmd/AV2ncGnJiDGdRVdQscT6sI6DW7lmHlHR4UeMsD5J0vNh/UI aQATIBqEb95RYvNMVSi99VITUFZV1XgkH3tjMVdXvyAlERBFONwagd1RFtYxHEE4Ojt7N4EcxC9 tkwHl6UTbFCjJCE8cDG1r87LsZOxLJgRlZ2wEmoyjQ3aNUbsx+M1svl789c11AOxtNoYvSmP9sr TWkXH6C/TVd8R3BU5uGmUJktf2r0rUZFbz0oEHEUpasSlHcjz4uFN9YGsHRNZkQ3U37UfrbBpxS HX2K3MkF6i/yFY07Kyuin9Jp+Ggs/DbA2grwjd/QG26AhneccNig2xjaP8VQ9I30DzFxKr1gJO0 GAqBtBUZgXDl3RWC7n7PMiLUoXUkt/GnX5uYlGMvlfI7KMtCxUzrYG5Gs= X-Received: by 2002:a05:7022:ec86:b0:128:bae0:e044 with SMTP id a92af1059eb24-12a96ee7565mr3175255c88.30.1774502945123; Wed, 25 Mar 2026 22:29:05 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d::8bd]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa78462fesm3013681c88.15.2026.03.25.22.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 22:29:04 -0700 (PDT) From: Rosen Penev To: linux-clk@vger.kernel.org Cc: Chanwoo Choi , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Kees Cook , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org (open list:MAXIM PMIC AND MUIC DRIVERS FOR EXYNOS BASED BO...), linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not covered by other areas):Keyword:\b__counted_by(_le|_be)?\b) Subject: [PATCH] clk: clk-max77686: kzalloc + kcalloc to kzalloc Date: Wed, 25 Mar 2026 22:28:47 -0700 Message-ID: <20260326052847.335089-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify allocation by using a flexible array member to combine allocations. Use struct_size to calculate size properly. Use __counted_by to get extra runtime analysis. Assign counting variable right after allocation as required by __counted_by. Signed-off-by: Rosen Penev Reviewed-by: Brian Masney --- drivers/clk/clk-max77686.c | 32 +++++++++++++------------------- 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c index 3727d5472450..9149ce4f702d 100644 --- a/drivers/clk/clk-max77686.c +++ b/drivers/clk/clk-max77686.c @@ -47,8 +47,8 @@ struct max77686_clk_init_data { =20 struct max77686_clk_driver_data { enum max77686_chip_name chip; - struct max77686_clk_init_data *max_clk_data; size_t num_clks; + struct max77686_clk_init_data max_clk_data[] __counted_by(num_clks); }; =20 static const struct @@ -168,19 +168,7 @@ static int max77686_clk_probe(struct platform_device *= pdev) struct regmap *regmap; int i, ret, num_clks; =20 - drv_data =3D devm_kzalloc(dev, sizeof(*drv_data), GFP_KERNEL); - if (!drv_data) - return -ENOMEM; - - regmap =3D dev_get_regmap(parent, NULL); - if (!regmap) { - dev_err(dev, "Failed to get rtc regmap\n"); - return -ENODEV; - } - - drv_data->chip =3D id->driver_data; - - switch (drv_data->chip) { + switch (id->driver_data) { case CHIP_MAX77686: num_clks =3D MAX77686_CLKS_NUM; hw_clks =3D max77686_hw_clks_info; @@ -201,13 +189,19 @@ static int max77686_clk_probe(struct platform_device = *pdev) return -EINVAL; } =20 - drv_data->num_clks =3D num_clks; - drv_data->max_clk_data =3D devm_kcalloc(dev, num_clks, - sizeof(*drv_data->max_clk_data), - GFP_KERNEL); - if (!drv_data->max_clk_data) + drv_data =3D devm_kzalloc(dev, struct_size(drv_data, max_clk_data, num_cl= ks), GFP_KERNEL); + if (!drv_data) return -ENOMEM; =20 + drv_data->num_clks =3D num_clks; + drv_data->chip =3D id->driver_data; + + regmap =3D dev_get_regmap(parent, NULL); + if (!regmap) { + dev_err(dev, "Failed to get rtc regmap\n"); + return -ENODEV; + } + for (i =3D 0; i < num_clks; i++) { struct max77686_clk_init_data *max_clk_data; const char *clk_name; --=20 2.53.0