From nobody Fri Apr 3 01:28:26 2026 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754FE39C634 for ; Thu, 26 Mar 2026 04:26:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774499194; cv=none; b=ho9ppee+5uCwpfOvR26ufBqiDsUrkvIP+Ho9ri8YSfjhkJ0YNl1nNKYMinqYDZtL4i+0/aJ4NdxSExPThWntIphCpJcrYw2zMfSsi47grNBU/yvif6SRdVRgVKHMXg51pfTa/Zl4cdUXYzlnsglCrw9kYsV32SEIx5qV+silRnY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774499194; c=relaxed/simple; bh=0ceBGG1xWqRMKTwBp+756nABE5mwIRW71phJJkYD/MY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W6w3xoX2pYVvllJ68XLB2FzhjGOy8C3rDL60uxRCwCIadmvCRZkp0mwxtGb83ef75MuCNmv3BQwrlZ3s6GocUMw0QLJfqK8duD8oWfIWSVjw4X5mYqKxI/RnD5s1Tnr3KwjNE9fhXNtcAEHFvslYW6pdTtvAXnXXmP9GqefcTNU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nPvMTIvo; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nPvMTIvo" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c74f0c3fc16so204919a12.2 for ; Wed, 25 Mar 2026 21:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774499193; x=1775103993; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ry38seNjGiF2EYLGqUoMowJxqEVOtzW90BrHDDfiPH8=; b=nPvMTIvojQ8GZ5ht4teuduK202QqP0VmPPxQkvypoJP10MZt4pBZNAG2eRg6gaMK+Q tFQIeHkPeSEnPtgOmUsP+XmCdEz7SMCd8ayZZeYtvjSAikON9pgYakZCTYS0x0XEJHhg 0uT/5vfhaHiewXCOXaZkCJzVlUlJY6s+TNGxOP7h3LOq2Jqc4AoIIq0x9jbuDyJEx8bv U5aR0h8+jVL8rzKRxwqWDZlqN8W2g6mVYjEaKYY2eBULmnlQA5UEHSJX1EjXxRW/W1vf qCl5To49LjeIFWVPpUnPqQ59f941VbcaT40Sl4+zw789K1ld16/i9S0cH69xU12egMou 3G4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774499193; x=1775103993; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ry38seNjGiF2EYLGqUoMowJxqEVOtzW90BrHDDfiPH8=; b=lW2jHyMBC2dcaRskXgnz0OxfjnT2bTmRMxVln4ZB6pUxAwvyRr4jBUmR/9p/WHg5dv yb3R/x/RtuWfsjSlt5MmC5CViTW3H7jLITlpT6b//tNvZKIQS9kLp2Vmt4we+xfILGAJ i8njx6Gnwuu6VfKHh9iEZWeO35QV70qPRlBdWGQxIGDt/d62OcabmmiVOST65iGEogoT wJFuHkeGz/+HNMYJ7gDBv7xTNhA8Zxsyrtl0RO8OtrHUwlwAHMFzVXGwlwu5XxXvhSoH T9uq4UQS8xVxBTFr52vPjvLFUrlJwTbzp30HZyNfLo0nlt+B0rDNEdvEO2n8xLnNZF1H wimg== X-Forwarded-Encrypted: i=1; AJvYcCW/tBXTOb9mGoKQV5X9CnjDMnlCL0opXnHZbFW9J2bsBl4wtj+IBUf/CLp+PeqqWiBbZrRFMcB1Qe3UYe4=@vger.kernel.org X-Gm-Message-State: AOJu0YwNYgKb51vvA2sCt7sb0D1mZsujDL1J9Jxiz2TI65VciJcpfTr3 rdttLbfVfMc7d7ERxx7toL2QWN3kRwIFaP0NlEOS6Uele1hwCqEz0j30 X-Gm-Gg: ATEYQzwLYBzY5mchf58AmQaRXJ1Ji8QbJPJuoHuRAxC9YdK/fCQ00ciLIlqf4CxHWyU JLNxZbY5CT9zCwh8tHgQc9MQG77GP4himxNU/huFU0ropd01fium9kHpLafAh1pbyy1e+WZJTvR 4wTEgvhZg/m0tC0M0ilz1LommN617WvvUvv0aExHWEdOV4xaA1sE6T3g8UhDeSSocFz7UyFvSxu +7mh+z6043wt5w/a4SQAIVAZgW+EnE1B59VZeYHecvw8P9WANdkBZ4lApsnU2YbS5M8kkanPFL0 tYk4dW2teZpkMUb86KQkHcgJqqgCXXwPsEqpxHkW1SVTTo4psqRr6uPTqFYQ4pbtxhWXvyu54db PClWHiNXVtKW64BCcBS/CH4JoY3+sgPcvvtoK6n/4b/P4Rd26Zi+dv8LnmPy801dzE6P+NXQhGb 98L3jEPUNasRN/7Di8/pVJYAewHr/w6ugC/S4k/IlG7i0= X-Received: by 2002:a05:6a20:3948:b0:398:6e6b:da1f with SMTP id adf61e73a8af0-39c4abcd94bmr6123102637.25.1774499192718; Wed, 25 Mar 2026 21:26:32 -0700 (PDT) Received: from ArchDesktopLeo ([2400:a840:5c41:0:e012:ea6c:986:40a8]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d404342sm1258716b3a.61.2026.03.25.21.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 21:26:32 -0700 (PDT) From: Leo Timmins To: pasha.tatashin@soleen.com, rppt@kernel.org, linux-kernel@vger.kernel.org Cc: pratyush@kernel.org, akpm@linux-foundation.org, Leo Timmins Subject: [PATCH v3 1/2] liveupdate: propagate file deserialization failures Date: Thu, 26 Mar 2026 12:25:34 +0800 Message-ID: <20260326042546.8031-2-leotimmins1974@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326042546.8031-1-leotimmins1974@gmail.com> References: <20260326042546.8031-1-leotimmins1974@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" luo_session_deserialize() ignored the return value from luo_file_deserialize(). As a result, a session could be left partially restored even though the /dev/liveupdate open path treats deserialization failures as fatal. Propagate the error so a failed file deserialization aborts session deserialization instead of silently continuing. Fixes: 16cec0d26521 ("liveupdate: luo_session: add ioctls for file preserva= tion") Reviewed-by: Pasha Tatashin Signed-off-by: Leo Timmins Reviewed-by: Pratyush Yadav --- kernel/liveupdate/luo_session.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_sessio= n.c index 783677295640..25ae704d7787 100644 --- a/kernel/liveupdate/luo_session.c +++ b/kernel/liveupdate/luo_session.c @@ -558,8 +558,13 @@ int luo_session_deserialize(void) } =20 scoped_guard(mutex, &session->mutex) { - luo_file_deserialize(&session->file_set, - &sh->ser[i].file_set_ser); + err =3D luo_file_deserialize(&session->file_set, + &sh->ser[i].file_set_ser); + } + if (err) { + pr_warn("Failed to deserialize files for session [%s] %pe\n", + session->name, ERR_PTR(err)); + return err; } } =20 --=20 2.53.0