From nobody Thu Apr 2 23:54:45 2026 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3194436F434 for ; Thu, 26 Mar 2026 01:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774489476; cv=none; b=kKJMvK6PcJ9BoHFi48U6oveeSRm8KP+p9v1ppT0MnsEsb5YtzJjz++1gDYzs/61qrlU9Xgw8QO3xXw5COt6qxcrokTr6GLo1AajKBHjGEqJYRNS4MV2D6dkjGs9621dJNBkC9SeUpqasDy6XeZlcv5VtjxEsPTzNBj0MqdyB8wc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774489476; c=relaxed/simple; bh=ZMCcAXpKFqDBsR914nXtymQFqLT+yTZjxAhGKmPLLUw=; h=Mime-Version:Subject:From:To:CC:In-Reply-To:Message-ID:Date: Content-Type:References; b=WhyW1IopZ2DypFV2Y4xHHUVjFqpv8sW9ewEMSP3303yVNhPWCBMCBmtrtV5ezFH3nb7O4YY/Wr6LA92dYRqYApQJjsAFTVxCF4+0QZF38fWII15oj7Mv/rKP1PJR7LdWzLiz/iNVu0/NFNZ0zGmpxGt6SYJa4SNaXBJmH+if76U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=JMZIznl1; arc=none smtp.client-ip=203.254.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="JMZIznl1" Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20260326014431epoutp048d73c91593be61883a26a192750775a6~gQMW2Z8wj1068010680epoutp04s for ; Thu, 26 Mar 2026 01:44:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20260326014431epoutp048d73c91593be61883a26a192750775a6~gQMW2Z8wj1068010680epoutp04s DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1774489471; bh=5IYFGg1UCPmPFLY2KOd+jdUPq6T6ca4Lx2iykpqmAr8=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=JMZIznl1aO7O7Xv5twWyBhBf1b0RQEUjKtnKv52cPgPKcGH+RIijvCxIjEKOCyRgD t+in4gRB0Lhpe2okGzHFc66PECYkzsIdHjC5GhZ5mlUNdI+6RJmCqIH1mVbtMF1V58 e89LErauOU06FlJJ8gF2ai7ex0w89D1Zq7YKwLJA= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas2p2.samsung.com (KnoxPortal) with ESMTPS id 20260326014430epcas2p2421661bf9a868d815c1784a27dd8aae6~gQMWOwq2y3270532705epcas2p2S; Thu, 26 Mar 2026 01:44:30 +0000 (GMT) Received: from epcas2p3.samsung.com (unknown [182.195.38.211]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4fh65V0K4rz6B9mB; Thu, 26 Mar 2026 01:44:30 +0000 (GMT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Subject: [PATCH v4] nvme: Skip trace complete_rq on host path error Reply-To: hmi.jeon@samsung.com Sender: =?UTF-8?B?7KCE66+87Iud?= From: =?UTF-8?B?7KCE66+87Iud?= To: Keith Busch , Justin Tee CC: "axboe@kernel.dk" , "sven@kernel.org" , "j@jannau.net" , "neal@gompa.dev" , "hch@lst.de" , "sagi@grimberg.me" , "justin.tee@broadcom.com" , "nareshgottumukkala83@gmail.com" , "paul.ely@broadcom.com" , James Smart , "kch@nvidia.com" , "linux-arm-kernel@lists.infradead.org" , "linux-nvme@lists.infradead.org" , "asahi@lists.linux.dev" , "linux-kernel@vger.kernel.org" , =?UTF-8?B?7J207J2A7IiY?= , =?UTF-8?B?7KCE66+87Iud?= , =?UTF-8?B?7Lm47LCs?= X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20260326014429epcms2p135ffd3c2b2fface6423d045e9614c262@epcms2p1> Date: Thu, 26 Mar 2026 10:44:29 +0900 X-CMS-MailID: 20260326014429epcms2p135ffd3c2b2fface6423d045e9614c262 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-223,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6 References: <20260320052101epcms2p42ae135da60b36685e9b7fca6849b57a6@epcms2p4> <945a3e98-ee75-453c-ae80-f3c9e3e57e58@gmail.com> <20260325063333epcms2p60954532c1b65a1665bad6dcdcfd7d62c@epcms2p6> Hi Keith Busch, If it's host pathing error, Do you mean to skip `trace_nvme_complete_rq()`? If so, I agree with this approach. Thank you Regards, Minsik Jeon From c1f3c209c35233154bf5918092bdbb085828db23 Mon Sep 17 00:00:00 2001 From: Minsik Jeon Date: Thu, 26 Mar 2026 11:09:57 +0900 Subject: [PATCH v4] nvme: Skip trace complete_rq on host path error we were checking host_pathing_error before calling nvme_setup_cmd(). This is caused the command setup to be skipped entirely when a pathing error occurred, making it impossible to trace the nvme command via trace_cmd nvme_complete_rq(). As a result, when nvme_complete_rq() logged a completion with cmdid=3D0, it was impossible to correlate the completion with the nvme command request. This patch Skip trace_nvme_complete_rq() on NVMe host path error. Co-authored-by: Beomsoo Kim Co-authored-by: Eunsoo Lee Co-authored-by: Steven Seungcheol Lee Signed-off-by: Minsik Jeon --- drivers/nvme/host/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 766e9cc4ffca..8f98d5220206 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -458,7 +458,9 @@ void nvme_complete_rq(struct request *req) { struct nvme_ctrl *ctrl =3D nvme_req(req)->ctrl; =20 - trace_nvme_complete_rq(req); + if (nvme_req(req)->status !=3D NVME_SC_HOST_PATH_ERROR) + trace_nvme_complete_rq(req); + nvme_cleanup_cmd(req); =20 /* --=20 2.52.0