From nobody Fri Apr 3 01:24:07 2026 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4ED9398915 for ; Thu, 26 Mar 2026 01:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774489382; cv=none; b=R4X7P7dKK0EVQXwxnjee32eQIQ85Us2yH8itilzeQQ0baX4o3C3CedNacfYZ7Hu+LxMfJwLJPThXgmlKTRhkHVS3FOsD0jIwphmx+DiwsUQpVxeTtpyQH0NNjujXwiwjbMY7p0gwjncQ2PsSiGSeAl4/yRbgm2ILKoKdeLRJFvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774489382; c=relaxed/simple; bh=Cstg9Tn/KwBnwQwZthXsVyLc96Oiq8jwCupkL55xgc8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jlJpLRk9DtU4wSZvvpEMfWk8WkOyn7eYCKCDeBtAuD0OXwtw+HrKbPVHwq22r8Fu//Z9mlvBTixsMftlgNHKNgmqoREnq8cJq/nxkl9XnlppBNn1z6wh1gto0+srrVAPHy18EJdUMTgxdVe+/vwyGqje8bRuZ0v9SZn1EIdcu10= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n6pAMhDP; arc=none smtp.client-ip=209.85.217.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n6pAMhDP" Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-6028bb29cc9so249212137.0 for ; Wed, 25 Mar 2026 18:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774489380; x=1775094180; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0ZnbVMirv8VDzglIV3UEReSG5jpGe65jGd9BsAEXnlc=; b=n6pAMhDPB9gVXy0zWwZ1K6FJy+ZtD6muldjoBClzWDqHnMeHz/Ctv4l2SYq1WRc2P/ U+8ANZKO1rmmhrwLL2/tNG8sS9QIj7VtaYp/5JPysQBhq8/l71s3xPbsdW4zeTfXnV00 71prFiLB2DywH7hbYPSX/FARsLeNE7QBs8nK2VpkGS3pVgqNfXNOYcXwanTUQ+rIoAQ9 bJys+fOBMckLbwN/yyqiZqrPormrVVi+Yzp8+s2LngZAu5l9KN395XavN9ihSWqxkz2k /RZby8ncTvfgJC4dROtjfSyCDbD4v2XLtQJAKw4U0WgwiK2TVRULmLqIc2WpRVnix+Lm WZOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774489380; x=1775094180; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0ZnbVMirv8VDzglIV3UEReSG5jpGe65jGd9BsAEXnlc=; b=NMD74MHIWEWSnsEhZbnbGH9jI71jt3s3pCEtgL7VACDP9t/TNRIFMlBoYPab4XyVze S/wFvlsr0dZ96Maelzd/TSUEEEcEohMBJlAiCeQ+LvP4qPqbPNRGChct5ISpoZSkD+tF hW54dLvX2le56FPW1d0A6ukAA13jH0yWJuByueV1WGzGP92ZRSbmpe94y9Zt0PgZEDiT Qlck7B/lJc/gq2+MlGw3Oc7hzqKKMjJouOifdtccse5D/o9N3tjxYBNu6eUP/7ix6T11 EZK1AGcDDTUy/ZmBMnNqphrASTaQwHjspoV4yNabh9gc2ue/ZxM10AfADcbWFS+U/koq C0RQ== X-Forwarded-Encrypted: i=1; AJvYcCVWYVj4hGJpEkur1jhr7Tt0eWGkaSR/YhZnTxC6wn4HZseI0/PINj8hcn0GKGwog0ZDpyCbLRbRRsHcNt8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq5sV8sQ0aNEF4UO/b/tZuy8BLkWER+pMVie94hXn5rF98WoTY dysCxbnrLFhezXwXcaWm4/OIM1IPGPiz0FumjKb2/hOYdlx6s41AnpAj X-Gm-Gg: ATEYQzxZ1yyrs/RC/Tri/CnfiCouyiIz8d/Fje/V8gtnGShL5GGmTAOTRVFBgHBvf9m enMKWBs8vs6MoG8VUR4L1Qo7MSqCTMn2Ux95w4NgT/ZNsWMkqNsVpmPSAtRZJNxwjCh/Qpa9BXS PxPuZHxDdPCuiQzDPW43WZhzG5+4sbBBRlYreAYmDM3RPL+zPrBJ8KtKbLrAL1q3LI17ai2kheW tJwfQhXwTegjClYlf+60P/wOZaT5YAvsEo8EICx6BRVkiA4ftlS+R106Cgx6TIv1hbxIST959n1 3we2pGFYxYSqPSChpIBwWgUWXpVWvZflI4bDgpCou7Pd3Znwr0ziYyKUxg+jlR5WmrL5d05Oou0 58xJY3hCykEI12f/O9b2npPa8Kbk2Bb0qCgc/ZulE1+h5eKN6besN/52ck/SfPmWuyk4iIl1rjy z32xn5HhNo4z22JXq5XC+cv5mVL38guL1RlQvTYoP07OspH+U0wEoHham4m5hpKNe+pH9tj3dmg Zejmr0JVWmpiXAlrZA= X-Received: by 2002:a05:6102:26c9:b0:603:273f:3570 with SMTP id ada2fe7eead31-60385f6e8dbmr3181732137.15.1774489379703; Wed, 25 Mar 2026 18:42:59 -0700 (PDT) Received: from localhost.localdomain ([131.255.96.187]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-604d50c928asm1661643137.5.2026.03.25.18.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 18:42:59 -0700 (PDT) From: Marcos Andrade To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH 1/2] staging: rtl8723bs: fix coding style issues in core:rtw_wlan_util.c Date: Thu, 26 Mar 2026 01:42:20 +0000 Message-ID: <20260326014221.525368-2-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260326014221.525368-1-marcosandrade95963@gmail.com> References: <20260326014221.525368-1-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The 'enable' parameter in Switch_DM_Func() is of type u8. Explicitly comparing it to 'true' (which evaluates to 1) is error-prone. If the function is ever called with any non-zero value other than 1, the condition will evaluate to false, incorrectly clearing the hardware register instead of setting it. Evaluate the condition implicitly to ensure that any non-zero value correctly triggers the set operation. This change also resolves the following check reported by checkpatch.pl. Signed-off-by: Marcos Andrade --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 3242978da36c..41868dda3838 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -236,7 +236,7 @@ void Restore_DM_Func_Flag(struct adapter *padapter) =20 void Switch_DM_Func(struct adapter *padapter, u32 mode, u8 enable) { - if (enable =3D=3D true) + if (enable) rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_SET, (u8 *)(&mode)); else rtw_hal_set_hwreg(padapter, HW_VAR_DM_FUNC_CLR, (u8 *)(&mode)); --=20 2.53.0