From nobody Thu Apr 2 20:20:29 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1180E84039; Thu, 26 Mar 2026 14:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774533858; cv=none; b=fHPz8zo6PBhQDvwj6NXkghw9Ldkkl/+yd+fZZe93TUXXmrqazbQsl8V+AHRsSZlXH71w629gEQJaOQHUIkKZoNE0wMjnmnJxq340Kx3bubfXTSsuv/qMHquNU/GAzBCelp/sxF3rov7fgkJz5GYOzi0ikt0xTNb/rzeqUJrl/m4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774533858; c=relaxed/simple; bh=iI9W14V1RMJIRNQD8EbjPf4OEseF5EtwFKCyEm0lqYY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=R47NJJSXVvN3ZtkpjZdtRVNXDroayDX7d7c9jMnwvoTdbNMioqZnTpcOscw7g6WW5dZj7tzdM+mPlfg2HPgQ8Q/UGChFEHQMW9SuKc+hzwjKZS9KYxGlAvCTuLNQHYu4gshqbc8mgdcV/qLvxB7K1+16VeJW7tPmVqlhEApq95U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RxwtBkzy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RxwtBkzy" Received: by smtp.kernel.org (Postfix) with ESMTPS id ADFE4C116C6; Thu, 26 Mar 2026 14:04:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774533857; bh=iI9W14V1RMJIRNQD8EbjPf4OEseF5EtwFKCyEm0lqYY=; h=From:Date:Subject:To:Cc:Reply-To:From; b=RxwtBkzystJSG6+xlFe+4+30rrspFUiSANLl0nRRKCHD2hd/Rmc7H79UnXmSB4s1j yI/bYKCTaZ01XVvIwswALoV9zkt9jLe6ol4GwF5d+mGauexJw05cdERgUfy3JKykAV 1rqdqjAv8zvWbB+Ocyf+mF2bfrQsIXq1tVgZM1yhFVEbF0ULD2wV7NEhrEqH4UaVh3 BrlUGdEYljmvtIdCNmunRIhWwPxUO//tQsinpG3EpwYeWrvyIBuRGswTLSzASYBK4C VL94poAozjiddu7/Kksj+OkH3tK/IQPeZMZwzA9dlBmfaz5mxEK/n6VIgEWkCp7gGi jOuJVIQLP2IYw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F2F10A62DA; Thu, 26 Mar 2026 14:04:17 +0000 (UTC) From: =?utf-8?q?J=2E_Neusch=C3=A4fer_via_B4_Relay?= Date: Thu, 26 Mar 2026 15:03:48 +0100 Subject: [PATCH v2] HID: wiimote: Fix table layout and whitespace errors Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260326-wiimod-table-v2-1-a11703ccdf41@posteo.net> X-B4-Tracking: v=1; b=H4sIAMM8xWkC/3XMQQ6CMBCF4auQWTumUyKKK+5hWLRlkEmUkrapG sLdrexd/i953wqRg3CEa7VC4CxR/FxCHypwk5nvjDKUBq10o2pq8CXy9AMmYx+MbmiNdcpo016 gXJbAo7x37taXniQmHz67num3/oEyIaGjsSXL6kT1uVt8TOyPMyfot237ArcxjZepAAAA X-Change-ID: 20260316-wiimod-table-cd9abc0a2a98 To: David Rheinsberg , Jiri Kosina , Benjamin Tissoires , Bogdan Petru , Joshua Jun Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774533856; l=7027; i=j.ne@posteo.net; s=20240329; h=from:subject:message-id; bh=FgYpCYvhtgKlsH8SHBekcIbkuz7x2xhzDunKOXgRYgY=; b=jlQ/SIc+gN4uLo3iBU+tNL2ZJ6ufbZYYpdrx121lMLWovx77IB3Bhvih4SGi05hEJVrkpjGvF QHAlRKyXcMeDfUdVRumQuX2Ggq3I0N1K89kzRGNe1Qn1/jfYHKO65sz X-Developer-Key: i=j.ne@posteo.net; a=ed25519; pk=NIe0bK42wNaX/C4bi6ezm7NJK0IQE+8MKBm7igFMIS4= X-Endpoint-Received: by B4 Relay for j.ne@posteo.net/20240329 with auth_id=156 X-Original-From: =?utf-8?q?J=2E_Neusch=C3=A4fer?= Reply-To: j.ne@posteo.net From: "J. Neusch=C3=A4fer" Some tab characters snuck into the data layout table for turntable extensions, which resulted in the table only looking right at a tabstop of 4, which is uncommon in the kernel. Change them to the equivalent amount of spaces, which should look correct in any editor. While at it, also fix the other whitespace errors (trailing spaces at end of line) introduced in the same commit. Fixes: 05086f3db530b3 ("HID: wiimote: Add support for the DJ Hero turntable= ") Reviewed-by: David Rheinsberg Signed-off-by: J. Neusch=C3=A4fer --- Changes in v2: - also fix the other whitespace errors in the file (suggested by David Rheinsberg ) - add Reviewed-by - Link to v1: https://lore.kernel.org/r/20260316-wiimod-table-v1-1-c1f91be0= 5137@posteo.net --- drivers/hid/hid-wiimote-modules.c | 58 +++++++++++++++++++----------------= ---- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/hid/hid-wiimote-modules.c b/drivers/hid/hid-wiimote-mo= dules.c index dbccdfa6391672..dccb78bb3afd61 100644 --- a/drivers/hid/hid-wiimote-modules.c +++ b/drivers/hid/hid-wiimote-modules.c @@ -2403,7 +2403,7 @@ static const struct wiimod_ops wiimod_guitar =3D { .in_ext =3D wiimod_guitar_in_ext, }; =20 -/*=20 +/* * Turntable * DJ Hero came with a Turntable Controller that was plugged in * as an extension. @@ -2439,15 +2439,15 @@ static const __u16 wiimod_turntable_map[] =3D { static void wiimod_turntable_in_ext(struct wiimote_data *wdata, const __u8= *ext) { __u8 be, cs, sx, sy, ed, rtt, rbg, rbr, rbb, ltt, lbg, lbr, lbb, bp, bm; - /*=20 + /* * Byte | 7 | 6 | 5 | 4 | 3 | 2 | 1 | 0 | *------+------+-----+-----+-----+-----+------+------+--------+ - * 0 | RTT<4:3> | SX <5:0> | - * 1 | RTT<2:1> | SY <5:0> | + * 0 | RTT<4:3> | SX <5:0> | + * 1 | RTT<2:1> | SY <5:0> | *------+------+-----+-----+-----+-----+------+------+--------+ * 2 |RTT<0>| ED<4:3> | CS<3:0> | RTT<5> | *------+------+-----+-----+-----+-----+------+------+--------+ - * 3 | ED<2:0> | LTT<4:0> | + * 3 | ED<2:0> | LTT<4:0> | *------+------+-----+-----+-----+-----+------+------+--------+ * 4 | 0 | 0 | LBR | B- | 0 | B+ | RBR | LTT<5> | *------+------+-----+-----+-----+-----+------+------+--------+ @@ -2458,20 +2458,20 @@ static void wiimod_turntable_in_ext(struct wiimote_= data *wdata, const __u8 *ext) * With Motion+ enabled, it will look like this: * Byte | 8 | 7 | 6 | 5 | 4 | 3 | 2 | 1 | *------+------+-----+-----+-----+-----+------+------+--------+ - * 1 | RTT<4:3> | SX <5:1> | 0 | - * 2 | RTT<2:1> | SY <5:1> | 0 | + * 1 | RTT<4:3> | SX <5:1> | 0 | + * 2 | RTT<2:1> | SY <5:1> | 0 | *------+------+-----+-----+-----+-----+------+------+--------+ * 3 |RTT<0>| ED<4:3> | CS<3:0> | RTT<5> | *------+------+-----+-----+-----+-----+------+------+--------+ - * 4 | ED<2:0> | LTT<4:0> | + * 4 | ED<2:0> | LTT<4:0> | *------+------+-----+-----+-----+-----+------+------+--------+ * 5 | 0 | 0 | LBR | B- | 0 | B+ | RBR | XXXX | *------+------+-----+-----+-----+-----+------+------+--------+ * 6 | LBB | 0 | RBG | BE | LBG | RBB | XXXX | XXXX | *------+------+-----+-----+-----+-----+------+------+--------+ */ -=09 - be =3D !(ext[5] & 0x10);=20 + + be =3D !(ext[5] & 0x10); cs =3D ((ext[2] & 0x1e)); sx =3D ext[0] & 0x3f; sy =3D ext[1] & 0x3f; @@ -2499,32 +2499,32 @@ static void wiimod_turntable_in_ext(struct wiimote_= data *wdata, const __u8 *ext) input_report_abs(wdata->extension.input, ABS_HAT1X, ltt); input_report_abs(wdata->extension.input, ABS_HAT2X, cs); input_report_abs(wdata->extension.input, ABS_HAT3X, ed); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_G_RIGHT],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_G_RIGHT], rbg); input_report_key(wdata->extension.input, wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_R_RIGHT], rbr); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_B_RIGHT],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_B_RIGHT], rbb); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_G_LEFT],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_G_LEFT], lbg); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_R_LEFT],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_R_LEFT], lbr); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_B_LEFT],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_B_LEFT], lbb); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_EUPHORIA],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_EUPHORIA], be); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_PLUS],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_PLUS], bp); - input_report_key(wdata->extension.input,=20 - wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_MINUS],=20 + input_report_key(wdata->extension.input, + wiimod_turntable_map[WIIMOD_TURNTABLE_KEY_MINUS], bm); =20 input_sync(wdata->extension.input); @@ -2557,7 +2557,7 @@ static void wiimod_turntable_close(struct input_dev *= dev) static int wiimod_turntable_probe(const struct wiimod_ops *ops, struct wiimote_data *wdata) { - int ret, i; + int ret, i; =20 wdata->extension.input =3D input_allocate_device(); if (!wdata->extension.input) @@ -2594,9 +2594,9 @@ static int wiimod_turntable_probe(const struct wiimod= _ops *ops, input_set_abs_params(wdata->extension.input, ABS_HAT1X, -8, 8, 0, 0); input_set_abs_params(wdata->extension.input, - ABS_HAT2X, 0, 31, 1, 1);=09 + ABS_HAT2X, 0, 31, 1, 1); input_set_abs_params(wdata->extension.input, - ABS_HAT3X, 0, 7, 0, 0); =20 + ABS_HAT3X, 0, 7, 0, 0); ret =3D input_register_device(wdata->extension.input); if (ret) goto err_free; --- base-commit: f338e77383789c0cae23ca3d48adcc5e9e137e3c change-id: 20260316-wiimod-table-cd9abc0a2a98 Best regards, --=20 J. Neusch=C3=A4fer