From nobody Thu Apr 2 22:07:11 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E31A1396596 for ; Thu, 26 Mar 2026 12:11:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774527111; cv=none; b=eYA/W3B3P2Il5c7kpQvpuebjwTU54oFIqf7hNpGa7abgy0YPaFXY2kS1AB0fpGKQEj9PMix+GHHs7Ue7o3aPbujfWa7k7k2p7xbdh4645gzSCBd8LD9KjphnmFRXEv6WD2rBbYqmrn9QOsGgRA5slnR0okYkqTAm73S85hOnY7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774527111; c=relaxed/simple; bh=q5VeKQaMOeAzIRvj0zdKA5E5UwciJ+dVl5nvFwGPIVA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=oqjgITNIh74MYiHvD8r0hymsJ9iL0qcrjVo83nG+qdVRn/FrsY1cTg+8IQ+EzKXIH6mPQTDeFtg0pHwRvD4T5bDQE6w89AwWFuIJ+IJES1CD80cPDSHi2QL0I3ijMMnyZ9TJsc5EfcmxkocHP/vB8fttReqiWjYR8xz4a/xJ5L8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FC7svJ2R; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FC7svJ2R" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2ad4d639db3so4160205ad.0 for ; Thu, 26 Mar 2026 05:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774527108; x=1775131908; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=Jt1VHbnznQyLT9ogy/s9keX/4mRMMLiQg9FocJbWV7M=; b=FC7svJ2RA1cD4RkKhptnTvP7Rf5IP8yjY64HM5Caa93WSkuIr9f4hWaqQD0UZa+ZLQ 6gBo/09jqUPHTfs9smmH/dWmOU3VsCfKlsK1KM/JmjaW+vTmXXPgPzf+27TJ04HachIg KOMzrxXanXOPgWjP0bVpDtKcx+Yer4BJevyACdzxjioVjVji2IUZ/Sw8AZLu9LOs1WvX 7SLCVwDVLPRicuJ+V3y985RHH3H2VB537an9QvpB9qVSHOaEJSR7bldGkdBbKPBNkTgz KQ19xIB0WwiM4qkL0xvaQuVjnW9Ismx9jVIchdzQjYNpn8IIYVrfbjdAXw7F/QeS+US2 DnUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774527108; x=1775131908; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Jt1VHbnznQyLT9ogy/s9keX/4mRMMLiQg9FocJbWV7M=; b=aN2cN9B17PYCpWsy6v0imOwoKAfPKh1oUUNfp8sofeeWG7mCm6dnrMfsET839uvozd EkuNlq3ENP+BN8gVE6LOh4m8r53asozqFMsTQrfDzPqi6c/jTaP84QDtPhBGvyFrIPzi f04qKAHow7+vFS3XI3nwQLygb6DFr7i8x3Ne2XpgORdEKr+rGQxuJCi0orDwh3LI2SBL 5JyUteagw14A6WyR+AkoBRMVWQH0RzuL75rSB5UWENCeJeukI4trSsZZRaLUZ9zJhs6F WiBBy+kcanBt+242uGkWFl22pbn9xWHOstVl14/D1hvUIrYWKuxX95GifCB9G1LdHRr0 k8dg== X-Forwarded-Encrypted: i=1; AJvYcCWEX0Btpw/f3Zy3UZUY19uw6h/TXPeeAYp2wJ8X20GDzjVMjwK9P5YvRV2H066kUmCxfnOxxJ84AMlOHWA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx68xgRvfr5SdNe6BfYG1EHhiy6VCYW8Vf5JkJ+bwMaViy8RD9W 9wC2XbZh3tYS3afv8k/IwoeE/Ha9/qCNWOdN0XdBzfzoh1LdT8V5nT+/ X-Gm-Gg: ATEYQzxpi5GMNAdpY47TX06h+SXAWipdU3rRtq08eWZYL9x7i4dLHmyUEJiNA4ZxgI8 +ZIKsVIxCuSbyGGynuIEk2O7BekS8qD60ARzV590S26UEZaYMVmqspCvSbbNJz5omFxYAe9I7rU O/E4NgRgxvu3cRGEaD6xJ1txO6KyBSrmTZg+nKnt9Nq6eoYG756HruuwK7fv0a9J+gGHwFdIWZy xkuivrmW1D9cPn6QCeuTJsWFWzHwq7cGVYvTGOUHf3ODMFhTQv2qSLd3842dCKECQoCye7x4qFT BBWOlQvYrfccg7N623wiJHwWfI7VF41+yEMNeS02X8ppPH/jlJXltyIY9KPX9/AoiMURZ1d/iFh 4jFjBUz7VDRiiLU50/guhYJfKdjII6j5yR+rQV32KtarZDtNz2oXYuBZjroDkl53QUcSDyrMAxx EkUba6fNRt8cMjAFjVHLKBMQiAXwS3IIKoiX+Onts88VrOXjA= X-Received: by 2002:a17:903:234a:b0:2ae:4445:f39a with SMTP id d9443c01a7336-2b0b099d271mr76407185ad.7.1774527108015; Thu, 26 Mar 2026 05:11:48 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0bc87e820sm27623345ad.50.2026.03.26.05.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2026 05:11:47 -0700 (PDT) From: Felix Gu Date: Thu, 26 Mar 2026 20:11:42 +0800 Subject: [PATCH] iio: light: veml6070: Fix resource leak in probe error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260326-veml6070-v1-1-5d79022e76f1@gmail.com> X-B4-Tracking: v=1; b=H4sIAH0ixWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyMz3bLU3BwzA3MDXUMTC0tzSwsDC/OUNCWg8oKi1LTMCrBR0bG1tQD A1fHqWgAAAA== X-Change-ID: 20260326-veml6070-1489798087df To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Javier Carrasco Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774527105; l=1981; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=q5VeKQaMOeAzIRvj0zdKA5E5UwciJ+dVl5nvFwGPIVA=; b=K2IRwI23jzeggJTdMGQMp2IvyQTATTfUQWdah2xnK6ps4QNcLHM7qr6sGHW+/nGsnQ+VzmDdq NwP6INirp/TBopVzjdX0X62+6G+72hFgAW+W2z68q8YFsYY7VV68MCQ X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The original code registered the i2c dummy device cleanup via devm_add_action_or_reset() after i2c_new_dummy_device(). If probe failed between these two calls, the dummy device would leak. Use devm_i2c_new_dummy_device() which registers cleanup atomically with device creation, eliminating the error-path window. Fixes: 7501bff87c3e ("iio: light: veml6070: add action for i2c_unregister_d= evice") Signed-off-by: Felix Gu Reviewed-by: Andy Shevchenko --- drivers/iio/light/veml6070.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/iio/light/veml6070.c b/drivers/iio/light/veml6070.c index 6d4483c85f30..416a9520713f 100644 --- a/drivers/iio/light/veml6070.c +++ b/drivers/iio/light/veml6070.c @@ -247,13 +247,6 @@ static const struct iio_info veml6070_info =3D { .write_raw =3D veml6070_write_raw, }; =20 -static void veml6070_i2c_unreg(void *p) -{ - struct veml6070_data *data =3D p; - - i2c_unregister_device(data->client2); -} - static int veml6070_probe(struct i2c_client *client) { struct veml6070_data *data; @@ -283,7 +276,8 @@ static int veml6070_probe(struct i2c_client *client) if (ret < 0) return ret; =20 - data->client2 =3D i2c_new_dummy_device(client->adapter, VEML6070_ADDR_DAT= A_LSB); + data->client2 =3D devm_i2c_new_dummy_device(&client->dev, client->adapter, + VEML6070_ADDR_DATA_LSB); if (IS_ERR(data->client2)) return dev_err_probe(&client->dev, PTR_ERR(data->client2), "i2c device for second chip address failed\n"); @@ -294,10 +288,6 @@ static int veml6070_probe(struct i2c_client *client) if (ret < 0) return ret; =20 - ret =3D devm_add_action_or_reset(&client->dev, veml6070_i2c_unreg, data); - if (ret < 0) - return ret; - return devm_iio_device_register(&client->dev, indio_dev); } =20 --- base-commit: 66ba480978ce390e631e870b740a3406e3eb6b01 change-id: 20260326-veml6070-1489798087df Best regards, --=20 Felix Gu