From nobody Thu Apr 2 22:00:10 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F8D22DAFA1 for ; Thu, 26 Mar 2026 13:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774530772; cv=none; b=cRJsZI1VB0qlWxwsFBGZ0NVNptxkpdXfw2lHqCdbhOWlxQge2fiYtZzRBCID3v/2Q2Zi3heOmJGLs9V5yHoja/yQRulRojJ2E/VglCb05Z/rKsFJ0Pbj30mDgiji4sCCKUrtpLaHtSHIeUoCwNDhKIQXXj2spUy+41tu7QYA/Ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774530772; c=relaxed/simple; bh=kXEBX6aktrNXxxPjgSs66smVTLORZLIDKgjSxczFR7U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mr8sxL1IKZISPJQozSdD9lK/k8U6mk3Bu6FCp3TFOSMEqhu1W+VAIIpFuFu3NUlHOAJtdkaNoBN3KD3isv/tEkO4wexSiP/zrOHqNiVch3LmYSaDLt7QBHYUMJz8cskf5V739UHgFV07aqK1IUji/A8n9AdKMFpVlXjtoRSbhwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=FP/yjNnI; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="FP/yjNnI" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 104C311EB; Thu, 26 Mar 2026 14:11:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1774530678; bh=kXEBX6aktrNXxxPjgSs66smVTLORZLIDKgjSxczFR7U=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=FP/yjNnIId7im5sRcaVRX8Dl9SSVRKdgh7HE44/vivKb0VaNpSasQVBTxlfUR76DE T7PXF48MzutPA76CDTMiwem3agXRspn5sSVsLliEu0x6HKqmsf9XI0qwjboqiT9y9n uZZiAXLrIaTMJCy3yXsDwljXanEqZYiKDkIwfmaQ= From: Tomi Valkeinen Date: Thu, 26 Mar 2026 15:12:14 +0200 Subject: [PATCH 4/8] drm/bridge: tc358762: Configure SYSCTRL first Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260326-tc358762-fixes-v1-4-65f479227af5@ideasonboard.com> References: <20260326-tc358762-fixes-v1-0-65f479227af5@ideasonboard.com> In-Reply-To: <20260326-tc358762-fixes-v1-0-65f479227af5@ideasonboard.com> To: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1636; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=kXEBX6aktrNXxxPjgSs66smVTLORZLIDKgjSxczFR7U=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpxTC+J1M7nueUSN4j2rkrjp7d4olSoCPFzpwWW tBGuOfDN5mJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCacUwvgAKCRD6PaqMvJYe 9ZaPD/4tG6GPM8QNhA8dzVZwTvfGn8qB5VTALEaSmyKjVw1lvYt+9p0Og4tlAMk2OeM8XNPe/e+ nIOWl+VxG/IlkTBFgGdaE+w3+S/YxO7HHpANPcnMBUd2KmqGVsS+Pr9GU5qpQT6InVFb8eP9OTh K2+0jqdbxVGP280KRI1tlUom+SMIfqt33yxe1qWWeHh0VIr39CZw8MH1KsPbFmJYwGbvI3+ELq5 32/bXy/vju+j3fgh1LXtOr7OPMous9OMFSqNZMa4FhDgrHFuGzDVh51gvZiAZ/YarxEJIzT+xv7 2A87irhcFnZB6OjcOtLKeP3lNDNya0o+eUygSFSezBIVHHW2iF/VMKNh08WFo/VGaJCX0AGhxkQ EjZZMfP6NVGzvFeGTEU3gJHcECLamkg+1gEHXo1u8eUXrZDQHwxeeRLPtp/g7c7IPiMIrbRvUlt 53brmlDV0tT3YtWJwg52KXmPf6mXzGgQ+9ZuLjPma4p9b+jXgV+z+g9Vdombk54BZBHc7VVbbGo bkNgZToNjAuMUtHC+alT7Oaxw6dygyGsi0uaQ55vzz5OOfk3jX0TPdG9ULf7MXTor99x5IMjVIf te8kZwTwl6rEhYTixEPrTCVLEejxRsMGB4egyIT62DM9lhy2jj2ZJmTEtJIjxH/1Ze7wFNcjAjk w8bBtFylUEslm0A== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 SYSCTRL affects the DPI output and the clock tree, but we configure it late, when the DPI output is already enabled and clocks are running. Move the SYSCTRL configuration to the beginning, before anything is enabled. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358762.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc3= 58762.c index cbedffb7a705..053579591dba 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -134,6 +134,13 @@ static int tc358762_init(struct tc358762 *ctx) { u32 lcdctrl; =20 + tc358762_write(ctx, SYSCTRL, + FIELD_PREP(SYSCTRL_DPIDATA_IO_MASK, SYSCTRL_DPIDATA_IO_4MA) | + FIELD_PREP(SYSCTRL_DPISTB_IO_MASK, SYSCTRL_DPISTB_IO_4MA) | + FIELD_PREP(SYSCTRL_PCLKDIV_MASK, SYSCTRL_PCLKDIV_DIV_3)); + + msleep(100); + tc358762_write(ctx, DSI_LANEENABLE, DSI_LANEENABLE_L0EN | DSI_LANEENABLE_CLEN); tc358762_write(ctx, PPI_D0S_CLRSIPOCOUNT, 5); @@ -157,13 +164,6 @@ static int tc358762_init(struct tc358762 *ctx) =20 tc358762_write(ctx, LCDCTRL, lcdctrl); =20 - tc358762_write(ctx, SYSCTRL, - FIELD_PREP(SYSCTRL_DPIDATA_IO_MASK, SYSCTRL_DPIDATA_IO_4MA) | - FIELD_PREP(SYSCTRL_DPISTB_IO_MASK, SYSCTRL_DPISTB_IO_4MA) | - FIELD_PREP(SYSCTRL_PCLKDIV_MASK, SYSCTRL_PCLKDIV_DIV_3)); - - msleep(100); - tc358762_write(ctx, PPI_STARTPPI, PPI_STARTPPI_STARTPPI); tc358762_write(ctx, DSI_STARTDSI, DSI_STARTDSI_STARTDSI); =20 --=20 2.43.0