From nobody Fri Apr 3 01:24:24 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D89673E92BA for ; Wed, 25 Mar 2026 16:24:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774455845; cv=none; b=tbH9qMZU6PMHRNBp3v9JpfMJclljRbESMrwTQ+61mBgbjn0vZCl0NoSQTT4kH0AnuKg3axisq9TZSPObbEQO5r/7rT9XuIVbjy+a91MHw9W8fgG4FX9PZ/hqJAK29STUZHs0A+3xdm2bRl2ey5WFuUSAXVbeermdGfuE8sbpm28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774455845; c=relaxed/simple; bh=HX2kS2CXlof3uu3i5x67Qry8KYMPozu4hVnaRzMVy1A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=dktq5Gk+YeQAWqIwdchS8rP0rLF1yMg3FtOwDfs42UdxP4mxzhM4UMzLFXOGs79tLUtVWYZgEBtp7Ncb2CoLWHHQYgd/iAAQ4DP/speSrshpdJnPa+H0/pD1/YFIDxen9tAHV61LJbTw3ScjJEY7fVdAIQjLhwV89QN6H5Kd9/E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Df9WEdkL; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Df9WEdkL" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-829781b2b01so18177b3a.2 for ; Wed, 25 Mar 2026 09:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774455843; x=1775060643; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=9qbvYscf4zAVK6F+BRBQCeZsFQW9PNBr6bbrHWczJms=; b=Df9WEdkL111ttT+E+y9W0wlIyoD3NqyLkmJ45SUoT+6PSZ6WpCMNoCH49QJ38hHVGO lDHPe6ZULDIUlJugU7YAwM85DPFQ9LlPhzoE2OT4BK0UmWrtXlrRhBrc+is91Np8p4LP f0ZfoPfjOye26IK2T6BlxuFqkZcCrTqgQdvvbs+j28KpW8Eqcjjn5PK/cbgeNefWd/t/ seszevXYDzgZC3IZ+AJmOpi2rcDLVdZx+auaUZ3UHsE4OAUZpAuuym7XMpGhkMuB0drR CBr/J3e5kugi4j44IEdUlT16DC9aGyrZATEyA74v3ZMRHBUstyTmm3pOrFVIDOHaXl8N mNpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774455843; x=1775060643; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9qbvYscf4zAVK6F+BRBQCeZsFQW9PNBr6bbrHWczJms=; b=JgtwYR1DFmj4RVf3AfDJcGjBXAxldqqrd4IHJtyTs5D7q7akcrqfybGgpA5sCQZBoL mMfext5sYTPVL7G3CdGW1241Gum0eZFaHG1oNUPPRr6MimOdV8PXamhAP4PlADi5tssi GbXYQlx2VBv+ulSrcN0pP9wcK4MaY2NqpF35ileH9NrT452EBkqILhOEDEFM22X2FRyz pBI2Lmu+nIjiy9MNzf46yHJwVpCqlhxx1Tbci7tRRYYCgLks2XN9R+u3NXfZbnFPhj6p Ud+9P4UVcEGuo3wBkzEb+OZecdIe/9GdLGOeSCsD+/Q4enXFFGjUDH9mSiuamf6eZuRx ljKg== X-Forwarded-Encrypted: i=1; AJvYcCV96X1zNqN0sgQaL1OJ9nVUUaLn4dLuxJfxDXQDn2BwN/p/kvASdSqrCtgIVAUrQQp9Ivv5Vm0ZayKgbrE=@vger.kernel.org X-Gm-Message-State: AOJu0YwnIQFwSqRvfnZwC8NbYwFIEbnmtNmrG3wn8nHcdFRhTtKeV9sI p+m7FFxFJ170VrVJeggziONndU/NoHmJFwGWj6NY+eydgaLySnyKIRaT X-Gm-Gg: ATEYQzyPOjrjvx9MWS+mg0t7YkrMvLz3sDVomYPsYRDq3xlBU28q7Ay9NADJcoDlF7n birDjPyzO6p1RZhCzFqLwj3iunkmRL6Z8apEhDNPt0ZqYz2dJd0vH3heSFLnIApCsJlbNiTtvBK TlPZBplFN6RxHx+FIxl/cGDYo5BLVvMW1F2RC/XUcUhB2wJNsv2r68XgxpAOkHKEqQikXMp+sJU Bm46msFLv4QzidTY2XLFs5fgi07wqdsaVxo6iJm9MFe5rPGsajvi7fPgLT5b4Cx5a90Mk6z176/ n7mUERlBFyKXXMSF4TYeeOCwfbCtwxwCowGatWjGYkg1rljcPc6SwieuvdlHYZhKFb/nlduUyej /enwtZ4S10gRrlOhbrOZhd0Qwq9YjohlVOjrRuDZIX7wZSj10OdQS2ROPrk63cOc7DPHlwdZQvS 3IqU07BxFu4ERxzsYpNbD/vOxO6JH8vKwS1ZkB X-Received: by 2002:a05:6a00:414b:b0:822:6830:5900 with SMTP id d2e1a72fcca58-82c6de927e1mr3843698b3a.6.1774455843050; Wed, 25 Mar 2026 09:24:03 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82c7d3fe576sm154141b3a.54.2026.03.25.09.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 09:24:02 -0700 (PDT) From: Felix Gu Date: Thu, 26 Mar 2026 00:23:58 +0800 Subject: [PATCH] phy: spacemit: Remove incorrect clk_disable() in spacemit_usb2phy_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260326-k1-usb3-v1-1-0c2b6adf5185@gmail.com> X-B4-Tracking: v=1; b=H4sIAB0MxGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYyMz3WxD3dLiJGPdNLNEU6M0E0NjM0MzJaDqgqLUtMwKsEnRsbW1AEl nPspZAAAA X-Change-ID: 20260326-k1-usb3-f6a52f413616 To: Vinod Koul , Neil Armstrong , Yixun Lan , Ze Huang Cc: linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774455840; l=994; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=HX2kS2CXlof3uu3i5x67Qry8KYMPozu4hVnaRzMVy1A=; b=sSdhxxaVsPk/RdstKNgVGGb1XcCzLpe10MvOCK2PNP2EgqoJLouU9wzirIXc7obo9ACJIFgct lGVdOCDrwH0Dluk863nVDQj75lYZPTyRtb/Zqo0J6KxN9VFH7fpY6Kq X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When clk_enable() fails, the clock was never enabled. Calling clk_disable() in this error path is incorrect. Remove the spurious clk_disable() call from the error handling in spacemit_usb2phy_init(). Fixes: fe4bc1a08638 ("phy: spacemit: support K1 USB2.0 PHY controller") Signed-off-by: Felix Gu Reviewed-by: Ze Huang --- drivers/phy/spacemit/phy-k1-usb2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/spacemit/phy-k1-usb2.c b/drivers/phy/spacemit/phy-= k1-usb2.c index 9215d0b223b2..e8c1e26428a9 100644 --- a/drivers/phy/spacemit/phy-k1-usb2.c +++ b/drivers/phy/spacemit/phy-k1-usb2.c @@ -97,7 +97,6 @@ static int spacemit_usb2phy_init(struct phy *phy) ret =3D clk_enable(sphy->clk); if (ret) { dev_err(&phy->dev, "failed to enable clock\n"); - clk_disable(sphy->clk); return ret; } =20 --- base-commit: 85964cdcad0fac9a0eb7b87a0f9d88cc074b854c change-id: 20260326-k1-usb3-f6a52f413616 Best regards, --=20 Felix Gu