From nobody Thu Apr 2 22:23:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D2AA3B6364; Thu, 26 Mar 2026 07:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; cv=none; b=tR+FIVNAL8d5ClQT8ZKFG+luwjbNHRXbfWL0s6fwhW0ADsHpL7ktwPXotd8Et2ZOObtNxvYRNt5/YXA363jR2m5meK6df6Ew/ffOR/ybBuWyDCm/lApV2P0gc419MEo3b48gc8tDudm0BVuMZ8T+0iSryw+G6k1LWpO/4Sb0u7g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; c=relaxed/simple; bh=vtWkUX7nJXT4VBvGcL/Y+2qsHiE82woSkLVt9snsg2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fF5tpY3X/iIFtBAzSdQKmiU8ihLrgyobPgHd1BOfUQWWRNi2v/tCv2g3Z80SCPpT7MScVF/8wkGGEw/K/XZLeJOCHhRoxVrXPN04sNnXN/OVCrQjYyvxWpUqsQwPUWLDMWI1WtcHDQ1AixWvvI6BZyGxJViKeH4lezTgzodtzqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=spV/vS4n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="spV/vS4n" Received: by smtp.kernel.org (Postfix) with ESMTPS id D02DDC2BC87; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774511852; bh=vtWkUX7nJXT4VBvGcL/Y+2qsHiE82woSkLVt9snsg2I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=spV/vS4nhb3kViGo8Kl3MNZJio1YqbA6a+cuo3k/Ma5/Fh/zY/OmE7N+3T+Lbv9un 5pL/7PluFmZ8535zyc2wBuSgS7inOAPTdKXQ/AopStiTqSsGjFuGCWeXpGffh+Zo9q vJBfXu5TkrFQfNUcJCmcjFrLG16zEEwzM9HmTZVh7kyDlUq3G44MOuXyCObVSEn4KR sbKfguh+2TcOCn0D/T1apc9S2rn6JNC7Ko6UuvWRgNxsksP3Fae1aWw5PPRFphIxIO +JUoXLsaHzuhIvDXFcbv5+sJvdfthc4rQk/75kW06Ec9v6OJH/L2qRgEZ6z1nsPctc qRiXtMr08BbZA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE94E106F2E8; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Thu, 26 Mar 2026 00:57:31 -0700 Subject: [PATCH v3 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with vin supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260326-expressatt_camera_flash-v3-1-e75e5d58990f@gmail.com> References: <20260326-expressatt_camera_flash-v3-0-e75e5d58990f@gmail.com> In-Reply-To: <20260326-expressatt_camera_flash-v3-0-e75e5d58990f@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Conor Dooley X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774511852; l=2722; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=3x0hUrCLPBGYYoXg/LCYnxv46dNWEF519f2FRG1sBE0=; b=8TOw20x4xSxnXws/3MeyRTo1c6YiWeDxoLkOcW50WnaS4RS9KgYUoCHwLpX0ej5bCtjYgyync X3NwnI1V5FvDer4M9wORUZ930gLNjnpTTnvfzvKyR4LoNQ2kbeq6SWl X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Some flash ICs use the same one-wire pulse-count protocol as the RT8515 but have only a single enable line for both flash and torch modes, plus an optional input voltage supply (e.g. a GPIO-controlled fixed regulator) that gates power to the chip. Make ent-gpios optional and add a vin-supply property to support these variants. Add a oneOf constraint requiring exactly one of ent-gpios or vin-supply. Add a binding example showing the single-GPIO configuration with an input supply. Assisted-by: Claude:claude-opus-4.6 Acked-by: Conor Dooley Reviewed-by: Linus Walleij Signed-off-by: Rudraksha Gupta --- .../devicetree/bindings/leds/richtek,rt8515.yaml | 34 ++++++++++++++++++= +++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/D= ocumentation/devicetree/bindings/leds/richtek,rt8515.yaml index 0356371a6b01..ab3c5139132c 100644 --- a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml @@ -15,6 +15,10 @@ description: | current for each mode is defined in hardware using two resistors RFS and RTS. =20 + Some flash ICs use the same one-wire pulse-count protocol but have + only a single enable line for both flash and torch modes. For these + single-channel variants, only enf-gpios is needed. + properties: compatible: const: richtek,rt8515 @@ -26,6 +30,11 @@ properties: ent-gpios: maxItems: 1 description: A connection to the 'ENT' (enable torch) pin. + Not present on single-channel flash ICs that use only one enable + line for both flash and torch modes. + + vin-supply: + description: Optional input supply for the flash IC. =20 richtek,rfs-ohms: minimum: 7680 @@ -81,10 +90,15 @@ properties: =20 required: - compatible - - ent-gpios - enf-gpios - led =20 +oneOf: + - required: + - ent-gpios + - required: + - vin-supply + additionalProperties: false =20 examples: @@ -108,4 +122,22 @@ examples: }; }; =20 + - | + /* Single-channel flash IC with input supply */ + #include + #include + + led-controller { + compatible =3D "richtek,rt8515"; + enf-gpios =3D <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply =3D <&flash_reg>; + richtek,rfs-ohms =3D <16000>; + + led { + function =3D LED_FUNCTION_FLASH; + color =3D ; + flash-max-timeout-us =3D <250000>; + }; + }; + ... --=20 2.53.0 From nobody Thu Apr 2 22:23:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D2163B635E; Thu, 26 Mar 2026 07:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; cv=none; b=NvPNXiDp+4G9kFEb0fyU+IyUGhIcVRoD3Dw7OVNEZDUoRvktZiKk5QdxcIHvzQ+97FvqNcaeffzDPck8GR5zKukVQkIOo0tAaScZ+7NTYAudd54pI42hjvaXsuKyLejU/bxEo/RefCzK8Y94di+XzQjoldzXw6ALR8ltxbPLQjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; c=relaxed/simple; bh=kYdQEFCUjsNVHV6Kb5XOYYCwl12ecHQGVP9RCUGtumw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iym1RZdPOP9lKSEeCFnDkRB2If+EMyofiA/S4JsoN69CO8rmMuQ4HeuKyyUCt/3eIqD/Pj7NlTS2jH/PA12BJMiuFd+px9jyXPVFb7Ay/bAh/cOf7rH4rADhzPXgTJqc49VrtHmxeexewHUoMMQd2gt2MxxBjfeGvVnXEft/9cw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FZ49RFl4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FZ49RFl4" Received: by smtp.kernel.org (Postfix) with ESMTPS id DE2A6C2BCB1; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774511853; bh=kYdQEFCUjsNVHV6Kb5XOYYCwl12ecHQGVP9RCUGtumw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=FZ49RFl4cOdavtLxwOKm20wggQENV3LaUWU+IkHfITlfBPeGXUxlfIXMJ83QARail 4O6GN+vN4iCHRdAq6ERfcBxqa0bUOBTZGR/yq21P8gf1DPL2aZDKSs5JQkEGS5EjA6 /g6+62Km/FCt515Ir7sYA4D5xp/z7KdGHMwUmoWPr9R8jbGOVE4G5C1azrTK7cp6h0 jyPyoty2O+wB+kyqvUOhqo7bFVoI4F9SLkWSO/rftctwVBA9AvX5yAlSVh+a+NMyZS jEg56HSlSmbFtvX8VtJ6oi8B79XJrLMv6kqdb7zdp2HiZq9A7tZ0h7gYImvF4muVFK X1kwe4Dlbng4w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF7F7106F2EA; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Thu, 26 Mar 2026 00:57:32 -0700 Subject: [PATCH v3 2/3] leds: flash: rt8515: Support single-GPIO flash ICs with vin supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260326-expressatt_camera_flash-v3-2-e75e5d58990f@gmail.com> References: <20260326-expressatt_camera_flash-v3-0-e75e5d58990f@gmail.com> In-Reply-To: <20260326-expressatt_camera_flash-v3-0-e75e5d58990f@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774511852; l=6405; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=DxF5mr9S7uv5Cl6kr35TrWcazHvf6XEimdIWdUqrFXQ=; b=YHBFR5RPRglHCH2KuCsKeuM/gq+oIW3ZdvzbxUjlZLxoLKterQK6y2Y1c8gBWKAXaBe3oukFZ Y937K0FY7onD83c8SliHKUOBIMzn8FnyiUtzQkJN4OOVEV7vMoRdgcf X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Extend the RT8515 driver to support flash ICs that use only a single GPIO for both flash and torch modes (no separate ENT pin), with an optional vin regulator that gates power to the flash IC. When vin-supply is provided, the driver enables the regulator before activating the LED and disables it when turning off. Make ent-gpios optional and validate at probe time that exactly one of ent-gpios or vin-supply is provided. When ent-gpios is absent, the driver uses enf-gpios for both flash and torch brightness control. Assisted-by: Claude:claude-opus-4.6 Signed-off-by: Rudraksha Gupta --- drivers/leds/flash/leds-rt8515.c | 90 ++++++++++++++++++++++++++++++++----= ---- 1 file changed, 72 insertions(+), 18 deletions(-) diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8= 515.c index f6b439674c03..739cac8789c8 100644 --- a/drivers/leds/flash/leds-rt8515.c +++ b/drivers/leds/flash/leds-rt8515.c @@ -63,16 +63,44 @@ static struct rt8515 *to_rt8515(struct led_classdev_fla= sh *fled) return container_of(fled, struct rt8515, fled); } =20 -static void rt8515_gpio_led_off(struct rt8515 *rt) +static int rt8515_led_off(struct rt8515 *rt) { + int ret; + gpiod_set_value(rt->enable_flash, 0); - gpiod_set_value(rt->enable_torch, 0); + if (rt->enable_torch) + gpiod_set_value(rt->enable_torch, 0); + + /* Disable regulator */ + ret =3D regulator_is_enabled(rt->reg); + if (ret < 0) + return ret; + if (ret > 0) + return regulator_disable(rt->reg); + + return 0; } =20 -static void rt8515_gpio_brightness_commit(struct gpio_desc *gpiod, - int brightness) +static int rt8515_set_flash_brightness(struct rt8515 *rt, + struct gpio_desc *gpiod, + int brightness) { int i; + int ret; + + /* + * Reset the IC to start brightness from zero, + * then re-enable and pulse to the desired level. + */ + ret =3D rt8515_led_off(rt); + if (ret) + return ret; + /* IC needs time to reset its brightness counter */ + usleep_range(100, 200); + /* Enable regulator */ + ret =3D regulator_enable(rt->reg); + if (ret) + return ret; =20 /* * Toggling a GPIO line with a small delay increases the @@ -84,31 +112,41 @@ static void rt8515_gpio_brightness_commit(struct gpio_= desc *gpiod, gpiod_set_value(gpiod, 1); udelay(1); } + + return 0; } =20 /* This is setting the torch light level */ -static int rt8515_led_brightness_set(struct led_classdev *led, +static int rt8515_set_brightness(struct led_classdev *led, enum led_brightness brightness) { struct led_classdev_flash *fled =3D lcdev_to_flcdev(led); struct rt8515 *rt =3D to_rt8515(fled); + int ret =3D 0; =20 mutex_lock(&rt->lock); =20 if (brightness =3D=3D LED_OFF) { /* Off */ - rt8515_gpio_led_off(rt); + ret =3D rt8515_led_off(rt); + if (ret) + goto out; } else if (brightness < RT8515_TORCH_MAX) { - /* Step it up to movie mode brightness using the flash pin */ - rt8515_gpio_brightness_commit(rt->enable_torch, brightness); + /* Step it up to movie mode brightness */ + ret =3D rt8515_set_flash_brightness(rt, rt->enable_torch ? + rt->enable_torch : rt->enable_flash, brightness); + if (ret) + goto out; } else { /* Max torch brightness requested */ - gpiod_set_value(rt->enable_torch, 1); + gpiod_set_value(rt->enable_torch ? rt->enable_torch : + rt->enable_flash, 1); } =20 +out: mutex_unlock(&rt->lock); =20 - return 0; + return ret; } =20 static int rt8515_led_flash_strobe_set(struct led_classdev_flash *fled, @@ -117,27 +155,33 @@ static int rt8515_led_flash_strobe_set(struct led_cla= ssdev_flash *fled, struct rt8515 *rt =3D to_rt8515(fled); struct led_flash_setting *timeout =3D &fled->timeout; int brightness =3D rt->flash_max_intensity; + int ret =3D 0; =20 mutex_lock(&rt->lock); =20 if (state) { /* Enable LED flash mode and set brightness */ - rt8515_gpio_brightness_commit(rt->enable_flash, brightness); + ret =3D rt8515_set_flash_brightness(rt, rt->enable_flash, brightness); + if (ret) + goto out; /* Set timeout */ mod_timer(&rt->powerdown_timer, jiffies + usecs_to_jiffies(timeout->val)); } else { timer_delete_sync(&rt->powerdown_timer); /* Turn the LED off */ - rt8515_gpio_led_off(rt); + ret =3D rt8515_led_off(rt); + if (ret) + goto out; } =20 fled->led_cdev.brightness =3D LED_OFF; /* After this the torch LED will be disabled */ =20 +out: mutex_unlock(&rt->lock); =20 - return 0; + return ret; } =20 static int rt8515_led_flash_strobe_get(struct led_classdev_flash *fled, @@ -166,9 +210,12 @@ static const struct led_flash_ops rt8515_flash_ops =3D= { static void rt8515_powerdown_timer(struct timer_list *t) { struct rt8515 *rt =3D timer_container_of(rt, t, powerdown_timer); + int ret; =20 /* Turn the LED off */ - rt8515_gpio_led_off(rt); + ret =3D rt8515_led_off(rt); + if (ret) + dev_err(rt->dev, "failed to turn off LED (%d)\n", ret); } =20 static void rt8515_init_flash_timeout(struct rt8515 *rt) @@ -298,12 +345,18 @@ static int rt8515_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(rt->enable_flash), "cannot get ENF (enable flash) GPIO\n"); =20 - /* ENT - Enable Torch line */ - rt->enable_torch =3D devm_gpiod_get(dev, "ent", GPIOD_OUT_LOW); + /* ENT - Enable Torch line (optional for single-GPIO flash ICs) */ + rt->enable_torch =3D devm_gpiod_get_optional(dev, "ent", GPIOD_OUT_LOW); if (IS_ERR(rt->enable_torch)) return dev_err_probe(dev, PTR_ERR(rt->enable_torch), "cannot get ENT (enable torch) GPIO\n"); =20 + /* Optional VIN supply */ + rt->reg =3D devm_regulator_get(dev, "vin"); + if (IS_ERR(rt->reg)) + return dev_err_probe(dev, PTR_ERR(rt->reg), + "failed to get vin supply\n"); + child =3D device_get_next_child_node(dev, NULL); if (!child) { dev_err(dev, @@ -333,8 +386,9 @@ static int rt8515_probe(struct platform_device *pdev) =20 fled->ops =3D &rt8515_flash_ops; =20 - led->max_brightness =3D rt->torch_max_intensity; - led->brightness_set_blocking =3D rt8515_led_brightness_set; + led->max_brightness =3D rt->enable_torch ? + rt->torch_max_intensity : rt->flash_max_intensity; + led->brightness_set_blocking =3D rt8515_set_brightness; led->flags |=3D LED_CORE_SUSPENDRESUME | LED_DEV_CAP_FLASH; =20 mutex_init(&rt->lock); --=20 2.53.0 From nobody Thu Apr 2 22:23:01 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88C843B6BE2; Thu, 26 Mar 2026 07:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; cv=none; b=e+0R+z4AyXD/EHf9katwZxN+fq/C9FpIlfefpLZ7yDuccR2z4+iT2ebhf/d9TGS2/8EVgJR7foIS6M12WK9r225T66sHbwGN4Dgssn4TeZKG+WlyJcosJ8e+xmVGLqrpsTc+2oHimf3BebkujZ4ICXnyjH88lNIvH89h+eYXrDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774511853; c=relaxed/simple; bh=xDLWcXbFRmCefCm+pbQPSZwGrH6dkIj26hBraq/lSrg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uWsard8RzoASY/FQrgW3w0g4cccCT5fQvFtSakQM1V3HYYzf6yZCuS6jL+sdq7V3xqEoks+jsAD28zhauwHAtQ+CLyIoseGVQojBYqR+9f/ueaeGN8xDfi1KQJowgzrPOAO5Sf3msf5SFs6EhBG6Uj+Jyy6VMfEgcbKdIsp42AE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jRxKOUup; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jRxKOUup" Received: by smtp.kernel.org (Postfix) with ESMTPS id E7F37C2BCB6; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774511853; bh=xDLWcXbFRmCefCm+pbQPSZwGrH6dkIj26hBraq/lSrg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=jRxKOUupnWneaVTnuY5bCmp+zXMxm64RRLQUeaKByfi2NgyRH2sg6woJj+bUEOn/Z A14JGuJsA9q5zIj4+eLcsRD/jBVB9ojQMLdnw/QGMLTbyM5q0dFatlZ7z9CwZQJ47m i46WfLjayw7HtDO8bIDzVSVe1eNj1vE51+Z2/UrXpfVxFJ5RKGu/qY32c3LOvTZ47X pOtvqnPqth2CHaJAxJ20IIW+B5rwCLD+mRKFxmg+k4r3cGmVxJ+5mc/nPp5HImXx0j 00BVgczDgP4PfNGCokLj4iM88kYitv01fmHZs4C5/nZWwFnwh3tJTCKLMqZR4twBfJ eVaJ8xfY1wUAQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF95A106F2E9; Thu, 26 Mar 2026 07:57:32 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Thu, 26 Mar 2026 00:57:33 -0700 Subject: [PATCH v3 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260326-expressatt_camera_flash-v3-3-e75e5d58990f@gmail.com> References: <20260326-expressatt_camera_flash-v3-0-e75e5d58990f@gmail.com> In-Reply-To: <20260326-expressatt_camera_flash-v3-0-e75e5d58990f@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1774511852; l=2769; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=E3bvoy4yC0bIqkNCh6mchqNlZsPxKTVNKTYXqgkkJOA=; b=hc5OnPVs0kdOQ0weHsoKi54CZFSnCzCNylJgdSXsqUKnLh9pHh7R4LYveHiDkwHv2OjFwB/c+ I1TZi3ZgSYWC/lV9hm1coRg2PMRtnrt7v8RMFN9ciV5ejzxlD4IgJeO X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Add camera flash support for the Samsung Galaxy Express (expressatt). The flash IC uses a one-wire pulse-count protocol on GPIO 3, powered by a GPIO-controlled fixed regulator on PMIC MPP 4. The regulator is modeled as a regulator-fixed node and supplied to the flash IC via vin-supply. Downstream references: Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/drivers/leds/Makefile#L51 Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/arch/arm/mach-msm/board-apexq-camera.c#L591 Assisted-by: Claude:claude-opus-4.6 Reviewed-by: David Heidelberg Signed-off-by: Rudraksha Gupta Reviewed-by: Konrad Dybcio --- .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 43 ++++++++++++++++++= ++++ 1 file changed, 43 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/a= rch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts index c4b98af6955d..35514fd53e3d 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include =20 #include "qcom-msm8960.dtsi" @@ -61,6 +62,32 @@ touchkey_enable: touchkey-enable { regulator-boot-on; }; =20 + vreg_flash: regulator-flash { + compatible =3D "regulator-fixed"; + regulator-name =3D "VREG_FLASH_3P3"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + gpio =3D <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + pinctrl-0 =3D <&flash_led_unlock>; + pinctrl-names =3D "default"; + }; + + led-controller { + compatible =3D "richtek,rt8515"; + enf-gpios =3D <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply =3D <&vreg_flash>; + richtek,rfs-ohms =3D <16000>; + pinctrl-0 =3D <&cam_flash_en>; + pinctrl-names =3D "default"; + + led { + function =3D LED_FUNCTION_FLASH; + color =3D ; + flash-max-timeout-us =3D <250000>; + }; + }; + i2c-gpio-touchkey { compatible =3D "i2c-gpio"; #address-cells =3D <1>; @@ -172,6 +199,13 @@ touchscreen@4a { }; =20 &tlmm { + cam_flash_en: cam-flash-en-state { + pins =3D "gpio3"; + function =3D "gpio"; + drive-strength =3D <16>; + bias-pull-down; + }; + spi1_default: spi1-default-state { mosi-pins { pins =3D "gpio6"; @@ -572,3 +606,12 @@ magnetometer@2e { /* TODO: Figure out Mount Matrix */ }; }; + +&pm8921_mpps { + flash_led_unlock: flash-led-unlock-state { + pins =3D "mpp4"; + function =3D "digital"; + output-low; + power-source =3D ; + }; +}; --=20 2.53.0