From nobody Thu Apr 2 23:59:22 2026 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6484839020C for ; Wed, 25 Mar 2026 21:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774474116; cv=none; b=tDXAjzKXbPzTZb2a1I6GC9aa2LWl0WPY6qo+VdlolPUQznkXrWNsyB2YCqO923iYDIlz4LP++mBGH4HSQygcUSfDSlD8ij9eoAf/g7m6rZotuSWPr9LIuP7wUf+Op5dw2o/hr0/l3Wi4d5M0IQ1CoHJAsP0z6yOhTwT7NUSu3cQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774474116; c=relaxed/simple; bh=dZn3sIYKjksM96meVTQNN5g1BY1Ruf7AkckoMYg0fGw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N6aPoFmTSOENsZmoOAY326iAJdG+sADHfO3GUDE/lx8NmK5KGiJ89LA/nKURWlmPfBMLgxDT9Qf6BLBgjRkNgSJzcqcDnCXFiPgNHrzfgV6754TSMD19w86/LB9Wpw73cos7j9ISzUI2QyVyudv/PPXw3DGLuDeG4SPj1wmTPJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CEipKy8Z; arc=none smtp.client-ip=209.85.222.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CEipKy8Z" Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-95194fbf768so94459241.1 for ; Wed, 25 Mar 2026 14:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774474113; x=1775078913; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NhH6u8MbNJGpGxJ5nMUQP9i3yhSfD2LDetMrAwhe3b4=; b=CEipKy8ZuR+OKrDRsl69MQeQzpWmGspO5d76aKDjrNPYPTkSsvXpBZ4xlaVnQsGzMs Ymz4K5fSxpFdch8eSkVNij43RfQJdKZAfNITymy1dg9+XTSiR/rdAjFq/9R5aK47cymm fl0tH463X/X19zquvAcMeLb+blOphhYQDz4Hfgse2peABUDTcU/caoZEz6rrZxg5dshy tn9x1fM9nPx8SJxIDM/P/skQi6Gs72RKKwEr2+HuenYqK9NHcVpiy4fUxmATO9VuNmtZ lgrQLhpH3+/e+YQrCAmCICCj31b1z9RanMVIPH2E+hFI0XRuYFHQAf5KzIvP0ItPq83t ub/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774474113; x=1775078913; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NhH6u8MbNJGpGxJ5nMUQP9i3yhSfD2LDetMrAwhe3b4=; b=fKQBwzkUO/U3ROsT+164dE9Ae0jR1I2HEaqbC2fB8djcnu9LYfnSGchmrdyj3a8vf8 FvtwDujHiP3KEzFetGvbVhGKTKFZi6P52FT/Pj1PcVsThJh2idSdK7H/N80E5tpW7RWI jfw8H1Wtpbj890JYWZHxiQhvxutkjPQvOLdkc7y4kGSCFfFUwR4IxeztPKOzHpUlvyF4 eeCpB/S4frLIXtHZ9Ix7zWGU5rBGn+9JB8mVekHlsg8x6IT/b729ySEkhte25fZvmopI 6wG0xWN02IM8q9nTS8yrYD4Wqp+4pEBLL+KINdHB0q4LIJ4E/XoIeLbtsETcFy9MlaCK XdmA== X-Forwarded-Encrypted: i=1; AJvYcCVGDiSv/2aLvs0Pju2KbSXPYvGGYWrDt1ZN1wMZSjlFuXlpzbc/rEzpSs4v4KBT2skwIe6VlWXb+W0TAqk=@vger.kernel.org X-Gm-Message-State: AOJu0YwJtH/bHwW4k/cu3XIrdF8ZaCYHbD6CpQs65PyqVn9Dfr7HXR8G qEXyDFkWayIbSmsxIHNMIEh+r41HoK5THPdVp4luoL0FlKTPjgKUGjzqxwdsFg== X-Gm-Gg: ATEYQzyXdPBxknIjZzRWh9drsFzML0w0Y9Y2lC5QCpTdvWOM1ZyI3pSshy5Z24WNTsQ oCgKqIr3UOyMSvKHyZm5NFCGLeSy2mlRUBxKVccZOG8LyRD2XoW6hBkAx4K+/+qbta45dePcJkm MePpocboazt88f3xvm/r/tbJthkW8mXpuRADNg762uT38fDiUVfx09mENGb/R2IHkOXXS5lq7/z esDXFu9FkxTjrf/HlM4VgHJsriki4IQIH+xtIcJtfbwrGuyHc+sv87+xOkUc+cC23i/Nk2zaC8w 9jd43+U1QgFK6Rupfr9Af6Dmu/0Q9Q1nNe7qv3KsYJWuIlrZt68NFQOQs3XM/CkdbtLAGzHwc55 KJ+jfHQE9v9JDNNsdosO9PpVwGISDC+4MqAzpkzMz67njbJHy0nzkOSiGayO7x5rY7pQEknhIH1 HIbhMTeeImwOxXXl1/62k0Oe9QjLKXRdgsocBvNj8A9oHKyHqNMWyvkcJbwqYmMbx5U5ajNyG3Z pVwMo+pdqmArHxy X-Received: by 2002:a05:6102:290d:b0:600:3b3e:681a with SMTP id ada2fe7eead31-603161b7da7mr4084461137.14.1774474113222; Wed, 25 Mar 2026 14:28:33 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:4c64:82a2:6788:b4b3:f9bb:acc1]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-951be56f28esm1469494241.10.2026.03.25.14.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 14:28:32 -0700 (PDT) From: Rodrigo Gobbi To: gregkh@linuxfoundation.org Cc: ~lkcamp/patches@lists.sr.ht, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: remove unused arg at odm_interface.h Date: Wed, 25 Mar 2026 18:21:08 -0300 Message-ID: <20260325212826.20309-1-rodrigo.gobbi.7@gmail.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The header file uses some macros to create proper constants for ODM_REG and ODM_SET but current macros were not using _ic_type, leading to a checkpatch warn: WARNING: Argument '_ic_type' is not used in function-like macro Remove that arg, currently there is no support for per ic type Signed-off-by: Rodrigo Gobbi --- Hi, all, While exploring with checkpath found this warn: drivers/staging/rtl8723bs/hal/odm_interface.h:32: WARNING: Argument '_ic_ty= pe' is not used in function-like macro Looks like original plan was to support multi IC with hal for creating fina= l reg macros, but apparently only 8723 ic is supported and "ic type" (_pDM_Odm) was not used leading to that warn:=20 #define _cat(_name, _func) _func##_11N(_name) #define ODM_REG(_name, _pDM_Odm) _cat(_name, _pDM_Odm->SupportICType, _reg) #define ODM_BIT(_name, _pDM_Odm) _cat(_name, _pDM_Odm->SupportICType, _bit) This patch is suggesting to remove that arg from macro and its usage. Tks and regards. --- drivers/staging/rtl8723bs/hal/odm.c | 4 ++-- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 8 ++++---- drivers/staging/rtl8723bs/hal/odm_DIG.c | 8 ++++---- drivers/staging/rtl8723bs/hal/odm_interface.h | 12 ++++++------ 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 639b6da2302b..3dffa7620768 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -131,8 +131,8 @@ u8 CCKSwingTable_Ch14_New[CCK_TABLE_SIZE][8] =3D { =20 static void odm_CommonInfoSelfInit(struct dm_odm_t *pDM_Odm) { - pDM_Odm->bCckHighPower =3D (bool) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_RE= G(CCK_RPT_FORMAT, pDM_Odm), ODM_BIT(CCK_RPT_FORMAT, pDM_Odm)); - pDM_Odm->RFPathRxEnable =3D (u8) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG= (BB_RX_PATH, pDM_Odm), ODM_BIT(BB_RX_PATH, pDM_Odm)); + pDM_Odm->bCckHighPower =3D (bool) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_RE= G(CCK_RPT_FORMAT), ODM_BIT(CCK_RPT_FORMAT)); + pDM_Odm->RFPathRxEnable =3D (u8) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_REG= (BB_RX_PATH), ODM_BIT(BB_RX_PATH)); =20 pDM_Odm->TxRate =3D 0xFF; } diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/stag= ing/rtl8723bs/hal/odm_CfoTracking.c index 166af5f6c9e0..0eaedd8f6469 100644 --- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c +++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c @@ -47,8 +47,8 @@ static void odm_SetATCStatus(void *pDM_VOID, bool ATCStat= us) =20 PHY_SetBBReg( pDM_Odm->Adapter, - ODM_REG(BB_ATC, pDM_Odm), - ODM_BIT(BB_ATC, pDM_Odm), + ODM_REG(BB_ATC), + ODM_BIT(BB_ATC), ATCStatus ); pCfoTrack->bATCStatus =3D ATCStatus; @@ -61,8 +61,8 @@ static bool odm_GetATCStatus(void *pDM_VOID) =20 ATCStatus =3D (bool)PHY_QueryBBReg( pDM_Odm->Adapter, - ODM_REG(BB_ATC, pDM_Odm), - ODM_BIT(BB_ATC, pDM_Odm) + ODM_REG(BB_ATC), + ODM_BIT(BB_ATC) ); return ATCStatus; } diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8= 723bs/hal/odm_DIG.c index 33661182d85a..a31c8368f9d9 100644 --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c @@ -297,9 +297,9 @@ void ODM_Write_DIG(void *pDM_VOID, u8 CurrentIGI) } =20 /* 1 Set IGI value */ - PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM= _Odm), CurrentIGI); + PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG(IGI_A), ODM_BIT(IGI), CurrentIGI); =20 - PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG(IGI_B, pDM_Odm), ODM_BIT(IGI, pDM= _Odm), CurrentIGI); + PHY_SetBBReg(pDM_Odm->Adapter, ODM_REG(IGI_B), ODM_BIT(IGI), CurrentIGI); =20 pDM_DigTable->CurIGValue =3D CurrentIGI; } @@ -336,7 +336,7 @@ void odm_DIGInit(void *pDM_VOID) =20 pDM_DigTable->bStopDIG =3D false; pDM_DigTable->bPSDInProgress =3D false; - pDM_DigTable->CurIGValue =3D (u8) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_RE= G(IGI_A, pDM_Odm), ODM_BIT(IGI, pDM_Odm)); + pDM_DigTable->CurIGValue =3D (u8) PHY_QueryBBReg(pDM_Odm->Adapter, ODM_RE= G(IGI_A), ODM_BIT(IGI)); pDM_DigTable->RssiLowThresh =3D DM_DIG_THRESH_LOW; pDM_DigTable->RssiHighThresh =3D DM_DIG_THRESH_HIGH; pDM_DigTable->FALowThresh =3D DMfalseALARM_THRESH_LOW; @@ -806,7 +806,7 @@ void ODM_Write_CCK_CCA_Thres(void *pDM_VOID, u8 CurCCK_= CCAThres) =20 /* modify by Guo.Mingzhi 2012-01-03 */ if (pDM_DigTable->CurCCK_CCAThres !=3D CurCCK_CCAThres) - rtw_write8(pDM_Odm->Adapter, ODM_REG(CCK_CCA, pDM_Odm), CurCCK_CCAThres); + rtw_write8(pDM_Odm->Adapter, ODM_REG(CCK_CCA), CurCCK_CCAThres); =20 pDM_DigTable->PreCCK_CCAThres =3D pDM_DigTable->CurCCK_CCAThres; pDM_DigTable->CurCCK_CCAThres =3D CurCCK_CCAThres; diff --git a/drivers/staging/rtl8723bs/hal/odm_interface.h b/drivers/stagin= g/rtl8723bs/hal/odm_interface.h index d19347b02890..400473ca58ca 100644 --- a/drivers/staging/rtl8723bs/hal/odm_interface.h +++ b/drivers/staging/rtl8723bs/hal/odm_interface.h @@ -23,18 +23,18 @@ #define ODM_REG_DIG_11N 0xC50 #define ODM_REG_DIG_11AC 0xDDD =20 -ODM_REG(DIG, _pDM_Odm) +ODM_REG(DIG) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D*/ =20 #define _reg_11N(_name) ODM_REG_##_name##_11N #define _bit_11N(_name) ODM_BIT_##_name##_11N =20 -#define _cat(_name, _ic_type, _func) _func##_11N(_name) +#define _cat(_name, _func) _func##_11N(_name) =20 /* _name: name of register or bit. */ -/* Example: "ODM_REG(R_A_AGC_CORE1, pDM_Odm)" */ -/* gets "ODM_R_A_AGC_CORE1" or "ODM_R_A_AGC_CORE1_8192C", depends = on SupportICType. */ -#define ODM_REG(_name, _pDM_Odm) _cat(_name, _pDM_Odm->SupportICType, _reg) -#define ODM_BIT(_name, _pDM_Odm) _cat(_name, _pDM_Odm->SupportICType, _bit) +/* Example: "ODM_REG(R_A_AGC_CORE1)" */ +/* gets "ODM_R_A_AGC_CORE1" or "ODM_R_A_AGC_CORE1_8192C". */ +#define ODM_REG(_name) _cat(_name, _reg) +#define ODM_BIT(_name) _cat(_name, _bit) =20 #endif /* __ODM_INTERFACE_H__ */ --=20 2.48.1