From nobody Thu Apr 2 23:53:26 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E475329C48 for ; Wed, 25 Mar 2026 21:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774473031; cv=none; b=ZYYmIaDTprRGHymyvgKtBzqgUoYKLKjnXiBwL9noNb7LtqxnhZIf7Qg0zVRyiAMRzgNLQcMC3S/0QsIUqgrxNQpmYbQ1c9JSol02R6LVNx1z4pnGn333X5S3Hc4BKG0GkfE0CTsMpHmYhDYZKB9BkUsdILhH2RUw0MqOfqV/TCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774473031; c=relaxed/simple; bh=EdB6DPiN8FKeiio8Zju6nWp05TVS4Vg3vXPECqfqVio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WJEjPDK9OxeukiBJbtYS9Oa5yKJ5b/2xxIm5hm2euZ5U7YiSvGx2P0NoJLVWrhAVVY880V85FtDrQU8+9ffmocH+bkYCaSrAe9gf9L8NmzGN/Ds8W2r2z/7if0elZBp2HdH6unUa+36JI42h6IsPG6Gk/T27henk6gYH4aBZb6A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p+WYWLBd; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p+WYWLBd" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-487035181a7so1989625e9.2 for ; Wed, 25 Mar 2026 14:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774473029; x=1775077829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=15zkOITK805bj4kGcIz33FjQCtlZ3HG9BF9nSIpqkFU=; b=p+WYWLBdmsOSqKjKWYi3Yzecx7V01yIOrJlSXr7cX03kmTfdWnn7fSyoRJnAp5Far4 1Qh6FUYD3c/3JSuDJyzjjxuEGwaEbh3lLdjMR/oa4Ag1Yr4C0dAcm9wrPenmNIeVSd91 fDnj1HnqKRtBMQNF0YQzO5azaclLynlPk4EsoJWS7xrJ0T6qncRWaH8hj4JBxxH/bN7k x7VxaN4Cmte/isCqd/81y/AKYecWS5ExSWnHCGR0cyt3/B60ZG1xnDDYGv3VGLb1yIy+ FUxo6cLVIR8MqKh/eFaCtJvKVY+IwzdrgcrUFxueoVzV5Kph/zrf1+Z2p4zu3IfV77eW fUBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774473029; x=1775077829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=15zkOITK805bj4kGcIz33FjQCtlZ3HG9BF9nSIpqkFU=; b=QANaHRT9fRkA7hLeAZMyuAZhpesIjCUK+/t9QOG9Oz7n4rpF8I0wQOoCvjZ8hisEjh e4MwH2zUSGYk39SBEymlhvc9T2XWSNHjqHw8oD5Z9VR4afM7ZHMD2dtODvFWyqZlj2UR ni17MJm5ioxQP3iuVZwCWGLaZTh+KxP8alRylImq6f9oqZJQw4r8lQcN27doKmqT7ZjC 23LI+SGPwBdV63+k9DegACHCBMf7E74m/LK4bOPsn0/iKVvx+EjrO1HOHSenviSMVZmG R4JGyx/dW1M2uJWaxuEaye0YTFTnrB4+jC38MWy2zGECGA2k3TcSM4BqQ2DJ/3FLkDR7 mDhw== X-Forwarded-Encrypted: i=1; AJvYcCWMg8ZZg/FJMwoUs1vf8g8wSi1wE8HrZMj3LsWxL5fYyUigAlr0cctjnZElj8o8Wu3G5ByQGhwE9j1FzVw=@vger.kernel.org X-Gm-Message-State: AOJu0YyLhAT7ZHfkun8Eq/3gxrECH7+Go54lvU2mE/BjJOgbyPgufcpe jcyWXNDp5O3vGf3VNgnfQkq6Q/PuO6GMFYVd5Pk88N8qlTwfhrKOLxrEr/pz X-Gm-Gg: ATEYQzwwHZQMLpAU4qQqITQdIyuM3C8Ls+aFUR7/C0AnlkWIfrbblN1HZAgzRDt4Wej RBEk9uOH8OeWevZ7w/PWaNCwcEPdtl8hf+AKYALm/wa3IynJDtgKkqk1CmaSM3tfbjxt0caIsbW 4s/RuPO+JR6hXqgvwy4vo1OOenuZXcmWJi330iD5gJSfS7DjkVy+ljuGkUKpRdCFtq/p7QvT8Dr s0uf+CGdXI1wD6ybuY6LvvzfNmxSf/g4qgHOcOdUzVeVfgjrJUU+hMMpXHNijzA5xHXuqv36aDs tVhlfCuzZjBuSKME/FF7NYQIafjT9cbj43OTA9Uvew6hTyXUN6osntjz5KTOxvWpZzCfXB0Vz1e Djz7kG4Ro5o7Cf5UuQ6rmgQpvlUSeoF7iGn0/rMGNKAxFODeEWBTU5O9FLDrzZbJsgJuHWa/mY1 tC97ZJxSrcAO4UKMebEqiI+ZQANQMGyI23RkqmI+Pjhw== X-Received: by 2002:a05:600c:3e1a:b0:486:af22:4a2a with SMTP id 5b1f17b1804b1-48715fbabedmr66812585e9.7.1774473028721; Wed, 25 Mar 2026 14:10:28 -0700 (PDT) Received: from localhost.localdomain ([78.241.70.142]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4871fb336c3sm11673765e9.2.2026.03.25.14.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 14:10:28 -0700 (PDT) From: Jihed Chaibi To: lars@metafoo.de, nuno.sa@analog.com Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, jihed.chaibi.dev@gmail.com Subject: [PATCH v2 1/2] ASoC: adau1372: Fix unchecked clk_prepare_enable() return value Date: Wed, 25 Mar 2026 22:07:03 +0100 Message-ID: <20260325210704.76847-2-jihed.chaibi.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260325210704.76847-1-jihed.chaibi.dev@gmail.com> References: <20260325210704.76847-1-jihed.chaibi.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" adau1372_set_power() calls clk_prepare_enable() but discards the return value. If the clock enable fails, the driver proceeds to access registers on unpowered hardware, potentially causing silent corruption. Make adau1372_set_power() return int and propagate the error from clk_prepare_enable(). Update adau1372_set_bias_level() to return the error directly for the STANDBY and OFF cases. Signed-off-by: Jihed Chaibi Reviewed-by: Nuno S=C3=A1 --- Changes in v2: - No changes. sound/soc/codecs/adau1372.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/adau1372.c b/sound/soc/codecs/adau1372.c index fdee689cae53..6345342218d6 100644 --- a/sound/soc/codecs/adau1372.c +++ b/sound/soc/codecs/adau1372.c @@ -782,15 +782,18 @@ static void adau1372_enable_pll(struct adau1372 *adau= 1372) dev_err(adau1372->dev, "Failed to lock PLL\n"); } -static void adau1372_set_power(struct adau1372 *adau1372, bool enable) +static int adau1372_set_power(struct adau1372 *adau1372, bool enable) { if (adau1372->enabled =3D=3D enable) - return; + return 0; if (enable) { unsigned int clk_ctrl =3D ADAU1372_CLK_CTRL_MCLK_EN; + int ret; - clk_prepare_enable(adau1372->mclk); + ret =3D clk_prepare_enable(adau1372->mclk); + if (ret) + return ret; if (adau1372->pd_gpio) gpiod_set_value(adau1372->pd_gpio, 0); @@ -829,6 +832,8 @@ static void adau1372_set_power(struct adau1372 *adau137= 2, bool enable) } adau1372->enabled =3D enable; + + return 0; } static int adau1372_set_bias_level(struct snd_soc_component *component, @@ -842,11 +847,9 @@ static int adau1372_set_bias_level(struct snd_soc_comp= onent *component, case SND_SOC_BIAS_PREPARE: break; case SND_SOC_BIAS_STANDBY: - adau1372_set_power(adau1372, true); - break; + return adau1372_set_power(adau1372, true); case SND_SOC_BIAS_OFF: - adau1372_set_power(adau1372, false); - break; + return adau1372_set_power(adau1372, false); } return 0; -- 2.47.3 From nobody Thu Apr 2 23:53:26 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDAB6330B22 for ; Wed, 25 Mar 2026 21:10:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774473033; cv=none; b=mgihDWFqXXxae984e+e8tK8pUTKFE8g/pH+L4zJqx4QrOsB+ID7An0tyAxXc4hrdUfw6uruaf/POKM6/+PqX0QSvLSLqrQdqnSLxLU40a9vaA0B7dmh6xSuOZrxJVkOFJQ3ElycZ8JyB0sU/GG0tFZ+Yn0jV8Zv+5YYqHeaIkJU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774473033; c=relaxed/simple; bh=tUzIUb7k3J6cOpfCCMDZdP6M9eodSIZ13LiGR9eH2hU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nxUzK2PhoS02TzBwXYwv+2LDb7z1ECG9TT3mvIZ4OnhsKqdgsqrkfEON96AcCbb2opEIJOi4Goj6UTtzTyOrB2y2tIWVLTYSfmSWF5mT0x8YU6pdOt9OcnCT6OsWBZ2RQAi74w+i9g1v3ZpUPuoDl8b235G3Qf4NodG90fjToOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pVgbQ528; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pVgbQ528" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-483487335c2so3567895e9.2 for ; Wed, 25 Mar 2026 14:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774473030; x=1775077830; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZZ5QxoSZaUzmehajJJUJGfXXBnnvkvRAu9eZCPtocyQ=; b=pVgbQ528hdXCN8bKjJOsph2rfkOhWkl+EAz9XGWKKscPBfbQaSRuiIhIIR07Ejgt/B mwLZ5zQ0b/Nu6AR4nXoY8bvG2d9wZ6lrjiB72tShm1d/2zSLz4EX2gobHyod9xHvb+w2 guiHp0T++5L/J3Umotmb52nhz4F0jpTUblxRlFG7L8em7U+ggfdgiPrzHfY5/O640Ez/ 7El9hMvKs8RZWrO0/3SggnFPcpJg7I3C4iMZgEGXmKoTXR91NTVH4zBztf6N7kh1FuX/ vRdp6ZnFrdjJv9jPgRFf2bwXWiXISd9xQnbag7GgIGBA8M7jcxrKZwIlRxqT9twf9Aot x7ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774473030; x=1775077830; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZZ5QxoSZaUzmehajJJUJGfXXBnnvkvRAu9eZCPtocyQ=; b=HvrETai46Mug6sRziszRwFklF9glBpzTyWaRLwYoER/VlL8697nb57LTwnOuV5pAtm eib9L5VdwgIz0XoDeIrIDUQsCESHLWzVFUiwzT+HMwFA3XdgBi6j+WB+P82uFCY8rYPv MpOjfk4v+6pVMe8lCaYAm2OTlod7OwOCjfmqdMtiBIlPViJSRkA/YuDbhPw5iVerS3L6 mqWifxUbkSZczxKKev0/ROJmMACG8vUXWV4Xq8cCX8U4HAVORWTkv621fatdBL28Qlxh zu2KY7LEm4B1mM5vMcZJkCYA7uUGjO6X38TsTW6KMXoRA1ViBr2NZImNyW8bHio8vHdg qGBQ== X-Forwarded-Encrypted: i=1; AJvYcCWmsnQaODZHYbUWYqb+Ypbeqt9GnwS5OJa4yGA8EZRAAMrCDM4GOoUQCBUGAZW7tLNMZgmU9qVMi0ziiGQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc2S5XHXSLtg5wxHoUvgO2aQ8KS12pmHxidJ7pdDzcoHljwoMF aXbTLBHWvsDt6hcF3xDEZXxB977QHgxSRpaHV1TZUmSmjuobk/OPF/g= X-Gm-Gg: ATEYQzwoZgIoe3egYKsagPvNIyadrxFMSNUSEf3G8tPi4X/SEKTiW/y7gkzwLubvqKs ANa9fbOzO4VQrg6YtPxnD5D9RyivwbwoDPWR8EoBKb4Rius+9FD1EzhcpTOHou+wYcbGqFh1rfl HZ7YwtgFzlzPQ9BwjqUwnAxNjnIL1j0ZTJE3yZMOMNkljSzZjHWmX6GARmfxLescv6Be5QQH2e5 SzRRaEnO38yNYFgdrye6djfgHsr3WhUo0h+x6H8AzQIrE3UJXri9Fqj0UZ0c/Iilis447ryOYLc iowGnx/ZOT1WEut3LcC9IBKEOVS/bUafsbvHZmoSi/Vxp/RUC3vagQQA5EfjScxA0J31lmCSaMW 39M8usWylMGFlA7kbrArIL1K27txEsnm5lvd/NGVmReBt1+uQqulH1RspyDAJM/H/mEzXG8+M3S bZtaQgQzrBhLyYNO4rC5qMt+GroLp/j2aSwjfG2XIdbQ== X-Received: by 2002:a05:600c:154a:b0:485:3d3e:1675 with SMTP id 5b1f17b1804b1-48715fd6119mr78561645e9.8.1774473030145; Wed, 25 Mar 2026 14:10:30 -0700 (PDT) Received: from localhost.localdomain ([78.241.70.142]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4871fb336c3sm11673765e9.2.2026.03.25.14.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 14:10:29 -0700 (PDT) From: Jihed Chaibi To: lars@metafoo.de, nuno.sa@analog.com Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, jihed.chaibi.dev@gmail.com Subject: [PATCH v2 2/2] ASoC: adau1372: Fix clock leak on PLL lock failure Date: Wed, 25 Mar 2026 22:07:04 +0100 Message-ID: <20260325210704.76847-3-jihed.chaibi.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260325210704.76847-1-jihed.chaibi.dev@gmail.com> References: <20260325210704.76847-1-jihed.chaibi.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" adau1372_enable_pll() was a void function that logged a dev_err() on PLL lock timeout but did not propagate the error. As a result, adau1372_set_power() would continue with adau1372->enabled set to true despite the PLL being unlocked, and the mclk left enabled with no corresponding disable on the error path. Convert adau1372_enable_pll() to return int, using -ETIMEDOUT on lock timeout and propagating regmap errors directly. In adau1372_set_power(), check the return value and unwind in reverse order: restore regcache to cache-only mode, reassert GPIO power-down, and disable the clock before returning the error. Signed-off-by: Jihed Chaibi Reviewed-by: Nuno S=C3=A1 --- Changes in v2: - Also unwind regcache and GPIO power-down state on PLL lock failure, as noted by Mark Brown. sound/soc/codecs/adau1372.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/adau1372.c b/sound/soc/codecs/adau1372.c index 6345342218d6..e3eba241bdf7 100644 --- a/sound/soc/codecs/adau1372.c +++ b/sound/soc/codecs/adau1372.c @@ -762,7 +762,7 @@ static int adau1372_startup(struct snd_pcm_substream *s= ubstream, struct snd_soc_ return 0; } -static void adau1372_enable_pll(struct adau1372 *adau1372) +static int adau1372_enable_pll(struct adau1372 *adau1372) { unsigned int val, timeout =3D 0; int ret; @@ -778,8 +778,12 @@ static void adau1372_enable_pll(struct adau1372 *adau1= 372) timeout++; } while (!(val & 1) && timeout < 3); - if (ret < 0 || !(val & 1)) + if (ret < 0 || !(val & 1)) { dev_err(adau1372->dev, "Failed to lock PLL\n"); + return ret < 0 ? ret : -ETIMEDOUT; + } + + return 0; } static int adau1372_set_power(struct adau1372 *adau1372, bool enable) @@ -807,7 +811,14 @@ static int adau1372_set_power(struct adau1372 *adau137= 2, bool enable) * accessed. */ if (adau1372->use_pll) { - adau1372_enable_pll(adau1372); + ret =3D adau1372_enable_pll(adau1372); + if (ret) { + regcache_cache_only(adau1372->regmap, true); + if (adau1372->pd_gpio) + gpiod_set_value(adau1372->pd_gpio, 1); + clk_disable_unprepare(adau1372->mclk); + return ret; + } clk_ctrl |=3D ADAU1372_CLK_CTRL_CLKSRC; } -- 2.47.3