From nobody Fri Apr 3 01:28:25 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0371348895; Wed, 25 Mar 2026 21:02:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774472533; cv=none; b=GMVzH8mo8KZMoxJwLrsik9aS4nzSj6QpmFo5cHJg6bO7Qo9dcdDzE3vKXcNZX1IJ1Wz8941kuvopdUNcttN2wfH5EQwES0Pz7W8p2KLdOe6AYqPMuEOZQK2Jc7DxvzFJuhYO7QrF7h6vNjt5zpRgJsv3CwHrUtqrgymJwDq8FIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774472533; c=relaxed/simple; bh=pUnRt60E4eVwuV/JK2wFa8KNuRSP42svA6IpzNxVhEY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FJAEFa0qpwK5j1CmWdEgPUx47qCxHV2m9Th3D1Ki/EE9vcug9NlmlM6lvxULD/OokuTqz2uRgAPjXAITEYlv7IeI/DQDRdB7Njwybib/6Wzhcmele7wr1x66dxIyNUfmWLJAbkk+TI9pzBXvIlBrao5TcXpiu7wJNMIRKp3pyjY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Rwu/pXJs; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Rwu/pXJs" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62P9Wrll094514; Wed, 25 Mar 2026 21:02:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=uBu1K38NNRbHA+kc7 FmrfFTckZQKlirl+LLZ1sU1V0w=; b=Rwu/pXJs2X24M4EgoOHj8L+xcd+5rTPP/ +6kNd6znfACFOJlI3yGkKfUZ7Ovd0z7pZk+PISKqoqrhZBANdHLBzJj4tHQN8ABe eP+yj2XR6rZLKrBh8Q046oZE4D6VEJoT3zvtY/sOARv1qEANRaMqAD0Pgfm3mUCL CC4DvuKzNuKOyrrDNt/YSMZ1c+wjgeaQRzxcsBmkqZiiMcwmIIr0iu5yPHjC2X8s hXxCX5JuFrXhELpB+w4L7y9yPWABGuKb7qRrRjWwACd1vLN6UnTL3uXWU56375Fc J5N0S1VwQX31jaaBpT2LvoXROt7gGLBvbMuOdyUxL12xKBwwH5IjA== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1ky09feb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2026 21:02:07 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62PK8tHa011824; Wed, 25 Mar 2026 21:02:06 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4d27vk816v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 25 Mar 2026 21:02:06 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62PL24LB26804892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2026 21:02:04 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C39FE5805D; Wed, 25 Mar 2026 21:02:04 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CBF9358052; Wed, 25 Mar 2026 21:02:03 +0000 (GMT) Received: from li-4c4c4544-004d-4810-8043-b7c04f423534.ibm.com.com (unknown [9.61.136.69]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 25 Mar 2026 21:02:03 +0000 (GMT) From: Anthony Krowiak To: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: jjherne@linux.ibm.com, borntraeger@de.ibm.com, mjrosato@linux.ibm.com, pasic@linux.ibm.com, alex@shazbot.org, kwankhede@nvidia.com, fiuczy@linux.ibm.com, pbonzini@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com Subject: [PATCH v1 12/24] s390-vfio-ap: Callback to set vfio device mig state during guest migration Date: Wed, 25 Mar 2026 17:00:59 -0400 Message-ID: <20260325210149.888028-13-akrowiak@linux.ibm.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260325210149.888028-1-akrowiak@linux.ibm.com> References: <20260325210149.888028-1-akrowiak@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDE0OSBTYWx0ZWRfX+BQWm4vZVRuS Na7XaGhx0TJGuo8GoFT1Z9fDgpUEF/MuSMFeUUPJefwNsKNrCi2t1qWduLl2Ysk7IbVNVMzpe+D 3P4lPjAVXwIVbLkmrtjo4gdWBvfqETbX15ukkZqyyJW3IbE6nJvppoNCm17rd/GIb0WMgxNREQ0 cRWzeAUG31D0MBWPC22/mVLAFTDpRene2xk7wics3mljO45WCmb0B5f4ubOMBjnmCoTInqp2PgG Y0MbHm2zRV2E4HdVw/Z0f64v5VBgLyNhgbXNhrMcv5/Ey6B3Paz7/CS5Ueh4NKN2YsArTaGR0a1 ddWI/ERyau0amUqXwxpxySFUUEW7ItKeTEhmAxIJYgK12M1l2f1C4d3fJ3K0SXyt4eH4OrXIRov +mORcnmYBZa8m2hbJx0xmHDnmzMKMtuGxvd5oz9h6xXdVsj9fnYLhAOKfsfHk4Wf4fxBzG6Qa1j lA23VqOPOzj1+pOW5ZQ== X-Authority-Analysis: v=2.4 cv=JK42csKb c=1 sm=1 tr=0 ts=69c44d4f cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=A_qOOsZ8MQ48mD1vPGUA:9 X-Proofpoint-ORIG-GUID: vldIpQ9aAhu5QiYCol8YDjgvbhKi8qZh X-Proofpoint-GUID: vldIpQ9aAhu5QiYCol8YDjgvbhKi8qZh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_05,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250149 Content-Type: text/plain; charset="utf-8" Implements the callback that sets a new migration state of a vfio device during live migration of guests with pass-through access to AP devices. This callback is mandatory for VFIO_DEVICE_FEATURE_MIGRATION support. The function pointer for this callback is specified via the 'migration_set_state' field of the 'vfio_migration_ops' structure which is stored with the VFIO device when the 'vfio_device' structure representing the mediated device is initialized. Signed-off-by: Anthony Krowiak --- drivers/s390/crypto/vfio_ap_migration.c | 87 ++++++++++++++++++++++++- 1 file changed, 86 insertions(+), 1 deletion(-) diff --git a/drivers/s390/crypto/vfio_ap_migration.c b/drivers/s390/crypto/= vfio_ap_migration.c index 76cbbe1adb7a..a8b109bc5cf9 100644 --- a/drivers/s390/crypto/vfio_ap_migration.c +++ b/drivers/s390/crypto/vfio_ap_migration.c @@ -96,10 +96,95 @@ static void vfio_ap_release_mig_files(struct ap_matrix_= mdev *matrix_mdev) } } =20 +static struct file * +vfio_ap_transition_to_state(struct ap_matrix_mdev *matrix_mdev, + enum vfio_device_mig_state new_state) +{ + struct vfio_ap_migration_data *mig_data; + enum vfio_device_mig_state cur_state; + + lockdep_assert_held(&matrix_dev->mdevs_lock); + mig_data =3D matrix_mdev->mig_data; + cur_state =3D mig_data->mig_state; + dev_dbg(matrix_mdev->vdev.dev, "%s: %d -> %d\n", __func__, cur_state, + new_state); + + if (cur_state =3D=3D VFIO_DEVICE_STATE_STOP && + new_state =3D=3D VFIO_DEVICE_STATE_STOP_COPY) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + if (cur_state =3D=3D VFIO_DEVICE_STATE_STOP && + new_state =3D=3D VFIO_DEVICE_STATE_RESUMING) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + if (cur_state =3D=3D VFIO_DEVICE_STATE_RESUMING && + new_state =3D=3D VFIO_DEVICE_STATE_STOP) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + if (cur_state =3D=3D VFIO_DEVICE_STATE_STOP_COPY && + new_state =3D=3D VFIO_DEVICE_STATE_STOP) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + if ((cur_state =3D=3D VFIO_DEVICE_STATE_STOP && + new_state =3D=3D VFIO_DEVICE_STATE_RUNNING) || + (cur_state =3D=3D VFIO_DEVICE_STATE_RUNNING && + new_state =3D=3D VFIO_DEVICE_STATE_STOP)) { + /* TODO */ + return ERR_PTR(-EOPNOTSUPP); + } + + /* vfio_mig_get_next_state() does not use arcs other than the above */ + WARN_ON(true); + + return ERR_PTR(-EINVAL); +} + static struct file *vfio_ap_set_state(struct vfio_device *vdev, enum vfio_device_mig_state new_state) { - return NULL; + int ret; + struct file *filp =3D NULL; + struct ap_matrix_mdev *matrix_mdev; + enum vfio_device_mig_state next_state; + struct vfio_ap_migration_data *mig_data; + + mutex_lock(&matrix_dev->mdevs_lock); + matrix_mdev =3D container_of(vdev, struct ap_matrix_mdev, vdev); + mig_data =3D matrix_mdev->mig_data; + dev_dbg(vdev->dev, "%s -> %d\n", __func__, new_state); + + while (mig_data->mig_state !=3D new_state) { + ret =3D vfio_mig_get_next_state(vdev, mig_data->mig_state, + new_state, &next_state); + if (ret) { + filp =3D ERR_PTR(ret); + break; + } + + filp =3D vfio_ap_transition_to_state(matrix_mdev, next_state); + if (IS_ERR(filp)) + break; + + mig_data->mig_state =3D next_state; + + if (WARN_ON(filp && new_state !=3D next_state)) { + fput(filp); + filp =3D ERR_PTR(-EINVAL); + break; + } + } + + mutex_unlock(&matrix_dev->mdevs_lock); + + return filp; } =20 static int vfio_ap_get_state(struct vfio_device *vdev, --=20 2.52.0